- 06 Dec, 2018 1 commit
-
-
tzik authored
This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint. RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed, and may causes nested Microtasks in a problematic way. E.g. that confuses v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext(). OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it respects the microtask suppressions. As all existing tests don't call RunMicrotasks() in the suppressed situation (like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should not affect to these tests. Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d Reviewed-on: https://chromium-review.googlesource.com/c/1360095Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#58068}
-
- 27 Jun, 2017 3 commits
-
-
Igor Sheludko authored
This is a reland of 72b88fda Original change's description: > [runtime] Make all built-in functions strict. > > According to ES#sec-built-in-function-objects all built-in functions > must be strict. > > This is a preliminary CL before changing the way we define built-in > functions in native JS files. > > Bug: v8:6529, v8:6459 > Change-Id: I8e60b342f04ea1b0843fe1990334cbb9b26ebac4 > Reviewed-on: https://chromium-review.googlesource.com/546215 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46237} Bug: v8:6529, v8:6459 Change-Id: Ic0eb3d7925ed63dd716c4a114601415f92627ca5 Reviewed-on: https://chromium-review.googlesource.com/550156Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#46262}
-
Michael Achenbach authored
This reverts commit 72b88fda. Reason for revert: Changes a layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/16595 Original change's description: > [runtime] Make all built-in functions strict. > > According to ES#sec-built-in-function-objects all built-in functions > must be strict. > > This is a preliminary CL before changing the way we define built-in > functions in native JS files. > > Bug: v8:6459 > Change-Id: I8e60b342f04ea1b0843fe1990334cbb9b26ebac4 > Reviewed-on: https://chromium-review.googlesource.com/546215 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#46237} TBR=adamk@chromium.org,ishell@chromium.org,verwaest@chromium.org Change-Id: Ic458b478b2dd23aae7ea2a51aa6052c1f5931c56 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6459 Reviewed-on: https://chromium-review.googlesource.com/549322Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#46242}
-
Igor Sheludko authored
According to ES#sec-built-in-function-objects all built-in functions must be strict. This is a preliminary CL before changing the way we define built-in functions in native JS files. Bug: v8:6459 Change-Id: I8e60b342f04ea1b0843fe1990334cbb9b26ebac4 Reviewed-on: https://chromium-review.googlesource.com/546215Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#46237}
-
- 01 Feb, 2017 1 commit
-
-
neis authored
Using .caller, one can get access to the internal function that invokes the handler passed to Promise.prototype.then. This internal function is a TF builtin that was set up as non-native and without an argument adaptor. As a consequence of this, when accessing .arguments on it, the frame-walking logic in the .arguments accessor thinks the number of arguments is -1 and we try to allocate an array of size -1. This CL marks the builtin function as native (making its .arguments be null), along with a few others that may have been incorrect in the same way. BUG=chromium:682349 Review-Url: https://codereview.chromium.org/2672453002 Cr-Commit-Position: refs/heads/master@{#42855}
-
- 19 Jan, 2017 1 commit
-
-
mstarzinger authored
This makes sure 32-bit constants that are used as {MachineType::Uint32} by the deoptimization translation are also interpreted as such when the literals are collected. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-681983 BUG=chromium:681983 Review-Url: https://codereview.chromium.org/2646463002 Cr-Commit-Position: refs/heads/master@{#42493}
-
- 09 Jan, 2017 1 commit
-
-
bmeurer authored
Don't assume that the prototype of an object is always a JSObject when inlining the known receiver map case for abstract relational comparison. BUG=chromium:679202 R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2621583002 Cr-Commit-Position: refs/heads/master@{#42123}
-
- 05 Feb, 2016 1 commit
-
-
jarin authored
Review URL: https://codereview.chromium.org/1675433003 Cr-Commit-Position: refs/heads/master@{#33767}
-
- 15 Jan, 2016 1 commit
-
-
ishell authored
BUG=chromium:577112 LOG=N Review URL: https://codereview.chromium.org/1584303002 Cr-Commit-Position: refs/heads/master@{#33320}
-
- 24 Jun, 2014 1 commit
-
-
yangguo@chromium.org authored
R=jkummerow@chromium.org, danno@chromium.org BUG=387636 LOG=Y Review URL: https://codereview.chromium.org/331863015 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21959 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Jun, 2014 1 commit
-
-
bmeurer@chromium.org authored
BUG=380512 LOG=y R=jarin@chromium.org Review URL: https://codereview.chromium.org/313073003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21665 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Apr, 2014 1 commit
-
-
jarin@chromium.org authored
This is to avoid triggering an assertion from Smi::FromInt. The generated code is unreachable, so it is not a real bug. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/221743005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20458 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Mar, 2014 1 commit
-
-
rossberg@chromium.org authored
R=verwaest@chromium.org, bmeurer@chromium.org BUG=chromium:357330 LOG=Y Review URL: https://codereview.chromium.org/219333003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20366 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Feb, 2014 3 commits
-
-
hpayer@chromium.org authored
BUG= R=verwaest@chromium.org Review URL: https://codereview.chromium.org/184393002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19599 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
BUG=347904 LOG=y R=hpayer@chromium.org Review URL: https://codereview.chromium.org/184303003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
LOG=y BUG=347542 R=yangguo@chromium.org Review URL: https://codereview.chromium.org/183763007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19592 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Feb, 2014 1 commit
-
-
rossberg@chromium.org authored
R=arv@chromium.org, mstarzinger@chromium.org BUG=346141 LOG=Y Review URL: https://codereview.chromium.org/177883002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19539 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Feb, 2014 1 commit
-
-
verwaest@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/165743003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19511 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Feb, 2014 1 commit
-
-
yangguo@chromium.org authored
R=dslomov@chromium.org BUG=v8:3159 LOG=N Review URL: https://codereview.chromium.org/163293002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-