1. 06 Dec, 2018 1 commit
    • tzik's avatar
      Replace %RunMicrotasks with %PerformMicrotaskCheckpoint · 07011cc4
      tzik authored
      This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
      
      RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
      and may causes nested Microtasks in a problematic way. E.g. that confuses
      v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
      
      OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
      respects the microtask suppressions.
      
      As all existing tests don't call RunMicrotasks() in the suppressed situation
      (like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
      not affect to these tests.
      
      Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
      Reviewed-on: https://chromium-review.googlesource.com/c/1360095Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58068}
      07011cc4
  2. 27 Jun, 2017 3 commits
  3. 01 Feb, 2017 1 commit
    • neis's avatar
      [promises] Fix .arguments on builtin function. · 5020db7f
      neis authored
      Using .caller, one can get access to the internal function that invokes the
      handler passed to Promise.prototype.then.  This internal function is a TF
      builtin that was set up as non-native and without an argument adaptor.  As a
      consequence of this, when accessing .arguments on it, the frame-walking logic in
      the .arguments accessor thinks the number of arguments is -1 and we try to
      allocate an array of size -1.
      
      This CL marks the builtin function as native (making its .arguments be null),
      along with a few others that may have been incorrect in the same way.
      
      BUG=chromium:682349
      
      Review-Url: https://codereview.chromium.org/2672453002
      Cr-Commit-Position: refs/heads/master@{#42855}
      5020db7f
  4. 19 Jan, 2017 1 commit
  5. 09 Jan, 2017 1 commit
  6. 05 Feb, 2016 1 commit
  7. 15 Jan, 2016 1 commit
  8. 24 Jun, 2014 1 commit
  9. 04 Jun, 2014 1 commit
  10. 03 Apr, 2014 1 commit
  11. 31 Mar, 2014 1 commit
  12. 28 Feb, 2014 3 commits
  13. 25 Feb, 2014 1 commit
  14. 20 Feb, 2014 1 commit
  15. 14 Feb, 2014 1 commit