1. 25 Jan, 2019 1 commit
  2. 24 May, 2017 1 commit
    • jarin's avatar
      Make non-Module generators only context allocate parameters. · a957b0f4
      jarin authored
      In particular, local variables should be allocated on stack (in bytecode register), and stored/loaded to the generator object on generator suspend/resume.
      
      The CL is based on @adamk's change to scoping/parsers (https://chromium-review.googlesource.com/c/498538/), I only made the debugger cope with this change.
      
      I should note that the CL changes the scope type of suspended generators from ScopeType.Closure to ScopeType.Local. In the future we might want to introduce ScopeType.SuspendedGenerator to make the distinction explicit.
      
      Some of the changes in the tests have been made because the debugger functions do not return scopes of closed generators anymore. Generators should be allowed to throw away their internal state when they finish.
      
      BUG=v8:6368
      
      Review-Url: https://codereview.chromium.org/2898163002
      Cr-Commit-Position: refs/heads/master@{#45515}
      a957b0f4
  3. 11 Nov, 2016 1 commit
    • jgruber's avatar
      [debug-wrapper] Conditional breaks, locals, evaluate, scopes · b32ee40d
      jgruber authored
      This CL adds support for:
      * conditional breaks in setBreakpoint,
      * locals in frame.local{Count,Name,Value},
      * evaluation on a frame in frame.evaluate,
      * and more detailed scope information in scopeObject.
      
      Uses of several functions that are not covered by the
      inspector protocol and are only used in tests have been removed.
      
      Local handling has been modified to also include arguments as locals.
      Inspector differs in this regard from our FrameDetails in that
      arguments are always shown as locals. Argument-related functions
      were removed.
      
      BUG=v8:5530
      
      Review-Url: https://codereview.chromium.org/2491543002
      Cr-Commit-Position: refs/heads/master@{#40917}
      b32ee40d
  4. 31 Mar, 2016 1 commit
  5. 15 Dec, 2015 1 commit
    • yangguo's avatar
      [debugger] debug-evaluate should not not modify local values. · abe2feb0
      yangguo authored
      Debug evaluate no longer writes back changes to the replicated
      context chain to the original after execution. Changes to the
      global object or script contexts still stick. Calling functions
      that bind to the original context chain also have their expected
      side effects.
      
      As far as I can tell, DevTools is not interested in modifying
      local variable values. Modifying global variable values still
      works as expected. However, I have not yet removed the old
      implementation, but merely keep it behind a flag.
      
      R=mstarzinger@chromium.org, rossberg@chromium.org
      
      Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
      Cr-Commit-Position: refs/heads/master@{#32841}
      
      Review URL: https://codereview.chromium.org/1513183003
      
      Cr-Commit-Position: refs/heads/master@{#32857}
      abe2feb0
  6. 14 Dec, 2015 2 commits
    • machenbach's avatar
      Revert of [debugger] debug-evaluate should not not modify local values.... · a2f2e913
      machenbach authored
      Revert of [debugger] debug-evaluate should not not modify local values. (patchset #2 id:20001 of https://codereview.chromium.org/1513183003/ )
      
      Reason for revert:
      [Sheriff] Layout test changes.
      
      Original issue's description:
      > [debugger] debug-evaluate should not not modify local values.
      >
      > Debug evaluate no longer writes back changes to the replicated
      > context chain to the original after execution. Changes to the
      > global object or script contexts still stick. Calling functions
      > that bind to the original context chain also have their expected
      > side effects.
      >
      > As far as I can tell, DevTools is not interested in modifying
      > local variable values. Modifying global variable values still
      > works as expected. However, I have not yet removed the old
      > implementation, but merely keep it behind a flag.
      >
      > R=mstarzinger@chromium.org, rossberg@chromium.org
      >
      > Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330
      > Cr-Commit-Position: refs/heads/master@{#32841}
      
      TBR=mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      
      Review URL: https://codereview.chromium.org/1526553003
      
      Cr-Commit-Position: refs/heads/master@{#32845}
      a2f2e913
    • yangguo's avatar
      [debugger] debug-evaluate should not not modify local values. · 92caa9b8
      yangguo authored
      Debug evaluate no longer writes back changes to the replicated
      context chain to the original after execution. Changes to the
      global object or script contexts still stick. Calling functions
      that bind to the original context chain also have their expected
      side effects.
      
      As far as I can tell, DevTools is not interested in modifying
      local variable values. Modifying global variable values still
      works as expected. However, I have not yet removed the old
      implementation, but merely keep it behind a flag.
      
      R=mstarzinger@chromium.org, rossberg@chromium.org
      
      Review URL: https://codereview.chromium.org/1513183003
      
      Cr-Commit-Position: refs/heads/master@{#32841}
      92caa9b8
  7. 16 Sep, 2014 1 commit
  8. 24 Mar, 2014 1 commit