- 04 Feb, 2015 25 commits
-
-
arv authored
We used to have a parse error for conflicting property keys. This check was removed to match ES6 (SpiderMonkey & Chakra already made this change). Since this check was removed we ended up with a few new cases when generating code. For example, accessors always generated code even if those should have been shadowed by a data property. BUG=v8:3856 LOG=Y R=adamk, dslomov@chromium.org Review URL: https://codereview.chromium.org/895693002 Cr-Commit-Position: refs/heads/master@{#26441}
-
arv authored
Motivation: Cleanup BUG=None R=adamk LOG=N Review URL: https://codereview.chromium.org/897633003 Cr-Commit-Position: refs/heads/master@{#26440}
-
mvstanton authored
On platforms that don't push the return address on the stack at time of call, there was an error. R=ulan@chromium.org Review URL: https://codereview.chromium.org/894753006 Cr-Commit-Position: refs/heads/master@{#26439}
-
balazs.kilvady authored
Port 275e088a BUG=chromium:455141 LOG=N Review URL: https://codereview.chromium.org/876083006 Cr-Commit-Position: refs/heads/master@{#26438}
-
arv authored
Class methods and accessors (both prototype and static) should be non enumerable. BUG=v8:3330 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/896643003 Cr-Commit-Position: refs/heads/master@{#26437}
-
ulan authored
BUG= Review URL: https://codereview.chromium.org/882913006 Cr-Commit-Position: refs/heads/master@{#26436}
-
loislo authored
Revert of Externalize deoptimization reasons. (patchset #6 id:100001 of https://codereview.chromium.org/874323003/) Reason for revert: it broke the build Original issue's description: > Externalize deoptimization reasons. > > 1) The hardcoded strings were converted into DeoptReason enum. > > 2) Deopt comment were converted into a pair location and deopt reason entries so > the deopt reason tracking mode would less affect the size of the RelocInfo table and heap. > > 3) DeoptReason entry in RelocInfo reuses kCommentTag value and generates short entry in RelocInfo table. > > BUG=452067 > LOG=n > > Committed: https://crrev.com/c49820e45b57f128a98690940875c049f612dde6 > Cr-Commit-Position: refs/heads/master@{#26434} TBR=alph@chromium.org,mstarzinger@chromium.org,svenpanne@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452067 Review URL: https://codereview.chromium.org/892843007 Cr-Commit-Position: refs/heads/master@{#26435}
-
loislo authored
1) The hardcoded strings were converted into DeoptReason enum. 2) Deopt comment were converted into a pair location and deopt reason entries so the deopt reason tracking mode would less affect the size of the RelocInfo table and heap. 3) DeoptReason entry in RelocInfo reuses kCommentTag value and generates short entry in RelocInfo table. BUG=452067 LOG=n Review URL: https://codereview.chromium.org/874323003 Cr-Commit-Position: refs/heads/master@{#26434}
-
marja authored
The syntax of this test snippet was so wrong ("function function") that it wasn't testing what it was supposed to test. R=rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/896043003 Cr-Commit-Position: refs/heads/master@{#26433}
-
balazs.kilvady authored
Port 6fc97a19 Original commit message: The first try failed because I needed to make a better distinction between clearing ICs according to policy at GC time or unconditional clearing (say, via %ClearFunctionTypeFeedback). It was also blocked by an issue in super constructor calls. This fix (https://codereview.chromium.org/892113002/) needs to land before checking in this CL. BUG= Review URL: https://codereview.chromium.org/896223002 Cr-Commit-Position: refs/heads/master@{#26432}
-
balazs.kilvady authored
Port c7851da4 Original commit message: This enables adding more language modes in the future. For maximum flexibility, LanguageMode is a bitmask, so we're not restricted to use a sequence of language modes which are progressively stricter, but we can express the language mode as combination of features. For now, LanguageMode can only be "sloppy" or "strict", and there are STATIC_ASSERTS in places which need to change when more modes are added. LanguageMode is a bit like the old LanguageMode when "extended" mode was still around (see https://codereview.chromium.org/8417035 and https://codereview.chromium.org/181543002 ) except that it's transmitted through all the layers (there's no StrictModeFlag). BUG= Review URL: https://codereview.chromium.org/890413003 Cr-Commit-Position: refs/heads/master@{#26431}
-
yurys authored
Revert of Add WeakKeyMap to v8.h (patchset #2 id:20001 of https://codereview.chromium.org/891473005/) Reason for revert: Revert this patch due to shared win build compilation failure http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/5030/steps/compile/logs/stdio Original issue's description: > Add WeakKeyMap to v8.h > > A new map wich references its keys weakly is added to v8.h. Internally it uses the same storage as JSWeakMap but doesn't depend on the JavaScript part of WeakMap implementation in weak-collection.js, hence it can be instantiated without entering any context. > > BUG=chromium:437416 > LOG=Y > > Committed: https://crrev.com/ee7ed39ac8327124e74dd7ad5f1de0dede988cb7 > Cr-Commit-Position: refs/heads/master@{#26425} TBR=jochen@chromium.org,mstarzinger@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:437416 Review URL: https://codereview.chromium.org/901663002 Cr-Commit-Position: refs/heads/master@{#26430}
-
yurys authored
Revert of Simplify WeakMap and WeakSet tests slightly. (patchset #1 id:1 of https://codereview.chromium.org/903463002/) Reason for revert: Revert this patch as the original CL has to be reverted to due to shared win build failure http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/5030/steps/compile/logs/stdio Original issue's description: > Simplify WeakMap and WeakSet tests slightly. > > R=rossberg@chromium.org > TEST=cctest/test-weakmaps,cctest/test-weaksets > > Committed: https://crrev.com/a90d7a871da19d33e93c8779186408c8d1615cac > Cr-Commit-Position: refs/heads/master@{#26428} TBR=rossberg@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/899833003 Cr-Commit-Position: refs/heads/master@{#26429}
-
mstarzinger authored
R=rossberg@chromium.org TEST=cctest/test-weakmaps,cctest/test-weaksets Review URL: https://codereview.chromium.org/903463002 Cr-Commit-Position: refs/heads/master@{#26428}
-
dcarney authored
BUG= Review URL: https://codereview.chromium.org/901603002 Cr-Commit-Position: refs/heads/master@{#26427}
-
dcarney authored
R=verwaest@chromium.org BUG= Review URL: https://codereview.chromium.org/895053002 Cr-Commit-Position: refs/heads/master@{#26426}
-
yurys authored
A new map wich references its keys weakly is added to v8.h. Internally it uses the same storage as JSWeakMap but doesn't depend on the JavaScript part of WeakMap implementation in weak-collection.js, hence it can be instantiated without entering any context. BUG=chromium:437416 LOG=Y Review URL: https://codereview.chromium.org/891473005 Cr-Commit-Position: refs/heads/master@{#26425}
-
dcarney authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/889843003 Cr-Commit-Position: refs/heads/master@{#26424}
-
dslomov authored
R=rossberg@chromium.org BUG=chromium:455141 LOG=N Review URL: https://codereview.chromium.org/902563002 Cr-Commit-Position: refs/heads/master@{#26423}
-
Dusan Milosavljevic authored
TEST= BUG= R=paul.lind@imgtec.com Review URL: https://codereview.chromium.org/894883004 Cr-Commit-Position: refs/heads/master@{#26422}
-
titzer authored
R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/896983002 Cr-Commit-Position: refs/heads/master@{#26421}
-
mvstanton authored
The first try failed because I needed to make a better distinction between clearing ICs according to policy at GC time or unconditional clearing (say, via %ClearFunctionTypeFeedback). It was also blocked by an issue in super constructor calls. This fix (https://codereview.chromium.org/892113002/) needs to land before checking in this CL. R=ulan@chromium.org Review URL: https://codereview.chromium.org/866493003 Cr-Commit-Position: refs/heads/master@{#26420}
-
marja authored
This enables adding more language modes in the future. For maximum flexibility, LanguageMode is a bitmask, so we're not restricted to use a sequence of language modes which are progressively stricter, but we can express the language mode as combination of features. For now, LanguageMode can only be "sloppy" or "strict", and there are STATIC_ASSERTS in places which need to change when more modes are added. LanguageMode is a bit like the old LanguageMode when "extended" mode was still around (see https://codereview.chromium.org/8417035 and https://codereview.chromium.org/181543002 ) except that it's transmitted through all the layers (there's no StrictModeFlag). BUG= Review URL: https://codereview.chromium.org/894683003 Cr-Commit-Position: refs/heads/master@{#26419}
-
akos.palfi authored
Port 64f81870 BUG= Review URL: https://codereview.chromium.org/885283008 Cr-Commit-Position: refs/heads/master@{#26418}
-
akos.palfi authored
Port 6f97a494 BUG= Review URL: https://codereview.chromium.org/895243002 Cr-Commit-Position: refs/heads/master@{#26417}
-
- 03 Feb, 2015 15 commits
-
-
caitpotter88 authored
Fixes tree closure caused by r26415 BUG=v8:3502 R=arv@chromium.org LOG=N Review URL: https://codereview.chromium.org/869773005 Cr-Commit-Position: refs/heads/master@{#26416}
-
caitpotter88 authored
Applies to API implementation of O.p.toString - Removes special handling of non-string @@toStringTag values (use builtinTag) - Removes special handling of @@toStringTags which match [[Class]] names (remove ~ prefix) - Add tests for non-string @@toStringTag values in test-api.cc BUG=v8:3502 R=arv@chromium.org LOG=N Review URL: https://codereview.chromium.org/892393003 Cr-Commit-Position: refs/heads/master@{#26415}
-
mvstanton authored
The Ast Call node is accustomed to using a vector IC slot for the cases when it uses a CallIC. The super constructor work alters this somewhat by using a CallConstructStub instead, however the CallConstructStub expects a vector slot and not a vector ic slot. This distinction needs to be maintained because slots and ic slots have different clearing strategies and are handled differently. R=dslomov@chromium.org BUG= LOG=N Review URL: https://codereview.chromium.org/892113002 Cr-Commit-Position: refs/heads/master@{#26414}
-
jarin authored
BUG=chromium:449291 LOG=n R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/898753003 Cr-Commit-Position: refs/heads/master@{#26413}
-
ulan authored
context. BUG=v8:3629 LOG=N Review URL: https://codereview.chromium.org/879273004 Cr-Commit-Position: refs/heads/master@{#26412}
-
caitpotter88 authored
- Removes special handling of non-string @@toStringTag values (use builtinTag) - Removes special handling of @@toStringTags which match [[Class]] names (remove ~ prefix) BUG=v8:3502 R=arv@chromium.org LOG=N Review URL: https://codereview.chromium.org/895633004 Cr-Commit-Position: refs/heads/master@{#26411}
-
ishell authored
Related to crbug/454297. Review URL: https://codereview.chromium.org/897523003 Cr-Commit-Position: refs/heads/master@{#26410}
-
dslomov authored
R=arv@chromium.org,rossberg@chromium.org BUG=v8:3834 LOG=N Review URL: https://codereview.chromium.org/867153003 Cr-Commit-Position: refs/heads/master@{#26409}
-
Daniel Vogelheim authored
BUG= Review URL: https://codereview.chromium.org/898783002 Cr-Commit-Position: refs/heads/master@{#26408}
-
Daniel Vogelheim authored
R=verwaest@chromium.org BUG=454625 NOTREECHECKS=true Review URL: https://codereview.chromium.org/892833003 Cr-Commit-Position: refs/heads/master@{#26407}
-
mstarzinger authored
R=bmeurer@chromium.org TEST=cctest/test-run-jsexceptions/Throw Review URL: https://codereview.chromium.org/896783002 Cr-Commit-Position: refs/heads/master@{#26406}
-
verwaest authored
BUG=454625 LOG=y Review URL: https://codereview.chromium.org/900553003 Cr-Commit-Position: refs/heads/master@{#26405}
-
Benedikt Meurer authored
If a (pure) node has two or more uses, but there exists a path from the common dominator of these uses to end, which does not contain a use, then we split the node such that no unnecessary computation takes place. Note however, that this only applies if the node cannot be hoisted out of a loop. BUG=v8:3864 LOG=n R=jarin@chromium.org Review URL: https://codereview.chromium.org/899433005 Cr-Commit-Position: refs/heads/master@{#26404}
-
bmeurer authored
R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/896463004 Cr-Commit-Position: refs/heads/master@{#26403}
-
https://codereview.chromium.org/886473005/yurys authored
Reason for revert: Broke compilation on component build http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/5007/steps/compile/logs/stdio Original issue's description: > Add WeakMap to v8.h > > A new map wich references its keys weakly is added to v8.h. Internally it uses the same storage as JSWeakMap but doesn't depend on the JavaScript part of WeakMap implementation in weak-collection.js, hence it can be instantiated without entering any context. > > BUG=chromium:437416 > LOG=Y > > Committed: https://crrev.com/37d4c57630636f21e3add8d3d1c7c978ff5fc8e0 > Cr-Commit-Position: refs/heads/master@{#26401} TBR=jochen@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:437416 Review URL: https://codereview.chromium.org/898763002 Cr-Commit-Position: refs/heads/master@{#26402}
-