- 01 Oct, 2019 22 commits
-
-
Igor Sheludko authored
... by flipping the flag. Bug: v8:9706 Change-Id: Ie0e70a243a5a6a703cdaa27c1ed55a78d9904bbe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826732 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#64075}
-
Jaime Bernardo authored
Explicitly #include<string> in v8.h, since std::string is referenced in it. In the C++ STL shipped with Visual Studio 2019, none of the headers included in v8.h ends up including the C++ string header, which caused a compile error. Bug: v8:9793 Change-Id: I84a133dd10dd6dcc7b70287af393e82cf0dc97df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834321Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#64074}
-
Ng Zhi An authored
Bug: v8:9728 Change-Id: Ic15d793e6408af1ea2e1f7f71b9130300d359a95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1808417Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64073}
-
Ross McIlroy authored
TurboProp will not reschedule after effect-control linearization, so the graph-assembler will be used to modify the schedule as new nodes are added. To enable this, ensure we use the graph assembler for all node creation from effect-control linearization onwards. BUG=v8:9684 Change-Id: I2be3f5d2a3f2cbee44c72bb397e9bd1d9ac7de05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832166 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64072}
-
Ng Zhi An authored
Change-Id: I5dcc3f708ca05a0d3b504cb4d7a89693ca0717b4 Bug: v8:9396 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1819521Reviewed-by:
-
Frank Tang authored
* Throws RangeError only when the calendar and numberingSystem is ill-formed. * Set the calendar and numberingSystem to the locale only if the values are valid. * Fix the order of GetOption of "localeMatcher". * Add more unit tests. See https://github.com/tc39/ecma402/pull/175 for details. Bug: v8:9786, v8:9787, v8:9788 Change-Id: Ic0f918ad7d9afb0b7c8df39caa0f44ef07ca10c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1830345 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64070}
-
Frank Tang authored
Bug: v8:9155 Change-Id: I54c65ee28171064f596fc305bb718613640f251a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832636Reviewed-by:
-
Joshua Litt authored
Removes the static protector values from isolate now that they are no longer needed. This is the final cl in the migration effort. Bug: v8:9463 Change-Id: I2127ef6c8a0cdaf0ccf28aed12539335ef985704 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1827455Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#64068}
-
Igor Sheludko authored
Bug: v8:9706 Change-Id: I5779e2fbaec5741cc9b8d44f7f3f721400e70b28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832174 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Dan Elphick authored
Pushes the optimised code path to after the main interpreter path, so the straightline path is just normal interpretation. Bug: v8:9771 Change-Id: I2f48ff290efcd85a5e30cf823027919560f8a56a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829220Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#64066}
-
Peter Marshall authored
This was missed when changing Object to hold a ptr field instead of abusing the this pointer. This was printing the stack address of the particular Object rather than the location of the printed code object on the heap. Change-Id: I5c884464419debcbc70b73fe8bdfa8107f2bdb71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833681 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This is a reland of 66129430 Fixed: Unaligned reads, unspecified evaluation order. Original change's description: > [regexp] Bytecode peephole optimization > > Bytecodes used by the regular expression interpreter often occur in > specific sequences. The number of dispatches in the interpreter can be > reduced if those sequences are combined into a single bytecode. > > This CL adds a peephole optimization pass for regexp bytecodes. > This pass checks the generated bytecode for pre-defined sequences that > can be merged into a single bytecode. > > With the currently implemented bytecode sequences a speedup of 1.12x on > regex-dna and octane-regexp is achieved. > > Bug: v8:9330 > Change-Id: I827f93273a5848e5963c7e3329daeb898995d151 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1813743 > Commit-Queue: Patrick Thier <pthier@google.com> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63992} Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux_gcc_rel Bug: v8:9330,chromium:1008502,chromium:1008631 Change-Id: Ib9fc395b6809aa1debdb54d9fba5b7f09a235e5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1828917Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Ana Peško authored
This is a reland of cfb60d43 Original change's description: > [regexp] Eagerly tier-up for very long strings > > For very long subject strings, the regexp interpreter is currently much slower > than the native machine code execution. This CL implements eager tier-up to the > compiler to avoid the performance penalty for subject strings of length greater > than 1000. > > Change-Id: I244ccbd60255e0f3bedc493b1cc3d25cdd42133e > Bug: v8:9566 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829273 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Ana Pesko <anapesko@google.com> > Cr-Commit-Position: refs/heads/master@{#64046} Bug: v8:9566 Change-Id: I81a10728c64ce3b35258c31eb8178e458d3de205 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832167Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ana Pesko <anapesko@google.com> Cr-Commit-Position: refs/heads/master@{#64063}
-
Georg Neis authored
This is an experiment to see the memory/performance impact. Bug: v8:9775 Change-Id: I2ae61ae8bb5c6c1c55436e96c4b2d8201cbf4739 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832177Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64062}
-
chrome://traceMike Stanton authored
Bug: chromium:1005195 Change-Id: I41b8526d1394d82b06bab975dc0cc18c080dfd60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829271 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#64061}
-
Leszek Swirski authored
Change-Id: I822f3961b2ec5ef8fb7ca4765cb7c9fd38514223 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832171 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64060}
-
Leszek Swirski authored
Avoid emitting deprecation checks for these fields. Bug: v8:9606 Change-Id: Id3e317a8c36728b3c7b063743ef9d36aa1209176 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832170 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
David Carlier authored
Change-Id: I4d4c6e8a6371102ae7b2ece7cbbc068cdd8c6799 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832165Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64058}
-
Dan Elphick authored
Moves CodeStubAssembler::BranchIfPrototypesHaveNoElements to AccessorAssembler and TNodifies it on the way. Bug: v8:9396 Change-Id: Ie5d8ad5abc3dbdb688c0cbee4610cd441ba1a9b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826736 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Andreas Haas authored
Apparently this is necessary. R=ulan@chromium.org Bug: v8:9396 Change-Id: Ia7c439308fb7edbb901f595aeb9fbf9389858daa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832161Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64056}
-
Michael Achenbach authored
It was confusing to silently run test262 only in the default variant with a switch on the infra side. We'll remove that switch in a follow up and explicitly configure the testing variant for test262 in builders.pyl. Bug: v8:9791 Change-Id: I0da351ff981c833704f51a415225aff24df1664a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829269Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64055}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0a96846..69e3270 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0081c0f..a19d353 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie36db05802205713ad5a49cfa180c58e32fda94f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1831187Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64054}
-
- 30 Sep, 2019 18 commits
-
-
Francis McCabe authored
This reverts commit 9efe315e. Reason for revert: Causing time out issues on box2d tests: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/27752 and https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20debug/29630 Original change's description: > Mark functions for optimization only on bytecode budget interrupts > > We used to mark functions for optimization on any interrupt. This sometimes > causes functions to OSR when not needed. The implementation was such because > we didn't have a different runtime function to distinguish bytecode budget > interrupts from other interrupts. For lazy feedback allocation we added a > new runtime function for bytecode budget interrupts so it makes it easier > to actually mark functions only when needed. > > This also includes a fix to reduce the stack limits for interrupts when > entering a scope that allows interrupts from a postponed interrupt scope. > > Bug: chromium:993061 > Change-Id: Iaf7b4dccb7a503e5b6bfcbb993bc7482aa593955 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829218 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64048} TBR=rmcilroy@chromium.org,mythria@chromium.org,leszeks@chromium.org Change-Id: I97938934fdaa030b958695d18e1788d75c17077c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:993061 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832645Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#64053}
-
Suraj Sharma authored
Since slow handler was previously not a Smi. The DCHECK assumed any Smi Handler on this path should be a proxy handler. Now it Checks for both, and should continue if the current handler is a slow handler. Bug: chromium:1008632 Change-Id: I079960894d7320d8d658d0990e8c32db51703206 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1828480Reviewed-by:
-
Vasili Skurydzin authored
prepare for ptr compression Change-Id: Ia459ad18a30fbfd8e51bd99735f0d63644d30b8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1831788Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64051}
-
Clemens Backes [né Hammacher] authored
This reverts commit 35ca0abd. Reason for revert: Speculative revert for https://crbug.com/1008597. Original change's description: > [wasm] Ship far jump tables > > This flips the --wasm-far-jump-table flag. It will allow for more than > 128MB of code space per wasm module on arm64, and will increase the > limit on the number of modules per process on x64 (was ~1000 before, > because we reserved 1GB for the code space per module). > > R=mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: I870ec616f4812e38ef1e3fccf0629854a247bb4f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1815247 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Backes [né Hammacher] <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63967} TBR=mstarzinger@chromium.org,clemensb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9477, chromium:1008597 Change-Id: Ie8740e09925130b304a37d97904443026aabae85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832162Reviewed-by:
-
Z Nguyen-Huu authored
Bug: v8:9781 Change-Id: I1f82a828f103cc2aa3f9553214f6b4867ffc3b17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829897 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Mythri A authored
We used to mark functions for optimization on any interrupt. This sometimes causes functions to OSR when not needed. The implementation was such because we didn't have a different runtime function to distinguish bytecode budget interrupts from other interrupts. For lazy feedback allocation we added a new runtime function for bytecode budget interrupts so it makes it easier to actually mark functions only when needed. This also includes a fix to reduce the stack limits for interrupts when entering a scope that allows interrupts from a postponed interrupt scope. Bug: chromium:993061 Change-Id: Iaf7b4dccb7a503e5b6bfcbb993bc7482aa593955 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829218Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Ana Pesko authored
This reverts commit cfb60d43. Reason for revert: Several bots timing out, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/24717 Original change's description: > [regexp] Eagerly tier-up for very long strings > > For very long subject strings, the regexp interpreter is currently much slower > than the native machine code execution. This CL implements eager tier-up to the > compiler to avoid the performance penalty for subject strings of length greater > than 1000. > > Change-Id: I244ccbd60255e0f3bedc493b1cc3d25cdd42133e > Bug: v8:9566 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829273 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Ana Pesko <anapesko@google.com> > Cr-Commit-Position: refs/heads/master@{#64046} TBR=yangguo@chromium.org,petermarshall@chromium.org,anapesko@google.com TBR=yangguo@chromium.org Change-Id: Id8dd362617988c8c5efa87ae157ee91c96cb1fdf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832163Reviewed-by:
-
Ana Peško authored
For very long subject strings, the regexp interpreter is currently much slower than the native machine code execution. This CL implements eager tier-up to the compiler to avoid the performance penalty for subject strings of length greater than 1000. Change-Id: I244ccbd60255e0f3bedc493b1cc3d25cdd42133e Bug: v8:9566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829273Reviewed-by:
-
Milad Farazmand authored
Port 1e4bb087 Original Commit Message: x64 code path is different and we can't do this optimization. R=solanes@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I173d7339706a9c09d3e6519d1cee36fa15692aca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829171 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Milad Farazmand authored
Port 559a0034 Original Commit Message: We didn't think this affected arm but it turns out it does. This is a port of https://chromium-review.googlesource.com/c/v8/v8/+/1688049 R=petermarshall@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id081736420a20216cef5c5f483acd987785c4d97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829899Reviewed-by:
-
Dominik Inführ authored
This reverts commit 70e07cdb. Reason for revert: Clusterfuzz found issue in chromium:1009019 Original change's description: > [heap] Insert directly into RememberedSet and remove StoreBuffer > > This CL removes the StoreBuffer and inserts slots into the > RememberedSet directly from within the RecordWrite builtin. Only calls > into C code when either the SlotSet-array or the bucket is not > allocated. This avoids filling the store buffer up with duplicates or > due to a write-heavy workload and then blocking the main thread on > store buffer processing. > > Change-Id: I05b0b0938d822cdf0e8ef086ad4527d3229c05b2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1815241 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64002} TBR=ulan@chromium.org,jkummerow@chromium.org,dinfuehr@chromium.org Change-Id: I6f4cc1641965c83b05f3b3830b0f526b362beb49 Bug: chromium:1009019, chromium:1009196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829259Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#64043}
-
Ana Peško authored
This CL changes the eager tier-up for global replaces slightly to include a previously unaccounted for path by moving the logic into the caller so that it includes this path as well. Change-Id: Ifc265ddb1183b8bb3ea75ca5d6c83d66e55e2837 Bug: v8:9566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829276 Commit-Queue: Ana Pesko <anapesko@google.com> Reviewed-by:
-
Dan Elphick authored
This is a short-term fix to prevent any merging of feedback slots for dynamic globals, while we work on a longer term solution to make it consistent between eager and lazy compilation. Bug: chromium:1008414, v8:8510 Change-Id: I4a5977046f53454d6f8a6ea2f41046abdf73418f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829270 Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Ingvar Stepanyan authored
Adds ability to pause JavaScript debugger from d8 by defining a global function `handleInspectorMessage` which should block waiting for a new inspector message, and `send` it afterwards. Additionally, adds a simple helper script that, when invoked via `websocketd` as per instructions, can be used for debugging `d8` using Chrome DevTools (inspecting script sources, pausing, stepping over, etc.). Change-Id: Iee75fb4e3f2ccc8c8552c804fefaefb233d6b089 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829221Reviewed-by:
-
Igor Sheludko authored
... in disabled state. It will be enabled in a follow-up CL. Bug: v8:9706 Change-Id: I43b482a4fd1bf9af0c6ba535b453e72463bee0f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826731Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Change-Id: Icb4c3a1a544331baab5d6637daa12bea87044715 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829268 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
David Carlier authored
/proc/sys/auxv might not be accessible, instead getting these from the user's stack. Change-Id: I2dcf696734e2b4dc1da27a991930b9e0d4228d51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730990 Commit-Queue: Clemens Backes [né Hammacher] <clemensb@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Change-Id: Ie96e645851beb26e9a777379ad68f1c173acd80d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829266Reviewed-by:
-
![Clemens Backes [né Hammacher]'s avatar](https://secure.gravatar.com/avatar/474af430daf77b962004ce934be86b3d?s=72&d=identicon "Clemens Backes [né Hammacher]")
