- 11 Jun, 2015 40 commits
-
-
dehrenberg authored
The spec says ToObject is called on the receiver, and this is observable if you call sort on a primitive. This patch trivially adds the call and a test. BUG=v8:4125 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1178193004 Cr-Commit-Position: refs/heads/master@{#28972}
-
arv authored
When setting a property using `super.prop = val` we need to use add property if we are adding a new property and not set property. BUG=493566 LOG=N R=verwaest@chromium.org, dslomov@chromium.org Review URL: https://codereview.chromium.org/1161073002 Cr-Commit-Position: refs/heads/master@{#28971}
-
Toon Verwaest authored
BUG=v8:4137 LOG=n R=arv@chromium.org Review URL: https://codereview.chromium.org/1179983002. Cr-Commit-Position: refs/heads/master@{#28970}
-
dehrenberg authored
%AddElement is not intended for objects which are not arrays, and its behavior may go away with future refactorings. This patch gets rid of it if the receiver of from or of is not the intrinsic Array object. Array.of and Array.from previously papered over failures in calling [[DefineOwnProperty]] when setting array elements. This patch makes them lead to exceptions, and adds tests to assert that the appropriate exceptions are thrown. BUG=v8:4168 R=adamk CC=rossberg,verwaest LOG=Y Review URL: https://codereview.chromium.org/1181623003 Cr-Commit-Position: refs/heads/master@{#28969}
-
arv authored
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function.prototype.bind Bound functions should have a name based on the function that was bound. BUG=N LOG=N R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1182513002 Cr-Commit-Position: refs/heads/master@{#28968}
-
verwaest authored
Reland of Use the LookupIterator in SetAccessor (patchset #1 id:1 of https://codereview.chromium.org/1175323004/) Reason: Didn't break anything Original issue's description: > Revert of Use the LookupIterator in SetAccessor (patchset #2 id:20001 of https://codereview.chromium.org/1178673003/) > > Reason for revert: > Blocks reverting of https://codereview.chromium.org/1175973002 > > Original issue's description: > > Use the LookupIterator in SetAccessor > > > > BUG=v8:4137 > > LOG=n > > > > Committed: https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9 > > Cr-Commit-Position: refs/heads/master@{#28955} > > TBR=jkummerow@chromium.org,verwaest@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4137 > > Committed: https://crrev.com/11dbd29de57b290ee8dac2a782a53f879beb416f > Cr-Commit-Position: refs/heads/master@{#28956} TBR=jkummerow@chromium.org,ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Review URL: https://codereview.chromium.org/1181813002 Cr-Commit-Position: refs/heads/master@{#28967}
-
verwaest authored
Revert of Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #1 id:1 of https://codereview.chromium.org/1179933002/) Reason for revert: Reland, this didn't break anything. Original issue's description: > Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/) > > Reason for revert: > It broke webkit_unit_tests > > Original issue's description: > > Remove GetAttributes from the mix to avoid another virtual dispatch. > > > > BUG=chromium:495949,v8:4137 > > LOG=n > > > > Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175 > > Cr-Commit-Position: refs/heads/master@{#28953} > > TBR=verwaest@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:495949,v8:4137 > > Committed: https://crrev.com/ae639d2ad646237e2f413259a0f116845ef96440 > Cr-Commit-Position: refs/heads/master@{#28958} TBR=ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:495949,v8:4137 Review URL: https://codereview.chromium.org/1182603002 Cr-Commit-Position: refs/heads/master@{#28966}
-
Toon Verwaest authored
BUG=v8:4137 LOG=n R=ishell@chromium.org Review URL: https://codereview.chromium.org/1173283004. Cr-Commit-Position: refs/heads/master@{#28965}
-
mtrofin authored
The main motivation is simplifying profiling activities: 1) Use hex instead of decimal for offsets, just like perf does. This affects --print-opt-code 2) When printing block information, indicate loop information: if block is header, where the end is; if block is in a loop, where the loop starts. This affects --code-comments. Using --print-opt-code --code-comments, and cross-referencing with data obtained from perf, one may now find the block a hotspot belongs to without needing to do hex2dec/dec2hex conversions. Once found, loop info is available locally, on the block. BUG= Review URL: https://codereview.chromium.org/1177123002 Cr-Commit-Position: refs/heads/master@{#28964}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1177103003 Cr-Commit-Position: refs/heads/master@{#28963}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1178083002 Cr-Commit-Position: refs/heads/master@{#28962}
-
arv authored
BUG=v8:4116 LOG=N R=adamk@chromium.org Review URL: https://codereview.chromium.org/1180873002 Cr-Commit-Position: refs/heads/master@{#28961}
-
dstence authored
R=mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1177263002 Cr-Commit-Position: refs/heads/master@{#28960}
-
Toon Verwaest authored
BUG=v8:4137 LOG=n R=ishell@chromium.org Review URL: https://codereview.chromium.org/1178953003. Cr-Commit-Position: refs/heads/master@{#28959}
-
ishell authored
Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/) Reason for revert: It broke webkit_unit_tests Original issue's description: > Remove GetAttributes from the mix to avoid another virtual dispatch. > > BUG=chromium:495949,v8:4137 > LOG=n > > Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175 > Cr-Commit-Position: refs/heads/master@{#28953} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:495949,v8:4137 Review URL: https://codereview.chromium.org/1179933002 Cr-Commit-Position: refs/heads/master@{#28958}
-
ishell authored
Revert of Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. (patchset #3 id:40001 of https://codereview.chromium.org/1178503004/) Reason for revert: Blocks revert of https://codereview.chromium.org/1175973002 Original issue's description: > Replace SetObjectProperty / DefineObjectProperty with less powerful alternatives where relevant. > > @yangguo: please look at the debugger part of the CL. > @ishell: please look at the rest. > > Additionally: > - Ensure the LookupIterator for named properties does not accidentally get indexes in. > - Fix the return value for typed array assignments to be the incoming value. > > BUG=v8:4137 > LOG=n > > Committed: https://crrev.com/15aa811f8fe2708a757c3b53ca89db736aa8b222 > Cr-Commit-Position: refs/heads/master@{#28954} TBR=yangguo@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Review URL: https://codereview.chromium.org/1181733002 Cr-Commit-Position: refs/heads/master@{#28957}
-
ishell authored
Revert of Use the LookupIterator in SetAccessor (patchset #2 id:20001 of https://codereview.chromium.org/1178673003/) Reason for revert: Blocks reverting of https://codereview.chromium.org/1175973002 Original issue's description: > Use the LookupIterator in SetAccessor > > BUG=v8:4137 > LOG=n > > Committed: https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9 > Cr-Commit-Position: refs/heads/master@{#28955} TBR=jkummerow@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Review URL: https://codereview.chromium.org/1175323004 Cr-Commit-Position: refs/heads/master@{#28956}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1178673003 Cr-Commit-Position: refs/heads/master@{#28955}
-
verwaest authored
@yangguo: please look at the debugger part of the CL. @ishell: please look at the rest. Additionally: - Ensure the LookupIterator for named properties does not accidentally get indexes in. - Fix the return value for typed array assignments to be the incoming value. BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1178503004 Cr-Commit-Position: refs/heads/master@{#28954}
-
verwaest authored
BUG=chromium:495949,v8:4137 LOG=n Review URL: https://codereview.chromium.org/1175973002 Cr-Commit-Position: refs/heads/master@{#28953}
-
cdai2 authored
port dd854449 (r28839) original commit message: Boolean "is_strong" parameters have begun to proliferate across areas where strong mode semantics are different. This CL repurposes the existing ObjectStrength enum as a replacement for them. BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1173973002 Cr-Commit-Position: refs/heads/master@{#28952}
-
cdai2 authored
port b27016b7 (r28827). original commit message: BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1178533002 Cr-Commit-Position: refs/heads/master@{#28951}
-
cdai2 authored
port bd32a9f7 (r28825). original commit message: BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1173963002 Cr-Commit-Position: refs/heads/master@{#28950}
-
cdai2 authored
port 345fa142 (r28802). port of r28769 overwrite some of r28802 so we port them again. original commit message: Before this we had 3 super related lexical bindings that got injected into method bodies: .home_object, .this_function, and new.target. With this change we get rid of the .home_object one in favor of using .this_function[home_object_symbol] which allows some simplifications throughout the code base. BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1173933005 Cr-Commit-Position: refs/heads/master@{#28949}
-
cdai2 authored
port e4782a9b (r28782) original commit message: Previously the %_DateField intrinsic would also check the object and throw an exception if you happen to pass something that is not a valid JSDate, which (a) violates our policy for instrinsics and (b) is hard to optimize in TurboFan (even Crankshaft has a hard time, but there we will never inline the relevant builtins, so it doesn't show up). The throwing part is now a separate intrinsics %_ThrowIfNotADate that throws an exception in full codegen and deoptimizes in Crankshaft, which means the code for the current use cases is roughly the same (modulo some register renamings/gap moves). BUG= R=weiliang.lin@intel.com Review URL: https://codereview.chromium.org/1174913002 Cr-Commit-Position: refs/heads/master@{#28948}
-
Toon Verwaest authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/1178883003 Cr-Commit-Position: refs/heads/master@{#28947}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1172683003 Cr-Commit-Position: refs/heads/master@{#28946}
-
martyn.capewell authored
Merge a following arithmetic or logical right shift into the existing shift of ARM64's Int32MulHigh or Uint32MulHigh code. BUG= Review URL: https://codereview.chromium.org/1179503003 Cr-Commit-Position: refs/heads/master@{#28945}
-
jacob.bramley authored
Revert of [arm64][turbofan]: Handle any immediate shift. (patchset #1 id:1 of https://codereview.chromium.org/1179733004/) Reason for revert: Breaks InstructionSelectorTest.Word64ShrWithWord64AndWithImmediate on debug builds (but not optdebug builds). I'll investigate. Original issue's description: > [arm64][turbofan]: Handle any immediate shift. > > With this patch, we can generate simple immediate-shift instructions for > immediates outside the range "0 <= imm < width". Several related > instruction selectors have also been updated accordingly. > > Example of generated code: > > ---- Before --- ---- After ---- > movz w0, #33 lsr w0, w1, #1 > lsr w0, w1, w0 > > BUG= > > Committed: https://crrev.com/36d771bbfa4af5efcc1c1dcf5b234445cb7ee722 > Cr-Commit-Position: refs/heads/master@{#28943} TBR=bmeurer@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1176393002 Cr-Commit-Position: refs/heads/master@{#28944}
-
jacob.bramley authored
With this patch, we can generate simple immediate-shift instructions for immediates outside the range "0 <= imm < width". Several related instruction selectors have also been updated accordingly. Example of generated code: ---- Before --- ---- After ---- movz w0, #33 lsr w0, w1, #1 lsr w0, w1, w0 BUG= Review URL: https://codereview.chromium.org/1179733004 Cr-Commit-Position: refs/heads/master@{#28943}
-
bmeurer authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/1175113005 Cr-Commit-Position: refs/heads/master@{#28942}
-
machenbach authored
NOTRY=true Review URL: https://codereview.chromium.org/1179693005 Cr-Commit-Position: refs/heads/master@{#28941}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1178103002 Cr-Commit-Position: refs/heads/master@{#28940}
-
hpayer authored
BUG= Review URL: https://codereview.chromium.org/1173243003 Cr-Commit-Position: refs/heads/master@{#28939}
-
yangguo authored
The alternative of passing an object template at context creation is unfeasible because we need a context to instantiate the template. At the time we create the context from snapshot or bootstrap from scratch, we would already need that template instance, leading to a chicken-and-egg problem. This is an alternative that is simpler and less intrusive. R=domenic@chromium.org, jochen@chromium.org Review URL: https://codereview.chromium.org/1182443002 Cr-Commit-Position: refs/heads/master@{#28938}
-
mstarzinger authored
TBR=machenbach@chromium.org NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/1178123002 Cr-Commit-Position: refs/heads/master@{#28937}
-
machenbach authored
NOTRY=true Review URL: https://codereview.chromium.org/1180473003 Cr-Commit-Position: refs/heads/master@{#28936}
-
mstarzinger authored
R=bmeurer@chromium.org BUG=v8:4131 LOG=N Review URL: https://codereview.chromium.org/1177743002 Cr-Commit-Position: refs/heads/master@{#28935}
-
machenbach authored
Revert of [heap] Unify the immortal immovable root detection mechanism. (patchset #3 id:40001 of https://codereview.chromium.org/1178853002/) Reason for revert: [Sheriff] tsan failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/4240 Original issue's description: > [heap] Unify the immortal immovable root detection mechanism. > > Uniformly use the Heap::GetRootListIndex() and > Heap::RootIsImmortalImmovable() methods to detect immortal immovable > roots in the optimizing compilers. > > R=jarin@chromium.org > > Committed: https://crrev.com/84e83da99a72edc169367bf88588b1a2f10c2e08 > Cr-Commit-Position: refs/heads/master@{#28933} TBR=jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1178083003 Cr-Commit-Position: refs/heads/master@{#28934}
-
bmeurer authored
Uniformly use the Heap::GetRootListIndex() and Heap::RootIsImmortalImmovable() methods to detect immortal immovable roots in the optimizing compilers. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1178853002 Cr-Commit-Position: refs/heads/master@{#28933}
-