- 06 May, 2022 10 commits
-
-
Peter Kasting authored
This is deprecated in C++20. Use constexprs and explicit casts to work around. Bug: chromium:1284275 Change-Id: I6a3974f3c678cb797081938622036a12a99c5d1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630349 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#80392}
-
Michael Lippautz authored
- Repurpose flag `treat_global_objects_as_roots` when taking a heap snapshot for toggling whether internals should be exposed (to `hide_internals`). - Use the toggle in creating heap snapshots for exposing class names as object names for C++ objects that have not explicitly been given a name. Change-Id: I77d71babfdfe53269964fe81ed985037a431c28b Bug: chromium:1321620 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623740Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80391}
-
nedenwang authored
Change-Id: I88a1bbddc7604fc5e557ae875ca196cf9c46574c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3626453Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Neden Wang <nedenwang@tencent.com> Cr-Commit-Position: refs/heads/main@{#80390}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0c83e78..a1147fb Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/ce96725..fb82ddb Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/f1108b6..3d54d41 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/58f3286..7979ffe Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/443d913..6a1494e R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I9e313473644596c6723f733b4347e7f22e6454ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629690 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80389}
-
Samuel Groß authored
This reverts commit 48481a67. Reason for revert: Fails roll into Chromium due to Asan, Android, and Fuchsia bots. See https://crrev.com/c/3631159 Original change's description: > [sandbox] Enable sandboxed pointers on Desktop > > Bug: chromium:1218005 > Change-Id: I3df750ee9101779952d8b1ae630c4d3b7563084b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578645 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Samuel Groß <saelo@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80376} Bug: chromium:1218005 Change-Id: I646f09947b5a32d1ada60887352cc3989e66ada3 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632099 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
Milad Fa authored
Remove unused variable reported by gcc. Change-Id: I02b37a41524d2c2d8e3ab1158bd0fd816c7124f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629601Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80387}
-
Michael Achenbach authored
This reverts commit 4251c285. Reason for revert: Fails on CI bots: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux/46503/overview Original change's description: > [Temporal] Add TimeZone get*Transition and getPlainDateTimeFor > > Also add non-intl (only support UTC) version of AO: > GetIANATimeZoneNextTransition, GetIANATimeZonePreviousTransition > (support of other timezone in Intl will come later) > > Spec Text: > https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getplaindatetimefor > https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getnexttransition > https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getprevioustransition > https://tc39.es/proposal-temporal/#sec-temporal-getianatimezonenexttransition > https://tc39.es/proposal-temporal/#sec-temporal-getianatimezoneprevioustransition > > > Bug: v8:11544 > Change-Id: I17d5a60638dcd8543e5d9f22c6560b311f2f402a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3534450 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80383} Bug: v8:11544 Change-Id: Icfbb643578ac028b06aa07c3ac6bbce030f49390 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630079 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80386}
-
Michael Achenbach authored
This reverts commit 2b140a9f. Reason for revert: Need to revert parent CL. Original change's description: > [Temporal] Add Calendar.prototype.yearMonthFromFields > > Add AO: IsValidISOMonth, RegulateISOYearMonth, ISOYearMonthFromFields > Spec Text: > https://tc39.es/proposal-temporal/#sec-temporal-isvalidisomonth > https://tc39.es/proposal-temporal/#sec-temporal-regulateisoyearmonth > https://tc39.es/proposal-temporal/#sec-temporal-isoyearmonthfromfields > https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.yearmonthfromfields > > > Bug: v8:11544 > Change-Id: I1baadbbe54fb0c3fd45750eddb13b790465c3a3b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3408773 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80384} Bug: v8:11544 Change-Id: I1d93a25ee36b08d7a0bc86937d5b0a18ab6cdf86 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3632098 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80385}
-
Frank Tang authored
Add AO: IsValidISOMonth, RegulateISOYearMonth, ISOYearMonthFromFields Spec Text: https://tc39.es/proposal-temporal/#sec-temporal-isvalidisomonth https://tc39.es/proposal-temporal/#sec-temporal-regulateisoyearmonth https://tc39.es/proposal-temporal/#sec-temporal-isoyearmonthfromfields https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.yearmonthfromfields Bug: v8:11544 Change-Id: I1baadbbe54fb0c3fd45750eddb13b790465c3a3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3408773 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80384}
-
Frank Tang authored
Also add non-intl (only support UTC) version of AO: GetIANATimeZoneNextTransition, GetIANATimeZonePreviousTransition (support of other timezone in Intl will come later) Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getplaindatetimefor https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getnexttransition https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getprevioustransition https://tc39.es/proposal-temporal/#sec-temporal-getianatimezonenexttransition https://tc39.es/proposal-temporal/#sec-temporal-getianatimezoneprevioustransition Bug: v8:11544 Change-Id: I17d5a60638dcd8543e5d9f22c6560b311f2f402a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3534450 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 05 May, 2022 22 commits
-
-
Peter Kasting authored
In C++20, u8"" generates a const char8_t*, not a const char*. Since "" accepts UTF-8 already, just switch to it. Bug: chromium:1284275 Change-Id: I873321a62a4d9e32b3b463913a3bc10231db3db3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630347Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80382}
-
Milad Fa authored
This CL adds prefixed store scalar and floating point instructions to the assembler and uses it during code generation if the processor supports it. They have also been added to the disassembler and the simulator. Change-Id: I0b9e0758f17ca6b86d4f2f2bb36be87fba14ecb7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3626173Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80381}
-
Milad Fa authored
`ldu` requires offset to be 4 byte aligned. Moving it under `GenerateMemoryOperationWithAlign`. Change-Id: I9f15a3e4d04f5381d0fb74abdd2f4d9160bc7243 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629345Reviewed-by:
-
Frank Tang authored
1. Move the use of MAYBE_RETURN to MAYBE_ASSIGN_RETURN_ON_EXCEPTION_VALUE if possible. 2. Remove some MYABE_RETURN in the wrong spot and therefore fix some tests. 3. Change Intl::GetTimeZoneIndex() to return Maybe<int32_t> as index and use < 0 value to indicate not getting index to make the function signature simpler. Bug: v8:11544 Change-Id: I685cbff142e9dea69ef316a1bc180730aef5aec8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625839Reviewed-by:
-
Peter Kasting authored
This prevents ambiguity errors in C++20 due to ADL when casting types in std::, which gains std::bit_cast<>(). Bug: chromium:1284275 Change-Id: I25046d1952a9304852e481ad8b84049c6769c289 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625838 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Andreas Haas authored
The write protection of code memory with mprotect is too expensive for lazy compilation. As the usefulness of this memory protection is limited anyways, this CL disables the memory protection in case lazy compilation is enabled. Bug: v8:12852 Change-Id: I4c56d4021a7b594e24a4d3d28a130a309c56de38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627596Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80377}
-
Samuel Groß authored
Bug: chromium:1218005 Change-Id: I3df750ee9101779952d8b1ae630c4d3b7563084b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3578645Reviewed-by:
-
Al Muthanna Athamina authored
NOTRY=true Bug: v8:12842 Change-Id: If3cac473407fc60523de5924170b7c3b99074d54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629546 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
jameslahm authored
This is a reland of commit 507fa4d7 This CL moves the NewJSObjectFromMap after deserializing object properties with dictionary map and fixes the DCHECK failure in JSReceiver::HasFastProperties when triggering GC. Original change's description: > [web snapshot] Add support for object with dictionary mode > > This CL adds the serialization support for object properties > with dictionary map. Shape id is used to distinguish between if the object has dictionary map. And add TODO to support “no map objects” which can have fast map and “objects with map” which needs to be turned to dictionary mode. > > Bug: v8:11525 > Change-Id: If3eb4195115a41d4a3f6cc7372924b982ca96fc1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3621593 > Commit-Queue: 王澳 <wangao.james@bytedance.com> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80366} Bug: v8:11525 Change-Id: I88422d698aa03fb7d3b21b5709eec2d0cf306256 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629738 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
Caitlin Potter authored
Based on the robust test suite for checking property "has/in" queries, with the intention of measuring the performance of accessing getOwnPropertyDescriptor. Background: getOwnPropertyDescriptor and defineProperty were identified as hot code taking up a significant chunk of startup time in a customer application. This benchmark aims to measure the difference made by a modifying Object.getOwnPropertyDescriptor. By current measurements, the geometric mean time of the new version is typically 1/6 that of the current upstream implementation, using this test specifically (however, only on arm64 / Apple M1... On Linux/x64, the results look more reasonable at a roughly 5-12% improvement in score). In its current form, this benchmark does very little to attempt to verify the results of the object, which may result in branches being discarded in Turbofan (but given the enormous difference between x64 and arm64, I'm not positive this is what is happening, and have not yet verified this). BUG= Change-Id: I0f10735315313ed97efd00fcccaedc1272d4d314 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3624979 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
-
Al Muthanna Athamina authored
NOTRY=true Bug: v8:12826 Change-Id: Ibe1bad5837221903a7a47af7f2cc49963952a67e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629335Reviewed-by:
-
Leszek Swirski authored
Consider the following * A ValueNode has inputs A and B * Input A has later uses, input B doesn't * The ValueNode's result must be in the same register as A It can then happen that UpdateUses frees B, and the result allocation emits a gap move from A's register to B's old register (now free) to preserve the value of A when the ValueNode writes into its register. This gap move is emmitted before the ValueNode start, which means that it clobbers B. Now, UpdateUses only clears registers _after_ node result allocation, so that the known free registers are still the ones before updating uses. Done naively, this would have bad consequences -- in the case where A has no later uses, it would still force the regalloc to save its value thinking that it is still live. So, this patch also introduces a concept of "AllocationStage" where we're either allocating at the start or end of a Node. Inputs are allocated at the start, results at the end. When walking registers during an allocation, nodes whose lifetimes end at the current node are considered to be dead at the "end" allocation stage, and we are allowed to a) use their registers, and b) drop them without preserving their value. Bug: v8:7700 Change-Id: I5ca764ed04b12269f189577e81eb7e2a27cd1b09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625978 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Stephen Roettger authored
Change-Id: I6dec06936cb12f2d6da69c1f147bea344c32cf73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629129Reviewed-by:
-
Al Muthanna Athamina authored
NOTRY=true Bug: v8:12826 Change-Id: I08be2980f92c69504290bb6152e48595e6a6c9aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629540 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Nico Hartmann authored
This reverts commit 507fa4d7. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/38308/overview Original change's description: > [web snapshot] Add support for object with dictionary mode > > This CL adds the serialization support for object properties > with dictionary map. Shape id is used to distinguish between if the object has dictionary map. And add TODO to support “no map objects” which can have fast map and “objects with map” which needs to be turned to dictionary mode. > > Bug: v8:11525 > Change-Id: If3eb4195115a41d4a3f6cc7372924b982ca96fc1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3621593 > Commit-Queue: 王澳 <wangao.james@bytedance.com> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80366} Bug: v8:11525 Change-Id: I0d236a9937a5942b387553a61991716321b063e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629541 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Owners-Override: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#80368}
-
Jakob Linke authored
Bug: v8:7700 Change-Id: I6e77592e6a3603533414971b59ef1fb9b2f89657 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629150Reviewed-by:
-
jameslahm authored
This CL adds the serialization support for object properties with dictionary map. Shape id is used to distinguish between if the object has dictionary map. And add TODO to support “no map objects” which can have fast map and “objects with map” which needs to be turned to dictionary mode. Bug: v8:11525 Change-Id: If3eb4195115a41d4a3f6cc7372924b982ca96fc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3621593 Commit-Queue: 王澳 <wangao.james@bytedance.com> Reviewed-by:
-
Nikolaos Papaspyrou authored
This CL cleans up the existing experimental implementation of conservative stack scanning. It retains the object start bitmap, to evaluate it as a mechanism for resolving inner pointers, and the conservative stack scanning visitor (which is currently not used). The flag v8_enable_conservative_stack_scanning is kept and will be used for experimental purposes. It currently does not imply any other flag. Bug: v8:10614 Bug: v8:12851 Change-Id: Id0ae0f437ed2601eed9ec634d2d1dd2f030d814e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602516Reviewed-by:
Jakob Linke <jgruber@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#80365}
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.dateadd is not yet implemented. Note: The intl version stated in https: //tc39.es/proposal-temporal/#sup-temporal.calendar.prototype.dateadd Bug: v8:11544 Change-Id: Id7fd043d234f559c0e03bdf3f0f31d8bc91da27f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3609208Reviewed-by:
-
Frank Tang authored
Also change the macro to pass method name directly to CHECK_RECEIVER() Remove MACROs which has up to only two usage. Sync with changes in https://github.com/tc39/proposal-temporal/pull/1693 Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.tojson https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.tojson Bug: v8:11544 Change-Id: I31f4ef6f725462da885893f1266d30590098b031 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3438378Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c812b8d..0c83e78 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/113378f..7208edd Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/393e3ee..f1108b6 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/d3c4414..58f3286 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/13acea3..443d913 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/75625c6..3e15bc0 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ifb09ed901ef782997b4674b40d74edc013750482 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3626176 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80362}
-
jiepan authored
WASM only supports simd128, but modern CPUs support up to 256 bit vector register or more, we will add an experimental feature to do 256 bit re-vectorization in Turbofan pipeline, this patch add simd256 machine representation. Bug: v8:12716 Change-Id: I1e6a3f2afa0a457fca2c261216f4113d0ed5b818 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3534456Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80361}
-
- 04 May, 2022 8 commits
-
-
Frank Tang authored
Add AO: ISOMonthDayFromFields Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.monthdayfromfields https://tc39.es/proposal-temporal/#sec-temporal-isomonthdayfromfields Bug: v8:11544 Change-Id: I8a04a8e61af8abdb902de33efbf5635b8e8300aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3408576 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.calendar.prototype.month Note- this is only the non-intl version. intl version in https://tc39.es/proposal-temporal/#sup-temporal.calendar.prototype.month will be implemented in later cl. Bug: v8:11544 Change-Id: Ibbbb00faa0bdb4d49784cd9aae69fb779d95f924 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3531554 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: I4003b30ec4f1e29a7c5d55a51cbf82fa3a7487e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585856 Commit-Queue: Vasili Skurydzin <vasili.skurydzin@ibm.com> Reviewed-by:
-
Dominik Inführ authored
This reverts commit 2b79eefe. Reason for revert: Speculative revert because of https://crbug.com/1322305 Original change's description: > Reland^2: [heap] Store size with invalidated object > > This is a reland of commit 23b2d571 > > When updating pointers during a full GC, a page might not be swept > already. In such cases there might be invalid objects and slots > recorded in free memory. Updating tagged slots in free memory is fine > even though not strictly necessary. > > However, the GC also needs to calculate the size of potentially dead > invalid objects in order to be able to check whether a slot is within > that object. But since that object is dead, its map might be dead as > well which makes size calculation impossible on such objects. The CL > changes this to cache the size of invalid objects. A follow-up CL will > also check the marking bit of invalid objects. > > Reason for reverts: > > Revert #2: In-object slack tracking on JSObjects doesn't update the > cached size of invalidated objects. The fix here was to stop > invalidating recorded slots on JSObjects at all and avoid that problem > completely (see https://crrev.com/c/3620274). > > Revert #1: Not all size changes go through NotifyObjectLayoutChange, so > https://crrev.com/c/3607992 introduced NotifyObjectSizeChange as a > bottleneck for object size changes/right-trimming. This method is > now used to update the size of invalidated objects. > > Bug: v8:12578, chromium:1316289 > Change-Id: I0478d04601c0270ddb39419ca6cf98719951eb4d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3623542 > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Reviewed-by: Patrick Thier <pthier@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80344} Bug: v8:12578, chromium:1316289 Change-Id: I6dd2dd13583123b9cb7933b15e2113fddc0c0b0b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627511 Owners-Override: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80357}
-
Anton Bikineev authored
Old gcc versions (< gcc-8) have problems with parameter packs in capture-lists wrapped in fold-expressions. Bug: chromium:1029379 Change-Id: I0c0ee7caa2d750f551e93fdfeb2667328bee4acb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627594 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This is temporary until we update our infra to always use --turbofan Change-Id: Ie1ca8ce2cae6744515d9810ae4f57f00c8670e36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3625977 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
In the future we may want to cache this in a separate slot to turbofan code, but for now cache maglev code in the same optimized code slot on the feedback vector. Bug: v8:7700 Change-Id: Idd40a024cc9beb9b4da06a88a3789d822ddd4ab7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3622916Reviewed-by:
-
Michael Lippautz authored
Bug: chromium:1322318 Change-Id: Id3899a493eb1519e2f7498dcad1e607cc2b6a5db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3627509Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80353}
-
