- 19 Sep, 2016 20 commits
-
-
bmeurer authored
Crankshaft just unconditionally deoptimizes the code when the length of a string addition result would overflow. In order to protect against deopt loops we insert a global protector cell. We will use the same mechanism for inlining certain string additions into TurboFan as well, and protecting against overflow (we will also extend this to deal with String.prototype.concat and friends once we get there). BUG=v8:5404 R=jarin@chromium.org,hpayer@chromium.org Review-Url: https://codereview.chromium.org/2348293002 Cr-Commit-Position: refs/heads/master@{#39511}
-
lpy authored
Previously we didn't implement TRACE_STR_COPY when we write trace events to file, which causes us to allocate a growing independent memory chunk for dumped runtime call stats table. Since we now have a fully functional TRACE_STR_COPY, this memory allocation can be avoided, this patch removes it. BUG=v8:5089 Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039 Review-Url: https://codereview.chromium.org/2342643004 Cr-Original-Commit-Position: refs/heads/master@{#39462} Cr-Commit-Position: refs/heads/master@{#39510}
-
mtrofin authored
This CL avoids relying on signed/unsigned implicit conversions when re-computing wasm mem sizes. BUG= Review-Url: https://codereview.chromium.org/2349053002 Cr-Commit-Position: refs/heads/master@{#39509}
-
littledan authored
Reland of Fix async/await memory leak (patchset #1 id:1 of https://codereview.chromium.org/2354473002/ ) Reason for revert: Relanding with faster-running test Original issue's description: > Revert of Fix async/await memory leak (patchset #5 id:80001 of https://codereview.chromium.org/2334323006/ ) > > Reason for revert: > newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop > > Original issue's description: > > Fix async/await memory leak > > > > This patch closes a memory leak in async/await where the desugaring > > was creating a situation analagous to that described in v8:5002. > > Intermediate Promises were being kept alive, so a long-running loop > > would cause linear memory usage on the heap. This patch returns > > undefined to the 'then' callback passed into PerformPromiseThen > > in order to avoid this hazard. Test expectations are fixed to remove > > expecting extraneous events which occurred on Promises that are > > now not given unnecessarily complex resolution paths before being > > thrown away. > > > > BUG=v8:5390 > > > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > > Cr-Commit-Position: refs/heads/master@{#39479} > > TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org > NOTRY=true > BUG=v8:5390 > > Committed: https://crrev.com/196db1999da130019bbf8e3bd65977f840e8afaf > Cr-Commit-Position: refs/heads/master@{#39493} TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=v8:5390 Review-Url: https://codereview.chromium.org/2348403002 Cr-Commit-Position: refs/heads/master@{#39508}
-
vogelheim authored
This is in preparation for upcmoming scanner + bookmarking cleanups. Also, drive-by fix for setting a bookmark close to the end of the stream, when the look-ahead character (c0_) is kEndOfInput, which the bookmarking logic also used as kNoBookmark. R=marja@chomium.org BUG=v8:4947 Review-Url: https://codereview.chromium.org/2345053003 Cr-Commit-Position: refs/heads/master@{#39507}
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2332243002 Cr-Commit-Position: refs/heads/master@{#39506}
-
chiniforooshan authored
The test does not compile with https://codereview.chromium.org/2253973003. I will comment it out, land the mentioned patch, fix the compile error (a simple one-liner), and enable the test again. BUG=647986 Review-Url: https://codereview.chromium.org/2348063002 Cr-Commit-Position: refs/heads/master@{#39505}
-
verwaest authored
BUG=v8:5209 Review-Url: https://codereview.chromium.org/2351673002 Cr-Commit-Position: refs/heads/master@{#39504}
-
jgruber authored
This commit ensures that the d8 shared library build uses the same logic as the standard static build by exporting relevant functions and classes. BUG=chromium:646337 Review-Url: https://codereview.chromium.org/2342563002 Cr-Commit-Position: refs/heads/master@{#39503}
-
heimbuef authored
BUG= Review-Url: https://codereview.chromium.org/2266493002 Cr-Commit-Position: refs/heads/master@{#39502}
-
marja authored
PreParser is already capable of handling natives, because ParseV8Intrinsic was moved to ParserBase. There's no reason to force eager parsing when natives are allowed. R=nikolaos@chromium.org, mstarzinger@chromium.org BUG=v8:5398 Review-Url: https://codereview.chromium.org/2342133003 Cr-Commit-Position: refs/heads/master@{#39501}
-
jochen authored
Forgot to include that in the previous CL TBR=machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2354513002 Cr-Commit-Position: refs/heads/master@{#39500}
-
jochen authored
Remove files that were removed from the build files but never deleted. R=machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2346103002 Cr-Commit-Position: refs/heads/master@{#39499}
-
petermarshall authored
BUG=v8:5364 Review-Url: https://codereview.chromium.org/2339123002 Cr-Commit-Position: refs/heads/master@{#39498}
-
nikolaos authored
According to the ES6 specification, in "for in/of" loops like: for (var v of [1,2,3]) return f(...); the call to f() should not be considered a tail call. This was not working properly, i.e., the case without declarations: var v; for (v of [1,2,3]) return f(...); R=adamk@chromium.org, ishell@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2343823002 Cr-Commit-Position: refs/heads/master@{#39497}
-
nikolaos authored
- Remove redundant "impl()->". - Remove NewBlock method from "impl()", exists in "factory()". - Resolve TODO comments. R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/2345103003 Cr-Commit-Position: refs/heads/master@{#39496}
-
jochen authored
If the scope was lazily parsed, the ScopeInfo won't be correct (and we won't store it in the SharedFunctionInfo). BUG=chromium:644106 R=marja@chromium.org Review-Url: https://codereview.chromium.org/2345243002 Cr-Commit-Position: refs/heads/master@{#39495}
-
machenbach authored
BUG=chromium:648153 NOTRY=true NOPRESUBMIT=true TBR=emso@chromium.org Review-Url: https://codereview.chromium.org/2352573002 Cr-Commit-Position: refs/heads/master@{#39494}
-
hablich authored
Revert of Fix async/await memory leak (patchset #5 id:80001 of https://codereview.chromium.org/2334323006/ ) Reason for revert: newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop Original issue's description: > Fix async/await memory leak > > This patch closes a memory leak in async/await where the desugaring > was creating a situation analagous to that described in v8:5002. > Intermediate Promises were being kept alive, so a long-running loop > would cause linear memory usage on the heap. This patch returns > undefined to the 'then' callback passed into PerformPromiseThen > in order to avoid this hazard. Test expectations are fixed to remove > expecting extraneous events which occurred on Promises that are > now not given unnecessarily complex resolution paths before being > thrown away. > > BUG=v8:5390 > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > Cr-Commit-Position: refs/heads/master@{#39479} TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org NOTRY=true BUG=v8:5390 Review-Url: https://codereview.chromium.org/2354473002 Cr-Commit-Position: refs/heads/master@{#39493}
-
jarin authored
Review-Url: https://codereview.chromium.org/2349983002 Cr-Commit-Position: refs/heads/master@{#39492}
-
- 18 Sep, 2016 5 commits
-
-
zhengxing.li authored
port 7f3d15aa(r39470) original commit message: In ignition, arguments to function calls and function constructors are pushed onto the stack before calling the function. It is required to check that stack does not overflow when pushing the arguments. BUG= Review-Url: https://codereview.chromium.org/2351543002 Cr-Commit-Position: refs/heads/master@{#39491}
-
zhengxing.li authored
port c7d7ca36(r39410) original commit message: Add a notion of "invocation count" to the baseline compilers, which increment a special slot in the TypeFeedbackVector for each invocation of a given function (the optimized code doesn't currently collect this information). Use this invocation count to relativize the call counts on the call sites within the function, so that the inlining heuristic has a view of relative importance of a call site rather than some absolute numbers with unclear meaning for the current function. Also apply the call site frequency as a factor to all frequencies in the inlinee by passing this to the graph builders so that the importance of a call site in an inlinee is relative to the topmost optimized function. Note that all functions that neither have literals nor need type feedback slots will share a single invocation count cell in the canonical empty type feedback vector, so their invocation count is meaningless, but that doesn't matter since we only use the invocation count to relativize call counts within the function, which we only have if we have at least one type feedback vector (the CallIC slot). See the design document for additional details on this change: https://docs.google.com/document/d/1VoYBhpDhJC4VlqMXCKvae-8IGuheBGxy32EOgC2LnT8 BUG= Review-Url: https://codereview.chromium.org/2352493002 Cr-Commit-Position: refs/heads/master@{#39490}
-
zhengxing.li authored
port 3ccedd5d(r39398) original commit message: BUG= Review-Url: https://codereview.chromium.org/2352483002 Cr-Commit-Position: refs/heads/master@{#39489}
-
v8-autoroll authored
Rolling v8/build to cce8ee87cfdbbac3b05240132f74fe1f398e83d1 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2346163002 Cr-Commit-Position: refs/heads/master@{#39488}
-
zhengxing.li authored
port 2ab3fcf4(r39377) original commit message: To make better inlining decisions, it's good to have call counts for poly/mega-morphic cases. This CL makes it work for calls, and another will follow to better unify the code between constructor calls and normal calls (and thence, to record megamorphic call counts there as well). BUG= Review-Url: https://codereview.chromium.org/2351523002 Cr-Commit-Position: refs/heads/master@{#39487}
-
- 17 Sep, 2016 4 commits
-
-
jbroman authored
In practice this is a dense array, because there is currently no provision in the format for assigning IDs other than sequentially to every object. Thus a FixedArray is more efficient than a general dictionary. BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2342293003 Cr-Commit-Position: refs/heads/master@{#39486}
-
v8-autoroll authored
Rolling v8/build to f7f13b559d1d51c4e932659e11b28be595595041 Rolling v8/buildtools to 6115afa0ea5ea33e1f284d9ef2175a03db1370ca TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2351503002 Cr-Commit-Position: refs/heads/master@{#39485}
-
gdeepti authored
test-run-wasm-module cctests broken in debug since recent refactoring changes for moving Compilation/Instantiation off the module object (https://codereview.chromium.org/2320723005). The problem here is that SetupIsolateForWasm tries to add the same property to a module_object multiple times and hits a DCHECK when this property is found on a lookup. - Fixed to use the setup method only once when CcTest::InitIsolateOnce is used. - Move setup method to test as this is only used for cctests/fuzzers. The install method should take care of this in the regular JS pipeline. R=mtrofin@chromium.org, ahaas@chromium.org Review-Url: https://codereview.chromium.org/2342263002 Cr-Commit-Position: refs/heads/master@{#39484}
-
mtrofin authored
We'd like wasm regressions to live under a subfolder of the mjsunit regression folder. BUG= Review-Url: https://codereview.chromium.org/2344373002 Cr-Commit-Position: refs/heads/master@{#39483}
-
- 16 Sep, 2016 11 commits
-
-
bakkot authored
Normally the parser just uses AstConsStrings to concatenate, but some types require an AstRawString. This patch adds an AstValueFactory method which produces one from two AstRawStrings. Review-Url: https://codereview.chromium.org/2348783002 Cr-Commit-Position: refs/heads/master@{#39482}
-
adamk authored
R=neis@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2347933002 Cr-Commit-Position: refs/heads/master@{#39481}
-
littledan authored
This patch implements a bug fix to the async/await specification described at https://github.com/tc39/ecma262/pull/692#issuecomment-247488411 Namely, the intermediate values of Promises may be rejected, and they do not have .then called on them anymore (now that the memory leak is fixed), but they do not correspond do unhandled rejections. This change has been tested manually with integration with Blink; once it is checked in and rolled, then further tests can be added on the Blink side for the uncaught rejection handler and async/await. BUG=v8:4483 Review-Url: https://codereview.chromium.org/2338273007 Cr-Commit-Position: refs/heads/master@{#39480}
-
littledan authored
This patch closes a memory leak in async/await where the desugaring was creating a situation analagous to that described in v8:5002. Intermediate Promises were being kept alive, so a long-running loop would cause linear memory usage on the heap. This patch returns undefined to the 'then' callback passed into PerformPromiseThen in order to avoid this hazard. Test expectations are fixed to remove expecting extraneous events which occurred on Promises that are now not given unnecessarily complex resolution paths before being thrown away. BUG=v8:5390 Review-Url: https://codereview.chromium.org/2334323006 Cr-Commit-Position: refs/heads/master@{#39479}
-
martyn.capewell authored
For denominators that are powers of two, replace Float64 division with multiplication by the reciprocal. Additionally, replace division by -1 with negation, and multiplication by two with addition. BUG= Review-Url: https://codereview.chromium.org/2347573002 Cr-Commit-Position: refs/heads/master@{#39478}
-
neis authored
Rename JSModule to Module and make it a Struct rather than a JSObject. We will later add a separate JSModuleNamespace object to implement the 'import * as foo' syntax. BUG=v8:1569 Review-Url: https://codereview.chromium.org/2345823002 Cr-Commit-Position: refs/heads/master@{#39477}
-
ishell authored
This CL also cleans up related interface descriptors: 1) unused StoreTransitionDescriptor is removed and VectorStoreTransitionDescriptor is renamed to StoreTransitionDescriptor. 2) on ia32/x87 architectures slot and vector are passed on the stack (dispatcher/handlers cleanup will be addressed in a separate CL). These two stub ports have to be combined in one CL because: 1) without changing the StoreTransitionDescriptor TF was not able to compile them on ia32/x87 (because of lack of registers), 2) it was not possible to change the descriptor first because Crankshaft was not able to deal with the stack allocated parameters in case of a stub failure. TBR=jkummerow@chromium.org BUG=v8:5269 Review-Url: https://codereview.chromium.org/2313093002 Cr-Commit-Position: refs/heads/master@{#39476}
-
vogelheim authored
Revert of [Tracing] Remove unnecessary memory allocation in runtime call stats. (patchset #1 id:1 of https://codereview.chromium.org/2342643004/ ) Reason for revert: Revert because this breaks V8's roll into Chromium. ASAN complains about memory accesses in a particular unit test. Borked roll CL: https://codereview.chromium.org/2348833002/ Reproduce breakage with: 1, args.gn: v8_deprecation_warnings = true use_goma = true is_asan = true 2, ninja -C out/... content_browsertests 3, out/.../content_browsertests --gtest_filter=V8SamplingProfilerTest.* Original issue's description: > [Tracing] Remove unnecessary memory allocation in runtime call stats. > > Previously we didn't implement TRACE_STR_COPY when we write trace events to > file, which causes us to allocate a growing independent memory chunk for dumped > runtime call stats table. Since we now have a fully functional TRACE_STR_COPY, > this memory allocation can be avoided, this patch removes it. > > BUG=v8:5089 > > Committed: https://crrev.com/e1997bb7d780d12e3a89078e8dd652dcf1d90039 > Cr-Commit-Position: refs/heads/master@{#39462} TBR=cbruni@chromium.org,fmeawad@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Review-Url: https://codereview.chromium.org/2349593004 Cr-Commit-Position: refs/heads/master@{#39475}
-
vogelheim authored
crrev.com/2339933002 and crrev.com/2314663002 were overlapping, so this slipped through the cracks. R=jochen@chromium.org BUG=v8:4947, chromium:646794 Review-Url: https://codereview.chromium.org/2343093002 Cr-Commit-Position: refs/heads/master@{#39474}
-
leszeks authored
Adds a fast path for loading DYNAMIC_LOCAL variables, which are lookup variables that can be context loaded, without calling the runtime, as long as there was no context extension by a sloppy eval along their context chain. BUG=v8:5263 Review-Url: https://codereview.chromium.org/2343633002 Cr-Commit-Position: refs/heads/master@{#39473}
-
mstarzinger authored
The predicate in question should only trigger once and hence the stack height should not be updated incrementally. This puts checks into place ensuring this holds. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2333923008 Cr-Commit-Position: refs/heads/master@{#39472}
-