- 05 Jan, 2021 1 commit
-
-
Benedikt Meurer authored
Consistently use InspectorTest.runAsyncTestSuite() in wasm inspector tests to make tests easier to debug (they'll fail instead of timing out in case of errors). Bug: chromium:1162229, chromium:1071432 Change-Id: I7aada196f9e34071aa1bb059bb45f85f75226060 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2609414 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#71908}
-
- 09 Dec, 2020 1 commit
-
-
Clemens Backes authored
Since there is no dependence defined in gn, the other file will not be uploaded to android devices for testing. We could add this dependence, but not selectively for the one test which actually needs that dependence. Hence fix it by duplicating the test body instead. R=mslekova@chromium.org CC=machenbach@chromium.org Change-Id: Ic65eea05a865cf4f521f66e293c4725bc2861444 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2577475Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71679}
-
- 30 Nov, 2020 3 commits
-
-
Clemens Backes authored
This is a reland of 4719dae1. The "V8 Linux64 TSAN - stress-incremental-marking" bot adds the --stress-incremental-marking flag for all variants, hence the SKIP in the status file was not triggered. We just explicitly disable the --stress-incremental-marking flag for the two new tests. This works for the "stress_incremental_marking" variant as well as the specific bot. Original change's description: > [wasm][inspector][test] Add more tests for code offsets > > The code offsets are sometimes wrong when compiled with streaming > compilation. Thus add more tests for synchronous, asynchronous, and > streaming compilation. The reported code offsets should all match. This > will be fixed in a follow-up CL. > > In order to make asynchronous WebAssembly compilation finish, the > inspector-test executable needs to pump the message loop before waiting > for new tasks to come in, just as other executables like d8. > This is added in this CL, but because of another bug this is skipped in > the stress-incremental-marking variant. Hence the new tests are also > skipped there. > > R=szuend@chromium.org > CC=ahaas@chromium.org > > Bug: chromium:1150303, v8:10748 > Change-Id: Ie1d63c8d6795e61627d838b7fa7b21e6728befc0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562382 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71483} Bug: chromium:1150303 Bug: v8:10748 Change-Id: I9adb9fc0250fab5c43dc85b695f4d338a9c7183c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565128Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71492}
-
Clemens Backes authored
This reverts commit 4719dae1. Reason for revert: Timeouts with --stress-incremental-marking: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20stress-incremental-marking/1093 Original change's description: > [wasm][inspector][test] Add more tests for code offsets > > The code offsets are sometimes wrong when compiled with streaming > compilation. Thus add more tests for synchronous, asynchronous, and > streaming compilation. The reported code offsets should all match. This > will be fixed in a follow-up CL. > > In order to make asynchronous WebAssembly compilation finish, the > inspector-test executable needs to pump the message loop before waiting > for new tasks to come in, just as other executables like d8. > This is added in this CL, but because of another bug this is skipped in > the stress-incremental-marking variant. Hence the new tests are also > skipped there. > > R=szuend@chromium.org > CC=ahaas@chromium.org > > Bug: chromium:1150303, v8:10748 > Change-Id: Ie1d63c8d6795e61627d838b7fa7b21e6728befc0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562382 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#71483} TBR=ahaas@chromium.org,clemensb@chromium.org,szuend@chromium.org Change-Id: Ia4361183bfafeca3cc7d71ffe12d0ec2b0722b49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1150303 Bug: v8:10748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565126Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71484}
-
Clemens Backes authored
The code offsets are sometimes wrong when compiled with streaming compilation. Thus add more tests for synchronous, asynchronous, and streaming compilation. The reported code offsets should all match. This will be fixed in a follow-up CL. In order to make asynchronous WebAssembly compilation finish, the inspector-test executable needs to pump the message loop before waiting for new tasks to come in, just as other executables like d8. This is added in this CL, but because of another bug this is skipped in the stress-incremental-marking variant. Hence the new tests are also skipped there. R=szuend@chromium.org CC=ahaas@chromium.org Bug: chromium:1150303, v8:10748 Change-Id: Ie1d63c8d6795e61627d838b7fa7b21e6728befc0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562382Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#71483}
-
- 19 May, 2020 1 commit
-
-
Clemens Backes authored
This is a reland of 3cc981cb with a fix for data race detected by TSan. Original change's description: > [wasm][debug] Fix tier down during streaming compilation > > If the debugger is enabled while streaming compilation is happening, we > won't correctly tier down to Liftoff. This is because during streaming > compilation, we always compile for no debugging. Fixing that is a bit > tricky, since when the debugger is enabled, functions can either already > have finished compiling, or they are currently being compiled, or their > wire bytes are not received yet. > Instead of handling this correctly while streaming compilation is > running, we just recompile the whole module with Liftoff after streaming > compilation finished. > > For testing this, we use the existing tests for async compilation, and > enable --wasm-test-streaming, which compiles via the streaming decoder > even in the async compilation case. > > R=thibaudm@chromium.org > > Bug: v8:10531 > Change-Id: I0177248a9ad2e90f83faee965d6746de05423f1f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207133 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67882} Bug: v8:10531, v8:10544 Change-Id: I884922b6ac55543e6ff9b1046438f6b3abab6f64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2207187Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67896}
-
- 25 Feb, 2020 1 commit
-
-
Andreas Haas authored
This is a reland of 03d5a7ba Nothing changed here compared to the original test. The tests on the blink side were invalid, I fixed them in https://crrev.com/c/2066907. Original change's description: > [wasm] The name of a custom section can cause a validation error > > The WebAssembly spec defines that the name of a custom section can cause > a validation error. The streaming decoder, however, used a separate > Decoder object to decode the name, and thereby avoided a validation > error. With this CL the streaming decoder uses the main decoder to > decode the name of the custom section. > > In addition this CL removes the test mjsunit/regress/wasm/regress-789952. > This test defined an invalid WebAssembly module and expected it to > compile. As it is a regression test, it makes no sense to fix the test. > The module is invalid because it defines the length of the custom section > to be '0', so there are no bytes in the custom section for its name. > > R=clemensb@chromium.org > CC=thibaudm@chromium.org > > Bug: v8:10126 > Change-Id: I8cfc77c9a5916570d5362d5922e0179a29774da8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2041446 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#66348} Bug: v8:10126 Change-Id: I48aaed8eb9899da1703030fb6809fe46a6e66191 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069325 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66431}
-
- 12 Feb, 2020 1 commit
-
-
Georg Neis authored
It's not sufficient to reset only the modules on the current DFS path. Bug: chromium:1050164 Change-Id: I00e5e12144ad70ac6371eea5e11590b72feaeecc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049853 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#66229}
-
- 16 Jan, 2020 1 commit
-
-
Jakob Gruber authored
The advance-by parameter can contain negative numbers, but until this CL was treated as unsigned. Bug: v8:10072,v8:9330 Change-Id: Ib9a9c2d47ba71fa819e89502d14871af6dfc9693 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002543 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#65809}
-
- 14 Jan, 2020 1 commit
-
-
Leszek Swirski authored
The fix in https://crrev.com/c/1997135 didn't properly recurse the cache scope after a with scope, passing the current scope rather than the original cache scope up the recursion. Now the "use external cache" check is done in LookupWith (and, analogously, LookupSloppyEval) while passing the given cache scope through the Lookup recursion. Fixed: chromium:1041210 Fixed: chromium:1041616 Change-Id: I5ac9ddc6c16d63b59aa034721fccec2f7781c4f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2000133 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65754}
-
- 07 Jan, 2020 1 commit
-
-
Leszek Swirski authored
During conflict detection, we want to early exit the scope loop when we find a non-conflict, but continue looking at the other declarations in the scope. Bug: chromium:1038588 Change-Id: Ia2a19b02222fbd13cec70d3a60d2f5bae4ce245b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1985991 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65602}
-