- 14 Nov, 2018 18 commits
-
-
Michael Starzinger authored
This makes the above factory function use a fine-grained scope when unlocking code space for modification. It now uses a cumulative per-page scope that collects only those memory chunks that needed to be touched during allocation. R=ulan@chromium.org Change-Id: I22de0fae8be507ba9d51868f668b902b3bae3d6a Reviewed-on: https://chromium-review.googlesource.com/c/1335558Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57503}
-
Clemens Hammacher authored
Variables of type {ExecutionTier} should be called "tier", not "mode". R=ahaas@chromium.org Bug: v8:8238 Change-Id: I09c640398ab8ad34ac6591d42ea7b0f9ba83d620 Reviewed-on: https://chromium-review.googlesource.com/c/1335688Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57502}
-
Clemens Hammacher authored
The callbacks must follow a specific order. This CL adds checks for that. This helped debugging an issue in a follow-up CL. R=ahaas@chromium.org Bug: v8:7921 Change-Id: I78e1caf9923e95401652d2a3952dcf29c2967062 Reviewed-on: https://chromium-review.googlesource.com/c/1325965Reviewed-by:
-
Igor Sheludko authored
Also add comments and regression tests. Bug: chromium:904272 Change-Id: I89e8ec537bbdce09fda120cd29d5a5e54e77cf19 Reviewed-on: https://chromium-review.googlesource.com/c/1335556Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57500}
-
Sathya Gunasekaran authored
Now we can pass in the prefix size to OrderedHashTable directly from the Derived class and have it calculate the hash table start offset based on this. Bug: v8:6443, v8:7569 Change-Id: I80d54b65116e18f5a0cab18eb51649adad447cce Reviewed-on: https://chromium-review.googlesource.com/c/1333682 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#57499}
-
Michael Starzinger authored
This makes the above factory function use a fine-grained scope when unlocking code space for modification. It is now based on the memory chunk of the resulting code object. R=ulan@chromium.org Change-Id: Iabe6fba7595ba3264b21bcd6f6634ab9725eaad9 Reviewed-on: https://chromium-review.googlesource.com/c/1335687Reviewed-by:
-
Leszek Swirski authored
Always generate a token for the first character in ScanSingleToken, and switch on that. If the token could change with subsequent characters, e.g. Token::ADD into Token::ASSIGN_ADD, then handle that in that token's case rather than going character-by-character. This allows us to have a tighter packing of the cases, and early detect numbers, keywords and identifiers. Change-Id: I8c3ac7a5453547abeb09fc90826a26390b15a415 Reviewed-on: https://chromium-review.googlesource.com/c/1335547Reviewed-by:
-
Ivica Bogosavljevic authored
This CL implements AtomicPair operators: Load, Store, Add, Sub, Or, Xor, And, Exchange and CompareExchange using runtime on MIPS32R2 and older. MIPS32R6 includes instructions for 64-bit atomic access so they are implemented using those. Change-Id: I1309c1ea4771480516ec5a92f7592533bdcb205c Reviewed-on: https://chromium-review.googlesource.com/c/1326466Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57496}
-
Predrag Rudic authored
Build started to fail after this commit: bd0a7fd6. Change-Id: I2b628c067f6e5120d19498fd0b766c5233baf3e1 Reviewed-on: https://chromium-review.googlesource.com/c/1335552Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57495}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Idb11b07df72f2d9d1c606d04af701cb4e9853664 Reviewed-on: https://chromium-review.googlesource.com/c/1335549Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57494}
-
Toon Verwaest authored
Change-Id: I084b57a3a32c9ecb01bb17c9339dfeada436ea66 Reviewed-on: https://chromium-review.googlesource.com/c/1335449 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57493}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Iacfa93bdce7d8d175db9e606b7c667e4c967da51 Reviewed-on: https://chromium-review.googlesource.com/c/1335451Reviewed-by:
-
Georg Neis authored
Bug: chromium:904417, v8:7790 Change-Id: Ie1edc179c88747a2515f2c42b4820ce3126bfe43 Reviewed-on: https://chromium-review.googlesource.com/c/1331478Reviewed-by:
-
Michael Achenbach authored
Apparently the first attempt wasn't working yet: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm/8806 TBR=sergiyb@chromium.org NOTRY=true Change-Id: I5864845e59508cd4cd1836798b56539d74bbb82e Reviewed-on: https://chromium-review.googlesource.com/c/1335450Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57490}
-
Toon Verwaest authored
Change-Id: Ib910d034aff130dfe4324d020eacb0e7bf185d30 Reviewed-on: https://chromium-review.googlesource.com/c/1335447Reviewed-by:
-
peterwmwong authored
[builtins] Adjust String.prototype.matchAll as per spec changes (https://github.com/tc39/proposal-string-matchall/pull/38) - Removes IsRegExp check and special handling when false - Removes MatchAllIterator - Extracts previously inlined CreateRegExpStringIterator - Update comments to match spec text and numbering Bug: v8:6890 Change-Id: Ie81757a499acc77910f029835fb042e70d86d83d Reviewed-on: https://chromium-review.googlesource.com/c/1317830 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57488}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Change-Id: Ie45a93dc851f0bc12800cbd91fe324c854b1dcb6 Reviewed-on: https://chromium-review.googlesource.com/c/1335448Reviewed-by:
-
Michael Achenbach authored
This is to prevent errors like: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm/8792 The error code suggests the OS killed the tests due to OOM. The time it took suggests OS paging. Fewer tests in parallel should mitigate this. NOTRY=true Change-Id: I847058cfb02a9a36795581df47760d921d695141 Reviewed-on: https://chromium-review.googlesource.com/c/1333674 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#57486}
-
- 13 Nov, 2018 22 commits
-
-
Junliang Yan authored
Port bd0a7fd6 Original Commit Message: This reduces the build steps after touching counters.h from 710 to 191, thus detaching counters.h from the giant include cluster. R=marja@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:7490,v8:8238 LOG=N Change-Id: I7694a21856c228c6d0335c1f1e5e9177c96cc7da Reviewed-on: https://chromium-review.googlesource.com/c/1333940Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57485}
-
Frank Tang authored
Remove old code in v8::Date::DateTimeConfigurationChangeNotification Add code to clear date time cache object in isolate. Running benchmark python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Strings/StringLocaleCompare" \ test/js-perf-test/JSTests.json python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Dates" \ test/js-perf-test/JSTests.json python -u tools/run_perf.py --binary-override-path \ out/x64.release/d8 --filter "JSTests/Numbers" \ test/js-perf-test/JSTests.json BEFORE THE FIX: StringLocaleCompare-Strings(Score): 184287 toLocaleDateString-Dates(Score): 10456 toLocaleString-Dates(Score): 10436 toLocaleTimeString-Dates(Score): 10700 toLocaleString-Numbers(Score): 2935 AFTER THE FIX in Patch Set 13: StringLocaleCompare-Strings(Score): 57470000 toLocaleDateString-Dates(Score): 6141000 toLocaleString-Dates(Score): 4093000 toLocaleTimeString-Dates(Score): 6323000 toLocaleString-Numbers(Score): 3371000 Bug: chromium:901748, chromium:901747, v8:5751 Change-Id: I7578e2ced0fe967dce6424d17f15ab806cc522be Reviewed-on: https://chromium-review.googlesource.com/c/1320892 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57484}
-
Tobias Tebbi authored
This CL is an experiment to get more performance data from the perf-bots and will likely lead to regressions. The try-bots (see patcheset 9) indicate some regressions, but it doesn't seem too bad. Change-Id: Ia173ab20ee2a4904663db0f4ca2ffb196b203c77 Reviewed-on: https://chromium-review.googlesource.com/c/1319763 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Mike Stanton authored
Now you can type: tools/torque/format-torque.py -i src/builtins/*.tq to format all the torque files in a particular directory. Is handy. TBR=danno@chromium.org Bug: v8:7793 Change-Id: Ifba85c4db553e19a65b87217fd2f670698c6b2c9 Reviewed-on: https://chromium-review.googlesource.com/c/1333679Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#57482}
-
Sathya Gunasekaran authored
With this we can just shortcircuit parsing if we see an incorrect Token::COMMA or Token::COLON when parsing class literals. Change-Id: Idd0c0c33b035b821ed23174f9cb1b12616a2a621 Reviewed-on: https://chromium-review.googlesource.com/c/1333678Reviewed-by:
-
Michael Stanton authored
This reverts commit 96a17c03. Reason for revert: Caused the tree to close Original change's description: > [Torque] format-torque.py accepts wildcards > > Now you can type: > tools/torque/format-torque.py -i src/builtins/*.tq > > to format all the torque files in a particular directory. Is handy. > > Bug: v8:7793 > Change-Id: I334b2c555c63fd7864636ebfd83a2631a5d44806 > Reviewed-on: https://chromium-review.googlesource.com/c/1333671 > Reviewed-by: Daniel Clifford <danno@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57479} TBR=danno@chromium.org,mvstanton@chromium.org Change-Id: Ib531bd2f20f438ef95b657eb86356ee724fa5b39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7793 Reviewed-on: https://chromium-review.googlesource.com/c/1333677Reviewed-by:
-
Mike Stanton authored
Now you can type: tools/torque/format-torque.py -i src/builtins/*.tq to format all the torque files in a particular directory. Is handy. Bug: v8:7793 Change-Id: I334b2c555c63fd7864636ebfd83a2631a5d44806 Reviewed-on: https://chromium-review.googlesource.com/c/1333671Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#57479}
-
Tobias Tebbi authored
This is important for transient types, which might be invalidated in a loop syntactically below the vulnerable use. Bug: v8:7793 Change-Id: Ia97c03282eefbc44d54beb8edc61f5d44af2c947 Reviewed-on: https://chromium-review.googlesource.com/c/1331547Reviewed-by:
-
Michael Starzinger authored
This refactoring hides the fact that some wrappers are first generated in the GC'ed heap and then copied into the native module. It is a first step towards avoiding the redundant copy. R=clemensh@chromium.org Change-Id: I531fa42e8b4c210948d306624007348a39b981e0 Reviewed-on: https://chromium-review.googlesource.com/c/1333673 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=v8:8179 Change-Id: I7dc024fe4880a787cadac8b79bca6da87e2d36de Reviewed-on: https://chromium-review.googlesource.com/c/1328926 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I9c022d8d1aa363168546303516b5b3ee6196fdb5 Reviewed-on: https://chromium-review.googlesource.com/c/1333412 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57475}
-
Daniel Clifford authored
In the process, move the rest of the implementation PLabels into the CodeAssembler for consistency. Change-Id: I56872d9fc756db066f0d13d87aeb55ec04de2495 Reviewed-on: https://chromium-review.googlesource.com/c/1329687 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57474}
-
Toon Verwaest authored
Change-Id: Ib73eca9233252a4b5b89f91cae1762528552c1b5 Reviewed-on: https://chromium-review.googlesource.com/c/1333407 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Daniel Clifford authored
Use same value to rethrow as was used before this change. This doesn't appear to be explicitly tested anywhere, but the behavior should stay unchanged nevertheless. Change-Id: Idaed90a143e9775746f034190918065897094acb Reviewed-on: https://chromium-review.googlesource.com/c/1329684Reviewed-by:
-
Michael Achenbach authored
Prevent timeouts like: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/23124 TBR=sergiyb@chromium.org NOTRY=true Change-Id: I550a0d85366aa7171e2e23b2f6d2482ec953eb52 Reviewed-on: https://chromium-review.googlesource.com/c/1333672Reviewed-by:
-
tzik authored
This CL replaces most of Isolate::GetEnteredContext with GetEnteredOrMicrotaskContext, as it should be more relevant. Here is a brief overview of the series of changes. https://docs.google.com/document/d/1MY_xlsYS7E6_qbwwY66-FH3JkAYeTHBlF5qVBrBpWyY/edit#heading=h.fx2rezbyzz5c Bug: v8:8124 Change-Id: I27355e325a92094240c25b672d1219f3214a9da0 Reviewed-on: https://chromium-review.googlesource.com/c/1297654Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Mike Stanton authored
BUG=v8:7793 Change-Id: Ibcf16998ef9a44ae899a2536ccf02af1b7b7193d Reviewed-on: https://chromium-review.googlesource.com/c/1333410 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Marja Hölttä authored
This reduces the build steps after touching counters.h from 710 to 191, thus detaching counters.h from the giant include cluster. BUG=v8:7490,v8:8238 Change-Id: I0c7e707fb945e293f8a5604cc8da438cd35b3210 Reviewed-on: https://chromium-review.googlesource.com/c/1329695 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: I19e23a1e91631a21d55bb5a42f1f538a655478f8 Reviewed-on: https://chromium-review.googlesource.com/c/1332233 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Just moving code around a bit. R=ahaas@chromium.org Bug: v8:7921 Change-Id: I6a9f9dab41360e9a0d8249fe77260788151cd88b Reviewed-on: https://chromium-review.googlesource.com/c/1333411Reviewed-by:
-
Clemens Hammacher authored
We were outputting the address of the WasmCodeManager instead of the native module. R=ahaas@chromium.org Change-Id: I70f0aca4ef9126b91fcc3716570bfc69e71d27c7 Reviewed-on: https://chromium-review.googlesource.com/c/1326024Reviewed-by:
-
Leszek Swirski authored
For some reason the C++ compiler fails to realise that next_ cannot change on entry into Scan from Next, and re-loads it, creating what looks like a data dependency that stalls the next instruction. Passing through a cached next_ value cleans up the generated code. Change-Id: Iab62ed1890a3a720e5fa90a90e802305e3d55a82 Reviewed-on: https://chromium-review.googlesource.com/c/1331551 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
