- 10 Sep, 2018 12 commits
-
-
Sreten Kovacevic authored
* Enable Liftoff wasm cctests on BE for mips and mips64 * Fix issues that were introduced with these tests and that are linked with Load/Store instructions * Change endianness on GetGlobal and SetGlobal, as done in TF * Skip I32Binop tests that fail with OOM error and seem to not be related directly to this task Bug: v8:6600 Change-Id: Ib62ca5e3c681326d28e70a5157d8646e0c8d0b51 Reviewed-on: https://chromium-review.googlesource.com/1213183 Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55751}
-
Tobias Tebbi authored
This CL makes sure, that logical operators (||, &&) always have return type never. Together with a check that never is never passed as a function argument, this prevents faulty evaluation as in !(x || y). Before, the logical operators had a behavior similar to (bool labels Taken, NotTaken), with a fast exit if the left-hand side allowed shor-circuit evaluation, but returning the right-hand side otherwise. Since we want to allow existing (a || b || c) patterns in the codebase, this requires weakening the restriction that the left- and right-hand side need to have the same type. Now the possibilites are: bool, never never, bool never, never bool, bool constexpr bool, constexpr bool Bug: v8:8137 Change-Id: I9576b337dc4008ac58b4625e77fef4e73bcdd6e3 Reviewed-on: https://chromium-review.googlesource.com/1215162Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55750}
-
Clemens Hammacher authored
If there are many workers and we are very unlucky, the cmpxchg loop can in fact fail for more than 5 times. This CL removes this unneeded limitation to avoid spurious failures. R=mstarzinger@chromium.org Bug: chromium:824443 Change-Id: I0a6adde1330c8a8389a42b36bf44e516fae8c574 Reviewed-on: https://chromium-review.googlesource.com/1213170Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55749}
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:8015, chromium:824443 Change-Id: I017e8bf9033fba1afdddcc5e3057860519dfc119 Reviewed-on: https://chromium-review.googlesource.com/1213210Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/66badbd..25c380c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Iaf3e13ec8f9174321c61016c622a046a71ef6335 Reviewed-on: https://chromium-review.googlesource.com/1214867 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55747}
-
Simon Zünd authored
This CL fixes a bug that allowed calls to Array.p.shift on zero-length arrays where the 'length' is read-only without throwing a TypeError. R=bmeurer@chromium.org, jgruber@chromium.org Bug: chromium:882233 Change-Id: Ib129ab4c4f4f233e7bb553effa77539badfbe26e Reviewed-on: https://chromium-review.googlesource.com/1215164Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#55746}
-
Georg Neis authored
It used to call the old IterableToList, which had the wrong semantics for holes. Bug: v8:8133 Change-Id: Idd5acd55a155bc43df7552135a44151bb2db38e9 Reviewed-on: https://chromium-review.googlesource.com/1213204Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55745}
-
Igor Sheludko authored
Bug: v8:8096 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If44c1a9a76c517fe329485d385f445b2be9f5ec2 Reviewed-on: https://chromium-review.googlesource.com/1213186Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55744}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I7ae9463768969d2821b19fa0d8c8a498d51f6b40 Reviewed-on: https://chromium-review.googlesource.com/1209943Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55743}
-
Stephan Herhut authored
This will replace "<?>" in certain debug output with the empty string. There should be no end-user visible changes, though. Change-Id: I80db2f2169532c600662977025185378004f7cd5 Reviewed-on: https://chromium-review.googlesource.com/1213188 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Bug: v8:6344, v8:8015 Change-Id: I6d96f039b47980f9df8d06c4097b70012fce3c82 Reviewed-on: https://chromium-review.googlesource.com/1215163Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55741}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f022f91..66badbd Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/a191af9..7ca3ffa TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I06c1f34978d0cbb0a3deb1ae5b5d3b732c289186 Reviewed-on: https://chromium-review.googlesource.com/1215009 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 09 Sep, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ead23c2..c869f29 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/4d2b901..f022f91 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ib6ed7ffe55424e26cf9189c71edf26a96b010e62 Reviewed-on: https://chromium-review.googlesource.com/1214588 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 08 Sep, 2018 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6533d05..0e1589b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bcc3e49..ead23c2 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/dd2c588..4d2b901 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I09c274664aa830bc8ad5892230fdc78f3753d25d Reviewed-on: https://chromium-review.googlesource.com/1214584 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 07 Sep, 2018 26 commits
-
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I2642a8a693f9803949bc279892dffdcac0b6144c Reviewed-on: https://chromium-review.googlesource.com/1212465 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55737}
-
Sathya Gunasekaran authored
Makes for a nicer stack trace Bug: v8:5367 Change-Id: I6d77907e08c2c4efc7a1b25016c7e83841c7c574 Reviewed-on: https://chromium-review.googlesource.com/1211444 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Daniel Ehrenberg <littledan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55736}
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org Change-Id: Ic5e8ea11035ad77d4a47e600283f83941ca5af43 Reviewed-on: https://chromium-review.googlesource.com/1213213Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55735}
-
Michael Achenbach authored
The isolates step times out due to some very slow tests. Marking as slow changes the test order and increases throughput. NOTRY=true TBR=yangguo@chromium.org Change-Id: Iaaf6fe93e7f0e17266923d1ab6f0fe7b09abea9e Reviewed-on: https://chromium-review.googlesource.com/1213212Reviewed-by:
-
Mike Stanton authored
An unnecessary call to ToString() on the array index caused trips to the runtime. The fix also includes performance micro-benchmarks so we'll have a harder time regressing this case in future. TBR=tebbi@chromium.org Bug: v8:8112 Change-Id: I781e8b1bbe2eb56db961cf33b0dca8523868b83d Reviewed-on: https://chromium-review.googlesource.com/1213207 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55733}
-
🎉 Mathias Bynens authoredThis is a reland of 4dac9872 Original change's description: > Ship globalThis
🎉 > > Proposal repository: > https://github.com/tc39/proposal-global > > Intent to ship: > https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ > > Bug: v8:5537 > Change-Id: I60a6c5375165d89548db12fef454a64137d04c27 > Reviewed-on: https://chromium-review.googlesource.com/1195494 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55543} TBR=adamk@chromium.org,machenbach@chromium.org,gsathya@chromium.org,mathias@chromium.org No-Presubmit: true Bug: v8:5537 Change-Id: I1e20d606bb027d7afca713ffde87e183b6f610bd Reviewed-on: https://chromium-review.googlesource.com/1208633Reviewed-by:Mathias Bynens <mathias@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#55732}
-
Benedikt Meurer authored
For strict equality `a === b` with Symbol feedback we need to check only one side via CheckSymbol, since the resulting comparison can only be true if both sides are symbols. For consistency with the receivers case we check the left side, so CheckSymbol(a). This significantly reduces the number of CheckSymbol operations in optimized code for the ARES-6 Air benchmark. Bug: v8:6344 Change-Id: I50420f8d862fec31214b7e86b17919edcfc1f23e Reviewed-on: https://chromium-review.googlesource.com/1213173 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55731}
-
Michael Achenbach authored
Seems like most lifeedit tests are not predicable. NOTRY=true TBR=yangguo@chromium.org Bug: v8:8147 Change-Id: Ia0a3871112f5a6f4b5821ee401bfdfd26dd8f9e5 Reviewed-on: https://chromium-review.googlesource.com/1213211Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/86b5efe..f10582e TBR=adamk@chromium.org,gsathya@chromium.org Change-Id: I487211c0d77c74f88fa3b5fda23363cb255cfaa8 Reviewed-on: https://chromium-review.googlesource.com/1213344 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Michael Achenbach authored
Though it works with other variants apparently, we don't want to waste to many resources for now. NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:866862 Change-Id: I8da2808fec183efa1bf325664ecf33f18a5b02fc Reviewed-on: https://chromium-review.googlesource.com/1213187Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55728}
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org Bug: v8:8147 Change-Id: I596d9a798440c50bc43b5250bd4f09a3392934a9 Reviewed-on: https://chromium-review.googlesource.com/1213022Reviewed-by:
-
Igor Sheludko authored
... and add move constructor and move assignment operator. Also define some VirtualMemory parameters as r-values to explicitly express that the ownership is passed from the caller to callee. Bug: v8:8015 Change-Id: Iee27ddc844556dc7465177656b339cd1f83a3b56 Reviewed-on: https://chromium-review.googlesource.com/1213062Reviewed-by:
-
Benedikt Meurer authored
This replaces the previous CheckStringAdd operator which deopts in case the combined length overflows with a dedicated pure StringConcat operator. This operator is similar to NewConsString in that it takes the resulting length plus the two input strings. The operator relies on the length being checked explicitly by the surrounding code instead of baking the check into the operator itself. This way TurboFan can eliminate redundant/unnecessary StringConcat operations, since they are pure now. This also unifies the treatment of string addition in JSTypedLowering, and generalizes the StringLength constant-folding to apply to more cases not just the JSAdd cases inside JSTypedLowering. Bug: v8:7902, v8:8015 Change-Id: I987ec39815a9464fd5fd9c4f7b26b709f94f2b3f Reviewed-on: https://chromium-review.googlesource.com/1213205Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55725}
-
Maya Lekova authored
This optimization addresses a case triggered by the Templates/Untagged js-perf-test, in which template literals get compiled to a cascade of JSAdd(JSAdd, JSToString) nodes. Before the optimization in https://chromium-review.googlesource.com/c/v8/v8/+/1193342 JSToString no-ops used to get optimized away during typed lowering together with constant folding of string concatenation. This change allows us to get rid of a no-op JSToString call during native context specialization, thus allowing for constant folding of JSAdd to kick in and CheckStringAdd nodes to not be generated at all. This change also removes the NumberToString optimization from typed lowering, as it's being executed during earlier stage. Bug: chromium:879083 Change-Id: I1d8155ed969b6959fbb86fca21e4714b88a2695a Reviewed-on: https://chromium-review.googlesource.com/1202622 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Michael Achenbach authored
The cctest and unittests suites call the test executable to list the tests, which requires pushing the executables to the device on Android. NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:866862 Change-Id: I318dff7af2b2de3b8642ec4b6ba30b602da808bb Reviewed-on: https://chromium-review.googlesource.com/1213202Reviewed-by:
-
Stephan Herhut authored
Add a test that runs multiple workers that concurrently try to advance along a random sequence of numbers, using AtomicCompareExchange to update the shared current position. Change-Id: Ie073bbdce6fd6766ef1f73f996dd592b90b8b3c2 Reviewed-on: https://chromium-review.googlesource.com/1198769 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55722}
-
Florian Sattler authored
Bug: v8:8015 Change-Id: If6017a85683efcc847dab8034fdd82ac51106317 Reviewed-on: https://chromium-review.googlesource.com/1213182Reviewed-by:
-
Benedikt Meurer authored
This reverts commit 0aac3884. Reason for revert: Various performance regressions (Blink and JSTests). Original change's description: > [turbofan] Be more consistent about Smi comparisons. > > This changes SimplifiedLowering to be more consistent when chosing Smi > representation as input for Number comparisons. We already had some > isolated logic for doing (speculative) Number comparisons on Smis, but > only in the case where that decision was based on type feedback, not on > information already present in the graph. > > Bug: v8:7703 > Change-Id: I25370ade630917675a6ac79b5ae6a8afd253dfc7 > Reviewed-on: https://chromium-review.googlesource.com/1196422 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55518} TBR=jarin@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7703, chromium:881758, chromium:881759, chromium:881760 Change-Id: I4af9c0b0ad37dea17ceabeb721c92a7cc978987a Reviewed-on: https://chromium-review.googlesource.com/1213185Reviewed-by:
-
Benedikt Meurer authored
Make the TurboFan Typer infer proper types for calls to the known Symbol.prototype.toString() and Symbol.prototype.valueOf() builtins. Bug: v8:8015 Change-Id: Ia133bd8f2cfcabaf984820a953b357d1747d6892 Reviewed-on: https://chromium-review.googlesource.com/1213203 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Splits PreParsedScopeDataBuilder out of ProducedPreParserScopeData to make the split between building PreParsedScopeData and using already build PreParserScopeData more explicit. BUG=v8:8041 Change-Id: Iab42cab84c247152c14ac39f3136f985753160ec Reviewed-on: https://chromium-review.googlesource.com/1202104 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
jgruber authored
The first: we allocated within the argument list of a function call on a handlified receiver. The allocation may trigger GC which leaves us with a stale receiver reference. The second: in generated code we triggered further allocations while an uninitialized fixed array was live. Bug: v8:8145 Change-Id: If59cab6274277534b2ff6463daa5863b8feae22c Reviewed-on: https://chromium-review.googlesource.com/1213162Reviewed-by:
-
Ulan Degenbaev authored
This is needed to implement a new metric that measures health of Web Page Replay archives. Bug: chromium:880432 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I59aed22e4671e491fc3a30d04fbdce1643404b32 Reviewed-on: https://chromium-review.googlesource.com/1204570 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I4062fea76f0db405e38f5f5b7d8b78409ff57357 Reviewed-on: https://chromium-review.googlesource.com/1209787 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55715}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I6bf929bea03a59b40f205482b7604f44e61bc6f8 Reviewed-on: https://chromium-review.googlesource.com/1209846 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Florian Sattler authored
String find has a faster overload for char, hence, we should pass a char instead of a string where possible. Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I49611d84bfb195992b6e2de538a726a8654b7b71 Reviewed-on: https://chromium-review.googlesource.com/1209348 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Florian Sattler authored
In these cases the std::function state does not change, hence, it can be a const ref. Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I221b0c3e18c5c1f54d35d671445d2e947cf64c02 Reviewed-on: https://chromium-review.googlesource.com/1209822 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
