- 10 Jul, 2015 24 commits
-
-
mbrandy authored
Port e50c861b R=mstarzinger@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1230973006 Cr-Commit-Position: refs/heads/master@{#29583}
-
mbrandy authored
Port 8965b683 Original commit message: Break point at calls are currently set via IC. To change this, we need to set debug break slots instead. We also need to distinguish those debug break slots as calls to support step-in. To implement this, we add a data field to debug break reloc info to indicate non-call debug breaks or in case of call debug breaks, the number of arguments. We can later use this to find the callee on the evaluation stack in Debug::PrepareStep. R=yangguo@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1231173002 Cr-Commit-Position: refs/heads/master@{#29582}
-
paul.lind authored
Do the check in release mode, too. Prefer crash over mis-patched branch instruction. BUG=v8:4294 LOG=N Review URL: https://codereview.chromium.org/1233623004 Cr-Commit-Position: refs/heads/master@{#29581}
-
arv authored
Goodbyes are not forever. Goodbyes are not the end. They simply mean I’ll miss you Until we meet again! ~Author Unknown BUG=N LOG=N R=adamk@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1208423016 Cr-Commit-Position: refs/heads/master@{#29580}
-
verwaest authored
Revert preallocating of descriptors since right now getters and setters cause copying of descriptor arrays BUG= Review URL: https://codereview.chromium.org/1225213008 Cr-Commit-Position: refs/heads/master@{#29579}
-
arv authored
We have to call CheckConflictingVarDeclarations in case we have enabled --harmony-sloppy BUG=v8:4287 LOG=N R=littledan@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1226103002 Cr-Commit-Position: refs/heads/master@{#29578}
-
arv authored
With --harmony-sloppy we can get to a runtime store in the presence of an eval. We therefor need to check that the value is not the hole which is used to enforce TDZ. BUG=v8:4284 LOG=N R=rossberg@chromium.org, littledan@chromium.org Review URL: https://codereview.chromium.org/1214733013 Cr-Commit-Position: refs/heads/master@{#29577}
-
verwaest authored
For now it uses a pretty slow path for accessing strings by wrapping it into a new temporary wrapper. BUG=v8:4042, v8:3088 LOG=y Review URL: https://codereview.chromium.org/1221303019 Cr-Commit-Position: refs/heads/master@{#29576}
-
verwaest authored
BUG=v8:4177 LOG=n Review URL: https://codereview.chromium.org/1233493007 Cr-Commit-Position: refs/heads/master@{#29575}
-
verwaest authored
BUG=v8:4137, v8:4177 LOG=n Review URL: https://codereview.chromium.org/1230213002 Cr-Commit-Position: refs/heads/master@{#29574}
-
yangguo authored
- we now have 6 bits to store RelocInfo mode. - removed a redundant tag byte per long reloc info entry. - renamed methods to be more precise. Review URL: https://codereview.chromium.org/1230183002 Cr-Commit-Position: refs/heads/master@{#29573}
-
machenbach authored
This allows running two executables interleaved to reduce flakiness of tryjobs. The executables must reside in different out directories. BUG=chromium:507213 LOG=n NOTRY=true TEST=python -m unittest run_perf_test Review URL: https://codereview.chromium.org/1215273003 Cr-Commit-Position: refs/heads/master@{#29572}
-
verwaest authored
BUG=v8:4137,v8:4177 LOG=n Review URL: https://codereview.chromium.org/1232463005 Cr-Commit-Position: refs/heads/master@{#29571}
-
verwaest authored
BUG=chromium:507980 LOG=n Review URL: https://codereview.chromium.org/1234553002 Cr-Commit-Position: refs/heads/master@{#29570}
-
hablich authored
BUG= TBR=machenbach@chromium.org,vogelheim@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1235573002 Cr-Commit-Position: refs/heads/master@{#29569}
-
yangguo authored
If we do it too early, we might get a constant pool between the reloc info and the actual slot. R=ulan@chromium.org Review URL: https://codereview.chromium.org/1229673005 Cr-Commit-Position: refs/heads/master@{#29568}
-
ishell authored
BUG=chromium:490021 LOG=N Review URL: https://codereview.chromium.org/1235563002 Cr-Commit-Position: refs/heads/master@{#29567}
-
epertoso authored
Review URL: https://codereview.chromium.org/1230173002 Cr-Commit-Position: refs/heads/master@{#29566}
-
ulan authored
BUG=chromium:508584 LOG=NO Review URL: https://codereview.chromium.org/1230163002 Cr-Commit-Position: refs/heads/master@{#29565}
-
bmeurer authored
EnumtSet has been deprecated for quite some time, and replaced with the more general and type safe base::Flags template class. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1229233002 Cr-Commit-Position: refs/heads/master@{#29564}
-
machenbach authored
BUG=v8:4279 LOG=n NOTRY=true TBR=jarin@chromium.org Review URL: https://codereview.chromium.org/1235493005 Cr-Commit-Position: refs/heads/master@{#29563}
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1213623020 Cr-Commit-Position: refs/heads/master@{#29562}
-
yangguo authored
Break point at calls are currently set via IC. To change this, we need to set debug break slots instead. We also need to distinguish those debug break slots as calls to support step-in. To implement this, we add a data field to debug break reloc info to indicate non-call debug breaks or in case of call debug breaks, the number of arguments. We can later use this to find the callee on the evaluation stack in Debug::PrepareStep. BUG=v8:4269 R=ulan@chromium.org LOG=N Review URL: https://codereview.chromium.org/1222093007 Cr-Commit-Position: refs/heads/master@{#29561}
-
machenbach authored
BUG=v8:4279 LOG=n NOTRY=true TBR=jarin@chromium.org Review URL: https://codereview.chromium.org/1233603002 Cr-Commit-Position: refs/heads/master@{#29560}
-
- 09 Jul, 2015 14 commits
-
-
adamk authored
When running without a snapshot, the GlobalEval function gets lazy compiled. By the time we compile it, its name is "eval", which causes the parser to choke (functions named "eval" aren't allowed in strict mode!). Instead, we now always skip checking the function name when lazy-parsing, as the name has already been checked appropriately by the preparser. Also cleaned up other cases that don't require name checking by introducing FunctionNameValidity enum and passing appropriate values throughout the parser and preparser. This lets us pass an additional 18 test262 tests. BUG=v8:4198 LOG=n Review URL: https://codereview.chromium.org/1227093005 Cr-Commit-Position: refs/heads/master@{#29559}
-
arv authored
Instead of updating the SharedFuntionInfo set the name property on the function directly. BUG=v8:4278 LOG=N R=verwaest@chromium.org, littledan@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1227523003 Cr-Commit-Position: refs/heads/master@{#29558}
-
binji authored
When quit() is called, d8 shell exits without cleanup. If a worker is running, it might be holding the context_mutex_, which if destroyed will DCHECK. BUG=4279 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1231473002 Cr-Commit-Position: refs/heads/master@{#29557}
-
arv authored
The function returned from Function.prototype.bind should have the same [[Prototype]] as the receiver. BUG=v8:3889 LOG=N R=adamk@chromium.org, verwaest@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1217603005 Cr-Commit-Position: refs/heads/master@{#29556}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#29555}
-
machenbach authored
TBR=bmeurer@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1228073002 Cr-Commit-Position: refs/heads/master@{#29554}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#29553}
-
bmeurer authored
This basically means that we must not use the b(Label*) version here, but the b(int) version instead to jump over the constant pool. BUG=v8:4292 LOG=y Review URL: https://codereview.chromium.org/1224243002 Cr-Commit-Position: refs/heads/master@{#29552}
-
rmcilroy authored
Review URL: https://codereview.chromium.org/1225683010 Cr-Commit-Position: refs/heads/master@{#29551}
-
bmeurer authored
The b, bl and blx methods that take labels basically ignore the constant pool check and just block the constant pool for the next instruction. This way a long enough sequence of those instructions will block can potentially block the constant pool emission for too long. BUG=v8:4292 LOG=y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1223093004 Cr-Commit-Position: refs/heads/master@{#29550}
-
yangguo authored
R=mstarzinger@chromium.org BUG=chromium:507977 LOG=N Review URL: https://codereview.chromium.org/1230653004 Cr-Commit-Position: refs/heads/master@{#29549}
-
rmcilroy authored
Use NumAllocatableRegisters() instead of kMaxNumAllocatableRegisters in ArchDefaultRegisterConfiguration::ArchDefaultRegisterConfiguration() otherwise the compiler DCHECKS if triggered during snapshot builds on Arm where only 16 DoubleRegisters are avaiable instead of 32. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1230473006 Cr-Commit-Position: refs/heads/master@{#29548}
-
bmeurer authored
That parameter is just confusing and completely unused. Review URL: https://codereview.chromium.org/1228763003 Cr-Commit-Position: refs/heads/master@{#29547}
-
yangguo authored
The invariant is that as long as there is a debug info on the shared function info, no accessor IC is compiled for its code. That way we can guarantee that stepping into accessors, which requires a debug info, works for accessors. Review URL: https://codereview.chromium.org/1220283009 Cr-Commit-Position: refs/heads/master@{#29546}
-
- 08 Jul, 2015 2 commits
-
-
littledan authored
The breakage to Chrome seems to be based on @@isConcatSpreadable and turning that part off with this patch fixes the Maps Tips & Tricks test case. BUG=chromium:507553 LOG=Y R=adamk Review URL: https://codereview.chromium.org/1226063002 Cr-Commit-Position: refs/heads/master@{#29545}
-
adamk authored
Revert of [turbofan] Optimize string "length" property access based on types. (patchset #2 id:20001 of https://codereview.chromium.org/1216593003/) Reason for revert: Causes crash when running benchmarks/octane/regexp.js on ARM: http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2492/steps/Benchmarks/logs/regexp Original issue's description: > [turbofan] Optimize string "length" property access based on types. > > Optimize string "length" property access based on static type > information if possible, but also optimistically optimize the access > based on type feedback from the LoadIC. > > R=jarin@chromium.org > > Committed: https://crrev.com/17add22ff4b9c5ca638502e7708f0d9d99baca40 > Cr-Commit-Position: refs/heads/master@{#29543} TBR=mstarzinger@chromium.org,jarin@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1224083002 Cr-Commit-Position: refs/heads/master@{#29544}
-