- 17 Jul, 2015 21 commits
-
-
caitpotter88 authored
Prevents fatal error in debug builds BUG=v8:4271, 506954 R=binji@chromium.org LOG=N Committed: https://crrev.com/43ce9c6f101c4224addd9a54e0c39963188dc7fa Cr-Commit-Position: refs/heads/master@{#29524} Review URL: https://codereview.chromium.org/1214053004 Cr-Commit-Position: refs/heads/master@{#29737}
-
binji authored
BUG=chromium:497295 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1208933006 Cr-Commit-Position: refs/heads/master@{#29736}
-
dusan.milosavljevic authored
TEST=mjsunit/asm/embenchen/zlib BUG= Review URL: https://codereview.chromium.org/1232313007 Cr-Commit-Position: refs/heads/master@{#29735}
-
hichris123 authored
NumberFormat previously just used a min of 0 digits after the decimal and a max of 3. This CL changes it so that we use the ICU currency data, and set the min and max to the number of numbers after the decimal point for each currency. This CL also fixes a small bug where if the minimum fraction digits is above 3 but the maximum fraction digits isn't set, then it returns with only three numbers after the decimal point. BUG=435465,473104,304722 LOG=Y Review URL: https://codereview.chromium.org/1231613006 Cr-Commit-Position: refs/heads/master@{#29734}
-
verwaest authored
BUG=chromium:509936 LOG=y Review URL: https://codereview.chromium.org/1241953010 Cr-Commit-Position: refs/heads/master@{#29733}
-
mbrandy authored
Port 3285e3bf Original commit message Additionally, push the allocation site or undefined independently of creating a memento to preserve a fixed size for the construct frames. R=mlippautz@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1229163005 Cr-Commit-Position: refs/heads/master@{#29732}
-
paul.lind authored
An innocent-looking change in 'c63e50ed Reland Update V8 DEPS.' exposed latent bugs in SubStringStub and StringCharFromCodeGenerator. TEST=mjsunit/string-replace, msjunit/string-split, others.... BUG= Review URL: https://codereview.chromium.org/1233903003 Cr-Commit-Position: refs/heads/master@{#29731}
-
machenbach authored
Revert of Make d8 stop using to-be-deprecated APIs (patchset #3 id:40001 of https://codereview.chromium.org/1239053004/) Reason for revert: [Sheriff] Breaks: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20code%20serializer/builds/3400 Original issue's description: > Make d8 stop using to-be-deprecated APIs > > BUG=v8:4134 > LOG=n > R=yangguo@chromium.org > > Committed: https://crrev.com/af82ef84b4f851411f00e69167ab29382c7499b8 > Cr-Commit-Position: refs/heads/master@{#29726} TBR=yangguo@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4134 Review URL: https://codereview.chromium.org/1240993003 Cr-Commit-Position: refs/heads/master@{#29730}
-
ishell authored
Revert of Reland "Enable loads and stores to global vars through property cell shortcuts installed into paren… (patchset #1 id:1 of https://codereview.chromium.org/1237043006/) Reason for revert: chromium:510738, chromium:510911 Original issue's description: > Reland "Enable loads and stores to global vars through property cell shortcuts installed into parent script context." > > Committed: https://crrev.com/48584df5ed97e2cdec1b4900f783c47adc3a3d32 > Cr-Commit-Position: refs/heads/master@{#29670} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1238163002 Cr-Commit-Position: refs/heads/master@{#29729}
-
verwaest authored
BUG=chromium:509936 LOG=y Review URL: https://codereview.chromium.org/1228113007 Cr-Commit-Position: refs/heads/master@{#29728}
-
verwaest authored
BUG=chromium:509936 LOG=y Review URL: https://codereview.chromium.org/1241973003 Cr-Commit-Position: refs/heads/master@{#29727}
-
jochen authored
BUG=v8:4134 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1239053004 Cr-Commit-Position: refs/heads/master@{#29726}
-
verwaest authored
BUG=chromium:509936 LOG=y Review URL: https://codereview.chromium.org/1242123002 Cr-Commit-Position: refs/heads/master@{#29725}
-
jochen authored
Don't chicken out on upload already, and ignore 'none' value BUG=none R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1237353003 Cr-Commit-Position: refs/heads/master@{#29724}
-
chunyang.dai authored
port 3285e3bf (r29719). original commit message: Additionally, push the allocation site or undefined independently of creatin BUG= Review URL: https://codereview.chromium.org/1229023003 Cr-Commit-Position: refs/heads/master@{#29723}
-
yangguo authored
Revert of Debugger: use FrameInspector in ScopeIterator to find context. (patchset #3 id:40001 of https://codereview.chromium.org/1239033002/) Reason for revert: breaks roll: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/87292/steps/browser_tests%20%28with%20patch%29/logs/DevToolsSanityTest.TestPauseWhenScriptIsRunning Original issue's description: > Debugger: use FrameInspector in ScopeIterator to find context. > > In optimized code, it's not guaranteed that the current context > is stored in its frame slot. > > R=bmeurer@chromium.org > BUG=v8:4309 > LOG=N > > Committed: https://crrev.com/3a0ee39cbde6a9778cfc4e2a6a0a8ff68933ff38 > Cr-Commit-Position: refs/heads/master@{#29697} TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4309 Review URL: https://codereview.chromium.org/1243553002 Cr-Commit-Position: refs/heads/master@{#29722}
-
verwaest authored
BUG=chromium:509936 LOG=y Review URL: https://codereview.chromium.org/1242093002 Cr-Commit-Position: refs/heads/master@{#29721}
-
jochen authored
BUG=none R=verwaest@chromium.org LOG=y Review URL: https://codereview.chromium.org/1114873002 Cr-Commit-Position: refs/heads/master@{#29720}
-
mlippautz authored
Additionally, push the allocation site or undefined independently of creating a memento to preserve a fixed size for the construct frames. BUG= Review URL: https://codereview.chromium.org/1239593003 Cr-Commit-Position: refs/heads/master@{#29719}
-
v8-autoroll authored
Rolling v8/buildtools to 125d157607de4d7c95bf8b02dd580aae17962f19 Rolling v8/third_party/android_tools to 2abd22b08cd757f88362f44b02484de43e4b9611 Rolling v8/third_party/icu to ffeeae138703e692f07d2c438203f32b84e7a094 Rolling v8/tools/clang to f729011d84762dfae62bbf4218580367dbfc7451 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1238783004 Cr-Commit-Position: refs/heads/master@{#29718}
-
littledan authored
- Test that TypedArray properties cannot be set in strict mode Properties like %TypedArray%.prototype.length have a getter and no setter. This test verifies that property, which was apparently not true in the past or had no test ensuring throwing in this case. - Test that TypedArray integer indexed properties (array elements) are not configurable Both of these have passed for some time, but there are open bugs against them and apparently no tests verifying that they are fixed. BUG=v8:3048, v8:3799 LOG=N R=adamk Review URL: https://codereview.chromium.org/1232843005 Cr-Commit-Position: refs/heads/master@{#29717}
-
- 16 Jul, 2015 19 commits
-
-
littledan authored
This is a change from ES5 to ES6: When reversing an array, first it is checked whether the element exists, before the element is looked up. The order in ES6 is [[HasElement]] lower [[Get]] lower (if present) [[HasElement]] upper [[Get]] upper (if present) In ES5, on the other hand, the order was [[Get]] lower [[Get]] upper [[HasElement]] lower [[HasElement]] upper To mitigate the performance impact, this patch implements a new, third copy of reversing arrays if %_HasPackedElements. This allows us to skip all membership tests, and a quick and dirty benchmark shows that the new version is faster: Over 4 runs, the slowest for the new version: d8> var start = Date.now(); for (var i = 0; i < 100000000; i++) [1, 2, 3, 4, 5].reverse(); Date.now() - start 4658 Over 3 runs, the fastest for the old version: d8> var start = Date.now(); for (var i = 0; i < 100000000; i++) [1, 2, 3, 4, 5].reverse(); Date.now() - start 5176 BUG=v8:4223 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1238593003 Cr-Commit-Position: refs/heads/master@{#29716}
-
littledan authored
ES2015 made a change vs ES5, where the "lastIndex" property of a RegExp (which can be modified by a user to start the next search at a different location) is cast to an integer with ToLength rather than ToInteger. The main difference is on negative numbers, and this is tested by test262. This patch implements that change on RegExps and enables the test262 test now that it passes. R=adamk LOG=Y BUG=v8:4244 Review URL: https://codereview.chromium.org/1241713004 Cr-Commit-Position: refs/heads/master@{#29715}
-
adamk authored
BUG=v8:3887 LOG=y Review URL: https://codereview.chromium.org/1238693004 Cr-Commit-Position: refs/heads/master@{#29714}
-
adamk authored
The issue with spread arrays which caused us to turn it off was fixed in https://chromium.googlesource.com/v8/v8/+/24e98281 BUG=v8:3018 LOG=y Review URL: https://codereview.chromium.org/1239873002 Cr-Commit-Position: refs/heads/master@{#29713}
-
bbudge authored
This CL exposes the constructor function, defines type related information, and implements value type semantics. It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero. TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc LOG=Y BUG=v8:4124 Committed: https://crrev.com/e5ed3bee99807c502fa7d7a367ec401e16d3f773 Cr-Commit-Position: refs/heads/master@{#29689} Review URL: https://codereview.chromium.org/1219943002 Cr-Commit-Position: refs/heads/master@{#29712}
-
adamk authored
Revert of [turbofan] Ship TF for try-catch statements. (patchset #1 id:1 of https://codereview.chromium.org/1216373002/) Reason for revert: Causes gbemu-part1 to time out on Linux dbg builders http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/3867/ http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20code%20serializer/builds/3386/ http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20greedy%20allocator/builds/828/ Original issue's description: > [turbofan] Ship TF for try-catch statements. > > R=hablich@chromium.org > BUG=v8:4131 > LOG=N > > Committed: https://crrev.com/1251d02e7bb2a13ae5cf6fda5d3403730d2ae12f > Cr-Commit-Position: refs/heads/master@{#29708} TBR=hablich@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4131 Review URL: https://codereview.chromium.org/1234363003 Cr-Commit-Position: refs/heads/master@{#29711}
-
caitpotter88 authored
BUG= LOG=N R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1234213004 Cr-Commit-Position: refs/heads/master@{#29710}
-
binji authored
Calling quit() from d8 will call exit(), which will run static destructors. If context_mutex_ is statically allocated, pthread_mutex_destroy will be called. When running d8 in "isolates" mode, another thread may be running. If it calls CreateEvaluationContext, it will lock the context_mutex_. If the mutex is destroyed while it is locked, it will return an error. This CL changes the Mutex to a LazyMutex, which will leak instead of being destroyed. BUG=v8:4279 R=jarin@chromium.org R=machenbach@chromium.org LOG=n Review URL: https://codereview.chromium.org/1240553003 Cr-Commit-Position: refs/heads/master@{#29709}
-
mstarzinger authored
R=hablich@chromium.org BUG=v8:4131 LOG=N Review URL: https://codereview.chromium.org/1216373002 Cr-Commit-Position: refs/heads/master@{#29708}
-
mstarzinger authored
TBR=yangguo@chromium.org Review URL: https://codereview.chromium.org/1242023003 Cr-Commit-Position: refs/heads/master@{#29707}
-
mstarzinger authored
The aforementioned intrinsic is no longer needed and can be fully desugared now that binding assignments to 'this' are explicit. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1234383002 Cr-Commit-Position: refs/heads/master@{#29706}
-
mstarzinger authored
This makes the implicit initializing assignment to 'this' performed after a super constructor call explicit in the AST. It removes the need to handle the special case where a CallExpression behaves like a AssignmentExpression from various AstVisitor implementations. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1226123010 Cr-Commit-Position: refs/heads/master@{#29705}
-
mbrandy authored
Port c63e50ed Original commit message: Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c Reland after https://codereview.chromium.org/1241643002/ R=machenbach@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1240833002 Cr-Commit-Position: refs/heads/master@{#29704}
-
mbrandy authored
Port fc9c5275 Original commit message: By not having to patch the return sequence (we patch the debug break slot right before it), we don't overwrite it and therefore don't have to keep the original copy of the code around. R=yangguo@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1238503003 Cr-Commit-Position: refs/heads/master@{#29703}
-
mbrandy authored
Port 1d9d8957 Original commit message: This changes the calling convention of the CallConstructStub to take the original constructor (i.e. new.target in JS-speak) in a register instead of magically via the operand stack. For optimizing compilers the operand stack doesn't exist, hence cannot be peeked into. R=mstarzinger@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1230103004 Cr-Commit-Position: refs/heads/master@{#29702}
-
hablich authored
Revert of Expose SIMD.Float32x4 type to Javascript. (patchset #14 id:450001 of https://codereview.chromium.org/1219943002/) Reason for revert: Seems to brake the latest roll into Chromium: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/59796/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Expose SIMD.Float32x4 type to Javascript. > This CL exposes the constructor function, defines type related > information, and implements value type semantics. > It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero. > > TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc > > LOG=Y > BUG=v8:4124 > > Committed: https://crrev.com/e5ed3bee99807c502fa7d7a367ec401e16d3f773 > Cr-Commit-Position: refs/heads/master@{#29689} TBR=rossberg@chromium.org,littledan@chromium.org,martyn.capewell@arm.com,bbudge@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review URL: https://codereview.chromium.org/1241533004 Cr-Commit-Position: refs/heads/master@{#29701}
-
epertoso authored
R=jochen@chromium.org,yangguo@chromium.org LOG=n BUG= Review URL: https://codereview.chromium.org/1233563005 Cr-Commit-Position: refs/heads/master@{#29700}
-
yangguo authored
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1230813004 Cr-Commit-Position: refs/heads/master@{#29699}
-
yangguo authored
This helps reasoning about setting break points. Functions that have debug info is also guaranteed to be able to set break points. R=ulan@chromium.org BUG=v8:4132 LOG=N Review URL: https://codereview.chromium.org/1227213003 Cr-Commit-Position: refs/heads/master@{#29698}
-