Commits · c8aea7a184a250882fdf3a6e0cea61110e05bff3 · Linshizhi / V8

20 Apr, 2012 8 commits

Put new global var semantics behind a flag until WebKit tests are cleaned up. · c8aea7a1

rossberg@chromium.org authored Apr 20, 2012

R=mstarzinger@chromium.org
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10163003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11402 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c8aea7a1

MIPS: Port function call type-feedback cells to x64 and ARM. · 29f04635

mstarzinger@chromium.org authored Apr 20, 2012

Port r11391 (789b1078)

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10124013
Patch from Akos Palfi <palfia@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11401 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

29f04635

Remove dead code from our JS builtin-code in math.js. · 91ccfce2

fschneider@chromium.org authored Apr 20, 2012

$random is never used within our JS builtin code.
Review URL: https://chromiumcodereview.appspot.com/10166003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11400 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

91ccfce2

Enable stepping into callback passed to builtins (e.g. Array.forEach). · f516037a

yangguo@chromium.org authored Apr 20, 2012

BUG=109564
TEST=

Review URL: https://chromiumcodereview.appspot.com/10078014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11399 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f516037a

Relax test-debug/ThreadedDebugging to stop flakiness. · 913568ce

jkummerow@chromium.org authored Apr 20, 2012

Actual bug tracked as issue 2047.

R=yangguo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10167002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11398 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

913568ce

Replaced the --limit-inling flag by three separate flags and bumped hard limits. · cac8bbff

svenpanne@chromium.org authored Apr 20, 2012

This change makes experiments with inlining limits much easier. Note that the
default values for the limits keep their old values for now. Renamed things a
bit for more consistency.

Review URL: https://chromiumcodereview.appspot.com/10162001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11397 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cac8bbff

Fix bug in forced-deletion of globals. · 3760893e

fschneider@chromium.org authored Apr 20, 2012

When inling functions across contexts in optimized code and using
ForceDelete from the API to delete a DontDelete global property we
can end up returning the hole value instead of throwing a ReferenceError
as expected after accessing a deleted global variable.

BUG=v8:2092
TEST=test/cctest/test-api/InlinedFunctionAcrossContexts
Review URL: https://chromiumcodereview.appspot.com/10035060

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11396 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3760893e

Flush PC-to-code cache before doing verification. · a0d67fd9

svenpanne@chromium.org authored Apr 20, 2012

Review URL: https://chromiumcodereview.appspot.com/10144002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11395 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a0d67fd9

19 Apr, 2012 12 commits

Finish refactoring done for ia32 for the other platforms. · cadf0586

fschneider@chromium.org authored Apr 19, 2012

Make non-templatized versions of LIR printing functions.

This avoid duplicating the code for each template instance.

BUG=v8:1803
Review URL: https://chromiumcodereview.appspot.com/10123011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11394 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cadf0586

Fix includes order. · d27ba7df

alexeif@chromium.org authored Apr 19, 2012

TBR=mnaganov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10078015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11393 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d27ba7df

Show names for the strong roots in heap snapshot. · 72a9e445

alexeif@chromium.org authored Apr 19, 2012

Review URL: https://chromiumcodereview.appspot.com/10128006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

72a9e445

Port function call type-feedback cells to x64 and ARM. · 60863e5c

mstarzinger@chromium.org authored Apr 19, 2012

R=fschneider@chromium.org
BUG=v8:1857,v8:2079

Review URL: https://chromiumcodereview.appspot.com/10124008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11391 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

60863e5c

Optimize ~~(expr) in optimized code. · 0556f878

fschneider@chromium.org authored Apr 19, 2012

~~ is commonly used to truncate a value to int32 (ToInt32).

This change avoid actually emitting the bitwise operations, and
just truncates the subexpression of ~~.

BUG=v8:2037
TEST=test/mjsunit/compiler/optimize-bitnot.js
Review URL: https://chromiumcodereview.appspot.com/10123007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11390 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0556f878

Hide internal references pointing to the empty array in heap profiler. · 988ea77b

alexeif@chromium.org authored Apr 19, 2012

Review URL: https://chromiumcodereview.appspot.com/10021052

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11389 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

988ea77b

Prepare push to trunk. Now working on version 3.10.5. · dfd54da6

svenpanne@chromium.org authored Apr 19, 2012

R=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10070008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11386 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dfd54da6

Fix issues when stressing compaction with WeakMaps. · 7d22d73e

mstarzinger@chromium.org authored Apr 19, 2012

1) While marking the backing hash table of a WeakMap we also need to
   record the slot because it might be on an evacuation candidate.
2) With incremental marking one backing hash table might be marked more
   than once because the WeakMap might have gone through a white to gray
   transition.
3) The corner case when the allocation of the backing hash table itself
   causes a GC, leads to a WeakMap with an undefined table field, so we
   still need to handle this case correctly.

R=vegorov@chromium.org
TEST=mjsunit/harmony/proxies-example-membrane --stress-compaction

Review URL: https://chromiumcodereview.appspot.com/9985010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11385 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7d22d73e

Fix presubmit check for the case when cpplint fails. · 0cfa7085

yangguo@chromium.org authored Apr 19, 2012

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10124006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11384 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0cfa7085

Fix mod on ia32 without SSE2. · f5caf3a7

svenpanne@chromium.org authored Apr 19, 2012

Review URL: https://chromiumcodereview.appspot.com/10128004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11383 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f5caf3a7

Fix missing GVN flag for new-space promotion. · 57739100

mstarzinger@chromium.org authored Apr 19, 2012

R=vegorov@chromium.org
BUG=chromium:123919
TEST=mjsunit/regress/regress-123919

Review URL: https://chromiumcodereview.appspot.com/10119016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11382 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

57739100

Fixed type transitions for mod on ia32. · 73814e75

svenpanne@chromium.org authored Apr 19, 2012

Previously we got stuck in the int32 state, because this handled everything
without a type transition. Note that other platforms do not have this bug.

Review URL: https://chromiumcodereview.appspot.com/10083044

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11381 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

73814e75

18 Apr, 2012 14 commits

Revert r11376 and r11379 due to compile failures on Windows. · 0f590eb4

mstarzinger@chromium.org authored Apr 18, 2012

TBR=jkummerow@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10116030

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11380 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0f590eb4

Fix presubmit failure in r11376. · 841158fb

mstarzinger@chromium.org authored Apr 18, 2012

R=jkummerow@chromium.org
TEST=cctest/test-api/StaticGetters[AfterDeath]

Review URL: https://chromiumcodereview.appspot.com/10021057

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11379 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

841158fb

Always show link to prototype transitions in heap snapshot. · 70918cb8

alexeif@chromium.org authored Apr 18, 2012

... otherwise it is shown as a hidden reference with a meaningless name.

Review URL: https://chromiumcodereview.appspot.com/10041028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11378 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

70918cb8

Make static API getters inlineable. · 3b3e701a

mstarzinger@chromium.org authored Apr 18, 2012

R=danno@chromium.org
TEST=cctest/test-api/StaticGetters[AfterDeath]

Review URL: https://chromiumcodereview.appspot.com/10116024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11376 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3b3e701a

Make Value::IsUndefined and Value::IsNull inlineable. · a13e41f3

mstarzinger@chromium.org authored Apr 18, 2012

R=danno@chromium.org
TEST=cctest/test-api

Review URL: https://chromiumcodereview.appspot.com/10091035

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11375 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a13e41f3

MIPS: Implement rudimentary module linking. · 977b6027

rossberg@chromium.org authored Apr 18, 2012

Port r11336 (6dd4e844)

Original commit message:

Implement rudimentary module linking.

Constructs the (generally cyclic) graph of module instance objects
and populates their exports. Any exports other than nested modules
are currently set to 'undefined' (but already present as properties).

Details:
- Added new type JSModule for instance objects: a JSObject carrying a context.
- Statically allocate instance objects for all module literals (in parser 8-}).
- Extend interfaces to record and unify concrete instance objects,
and to support iteration over members.
- Introduce new runtime function for pushing module contexts.
- Generate code for allocating, initializing, and setting module contexts,
and for populating instance objects from module literals.
Currently, all non-module exports are still initialized with 'undefined'.
- Module aliases are resolved statically, so no special code is required.
- Make sure that code containing module constructs is never optimized
(macrofy AST node construction flag setting while we're at it).
- Add test case checking linkage.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10035028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11374 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

977b6027

MIPS: Refactor code generation for global declarations. · 1aa16d86

rossberg@chromium.org authored Apr 18, 2012

Port r11332 (0e6df8b6)

Original commit message:
Refactor code generation for global declarations.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10041029

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11373 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1aa16d86

MIPS: Refactoring of code generation for declarations, in preparation for modules. · 42b77f31

rossberg@chromium.org authored Apr 18, 2012

Port r11331 (bd7843a0)

Original commit message:
Refactoring of code generation for declarations, in preparation for modules.

Do proper dispatch on declaration type instead of mingling together
different code generation paths. Once we add more declaration forms,
this is more scalable.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10119017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11372 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

42b77f31

Make functions with switch statements inlinable. · 18af012b

svenpanne@chromium.org authored Apr 18, 2012

Review URL: https://chromiumcodereview.appspot.com/10083038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11370 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

18af012b

MIPS: Make SubStringStub more robust with unsafe arguments. · 7f30cf11

yangguo@chromium.org authored Apr 18, 2012

Port r11349 (5b381a).

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10107025
Patch from Daniel Kalmar <kalmard@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11367 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7f30cf11

MIPS: Skip canonicalization check in LStoreKeyedFastDoubleElement when it is not needed · bf2bc0b1

vegorov@chromium.org authored Apr 18, 2012

Port r11278 (e5dc7ebd).

Original commit message:

Skip canonicalization check in LStoreKeyedFastDoubleElement when it is not needed:

- if value is a result of integer32 to double conversion (can't be NaN);

- if value was loaded from fast double backing store (already canonicalized).

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10071004
Patch from Daniel Kalmar <kalmard@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11366 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bf2bc0b1

MIPS: fix-up after r11344 · b635c907

vegorov@chromium.org authored Apr 18, 2012

Removed a constant now duplicated by r11344 (7c41cf72).
This fixes compilation on MIPS (with the other submitted patches applied).

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10108023
Patch from Daniel Kalmar <kalmard@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11365 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b635c907

Simplify invocation sequence at monomorphic function invocation sites. · fd9bd722

vegorov@chromium.org authored Apr 18, 2012

Provide known target as a hint to HInvokeFunction instruction so that it can statically determine if arguments adaptation is required.

R=fschneider@chromium.org
BUG=v8:2079

Review URL: https://chromiumcodereview.appspot.com/10116021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11364 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fd9bd722

Fix typo in power_double_double · 5713859c

yangguo@chromium.org authored Apr 18, 2012

Contributed by net147@gmail.com

BUGS=
TEST=mjsunit/math-pow,mjsunit/math-sqrt

Review URL: https://chromiumcodereview.appspot.com/10116001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11363 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5713859c

17 Apr, 2012 6 commits

Fix incorrect Math.pow() calculations on MinGW-w64. · 661edb44

yangguo@chromium.org authored Apr 17, 2012

Original patch by Jonathan Liu <net147@gmail.com> https://chromiumcodereview.appspot.com/10026017/

BUG=
TEST=mjsunit/math-pow,mjsunit/math-sqrt

Review URL: https://chromiumcodereview.appspot.com/10108022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11362 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

661edb44

Fix typo in lazy-instance.h. · 6339bcb3

jkummerow@chromium.org authored Apr 17, 2012

There was no build error since we never used LazyDynamicInstance's default parameter.

BUG=v8:2091

Review URL: https://chromiumcodereview.appspot.com/10103032
Patch from Philippe Liard <pliard@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11359 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6339bcb3

Remove Debug object from the user roots in heap profiler. · 2ec3e594

alexeif@chromium.org authored Apr 17, 2012

Review URL: https://chromiumcodereview.appspot.com/10096016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11358 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2ec3e594

Fix MinGW-w64 GCC 4.7 compilation · bf630e23

yangguo@chromium.org authored Apr 17, 2012

Contributed by net147@gmail.com

BUGS=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10019012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11357 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bf630e23

Use ldexp instead of pow for more accuracy. · ac72f5c4

yangguo@chromium.org authored Apr 17, 2012

Original patch by net147@gmail.com: https://chromiumcodereview.appspot.com/10026011/

BUG=
TEST=cctest/test-conversions/Octal

Review URL: https://chromiumcodereview.appspot.com/10103030

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11356 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ac72f5c4

Push heap stats as HeapStatsUpdate struct instead of raw array of uint32_t values. · b2024c53

loislo@chromium.org authored Apr 17, 2012

We are pushing stats data as a raw array of uint32_t values at the moment.
It makes tricky the process of updating the API between v8 and WebKit.

BUG=none
TEST=HeapSnapshotObjectsStats

Review URL: https://chromiumcodereview.appspot.com/10110001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11355 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b2024c53