- 28 Sep, 2021 19 commits
-
-
Jakob Gruber authored
Update outdated comments and address TODO about kDataIndex. Change-Id: Ibf6e91857c0430cb9a598c98933db63ac42a1d1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3189197 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#77123}
-
Seth Brenith authored
When preparing to take a heap snapshot for the devtools, V8 uses CollectAllAvailableGarbage, which runs 2 to 7 rounds of garbage collection, depending on whether weak callbacks indicate that further rounds might be beneficial. Depending on how many rounds of GC run, varying amounts of bytecode and baseline code may be flushed, leading to inconsistent behavior and underreporting the amount of memory used by bytecode and baseline code. In this change, I propose that bytecode should not increase in age during these collections, so that the resulting snapshot is a better indication of actual memory usage. Change-Id: I644be37833f85bb58e2e2fad5da62949cbdc9bef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182885Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#77122}
-
Al Muthanna Athamina authored
Bug: v8:12257 Change-Id: I0c78e692a1712082818e8af32593b0489c4e18ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190103 Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#77121}
-
Victor Gomes authored
Change-Id: I796eacdf7c0e1fc9de5b31e47bf0e20cd4aa70d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190430 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/main@{#77120}
-
Victor Gomes authored
Use `const void*` to signal that we are not hashing for the `char*` contents. Change-Id: Ib8c31e293ec1e57a7799a68cfd2d59ce39076d43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190108 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77119}
-
Jakob Gruber authored
.. to avoid the expensive malloc call. Fixed: v8:9455 Change-Id: I6734fe07a3884b228d818f60be83d9e45c2ee383 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190105 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Michael Savigny authored
Add the use_remoteexec arg to the reclient mixin. Set both use_rbe and use_remoteexec while switch from one ot the other. Bug: chromium:1252752 Change-Id: I415a849dbd27c4de23d6f9fcfde7c1beba8f5f7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3188950Reviewed-by:
-
Thibaud Michaud authored
When handling the 'end' opcode, there was a confusion with the value of "unreachable". This DCHECK assumes the value of "unreachable" before closing the scope, but was placed after the value is potentially updated to reflect the state after the 'end' opcode. R=clemensb@chromium.org Bug: chromium:1251845 Change-Id: Iea526e6485fa705f6ff4077f54a53204cc70a926 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190102Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#77116}
-
Clemens Backes authored
R=manoskouk@chromium.org Bug: chromium:1252747 Change-Id: I337d5e26015f5af8c76caebb962093d1dad42952 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190095Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77115}
-
Jakob Gruber authored
The parser is organized in a somewhat tricky way s.t. it can be hard to map the implementation back to the specified grammar. In particular, the logic for CharacterClassEscape, ClassEscape, and CharacterEscape was implemented twice - once inside a character class, once outside. This CL refactors related logic to have only a single implementation. As a drive-by, fix one related inconsistency related to \k inside a character class. Fixed: v8:10602 Change-Id: I5858840159694fa6f8d1aa857027db80754e3dfd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3178966Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77114}
-
Jakob Kummerow authored
Bug: v8:12244,v8:12245 Change-Id: Ic677503ceeb5903e94cc60d7c95f0ec990fba691 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183163 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#77113}
-
Lu Yahan authored
The intent of the RISC-V ISA is that 32-bit C values are stored sign extended in registers, even for unsigned types. So we skip cctest case RunLoadStoreZeroExtend64/RunUnalignedLoadStoreZeroExtend64 due to sign extend uint32 Change-Id: Icfe727916b1c04aad5681902ec4782cc98906964 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3184560Reviewed-by:
Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by:
-
Jakob Kummerow authored
Several of the cctest/test-bytecode-generator/* tests used to rely on the __COUNTER__ C++ compiler macro, which could cause spurious test failures due to mismatched expectations when usages of that macro were added or removed elsewhere in the code. This patch switches to a custom, controllable static counter variable instead, to make the tests' behaviors self-contained. Bug: v8:12244 Change-Id: I4d875b6095e4ee4ef91933ab8c60c89054d1894a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186836Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#77111}
-
Zhao Jiazhong authored
Port commit a0ace8a8 On mips64 and loong64, sign-extend the 32-bit value. Change-Id: I058e3fcba94c25ad36ab1d751dea6bfc0558471a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3189854Reviewed-by:
Liu yu <liuyu@loongson.cn> Commit-Queue: Liu yu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#77110}
-
Victor Gomes authored
No-Try: true Bug: v8:12261 Change-Id: Ib51f8b694156228d2a3217b3cf171d15390af87d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3190092 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#77109}
-
Lu Yahan authored
Port e301d71f [compiler] Teach InstructionScheduler about protected memory accesses Port a0ace8a8 [wasm] Interpret table.grow result as 32 bit Port [regexp] Fix UAF in RegExpMacroAssembler Change-Id: Ieac5e4deae9c6bbf844788d927f5201b906495f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3189213 Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn> Reviewed-by:
-
Manos Koukoutos authored
Bug: chromium:1252747 Change-Id: I2eb0f71049836ca5a761928e3c8adf7034f5fdb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186437Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6476f40..a76920d Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/9d33a71..a9bc3e2 Rolling v8/buildtools/linux64: git_revision:de86ec4176235871a7cb335756987e41246dae4a..git_revision:0153d369bbccc908f4da4993b1ba82728055926a Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/c883cb1..50e90b8 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/a7e4ce0..a002c72 Rolling v8/third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/a46a633..8aecb68 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/444aba8..2146b04 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f35d350..ce514ad Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/efd7c81..2e80143 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ifcb08d19030149f8f920d334f4b0072c286d80bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3189492Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77106}
-
Lu Yahan authored
Port 3162604 3173681 Bug: v8:11382 Change-Id: Iea5910dfe1f091cb0d202f1abe894562f5c6c63f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3184561Reviewed-by:
-
- 27 Sep, 2021 21 commits
-
-
Shu-yu Guo authored
These tests test allocation failure and time out on TSAN. Bug: v8:11852 Change-Id: I81e0af3ab8130c05488c6a117dd1c6ef12aba33b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3188071 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77104}
-
legendecas authored
After the parameter processing, the arraybuffer may have been detached. TypedArray copyWithin/fill should throw in that condition. TypedArray includes should return false if the search element is not undefined. Change-Id: If507d0efa1dafbe3dcefcd368e5ea27406bb3df8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3144315Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#77103}
-
Georg Neis authored
Bug: v8:7790 Change-Id: Ibf6e842c2bec780a9a52643494def8efbab92466 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3185920 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77102}
-
Jakob Kummerow authored
Bug: v8:12244,v8:12245 Change-Id: Ib0db9d9431e42399d3031b5d7f315ddf3cd9993d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182441 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
This reverts commit ec4a3124. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1253374#c2 Original change's description: > heap: Resolve -Wshadow warning in allocation-observer.cc > > Bug: v8:12244, v8:12245 > Change-Id: Id6b9e0a3986fb04c1a949b26ecf20da652ddd097 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181537 > Auto-Submit: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77045} Bug: v8:12244, v8:12245 Change-Id: I506055fa7b959ac9adffa77ebc58234ec5b03371 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186834Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/main@{#77100}
-
Nico Hartmann authored
Prepare the Torque compiler to generate Kythe artifacts to be consumed by CodeSearch. Drive-by changes. * Extend SourcePosition by an offset in the input string, as this is required by the Kythe graph. * Correctly set missing identifier positions in Declarations. Bug: v8:12261 Change-Id: Ida0a4a562c99f58ab924ddde36f3146f3d3fd415 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3181102 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#77099}
-
Ng Zhi An authored
Bug: v8:12244 Change-Id: I57a54b43c1821b57ef45de38c4d7782534f74d2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183521Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77098}
-
Ng Zhi An authored
Don't really have a good name for this inner TryCatch. Bug: v8:12244 Change-Id: I4c1353bcd98e78e49d0354e285249302a8ee0dd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183522Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244 Change-Id: Ia441c2056a8a4edf44aa6fd5a1bb86726d599af9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182927Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:12240 Change-Id: I9bf62d8c99b1f945139e274652d667c1a361e2a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3180371Reviewed-by:
-
Andreas Haas authored
Bug: v8:12244 Change-Id: Ia99fac6e7001bb6bce12256d3fcce28e45222f7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182229Reviewed-by:
-
Camillo Bruni authored
- Print extension and type - Clarify elements printing Change-Id: Ie5d5fb60e20bb2f5bfee4e438a4dec52b3b27d13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186435 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#77093}
-
Andreas Haas authored
R=thibaudm@chromium.org Bug: v8:12244 Change-Id: I9012ec21f4dbf2c644b0cb3964e545bfb2b2112c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182442Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77092}
-
Victor Gomes authored
No-Try: true Bug: v8:11880 Change-Id: I8d15b1974e965a31b822308879d78461bf1a141f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186442 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77091}
-
Zhao Jiazhong authored
Port commit bba7c09a [regexp] Allow reentrant irregexp execution Port commit 4bbfc4b7 [regexp] Remove the `stack` parameter from regexp matchers Port commit c1700c56 [regexp] Fix UAF in RegExpMacroAssembler Bug: v8:11382 Change-Id: Ie2e95d7b19ecbd740e8d8a4130c725416abc114a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3185562Reviewed-by:
-
Patrick Thier authored
Activate argument count consistency (receiver is always included in JS argument count) for arm and arm64. Bug: v8:11112 Change-Id: I4b019721422a0a4653d59e81cde2f7d57708e625 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3186436 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#77089}
-
Igor Sheludko authored
... an ObjectVisitor subclass that takes care of caching values of both the main pointer compression cage base and code cage base (when the external code space is enabled). Drive-by: this CL also changes signature of RelocInfo::target_object_no_host(...) to accept PtrComprCageBase instead of Isolate*. Bug: v8:11880 Change-Id: I3fbb382e0a0170e28542bc495d8fecfd24da8a07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182231 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Omer Katz authored
Bug: chromium:1252634, chromium:1056170 Change-Id: Ifdecca29dbff4ed3d6ee2acd547a20add482d59f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183167Reviewed-by:
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:12244 Change-Id: I988ebec99cb791b21c46acf6de961627406d70ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182443Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:12244,v8:12245 Change-Id: I718eea6eb065b2775186322b888f805423d6be1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3183161 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Ray Wang authored
1. Now there is no serializer/deserializer-specific buffer size limit. 2. Update AUTHORS Ref: https://github.com/nodejs/node/issues/40059 Change-Id: Iad4c6d8f68a91ef21d3c404fb7945949e69ad9e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3170411Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
