- 31 Mar, 2016 1 commit
-
-
yangguo authored
R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org BUG=chromium:124206,chromium:569811 LOG=N Review URL: https://codereview.chromium.org/1834633003 Cr-Commit-Position: refs/heads/master@{#35145}
-
- 15 Dec, 2015 1 commit
-
-
yangguo authored
Debug evaluate no longer writes back changes to the replicated context chain to the original after execution. Changes to the global object or script contexts still stick. Calling functions that bind to the original context chain also have their expected side effects. As far as I can tell, DevTools is not interested in modifying local variable values. Modifying global variable values still works as expected. However, I have not yet removed the old implementation, but merely keep it behind a flag. R=mstarzinger@chromium.org, rossberg@chromium.org Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330 Cr-Commit-Position: refs/heads/master@{#32841} Review URL: https://codereview.chromium.org/1513183003 Cr-Commit-Position: refs/heads/master@{#32857}
-
- 14 Dec, 2015 3 commits
-
-
machenbach authored
Revert of [debugger] debug-evaluate should not not modify local values. (patchset #2 id:20001 of https://codereview.chromium.org/1513183003/ ) Reason for revert: [Sheriff] Layout test changes. Original issue's description: > [debugger] debug-evaluate should not not modify local values. > > Debug evaluate no longer writes back changes to the replicated > context chain to the original after execution. Changes to the > global object or script contexts still stick. Calling functions > that bind to the original context chain also have their expected > side effects. > > As far as I can tell, DevTools is not interested in modifying > local variable values. Modifying global variable values still > works as expected. However, I have not yet removed the old > implementation, but merely keep it behind a flag. > > R=mstarzinger@chromium.org, rossberg@chromium.org > > Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330 > Cr-Commit-Position: refs/heads/master@{#32841} TBR=mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1526553003 Cr-Commit-Position: refs/heads/master@{#32845}
-
yangguo authored
Debug evaluate no longer writes back changes to the replicated context chain to the original after execution. Changes to the global object or script contexts still stick. Calling functions that bind to the original context chain also have their expected side effects. As far as I can tell, DevTools is not interested in modifying local variable values. Modifying global variable values still works as expected. However, I have not yet removed the old implementation, but merely keep it behind a flag. R=mstarzinger@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1513183003 Cr-Commit-Position: refs/heads/master@{#32841}
-
yangguo authored
Debug-evaluate used to resolve stack variables that shadow context variables incorrectly, since the stack variable is not visible in the context chain. To fix this, we limit local variables accessible by debug- evaluate to the ones directly referenced inside the function. What is not referenced by the function itself, is considered optimized out and not accessible by debug-evaluate. To achieve this, we duplicate the entire context chain up to the native context, and write back changes after debug- evaluate. Changes to the original context chain will however be overwritten. This already happens for catch and block scopes though. Also fix a crash caused by declaring variables inside debug- evaluate. R=mstarzinger@chromium.org BUG=v8:4593 LOG=N Review URL: https://codereview.chromium.org/1500933002 Cr-Commit-Position: refs/heads/master@{#32828}
-
- 15 Jun, 2015 1 commit
-
-
bmeurer authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1183123002 Cr-Commit-Position: refs/heads/master@{#29018}
-
- 01 Sep, 2014 1 commit
-
-
jarin@chromium.org authored
This adds context deoptimization to Turbofan and Crankshaft (also submitted separately as https://codereview.chromium.org/515723004/). The second patchset removes the deoptimization/continuation block from calls. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/522873002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23547 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Jul, 2013 1 commit
-
-
yangguo@chromium.org authored
BUG=259300 R=ulan@chromium.org, verwaest@chromium.org Review URL: https://codereview.chromium.org/19569003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15727 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Jun, 2013 1 commit
-
-
yangguo@chromium.org authored
BUG=v8:2751 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18198003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15378 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Jun, 2012 1 commit
-
-
yangguo@chromium.org authored
R=ulan@chromium.org BUG=131994 TEST=regress/regress-131994.js Review URL: https://chromiumcodereview.appspot.com/10585002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11855 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Apr, 2012 2 commits
-
-
vegorov@chromium.org authored
TBR=kmillikin@chromium.org Review URL: https://chromiumcodereview.appspot.com/10067017 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11299 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
vegorov@chromium.org authored
R=kmillikin@chromium.org BUG=chromium:119609 TEST=test/mjsunit/regress/regress-119609.js Review URL: https://chromiumcodereview.appspot.com/10010046 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11298 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Mar, 2012 1 commit
-
-
yangguo@chromium.org authored
BUG=102153 TEST=regress-102153.js Review URL: https://chromiumcodereview.appspot.com/9625011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10963 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Sep, 2011 1 commit
-
-
yangguo@chromium.org authored
Review URL: http://codereview.chromium.org/7826007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9094 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Apr, 2009 1 commit
-
-
sgjesse@chromium.org authored
The generic step-in mechanism floods the function called with break points to ensure a break is hit when entering the function. This generic mechanism was also used for function.apply. The code for function.apply contains a keyed load IC which was patched when stepping into function.apply. However function.apply enteres an internal frame not a JavaScript frame. This caused the logic for returning from the break in function.apply to fail as it forced a jump to the IC on the top JavaScript frame. The top JavaScript frame was the frame for the function calling function.apply not the frame for the apply function. Now returning from the break point in the keyed load IC in the apply code caused a jump to the code for the call IC for the function calling function.apply in the first place. Not a pretty sight. Step-in now handles function.apply as a separate case where the actual JavaScript function called through apply is flodded with breakpoints instead of the function.apply function. BUG=269 BUG=8210@chromium.org Review URL: http://codereview.chromium.org/63055 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1683 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Mar, 2009 1 commit
-
-
http://code.google.com/p/v8/issues/detail?id=269sgjesse@chromium.org authored
BUG=269 Review URL: http://codereview.chromium.org/43023 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1484 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Feb, 2009 1 commit
-
-
sgjesse@chromium.org authored
Changed the debugger API to allow only one debug event listener to be registered. The public API now only has SetDebugEventListener instead of AddDebugEventListener and RemoveDebugEventListener. Moved the registrered debug event listener from the context to a global handle in the Debugger class. Storing it in the context did not make much sense. Changed a lot of tests to handle the API change. BUG=1242707 Review URL: http://codereview.chromium.org/19753 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1212 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 09 Sep, 2008 1 commit
-
-
christian.plesner.hansen@gmail.com authored
Added presubmit step to check copyright. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@242 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 22 Aug, 2008 1 commit
-
-
christian.plesner.hansen authored
In the shell sample don't print the result of executing a script, only evaluating expressions. Fixed issue when building samples on Windows using a shared V8 library. Added visibility option on Linux build which makes the generated library 18% smaller. Changed build system to accept multiple build modes in one build and generate seperate objects, libraries and executables for each mode. Removed deferred negation optimization (a * -b => -(a * b)) since this visibly changes operand conversion order. Improved parsing performance by introducing stack guard in preparsing. Without a stack guard preparsing always bails out with stack overflow. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Jul, 2008 1 commit
-
-
kasper.lund authored
Added a few samples and support for building them. The samples include a simple shell that can be used to benchmark and test V8. Changed V8::GetVersion to return the version as a string. Added source for lazily loaded scripts to snapshots and made serialization non-destructive. Improved ARM support by fixing the write barrier code to use aligned loads and stores and by removing premature locals optimization that relied on broken support for callee-saved registers (removed). Refactored the code for marking live objects during garbage collection and the code for allocating objects in paged spaces. Introduced an abstraction for the map word of a heap-allocated object and changed the memory allocator to allocate executable memory only for spaces that may contain code objects. Moved StringBuilder to utils.h and ScopedLock to platform.h, where they can be used by debugging and logging modules. Added thread-safe message queues for dealing with debugger events. Fixed the source code reported by toString for certain builtin empty functions and made sure that the prototype property of a function is enumerable. Improved performance of converting values to condition flags in generated code. Merged disassembler-{arch} files. git-svn-id: http://v8.googlecode.com/svn/trunk@8 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jul, 2008 1 commit
-
-
christian.plesner.hansen authored
git-svn-id: http://v8.googlecode.com/svn/trunk@2 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-