- 11 Aug, 2022 8 commits
-
-
Dominik Inführ authored
This CL adds the shared barrier to the RecordWrite builtin which is used in generated code for builtins, interpreted and optimized code. The out-of-line part of the barrier now checks whether either the POINTERS_TO_HERE_ARE_INTERESTING or the IN_SHARED_HEAP bit is set in the value object's page flags. Outside of marking the RecordWrite builtin now needs to check whether to insert into the generational or shared remembered set. Inserting into the shared remembered set will always call into C++ code. During marking the RecordWrite builtin now also needs to check whether this store created an old-to-shared pointer. Bug: v8:11708 Change-Id: Iaca4c3c0650aece4326936d7d63754a23cd0a028 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779679Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jakob Linke <jgruber@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#82375}
-
jiepan authored
Change-Id: Ic81be39ed0666c708f9129bef1e75268afc7faf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807123Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Jie Pan <jie.pan@intel.com> Cr-Commit-Position: refs/heads/main@{#82374}
-
Jakob Linke authored
.. to match behavior. According to the old signatures, the functions returned bool (they actually returned CompilationJob::Status). This only worked because return values are unused. Change to void return type instead. Drive-by: Code reuse in FinalizeMaglevCompilationJob. Bug: v8:7700 Change-Id: I45f75121c230063dec96a5197cc9fdc3b64aae6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3822683Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#82373}
-
Simon Zünd authored
We have a bug report from 2018 that no longer reproduces on ToT. This CL adds a regression bug regardless to make sure we don't re-introduce the bug that got fixed as a side-effect. R=kimanh@chromium.org Fixed: chromium:1246896 Change-Id: I8f9fdcbf7051b23e03cbbfc572771a410f70ad37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3822668Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#82372}
-
Liviu Rau authored
- Unify old Pool interface with the new context related interface - Add single threaded execution pool - Defer task killing back to OS context - Defer process listing in indicators back to OS context Bug: v8:12785 Cq-Include-Trybots: luci.v8.try:v8_numfuzz_dbg_ng,v8_numfuzz_ng,v8_numfuzz_tsan_ng,v8_android_arm64_n5x_rel_ng Change-Id: I8ffe01c5d567411203f69ecc451c718ff35d81c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3781347Reviewed-by:
Alexander Schulze <alexschulze@chromium.org> Commit-Queue: Liviu Rau <liviurau@google.com> Cr-Commit-Position: refs/heads/main@{#82371}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/93068bf..9497cae Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/b11e87a..11459ac R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I2650d015cf87ae06e8e985fa9ddc603daa90c5c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824286 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82370}
-
v8-ci-autoroll-builder authored
Rolling v8/buildtools/linux64: git_revision:3d773bba0927e67eae8fdaee5e28b0f6203d3bee..git_revision:c8c63300ac8ecb66d8126af5407257209ae59044 Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/fe1bc75..4d0f32e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/743fa6c..47666e0 Rolling v8/third_party/fuchsia-sdk/sdk: version:9.20220809.0.1..version:9.20220810.1.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I2673b770c93fdc18431dddf7614b041f3ba90963 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824284 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82369}
-
Shu-yu Guo authored
This is a reland of commit b1020a43 Changes since revert: - Fixed global safepoint interrupts in https://chromium-review.googlesource.com/c/v8/v8/+/3820913 Original change's description: > Reland "[shared-struct] Add Atomics.Condition" > > This is a reland of commit e2066ff6 > > Changes since revert: > - Rebased against c9918524, which > uses the external pointer table for the WaiterQueueNode stored > in the state field when compressing pointers. This relaxes > the alignment requirement of the state field to be 4-bytes when > compressing pointers. > - Moved the state field into the JSSynchronizationPrimitive base > class, since alignment and padding can now be made simpler. > > Original change's description: > > [shared-struct] Add Atomics.Condition > > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3630350 > > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > > Reviewed-by: Adam Klein <adamk@chromium.org> > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3763787 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Bug: v8:12547 Change-Id: Ibc6de74c7853e4ea766ff2c70f92339ba69f2675 Cq-Include-Trybots: luci.v8.try:v8_linux_arm64_rel_ng,v8_linux64_tsan_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820901Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#82368}
-
- 10 Aug, 2022 32 commits
-
-
Frank Tang authored
Split from cl/3822342 Should advance the length of the TimeZone Spec Text: https://tc39.es/proposal-temporal/#prod-CalendarDateTimeTimeRequired Bug: v8:11544 Change-Id: Ic16a16ac41c29cb04136030b2f2c8b78022f8241 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824879 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:11708 Change-Id: Iac70ab6701e691b2975856be69892daadd814f70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820913Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#82366}
-
Omer Katz authored
mark-compact.cc: Iterate over all new space pages. heap-layout-tracer.cc: Iterate over the paged new space. Bug: v8:12612 Change-Id: I4d8dfc48632908a80793a77c211020452c675ecf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3823134Reviewed-by:
-
Shu-yu Guo authored
Currently a deadlock can result on heap teardown during the shared heap verification which performs a global safepoint. The heap teardown awaits compile tasks, while the compile helper thread is waiting on a global safepoint. Bug: v8:11708 Change-Id: I8328a4b142cb9045bfaf592ac4f4dd259ba0d397 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820354 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Frank Tang authored
Change to use Handle<Object> instead of Handle<String> for calendar and offset_string. Spec text: https://tc39.es/proposal-temporal/#sec-temporal-torelativetemporalobject Bug: v8:11544 Change-Id: Ia9051f176e0e91a362b0c6b9edf6fea5a53ddcf2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3808256Reviewed-by:
-
Milad Fa authored
Port ca33c73e Original Commit Message: .. since these functions will also be used by Maglev codegen. R=jgruber@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Icccc06b76cd61902900b0deecbfe1fbe46202235 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3822670 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#82362}
-
Camillo authored
This is a reland of commit 5592bad9 - Disable timeout signal handler with --fuzzing - Properly initialize sigaction object Original change's description: > [d8] Dump stack trace on d8 tests timeouts on posix systems > > - Add a SIGTERM handler in d8 that dupms the stack trace > - Send SIGTERM before SIGKILL in the test runner > > Bug: v8:13115 > Change-Id: I75285f33caabab61ff6ae83c1fbc6faf45cf595a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791906 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82173} Bug: v8:13115 Change-Id: I115cc3f671ebe11ba204e75a6fc358ca3477e950 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820221Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82361}
-
Shu-yu Guo authored
This reverts commit 9d36b2dd. Reason for revert: Win64 crashes https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Win64%20-%20debug/43496/overview Original change's description: > [base] Add new API to protect data memory > > This adds a new {base::OS::SetDataReadOnly} method, which is similar to > {SetPermissions(kRead)}, but using another system call on Windows such > that it works on pages in the data segment. > {VirtualAlloc} will fail if called on a page of the data section, > whereas {VirtualProtect} succeeds. For the general {SetPermissions} > API we still want to use {VirtualAlloc} though, as it also changes the "committed" state of the pages. > > Note that we do not add a platform API for this, as the memory was > never allocated through the platform. We just directly protect it in > V8. > > R=mlippautz@chromium.org > > Bug: v8:12887 > Change-Id: If83bf6e5c500cc5cf08c76d04dfac5e2b4d35a2d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820482 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82349} Bug: v8:12887 Change-Id: I86fffa60d6766dcdaf44f57f18266fec22eb9016 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824409 Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#82360}
-
Pierre Langlois authored
The system analyzer relies on server-side processing to symbolize C++ addresses, using lws-middleware.js: ws --stack system-analyzer/lws-middleware.js lws-static cors This does not work on Android however, given the log file refers to the stripped apk file rather than the unstripped libchrome.so binary. This CL adds the --apk-embedded-library option to the middleware script to make this work: ws --stack system-analyzer/lws-middleware.js lws-static cors \ --apk-embedded-library=/path/to/out/android/lib.unstripped/libchrome.so Also, for completeness, add the --target option to set targetRootFS. Bug: v8:10644 Change-Id: I7bb73adf49e3af8eaa88a5e2c81ec913023ac1a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3823133 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by:Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#82359}
-
Jakob Linke authored
The zone-allocated objects, the destructor is never called. Such objects must therefore never contain members that themselves have non-trivial destructors, e.g. std containers. Fix occurrences of this antipattern in Maglev. Bug: v8:7700 Change-Id: I6892cf5203bb6e842397fd4292918b18134f97cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3822672 Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by:
-
Omer Katz authored
PagedNewSpace requires a different way of iterating over new space. This is because we can no longer assume that everything before top is allocated and everything after is free. Bug: v8:12612 Change-Id: Iedd36a6d3dc5019553f58f1ba9f5d06529a7ce9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3823129 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Adam Klein authored
This reverts commit 532ca599. Reason for revert: UBSan failures (integer overflow): https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/22615/overview Original change's description: > [maglev] Support LdaModuleVariable and StaModuleVariable > > Bug: v8:7700 > Change-Id: I036ac71324e0c1c96a4da4aacdb5a6718726db31 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3821203 > Reviewed-by: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: 王澳 <wangao.james@bytedance.com> > Cr-Commit-Position: refs/heads/main@{#82347} Bug: v8:7700 Change-Id: Iedbcb80a2ec41f299105bb814650ec4eff30db0d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3824718 Auto-Submit: Adam Klein <adamk@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82356}
-
jameslahm authored
... intrinsic. This CL also adds stack arguments support in CallBuiltin. Bug: v8:7700 Change-Id: I59d900414585f724c48f1557ba606f5b61cfb6da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3813073Reviewed-by:
-
Omer Katz authored
Bug: v8:12612 Change-Id: Ibd20ba65e81b86239e254b945c4c6c9c6137b714 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3822687 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Lu Yahan authored
Port commit 00746406 Change-Id: I9bd985b882ca2e39b24131bd6e0609920b826398 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3823859Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#82353}
-
ishell@chromium.org authored
... which will be necessary once builtins become Code-less. Bug: v8:11880 Change-Id: If48739c3a058e6baf3c2e062d8eaace062c27592 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3822686Reviewed-by:
-
Jakob Linke authored
ML-TF tiering remains very similar to Ignition-TF tiering: - When the interrupt budget is exhausted, enter the TieringManager which potentially decides to tier up and sets the appropriate TieringState on the FeedbackVector. - The prologue on ML function entry recognizes the TieringState (and also available cached TF code) and starts compilation and/or jumps into optimized code. TODOs: - ML-to-TF OSR is not yet supported. - ML code is no longer cached on the FeedbackVector. - Tracing is rudimentary. - The generated function-entry prologue is fairly large and must be either minimized or extracted into a builtin. - Tiering involving Sparkplug is not entirely robust yet (Sparkplug code may be installed with unexpected timing). Bug: v8:7700 Change-Id: I86b0692477f51b9967f318a4093bc874344120b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3629149Reviewed-by:
-
Camillo authored
- Add explicit --turbo-profiling-output and --turbo-profiling-input - Rename --turbo-profiling-log-file to --turbo-profiling-input - No longer log PGO data to v8.log - Add runtime %GetAndResetTurboProfilingData helper function for more controlled logging within chrome - Rewrite generate.py script to use more python3 Bug: v8:10470 Change-Id: Ib817b5c3793a0a7ae77103075ea2d6f6d0282150 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820381Reviewed-by:
-
Clemens Backes authored
This adds a new {base::OS::SetDataReadOnly} method, which is similar to {SetPermissions(kRead)}, but using another system call on Windows such that it works on pages in the data segment. {VirtualAlloc} will fail if called on a page of the data section, whereas {VirtualProtect} succeeds. For the general {SetPermissions} API we still want to use {VirtualAlloc} though, as it also changes the "committed" state of the pages. Note that we do not add a platform API for this, as the memory was never allocated through the platform. We just directly protect it in V8. R=mlippautz@chromium.org Bug: v8:12887 Change-Id: If83bf6e5c500cc5cf08c76d04dfac5e2b4d35a2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820482Reviewed-by: -
Clemens Backes authored
This reverts https://crrev.com/c/3778717, and also switches "Promise" to a boolean enum. The underlying clang crash is fixed, see linked issue. R=thibaudm@chromium.org Bug: chromium:1344641 Change-Id: I7fac50eb4f1155aca1c101f01892df78cdde46e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3823128Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82348}
-
jameslahm authored
Bug: v8:7700 Change-Id: I036ac71324e0c1c96a4da4aacdb5a6718726db31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3821203Reviewed-by:
-
jameslahm authored
Bug: v8:7700 Change-Id: I92596898718a57ea9d8fbd002306aa45a8e9a549 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3821206Reviewed-by:
-
jameslahm authored
Bug: v8:11525 Change-Id: I69c08f3cc4ee6b391e462a5d49de750f34bbc8cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3815487Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#82345}
-
Milad Fa authored
Port c3ca8158 Original Commit Message: In release builds, FLAG_debug_code is statically false. Without LTO, this information is not available to callers of the various Assert functions though. This CL defines the methods as empty if V8_ENABLE_DEBUG_CODE is not set. This removes some calls from non-LTO builds, and might even slightly improve LTO builds if we enable more optimizations earlier in the pipeline. R=clemensb@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I5c82eed38db6a2f49e833410554231bc61518b18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820068Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#82344}
-
Dominik Inführ authored
Introduce common bottleneck for all incremental marking step invocations from a task context. This will later be used to move code out of IncrementalMarking::Step. Bug: v8:11708 Change-Id: Iba2dc2402083f8b4152ded56eaf0e13d473442a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3822682Reviewed-by:
-
Michael Lippautz authored
This is a reland of commit 6953b555 The reland fixes tests that retrieved the stack start from a non-inlined frame's fp. This does not work in certain configurations as the resulting marker is too low to consider the first local variables in subsequent calls. The fix uses an inline frame address for the tests to get an upper bound of stack addresses to consider. Original change's description: > [handles] Remove precise on-stack representation of global handles > > Since https://crrev.com/c/3806439 on-stack traced handles are marked > conservatively when being used in combination with CppHeap. > > This change removes the precise on-stack representation of the > internal traced nodes as they nodes would anyways be marked > conservatively. The effects are: > - cheaper representation (just a single node space); > - uniform handling: no checks to distinguish on-stack vs on-heap; > - no brittleness around cleaning on-stack handles when the event loop > is empty; > > Change-Id: Id859623bfed77a66bdd064ea8065536264515eae > Bug: v8:13141 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3812039 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82306} Bug: v8:13141 Change-Id: I53ece36220e99d02be6df18f83c18450e5d5037b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3820585Reviewed-by:
-
Clemens Backes authored
Growing Wasm memory is allowed to fail nondeterministically. I checked locally that this is indeed what is making this test fail in --verify-predictable mode. R=jkummerow@chromium.org Bug: v8:13167 Change-Id: I91d21c91481ac692a9f6000be45d43d517e76cd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3822684Reviewed-by:
-
Clemens Backes authored
Tail call the StringAdd_CheckNone builtin. This also avoids the need to create a frame. X64 code before: 0 55 push rbp 1 4889e5 REX.W movq rbp,rsp 4 6a20 push 0x20 6 488b5500 REX.W movq rdx,[rbp+0x0] a 488b52f0 REX.W movq rdx,[rdx-0x10] e 8bb2c7000000 movl rsi,[rdx+0xc7] 14 4903f6 REX.W addq rsi,r14 17 e8a402f3ff call 0x7f2effeb5a80 (StringAdd_CheckNone) 1c 488be5 REX.W movq rsp,rbp 1f 5d pop rbp 20 c3 retl X64 code after: 0 488bd5 REX.W movq rdx,rbp 3 488b52f0 REX.W movq rdx,[rdx-0x10] 7 8bb2c7000000 movl rsi,[rdx+0xc7] d 4903f6 REX.W addq rsi,r14 10 e9ab02f3ff jmp 0x7fed7feb5a80 (StringAdd_CheckNone) R=jkummerow@chromium.org Bug: v8:12868 Change-Id: Ie722fb57abcd649d2586aad2c4aca55ff218fe43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3823127Reviewed-by: -
Andreas Haas authored
This is a reland of commit b67385d2 The fix landed in https://chromium-review.googlesource.com/c/v8/v8/+/3819643 Original change's description: > [wasm] Enable lazy compilation on --future > > This should increase test coverage of lazy compilation. > > R=clemensb@chromium.org > > Bug: v8:12852 > Change-Id: I205f4b642576add07db5851126370becdad52fb8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784597 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82291} Bug: v8:12852 Change-Id: I97c0aa7962b79e04dd778520e4c3108e20b83c10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3819641 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: I90c24cbddee7744fba779a0c25f5e4dd860137a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3823125 Auto-Submit: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds a small inspector test to verify that Runtime.evaluate with silent on/off can be interleaved while replMode is true for all evaluations. This is to check that the interaction between console and live expressions works as expected when the user enables "Pause on exceptions". R=bmeurer@chromium.org Bug: chromium:1335439 Change-Id: Iebd3f9f207312dc6dcd3d0b9a8483ef09608528f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3822685Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#82337}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I7dfc1e87b57455cc5b4622a67ac7c27df216c195 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3823126Reviewed-by:
-
