- 31 Mar, 2020 12 commits
-
-
Michael Lippautz authored
Quickfix to get non-clang bots green. Bug: v8:10370 Change-Id: I83591cd2bda94cd5aaffd023fe2b7068bdc7442f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2131066Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#66928}
-
Anton Bikineev authored
This CL introduces - Member - WeakMember - UntracedMember interfaces. Remaining work is to add pointer verifier and write barrier implementation. Bug: chromium:1056170 Change-Id: Iddb8e4d002db0b1d1652f2946ddfa08a98a889c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124323 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#66927}
-
Junliang Yan authored
Drive-by: Fix a few BE related issue with ptr-compr enabled. Change-Id: Ic2ff9e69a42e65089a1c1544e5eba1833c2fd95e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2057355Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#66926}
-
Marja Hölttä authored
The interpreter assumed that native context indices of the runtime functions are less than 256, which is not the case if intrinsics are at the end of the native context and we keep adding fields to native context. Also fix the operand type, so that we get a DCHECK failing if the ids don't fall into the expected range. Change-Id: I8bc13a90593739ec66cb0a507572cf5b2acc4235 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2129632 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#66925}
-
Michael Lippautz authored
Pure refactoring. The re-organization allows to easily add more platforms. Bug: chromium:1056170 Change-Id: Ia191c37a1dabff6952414c5314beeeae881713b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2129636Reviewed-by:
-
Joyee Cheung authored
Previously we use the error message for normal invalid private member access, so for a failed brand check for class C, the error is TypeError: Cannot read private member C from an object whose class did not declare it This updates the message to TypeError: Object must be an instance of class C Bug: v8:8330 Change-Id: Ida98f46b8387631194a9b7a48bd1f419045ac6e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2100688 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#66923}
-
Anton Bikineev authored
This tests that the stack doesn't get misaligned after asm trampolines. x86 and x64 psABI requires the stack to be 16 bytes aligned. Bug: chromium:1056170 Change-Id: I73e7100806c6ecf3f5e884a121a15bcc384d8011 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2128048Reviewed-by:
-
Georg Neis authored
A previous CL made the mode an explicit argument but failed to keep SimplifiedLowering from overriding it. Moreover, CheckedUint64Bounds so far didn't support the two modes. Change-Id: I01d8bf90fca77940fbeb428da57608a59f812c75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124833 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66921}
-
Michael Lippautz authored
Maintain a proper frame pointer in rbp when going through the trampoline. This ensures that e.g. gdb can properly unwind the stack. Bug: chromium:1056170 Change-Id: I7a9252316e7ce8d83cf54e1efc801b92476bc4ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2128050Reviewed-by:
-
Leszek Swirski authored
We can make sure we exhaustively test all CreateArgumentsTypes by using a switch rather than if-else. Change-Id: Id00094eeb4cb0af212f5c939314aec72a30a3ee0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2128054Reviewed-by:
-
Georg Neis authored
In https://chromium-review.googlesource.com/c/v8/v8/+/2124837 we changed the behavior of CreateDynamicFunction such that it throws a TypeError if the operation is disallowed. The TypeError constructor was taken from the target context, which didn't make a lot of sense: the entered context doesn't have access to the function ctor's context, so it won't have access to an exception created in the function ctor's context either. With this CL, the TypeError constructor is taken from the entered context instead. Note that this is not necessarily the calling context (we don't generally know the calling context at this point). Bug: v8:10361, chromium:1065094 Change-Id: I09daa1f913a7e33841eb7fa0c00fca435df64b2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2127866Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#66918}
-
Clemens Backes authored
If we want external people to stop shouting WASM, we should start by avoiding that in our own code base. This CL replaces almost all occurrences of "WASM" by "Wasm". The last remaining ones (in frames.cc) are in capitalized contexts where WASM fits. TBR=ecmziegler@chromium.org Bug: v8:10155 Change-Id: I905b92220768b99bb5e1165255691ffe4498dba3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2126917 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/master@{#66917}
-
- 30 Mar, 2020 16 commits
-
-
Ng Zhi An authored
For i8x16, most i8x16 should be done now. Drive by cleanup to remove unnecessary CpuFeatureScope (since they are in the macro assembler now). Bug: v8:9561 Change-Id: Ic4e9462eec62badfae7a5164562fdb167da76968 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2121169Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#66916}
-
Ng Zhi An authored
Bug: v8:9561 Bug: v8:10115 Change-Id: Iecec52c353e958a95e5508719cd7bd447ecc7bcc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2125507Reviewed-by:
-
Ulan Degenbaev authored
Bug: v8:6932 Change-Id: I9e77a41812c3ac9750cc4b03a8650c6e490df2a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2128047 Auto-Submit: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adds support for conservative stack scanning on x64. The trampolines saving callee-saved registers are compiled using clang (non-Windows) and MASM (Windows). This is using the default toolchain for assembly in Chromium/V8. This differs from Oilpan in Chromium where x86 and x64 are compiled using NASM [1]. V8 does not yet require this dependency and building the trampolines natively avoids it. (NASM also requires separate blocks for x64 Windows and non-Windows.) On non-x86/x64 platforms Chromium also uses clang, so there's little benefit in keeping the dependency. The trampolines are tested when building with clang. Other platforms follow in separate CLs. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/heap/asm/SaveRegisters_x86.asm Change-Id: Ice2e23e44391aa94147abe75ee0b5afac458b8f8 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124319 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Michael Lippautz authored
iOS does not support death tests. Bug: v8:10360 Change-Id: Ia86553d53eee811e5521c093fd034115a9d01750 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2128046 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Andrew Comminos authored
In order to implement CodeEntry deallocation when profiles are stopped, we need to be able to effectively deallocate strings. Introduce a simple imperative refcounting API using the existing HashMap slots for StringsStorage to enable this. Design doc: https://docs.google.com/document/d/1OTwlBnAMXZEaOICtuz16c01QnkPPdqHBoHpfGwnk5SY/edit Bug: chromium:956688 Change-Id: Iaa1142925f40aa66c064d011b2a0630de72037fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2121575Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#66911}
-
Z Nguyen-Huu authored
For globals, we would use name as follows. 1. If import: use <import_module>.<field_name> from WasmImport. 2. If export: use <field_name> from WasmExport. 3. Use global<index>. Add DecodeGlobalNames similar to DecodeFunctionNames. Doc: https://docs.google.com/document/d/1XoXWONLBgZWQ9dhtoMpQPvD0fnnWA50OorsuSXfME3g Bug: v8:10242 Change-Id: I11131528fc6ae6ca50727e9b428f76e76b0000e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2122523 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#66910}
-
Ng Zhi An authored
Implement i8x16.bitmask, i16x8.bitmask, i32x4.bitmask on arm. Bug: v8:10308 Change-Id: Ifa2439522b74a310d98621104deda80f3dc25b33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2101697Reviewed-by:
-
Joyee Cheung authored
The TODO of implementing static private brands is now obsolete now that we have implemented static private methods by directly desugaring the brand check into comparisons between the receiver and the class constructor in https://chromium-review.googlesource.com/c/v8/v8/+/1781011 Bug: v8:8330 Change-Id: Id2ab73ef13c67d626ecdfa6792252b5aea3aff45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095639Reviewed-by:
-
Milad Farazmand authored
Port a3d2f7a4 R=zhiguo.zhou@intel.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: If5888f737b10afa00c96d13243e3147cfcfbbb3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2127386Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#66907}
-
Clemens Backes authored
Debugging does not work reliably with multiple isolates involved. Thus skip all tests that we saw flaking so far. R=thibaudm@chromium.org Bug: v8:10359, v8:10358 Change-Id: I119f8fdb19efb91f7d9fad0f510ffb68c646e784 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2126906Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66906}
-
Clemens Backes authored
The last test will not be fixed in the context of enabling debugging in Liftoff. Instead, it will fail until we implement anyref in Liftoff. Thus, assign the new tracking bug to it. R=thibaudm@chromium.org Bug: v8:10351, v8:10356 Change-Id: Ic184f390841b0994bf37bbf5f7ecc13e6cf1f957 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124322 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Clemens Backes authored
When stepping in from JS, the stepping frame ID will not be set. Instead of ensuring to set it properly, we can just skip the check for the frame ID. It was needed before, when we didn't properly reset stepping information. Now, it's redundant anyway. Also, ensure that we don't redirect to the interpreter if the --debug-in-liftoff flag is set. Drive-by: Fix and clang-format some parts of the test (no semantic change). R=thibaudm@chromium.org, szuend@chromium.org Bug: v8:10351 Change-Id: I58a3cd68937006c2d6b755a4465e793abcf8a20c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124317Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Port a3d2f7a4 https://crrev.com/c/2113301 Change-Id: I2fefac5482e55c307226b417b51ab530b1f1d3ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2126588Reviewed-by:
-
Georg Neis authored
... instead of returning undefined. Bug: chromium:1065094 Change-Id: I0b0397a8affd44b58e7f4777f32ba22bbd001ab1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124837Reviewed-by:
-
Clemens Backes authored
If the type check fails, we should return. Otherwise we hit an error in ToLocalChecked below. R=yangguo@chromium.org Bug: chromium:1061673 Change-Id: I39e5b90b3574d0d2b77f5d704023aabb1c8130cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116035Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#66901}
-
- 28 Mar, 2020 2 commits
-
-
Michael Achenbach authored
NOTRY=true TBR=tmrts@chromium.org Bug: chromium:1065624 Change-Id: I6e49c48bb95e10b7fad1ff2c589a2dd459fff562 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124326Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66900}
-
Michael Achenbach authored
NOTRY=true TBR=tmrts@chromium.org Bug: chromium:1065624 Change-Id: I6115b867ac28650823bc2efa5305a5ea6f15b5a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124325Reviewed-by:
-
- 27 Mar, 2020 10 commits
-
-
Zhou, Zhiguo authored
Bug: v8:9909 Change-Id: Ie9a3098bcaa894266e850cc7094894d25709afd2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2113301 Commit-Queue: Zhiguo Zhou <zhiguo.zhou@intel.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#66898}
-
Ng Zhi An authored
Mostly i16x8 ops, this should complete all i16x8 ops. Bug: v8:9561 Change-Id: I73515c3c38a5a055ac00f97ba5c363df1bf3c771 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2111711Reviewed-by:
-
Ng Zhi An authored
Rework the remaining tests in grow-memory to check for first 5 offsets and last 5 offsets in the relevant pages. Bug: v8:7783 Change-Id: I59435f3c1a6f50ff808fdd045a6c7039860fc72e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2116647Reviewed-by:
-
Milad Farazmand authored
LoadTransform is not implemented on BE machines and instead, it is divided into 2 separate "Load" and "operation" nodes. We need to assure same behaviour applies on S390 simulator, however, S390 Sim does not execute BE code, it assume generated code is in LE format hence "V8_TARGET_BIG_ENDIAN" is set to false when running on Sim. This CL includes V8_TARGET_ARCH_S390_LE_SIM to assure same behaviour occurs when running on the Sim until V8_TARGET_BIG_ENDIAN can also include the simulator. Change-Id: If1decf9eccb43ac721b57d58362b8934d49cbff2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124847 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Michael Lippautz authored
Tbr: ulan@chromium.org Bug: chromium:1056170 Change-Id: I118b8f1911a6d61b15d3dee25aa00ab9dea4689f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124321Reviewed-by:
-
Ng Zhi An authored
All 6 replace_lane operations for ARM and ARM64. Changes to wasm-compiler required for ARM (where register aliasing is different - 2 fp registers map to 1 simd register). When src2_rc is kFpReg, and src1_rc is kFpRegPair, we still need to pin src2 when getting a register for src1, since the registers can overlap. (On other backends, src1_rc == src2_rc == kFpReg, so the current condition is met, and we correctly pin src2). Same for result_rc and src2_rc. Bug: v8:9909 Change-Id: Ib39b71534290a7109fb0da4bf62dabc66460a0dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2117637 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Clemens Backes authored
The output extends by four more breaks, since when stepping out of the function that has the breakpoint, we now also step through the two other functions on the stack. R=thibaudm@chromium.org Bug: v8:10351 Change-Id: I4b042cad0d88b923c3894fe979c43837260eb958 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2124315 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
DebugInfo::RemoveBreakpoint did not remove the correct breakpoint because of a confusion between offsets relative to the function and offsets relative to the module. This is not visible in the tests, as removed breakpoints are already skipped by the runtime function. Drive-by: replace a return which should have been a continue in OSR. R=clemensb@chromium.org Change-Id: I574c474139e969bd91217cfa7adc806d43db3c99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2120589 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adds: - GetStackStart - GetCurrentStackPosition - GetStackSlot which translates a stack slot through ASAN if needed Bug: v8:10354, chromium:1056170 Change-Id: I28e76f41de28415382f7cc32729e86d71e9f8f19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2122033 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Clemens Backes authored
There are only three tests with differing behaviour if Liftoff is used for debugging. This CL thus stages the --debug-in-liftoff flag behind --future (tested by the "future" variant) and excludes the three tests. This allows us to test the other (already working) tests for regressions, and iteratively shrinking down the list of failing tests. Drive-by: Tier down modules in tests before testing debugging features to avoid hitting a DCHECK in Liftoff recompilation for debugging. R=thibaudm@chromium.org, ecmziegler@chromium.org Bug: v8:10351 Change-Id: I3b1dd1a29258ecf13c1f60020fb06358005558d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2122021Reviewed-by:
-
