Commits · c55cdb5ede7f610f2e1e3c049afe872c27d22313 · Linshizhi / V8

08 May, 2014 3 commits

Harden yet more runtime functions · c55cdb5e

jkummerow@chromium.org authored May 08, 2014

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/270273005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21197 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c55cdb5e

Fix index register assignment in LoadFieldByIndex for arm, arm64, and mips. · 8999a006

ulan@chromium.org authored May 08, 2014

This instruciton clobbers the index register.

BUG=368243
LOG=N
TEST=mjsunit/regress/regress-368243
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/269273003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8999a006

Unbreak samples and tools. · 967a79d2

svenpanne@chromium.org authored May 08, 2014

Removed a related TODO in d8.cc on the way.

BUG=v8::3318
LOG=y
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/275463002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

967a79d2

07 May, 2014 10 commits

Broaden test expectation for ARM64. · ca11434e

mstarzinger@chromium.org authored May 07, 2014

R=machenbach@chromium.org
BUG=v8:3154
TEST=cctest/test-heap/ReleaseOverReservedPages

Review URL: https://codereview.chromium.org/270303005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21192 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ca11434e

Commenting out an assert to investigate mac test failure. · 0271098d

mvstanton@chromium.org authored May 07, 2014

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/268363010

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21191 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0271098d

Refactor mjsunit/fuzz-natives-* into a separate test suite. · e1bbd267

jkummerow@chromium.org authored May 07, 2014

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/252143002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21190 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e1bbd267

Remove GenerateBooleanCheck() since we have a boolean map now. · 066955e4

bmeurer@chromium.org authored May 07, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/269343003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21189 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

066955e4

Add back a dummy --harmony-promises flag · 515b000b

jochen@chromium.org authored May 07, 2014

This is mainly meant to help with the transition of chrome using the
flag to promises being enabled by default

BUG=none
LOG=n
R=rossberg@chromium.org, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/270503005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

515b000b

Turn CHECK()s into ASSERT()s. · b040340f

bmeurer@chromium.org authored May 07, 2014

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/275433002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b040340f

Fix constructors for HLoadNamedField. · a3fed0af

bmeurer@chromium.org authored May 07, 2014

Also try to determine an appropriate HType for tracked fields,
instead of (incorrectly) using HType::NonPrimitive() everywhere.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/269353003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a3fed0af

Merge counters and v8-counters · 24696e1d

jochen@chromium.org authored May 07, 2014

BUG=none
LOG=n
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/272433002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

24696e1d

Revert "Arm64: Ensure that csp is always aligned to 16 byte values even if... · 11f0e775

bmeurer@chromium.org authored May 07, 2014

Revert "Arm64: Ensure that csp is always aligned to 16 byte values even if jssp is not." and "Arm64: Fix check errors on Arm64 debug after r21177.".

This reverts commit r21177 and r21179 for breaking the arm64 build.

TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/271623002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21184 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

11f0e775

Fix invalid ASSERT() in HasStableMapValue(). · 87568c57

bmeurer@chromium.org authored May 07, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/267363002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

87568c57

06 May, 2014 27 commits

MIPS: Fix for 3303 MultithreadedParallelIsolates has a race condition. · 663c73b3

palfia@homejinni.com authored May 06, 2014

Port r21165 (50673b25)

Original commit message:
The fix is to make the code aging sequence hang off the isolate.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/264823004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

663c73b3

Arm64: Fix check errors on Arm64 debug after r21177. · 67ff6878

rmcilroy@chromium.org authored May 06, 2014

r21177 added extra AssertStackConsistency() checks which
increased code size on debug and caused the assembler buffer
to be too large.  Increased some of these buffers to
compensate.

Also, ProfileEntryHoolStub could use the wrong number of
instructions for kProfileEntryHookCallSize depending upon
whether debug code was being emitted or ALWAYS_ALIGN_CSP was
enabled.  Fixed this by taking ALWAYS_ALIGN_CSP into account
and ensuring that no debug code is emitted during
MaybeCallEntryHook().

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/263213008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

67ff6878

Revert "Prevent liveedit on or under generators with open activations" · 5c9ad091

rossberg@chromium.org authored May 06, 2014

Seems to crash some tests on buildbots.

TBR=ishell@chromium.org
CC=wingo@igalia.com,yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/273433002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21178 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5c9ad091

Arm64: Ensure that csp is always aligned to 16 byte values even if jssp is not. · 53bf1268

rmcilroy@chromium.org authored May 06, 2014

Even although the Arm64 specification specifies that csp
only needs to be aligned to 16 bytes if it is dereferenced, some implementations show poor performance if csp is every set to a non-aligned value.  This CL ensures that csp is always aligned to 16 byte values on these platforms and adds checks to ensure this in debug mode.

Also makes the following change:
 - Enable CPU support for arm64 to enable probing of cpu implementer and cpu part.
 - Add ALWAYS_ALIGN_CSP CpuFeature for Arm64 and set it based on runtime probing of the cpu implementer.
 - Rename PrepareForPush and PrepareForPop to PushPreamble and PopPostamble and move PopPostable after the pop.
 -

R=jacob.bramley@arm.com, ulan@chromium.org

Review URL: https://codereview.chromium.org/264773004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21177 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

53bf1268

Remove strange v8_target_arch=="mac" conditions from gyp files · f6e2d0eb

jochen@chromium.org authored May 06, 2014

mac is not an architecture, and it doesn't make sense to compile in both
the ia32 and x64 archs at the same time

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/255183002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21176 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f6e2d0eb

Import features.gypi into BUILD.gn · 517def0b

jochen@chromium.org authored May 06, 2014

BUG=none
R=brettw@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/261203003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21175 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

517def0b

Prevent liveedit on or under generators with open activations · ab96529a

wingo@igalia.com authored May 06, 2014

R=yangguo@chromium.org
LOG=N
TEST=mjsunit/harmony/generators-debug-liveedit.js
BUG=

Review URL: https://codereview.chromium.org/266983004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21174 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ab96529a

Re^3-land "Ship promises and weak collections" · ae0a36ee

rossberg@chromium.org authored May 06, 2014

R=jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/266243003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ae0a36ee

ARM64: Sign extension on MemOperand for keyed ops · ec2b42fd

m.m.capewell@googlemail.com authored May 06, 2014

SXTW extend mode is usually cheaper on loads and stores than arithmetic,
so move it to the memory accesses where possible for Keyed loads and
stores.

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/268483002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ec2b42fd

Fixed jump in non-SSE4.1 implementation of LMathFloor instruction on x64. · 9be0c4d3

ishell@chromium.org authored May 06, 2014

BUG=chromium:370384
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/261853009

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9be0c4d3

Revert "Removed default Isolate." · e9e373e8

svenpanne@chromium.org authored May 06, 2014

This reverts commit r21167, cctest/test-serialize has to be fixed first.

TBR=dcarney@chromium.org

Review URL: https://codereview.chromium.org/267163002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e9e373e8

Only force creating initial maps when we have prototypes. · 14c023c7

verwaest@chromium.org authored May 06, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/261983007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21169 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14c023c7

ARM64: Introduce TempDoubleRegister as a lithium operand constraint. · 4a9d0b04

baptiste.afsa@arm.com authored May 06, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/261933002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21168 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4a9d0b04

Removed default Isolate. · 9b4bd335

svenpanne@chromium.org authored May 06, 2014

There is probably room for more cleanup after this...

BUG=359977
LOG=y
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/262163006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21167 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9b4bd335

Pass in the map while creating JSFunction, and set prototype in the client. · af2be5b4

verwaest@chromium.org authored May 06, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/263083008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21166 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

af2be5b4

Fix for 3303 MultithreadedParallelIsolates has a race condition. · f2903b6f

mvstanton@chromium.org authored May 06, 2014

The fix is to make the code aging sequence hang off the isolate.

BUG=v8:3303
R=svenpanne@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/261953002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21165 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f2903b6f

Produce cached data only for scripts which compile without errors. · 43f9c678

marja@chromium.org authored May 06, 2014

ScriptCompiler::CompileUnbound handles cached data only when there was no
compilation error, so, if we produce the data for erroneous scripts, the
ScriptData object is leaked.

In addition, producing cached data for erroneous scripts makes little sense.

R=ulan@chromium.org
BUG=370327
LOG=N

Review URL: https://codereview.chromium.org/266423003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21164 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

43f9c678

Move generated math methods from platform to codegen · 00702723

jochen@chromium.org authored May 06, 2014

BUG=none
R=mstarzinger@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/269823006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

00702723

Pass dependency to HLoadNamedField for array length load · 2716ddd0

verwaest@chromium.org authored May 06, 2014

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/267773004

Patch from Jing Bao <jing.bao@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21162 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2716ddd0

ARM64: Use the shifter operand to merge in previous shift instructions. · cf8d874a

m.m.capewell@googlemail.com authored May 06, 2014

When possible, we transform sequences of code of the form
    lsl x8, x9, #imm
    add x0, x1, x8
into
    add x0, x1, x9 LSL #imm

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/257203002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21161 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cf8d874a

Remove broken %_Log functionality. · 55c077f9

mstarzinger@chromium.org authored May 06, 2014

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/265283007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21160 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

55c077f9

[Android]: Update Makefile.android to use platform-14 as minimum. · 5fb71327

rmcilroy@chromium.org authored May 06, 2014

The version of the NDK in Chromium only has platform/android-14 and above
(since Chrome only supports API 14 and above).  To make it easier for
developers to use the Chromium NDK to build V8, this CL updates the default
platform version to 14.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/267873002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21159 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5fb71327

Do not call setters of read-only accessors. · a872ffda

ulan@chromium.org authored May 06, 2014

BUG=
TEST=mjsunit/readonly-accessor
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/271433002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21158 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a872ffda

Make sure CPU profiler collects a sample on start. · d56f01ba

alph@chromium.org authored May 06, 2014

BUG=369035
LOG=N
R=bmeurer@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/263883008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21157 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d56f01ba

ARM64: Use default-NaN mode to canonicalize NaNs. · 77d6bca4

Jacob.Bramley@arm.com authored May 06, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/255343004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21156 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77d6bca4

Fix Mac64-debug issue introduced with r21154. · 96e2fee4

bmeurer@chromium.org authored May 06, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/271443002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21155 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

96e2fee4

Next bunch of fixes for check elimination. · a051bc57

bmeurer@chromium.org authored May 06, 2014

- Canonicalize HCheckMapValue with constant map to
  HCheckMaps, and get rid of the special treatment
  during check elimination.
- Track only stable object maps for HConstants and
  add CHECK()s to verify state during code generation.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/263923004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21154 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a051bc57