- 13 Jul, 2018 18 commits
-
-
Dan Elphick authored
All auto-generated with some fix-ups including marking the following classes as NeverReadOnlySpaceObject so their GetIsolate/GetHeap methods are safe to use: Code, CodeDataContainer, AbstractCode, DeoptimizationData, CompilationCacheTable, NormalizedMapCache, Script, SharedFunctionInfo TBR=yangguo@chromium.org Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I6cb5dcca88a0bc99b5afe80f553e06a661b5da3c Reviewed-on: https://chromium-review.googlesource.com/1135306 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54439}
-
Clemens Hammacher authored
No need to define a function just to default-initialize all fields. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: I059f310d22435a364dff8b7cfcb68c6314412c9a Reviewed-on: https://chromium-review.googlesource.com/1136306 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Dan Elphick authored
Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I195d65ec77a838878db340599fc8a5de1c3e1324 Reviewed-on: https://chromium-review.googlesource.com/1135541Reviewed-by:
-
Michael Starzinger authored
The code under test is handling of multi-return values in TurboFan and hence actually independent of WebAssembly. The only reason to generate WasmCode is in order to use the WebAseembly linkages. This changes the generated code to have {STUB} kind instead of {WASM_FUNCTION} kind to avoid having stack checks in the generated code which would require a proper WasmInstanceObject to be allocated. R=ahaas@chromium.org BUG=chromium:862508 Change-Id: I4feb7bff1a42bbf59cfc5f249f2e0585ce7011ad Reviewed-on: https://chromium-review.googlesource.com/1136438Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54436}
-
Michael Starzinger authored
This removes support to track the memory footprint of fully executed but not yet finalized compilation units. It was used to throttle creation of new tasks when the latent memory pressure of this unfinished jobs rose above a certain threshold. Now that units no longer incur a significant latent memory pressure, this is no longer needed. R=clemensh@chromium.org BUG=v8:7921 Change-Id: I3f4a563ebcb85b7aeac50f469a8a495eecf8aa3d Reviewed-on: https://chromium-review.googlesource.com/1136291Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54435}
-
Clemens Hammacher authored
This adds trace events for Liftoff compilation, Turbofan compilation, instantiation and running the start function. These are basic operations that help to understand the startup behaviour of WebAssembly modules. R=ahaas@chromium.org Change-Id: I0c0544cfd2d03de1783fa1d3a5897d3b8ef09e05 Reviewed-on: https://chromium-review.googlesource.com/1134768 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#54434}
-
Camillo Bruni authored
Abort after reaching MAX_NOF_RETRIES since there is only a very low chance that the page will keep on working after that. Change-Id: Ia9e5f3cf69ae2b5ad40a60f86a46800541404862 Bug: v8:7941 Reviewed-on: https://chromium-review.googlesource.com/1134771Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54433}
-
Michael Starzinger authored
This removes an occurrence where the "%Foo" native syntax appears as part of a string. Such strings are picked up by the fuzzer and recombined in unsupported ways, producing false-positive crash reports. Simply avoid having those strings in the fuzzing corpus. R=clemensh@chromium.org TEST=mjsunit/regress/wasm/regress-808848 BUG=chromium:844842 Change-Id: I017c1552578f0d26033e58b11353e87e27a69ebf Reviewed-on: https://chromium-review.googlesource.com/1136300Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7921 Change-Id: I5d6417c7b661066cecaf2eb7125d7399f3d9cf21 Reviewed-on: https://chromium-review.googlesource.com/1135141 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds constants that can be defined in the module scope: const kConstexprConst: constexpr int31 = 5; const kIntptrConst: intptr = 4; const kSmiConst: Smi = 3; They are implemented by generating "mini-macros" that return the expression on the right-hand side of the assignment. Bug: v8:7793 Change-Id: I0a476cb3111707fad56bf15e9547b377c7adab37 Reviewed-on: https://chromium-review.googlesource.com/1114745 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54430}
-
Ivica Bogosavljevic authored
Change-Id: Iecbc7b5b4f8cbea99cb83982d0b5f0db78dfa89e Reviewed-on: https://chromium-review.googlesource.com/1128964 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Reviewed-by:
Miran Karić <miran.karic@mips.com> Cr-Commit-Position: refs/heads/master@{#54429}
-
Michael Lippautz authored
This reverts commit 7bff339e. Reason for revert: Breaks autoroll, see bug. Bug: v8:7944 Original change's description: > Reland "[heap] Added External Strings to external memory accounting." > > This is a reland of 5863c0b6 > > Original change's description: > > [heap] Added External Strings to external memory accounting. > > > > Bug: chromium:845409 > > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 > > Reviewed-on: https://chromium-review.googlesource.com/1118164 > > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54110} > > Bug: chromium:845409 > Change-Id: Ied341ec6268000343d2a577b22f2a483460b01f5 > Reviewed-on: https://chromium-review.googlesource.com/1121736 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54410} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,petermarshall@chromium.org,rfbpb@google.com Change-Id: Ie55586e84f44a2d83c7f97110d60abb86f0730c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1136312Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54428}
-
Michael Lippautz authored
This reverts commit 6b4ba741. Reason for revert: Blocks roll, see bug. Bug: v8:7944 Original change's description: > Fix update external string call in morph string test. > > Bug: chromium:845409 > Change-Id: Ic9b1fa0f669c8b9a82ed91d3f348dd070fc9267f > Reviewed-on: https://chromium-review.googlesource.com/1135247 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54419} TBR=mlippautz@chromium.org,rfbpb@google.com Change-Id: I42121de37913bbe858b9a7c6a9dabf86090c493b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:845409 Reviewed-on: https://chromium-review.googlesource.com/1136311Reviewed-by:
-
Clemens Hammacher authored
In https://crrev.com/c/1044187 we messed up the macro definition, so the four f64 operations with c fallback were actually never emitted (we bailed out instead). This went unnoticed, as it does not produce an error. This CL reenables these four instructions. R=ahaas@chromium.org CC=predrag.rudic@mips.com Bug: v8:6600, v8:7933 Change-Id: I394a0348237676c12df741fc3f302c4576619ffc Reviewed-on: https://chromium-review.googlesource.com/1135532Reviewed-by:
-
Michael Starzinger authored
This moves the entire code generation phase (including code emission into the native module) into the background task. The code manager is fully thread safe by now and there are no Isolate-bound steps anymore. The only step remaining on the foreground task is publishing the fully finished code to other threads via {NativeModule::PublishCode}. R=clemensh@chromium.org BUG=v8:7921 Change-Id: Ia64c6ce945aabd071b26e61ef8d397fb7727a038 Reviewed-on: https://chromium-review.googlesource.com/1135004 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Clemens Hammacher authored
This is a reland of 5b744bfb. Node is fixed by this pull request: https://github.com/v8/node/pull/75 Original change's description: > Fix and extend lldbinit > > 1) Define all commands in one file. > 2) Add logic to make 'jco' print current pc by default. > 3) Add a comment to explain how to load the lldb_commands.py file. > 4) Minor refactorings. > > R=ahaas@chromium.org > No-Try: true > > Bug: v8:7754 > Change-Id: I553f2ce4cefedad05466c692a8665a570372b76a > Reviewed-on: https://chromium-review.googlesource.com/1127892 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54329} Bug: v8:7754 Change-Id: I8645ae07176fe6983a581dd175ed6f2b2b15d4ea Reviewed-on: https://chromium-review.googlesource.com/1135026Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54424}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6ff84ae..7b4d0db Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/39de3d2..8495de1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/32e3d1e..882c91e Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/e3d4003..7edc822 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia175b2c08112afe5b882ca2e40ffd9cdf4c0d16b Reviewed-on: https://chromium-review.googlesource.com/1136068 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54423}
-
Johannes Henkel authored
This is in preparation of removing the using statements that are currently in third_party/inspector_protocol/lib/Collections_h.template. Once this is done I can update https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1135832 some more and eventually roll it into v8 (and chromium's third party). R=dgozman Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I75a7b291715f241e3b58fb97ac91a0b0ff0ca70b Reviewed-on: https://chromium-review.googlesource.com/1135968 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#54422}
-
- 12 Jul, 2018 22 commits
-
-
Junliang Yan authored
Change-Id: I2e0166cf99f2f9b501c82cbf27215389a3eb3092 Reviewed-on: https://chromium-review.googlesource.com/1135124Reviewed-by:
Muntasir Mallick <mmallick@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#54421}
-
Vasili Skurydzin authored
Change-Id: I5d20ea5efb76a24c6569e56caf2e22638141ce95 Reviewed-on: https://chromium-review.googlesource.com/1117602 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#54420}
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: Ic9b1fa0f669c8b9a82ed91d3f348dd070fc9267f Reviewed-on: https://chromium-review.googlesource.com/1135247 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Michael Lippautz authored
The manual scope is usually used to test corner cases of GC behavior so disable the ineffective GC detecton there. Bug: v8:7859 Change-Id: I92a1e43db739846ff0db20a60cc2ace79496e5fe Reviewed-on: https://chromium-review.googlesource.com/1135140Reviewed-by:
-
Clemens Hammacher authored
Since Liftoff is fully implemented on arm64, we can enable the wasm/liftoff test. R=ahaas@chromium.org Bug: v8:6600 Change-Id: I901480a417a7cc438357a67b819f226e4d3b1df4 Reviewed-on: https://chromium-review.googlesource.com/1134776 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: v8:7790 Change-Id: I16a2fa9c37a8b00a067f8f7fd3a87cb747233132 Reviewed-on: https://chromium-review.googlesource.com/1128968 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54416}
-
Anna Henningsen authored
Some Linux kernels are built without `madvise()`. In that case, do not crash but rather ignore the return value instead. Refs: https://github.com/nodejs/node/issues/21562 Change-Id: Iff8d0d0e9e7935804e2fc994be7f8bd21c553846 Reviewed-on: https://chromium-review.googlesource.com/1131943Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54415}
-
Marja Hölttä authored
api.h: MAKE_TO_LOCAL funcs need the types to be available. scope.h, func-name-inferrer.h, bigint.h, module.h: These were using inline headers -> de-inlined. BUG=v8:7754,v8:7490 Change-Id: Id072f537682fb867cd68d79ca95b06628780d01f Reviewed-on: https://chromium-review.googlesource.com/1131175 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Set number of fixpoint iterations to 10 before switching to the linear algorithm. The flag's initial default value was set to 0 to use the linear algorithm all the time for testing purposes. Bug: chromium:844008 Change-Id: Ib0fd6241b55468ef5be2c4cc3cc147db2d432c83 Reviewed-on: https://chromium-review.googlesource.com/1134769Reviewed-by:
-
Joyee Cheung authored
This patch adds a variant of EmbedderGraph::AddEdge() which allows the embedder to specify the name of an edge. The edges added without name are element edges with auto-incremented indexes while the edges added with names will be internal edges with the specified names for more meaningful output in the heap snapshot. Refs: https://github.com/nodejs/node/pull/21741 Bug: v8:7938 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I8feefa2cf6911743e24b3b2024e0e849b0c65cd3 Reviewed-on: https://chromium-review.googlesource.com/1133299 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The WasmGrowMemory builtin (defined in builtins-wasm-gen.cc) expects the runtime function to return a Smi. Thus ensure that we are really always returning a Smi. R=mstarzinger@chromium.org Change-Id: I153d75a2ab8773adbcce01e9aa125a234c93d077 Reviewed-on: https://chromium-review.googlesource.com/1131737Reviewed-by:
-
Rodrigo Bruno authored
This is a reland of 5863c0b6 Original change's description: > [heap] Added External Strings to external memory accounting. > > Bug: chromium:845409 > Change-Id: I3fe2b294f6e038d77787cf0870d244ba7cc20550 > Reviewed-on: https://chromium-review.googlesource.com/1118164 > Commit-Queue: Rodrigo Bruno <rfbpb@google.com> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54110} Bug: chromium:845409 Change-Id: Ied341ec6268000343d2a577b22f2a483460b01f5 Reviewed-on: https://chromium-review.googlesource.com/1121736 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Currently the fuzzer only tests Turbofan and Liftoff in isolation. In order to test that both tiers use the same ABI, it should also test calls from one tier to the other. This CL introduces a new flag which controls which function will be compiled by which tier, and uses that in the fuzzer. R=ahaas@chromium.org Bug: chromium:862931, v8:6600 Change-Id: I450b906700972cfdb496b1734faed9f8208d652f Reviewed-on: https://chromium-review.googlesource.com/1134775 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Peter Marshall authored
When we changed FeedbackMetadata to be it's own type instead of a subtype of FixedArray, we missed this check for valid objects in old space. This restores the old behavior during verification. Bug: chromium:862433 Change-Id: Icdb144df4aebc0c6d78a28405c7f53e40b2e1376 Reviewed-on: https://chromium-review.googlesource.com/1134995Reviewed-by:
-
Dan Elphick authored
Bug: v8:7786 Change-Id: If9615f5dffc40937f9f35a209730d530be6b424b Reviewed-on: https://chromium-review.googlesource.com/1134986Reviewed-by:
-
Clemens Hammacher authored
Instead of passing {uint8_t*, size_t} pairs as arguments, pass {Vector<uint8_t>}. This is less error prone and {Vector} provides some helpful methods. R=ahaas@chromium.org Bug: v8:7754 Change-Id: I7469054774618e0bd5c9d38501759b1b2c51d104 Reviewed-on: https://chromium-review.googlesource.com/1134773Reviewed-by: -
Jungshik Shin authored
getGetoption() in intl.js misimplemented Ecma 402 #sec-getoption by calling options[property] twice, once to check if it's defined and the second time to retrieve the value when it's defined. Bug: v8:7869 Test: test262/intl402/RelativeTimeFormat/con*/cons*/option*order Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I6d585767232c9f4c0252e65e2891c813db3da641 Reviewed-on: https://chromium-review.googlesource.com/1128444 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#54405}
-
Clemens Hammacher authored
An unordered_map typically provides better performance. Instead of a compare function, we now need a hash function and equality defined on {Signature<T>}. R=mstarzinger@chromium.org Bug: chromium:862123 Change-Id: Iba71030f91949d7453740c884de1d8a4f921c618 Reviewed-on: https://chromium-review.googlesource.com/1131182 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I1045885ad1efe2b1dd7a9e2b83d1f5323e77dcbb Reviewed-on: https://chromium-review.googlesource.com/1134988Reviewed-by:
-
Andreas Haas authored
The instruction got removed from the proposal. R=titzer@chromium.org Bug: v8:7581 Change-Id: I3e27bad923544896ebf6ab8969e5c365a397f6c9 Reviewed-on: https://chromium-review.googlesource.com/1128754Reviewed-by:
-
Leszek Swirski authored
With ReadOnlyRoots and GetIsolate on JSReceiver, we can remove almost every isolate parameter from <Object>::Print. The remaining ones, like Map, are special-caseable for read-only maps, and as a result we can remove isolate parameters from <Object>::Print entirely. This patch also opportunistically cleans up a few places where isolates were only needed for Object::Print, such as TransitionAccessors and DescriptorArrays. TBR=yangguo@chromium.org,mstarzinger@chromium.org Bug: v8:7786 Change-Id: Id44bd53b9893e679eea5f37b9548257595a1bfd9 Reviewed-on: https://chromium-review.googlesource.com/1133385Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#54401}
-
Andreas Haas authored
With the introduction of multiple tables the element section is able to initialize any of the defined tables. However, the spec says that only tables of type AnyFunc can be initialized. With this CL we validate that entries in the element section only target AnyFunc tables. R=titzer@chromium.org Bug: v8:7581 Change-Id: Ifea383b13c91f582813b2aa4f01a5f724575cfa0 Reviewed-on: https://chromium-review.googlesource.com/1130519 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
