- 08 Jun, 2022 15 commits
-
-
Leszek Swirski authored
Anyone using CopyablePersistentTraits should be using v8::Global, so deprecate it and fix the uses in V8. Bug: v8:12915 Change-Id: I25e6f2a03e070db9e9af9bbd9ea8cbc0f838c5ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669254Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#81001}
-
Al Muthanna Athamina authored
NOTRY=true Bug: v8:12358 Change-Id: I89a880b9e187b8b149b670d38320aa46be0424dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695374 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#81000}
-
Samuel Groß authored
If enabled, a signal handler is installed which intercepts memory access violations (e.g. SIGSEGV) and checks whether they occurred inside the sandbox address space, in which case the process is terminated cleanly as this does not represent a (security) issue with the sandbox. However, if the access violation occurred outside the sandbox, the access violation is forwarded to the original signal handler. The filter can be enabled in d8 by specifying --enable-sandbox-crash-filter. Bug: v8:12878 Change-Id: If9d76267e90ee79ee81ab793d7774afed6226b7c Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688408Reviewed-by:
-
Clemens Backes authored
Flags will be protected from updates after V8 initialization (in the future). This CL avoids any updates of the --gc-interval flag during runtime, and instead updates a static field on the HeapAllocator directly. R=mlippautz@chromium.org Bug: v8:12887 Change-Id: I17a495cae50a46d59a8159c6ece1558d4d61b949 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687691 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Context: https://github.com/WebAssembly/exception-handling/pull/197 This change removes the wasm exception -> JS Error inheritance. R=jkummerow@chromium.org Bug: v8:8091 Change-Id: I479f16fe03d4d77d2ecd8409e96f9a3c063912b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688401 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#80997}
-
Andy Wingo authored
No functional change. Bug: v8:12868 Change-Id: I5f09861e2b5beb400dcc1656f80230404cf544b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693704Reviewed-by:
-
Igor Sheludko authored
... by default when fast W^X is enabled. Bug: v8:12054 Change-Id: I242567a07aa323127e5f7cdcbf3a1a7d5708b923 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688518 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#80995}
-
Al Muthanna Athamina authored
NOTRY=true Bug: v8:12725 Change-Id: I3650d920bfe7ec432e84fc294d38baf13b2ef53a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695375Reviewed-by:
-
Al Muthanna Athamina authored
Bug: v8:12013 Change-Id: Idb0ae37176b81623f6faaf5904352e95066684dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695373 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
-
Liu Yu authored
Port commit 3e43010a Bug: v8:12161 Change-Id: Ifda4003b9370ff340ea78d495a05dd310324fd8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3694661Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu Yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#80992}
-
Manos Koukoutos authored
- Rename WasmTrapElemSegmentDropped -> WasmTrapElemSegmentOutOfBounds. - Rename WasmArrayInitFromData -> WasmArrayInitFromSegment, in anticipation of array.init_from_elem. - Rename InitExprInterface::result_ -> computed_value_, to distinguish it from the {result} values. Also, rename generate_result() -> generate_value(). - Drive-by: Restructure Runtime_WasmArrayInitFromSegment. Change-Id: Ic372db909847c7a169f3d6732e64e8665f4200fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693702Reviewed-by:Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80991}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/6d50251..108ca84 fix typo in comment (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/108ca84 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: I091bbd6d668a0ebd949432c5307276b3b7fc8c68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3694933 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80990}
-
Jakob Kummerow authored
Performing the "swap with TypeCast" input optimization causes inconsistent types for unreachable AssertNonNull instructions (that should inherit that TypeCast's <bot> type). Fixed: v8:12945 Change-Id: Ie51cd6531267a2828c6aac92948edda5c2a5db37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693708 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#80989}
-
Manos Koukoutos authored
This reverts commit 5147e9c8. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Android%20Arm64%20-%20builder/45354/overview Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a568526..5ef7447 > > Rolling v8/buildtools/linux64: git_revision:37baefb026b199605affa7bcb24810d1724ce373..git_revision:2f71761a90bdccdb5f4a99e8b231c96aba0967d9 > > Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/c30c515..11395e5 > > Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/86ab9dd..1644d07 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3a2e446..45853b3 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/13c50b4..6754c49 > > Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220531.3.1..version:8.20220607.2.1 > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4e79fda..a455f33 > > R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: I388c75fffc589bcc2702f9d36fec250a6d6d37c3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3691131 > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#80987} Change-Id: I600e78aa222922ceffde2de1d714823645728b90 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3691852 Owners-Override: Manos Koukoutos <manoskouk@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a568526..5ef7447 Rolling v8/buildtools/linux64: git_revision:37baefb026b199605affa7bcb24810d1724ce373..git_revision:2f71761a90bdccdb5f4a99e8b231c96aba0967d9 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/c30c515..11395e5 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/86ab9dd..1644d07 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3a2e446..45853b3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/13c50b4..6754c49 Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220531.3.1..version:8.20220607.2.1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4e79fda..a455f33 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I388c75fffc589bcc2702f9d36fec250a6d6d37c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3691131 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80987}
-
- 07 Jun, 2022 24 commits
-
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plainyearmonth.compare https://tc39.es/proposal-temporal/#sec-temporal.plainmonthday.compare https://tc39.es/proposal-temporal/#sec-temporal.plainmonthday.prototype.equals Bug: v8:11544 Change-Id: Ia03946e0e183ec9b0a8130515607c29a32a8b265 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673418Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#80986}
-
Frank Tang authored
Implement AOs: RoundISODateTime Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.plaindatetime.prototype.tostring https://tc39.es/proposal-temporal/#sec-temporal-roundisodatetime Bug: v8:11544 Change-Id: Ib0318be8047bb01e593a43cef4405caa5979d1af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687568Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.zoneddatetime.prototype.withplaindate Bug: v8:11544 Change-Id: I8d7099906c04eae0e29ff0dabd48b736a07305d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3692432 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.add https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.subtract Also fix bug in IsValidEpochNanoseconds Bug: v8:11544 Change-Id: Ied605c9de4ee38a18e2356a89e3a69d534a004d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3617394 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
Bug: v8:12764 Change-Id: I4f4d2775045878576227463f27ded769c3cef362 No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3691797 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Deepti Gandluri authored
Bug: v8:12284 Change-Id: I9d4a5d7420c6650039f84b3c8fc7974e9e617ce3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687566Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/main@{#80981}
-
Georgia Kouveli authored
GCC doesn't accept 'lr' in inline assembly, specifically for the list of clobbered registers. Change all uses to 'x30', for consistency. Bug: v8:10026 Change-Id: I5654fee4ca398dfdd99c34d09fc5294d169a9bd8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693701Reviewed-by:
-
Milad Fa authored
Port e50d19cb Original Commit Message: https://crrev.com/c/3471854 already disabled the RecordWrite builtin specifically for incremental marking. Since this didn't regress performance as expected, we can now remove those versions of the builtin. This will simplify the barrier implementation a bit, but is also required for the shared heap write barrier. Unlike the generational barrier, the shared heap barrier can't be elided for map values. R=dinfuehr@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Ic1a31fad3faaafeab077590d71d6d998eaddcc6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3691128Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80979}
-
Manos Koukoutos authored
This is required for a V8 DEPS roll: https://chromium-review.googlesource.com/c/v8/v8/+/3691119. Change-Id: I65371eb7fd23b9dd13802e77bd3c14afdd592641 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688407Reviewed-by:
-
Nikolaos Papaspyrou authored
Mostly in comments, again, not much to be said... Bug: v8:12425 Change-Id: I6d6c70b4e4dba70ec6ac7574caecc77b65316050 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693698Reviewed-by:
-
Seth Brenith authored
I noticed in a recent build that C++ files from cctest didn't start compiling until after several slow non-parallel tasks such as running mksnapshot and linking v8_for_testing. I don't see any reason that cctest sources should wait for those tasks, so in this change I propose adjusting the build dependencies for more parallelism. Change-Id: I2472117c8555ac397fa1232954c8b699d6429d38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3690170Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#80976}
-
Samuel Groß authored
When the sandbox cannot be initialized, it's either because there is not enough virtual address space available, or because there is not enough memory for the kernel data structures needed for the reservation (this typically happens on Windows 7/8 where reserving virtual memory is expensive). Both cases should be reported as OOMs, not CHECK failures. Bug: chromium:1325302 Change-Id: I17bde9bcd4fbd6e3d54075b8891287c8fb01c1d7 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng,v8_linux_arm64_sim_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688406 Auto-Submit: Samuel Groß <saelo@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Liu Yu authored
Port commit e50d19cb Bug: v8:11708 Change-Id: Ia9a8cb9d8cd9e768fc056bc5555959e0aaeb3694 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3692435Reviewed-by:
-
Manos Koukoutos authored
Most notable: - Suggest '--experimental-wasm-gc' for wasm-gc type definitions. - Remove unused/useless fields from WasmTypeInfo. - Put more wasm Turbofan optimizations behind '--wasm-opt'. Change-Id: Ia298a58c2cf03964472a1445460d12ae72a5b04d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688404Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Milad Fa authored
Port: f149912f Drive-by: Defined EnqueueFunction under baseline-batch-compiler for platforms without spakrplug support, currently getting a link error when making a debug build. Bug: v8:12887 Change-Id: I4fc8584ef09ad024280f7e40554a5e73a207b64f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688474Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80972}
-
Liu Yu authored
Use doubleword load/store to swap values in FPSackSlots instead of word load/store. Besides, fix error in gap resolver. Change-Id: I57e9d577a6001bc970ce6b56b6f890eb3e4d196c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688325 Auto-Submit: Liu Yu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Manos Koukoutos authored
Drive-by: Make the code less verbose my returning the input node from SetInt32Type. Bug: v8:7748, chromium:1332385 Change-Id: I2fde9c2168af1365e305e7e8d894b03487e8a8d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687692Reviewed-by:
-
Patrick Thier authored
It is now considered best effort, that in-place internalizable strings are promoted into the shared old space instead of non-shared old space. This was previously an invariant, but it doesn't hold if the whole page containing the shared string is promoted instead of individual objects. In addition with conservative stack scanning individual objects won't be moved. Bug: v8:12007 Change-Id: I7474738b02b0c18080cb2e82268a02bf9b480c40 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688512Reviewed-by:
Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#80969}
-
Dominik Inführ authored
This build flag was removed in https://crrev.com/c/3314864. Bug: v8:12470 Change-Id: I365a1914ff096d07ae41d8bf35150615a9c91736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3676853 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80968}
-
Nico Hartmann authored
In typed-optimization, Turbofan optimized NumberFloor(NumberDivide(...)) patterns where both inputs are known to be of Unsigned32 type, but the replacement couldn't be typed consistently. This CL introduces a new operator Unsigned32Divide, which has the same semantics, but can be typed consistently and thus allows the simplified lowering verifier to validate the graph correctly. Bug: v8:12619 Change-Id: Iad77154d3d840c94edfd3ab91ffa37c840da0bc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3644790 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80967}
-
Dominik Inführ authored
https://crrev.com/c/3471854 already disabled the RecordWrite builtin specifically for incremental marking. Since this didn't regress performance as expected, we can now remove those versions of the builtin. This will simplify the barrier implementation a bit, but is also required for the shared heap write barrier. Unlike the generational barrier, the shared heap barrier can't be elided for map values. Bug: v8:11708 Change-Id: I44bc6ee79006a5be8c1b593dee7fc30c3b9cfa85 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3683341Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80966}
-
Igor Sheludko authored
Bug: v8:12797 Change-Id: Ide50026c7dc35197876e66cc53a7936acb765aa9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687735 Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Gabriel Charette authored
Mirrors a Chromium change @ https://chromium-review.googlesource.com/c/chromium/src/+/3680123 and a v8 change @ https://chromium-review.googlesource.com/c/v8/v8/+/3687370/ Bug: chromium:1330114 Change-Id: I61b1e34d54a496dda25936efbcd339fa35e64fb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3686476 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/main@{#80964}
-
Gabriel Charette authored
Mirrors a Chromium change @ https://chromium-review.googlesource.com/c/chromium/src/+/3680123 Bug: chromium:1330114 Change-Id: I6fdfd93264e669965245f5ba696fb5b605e417fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687370 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
- 06 Jun, 2022 1 commit
-
-
Luis Fernando Pardo Sixtos authored
Currently the Isolate is gotten off of the object that the operation is being performed on. Shared objects return the shared Isolate, which is incorrect as it shouldn't be used to run JS, nor does it have HandleScopes open. Plumb the executing Isolate through. Bug: v8:12547 Change-Id: I2f500cbb707b3ce2e8a78203df9920374c190d28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3691967 Commit-Queue: Luis Fernando Pardo Sixtos <lpardosixtos@microsoft.com> Reviewed-by:
-
