1. 08 Apr, 2020 1 commit
    • Clemens Backes's avatar
      Reland "[wasm] Debug in Liftoff by default" · 904a3e78
      Clemens Backes authored
      This is a reland of 44826509.
      TSan issue were fixed in https://crrev.com/c/2139574. One test
      failing in the 'stress' variant is skipped for now, until we figure
      out what the intended behaviour actually is.
      
      Original change's description:
      > [wasm] Debug in Liftoff by default
      >
      > This flips the --debug-in-liftoff flag to be on by default.
      > There are still some outstanding issues with that configuration, but not
      > more than with the interpreter configuration. Thus flip now, such that
      > we can fully focus on stabilizing that config.
      >
      > R=ecmziegler@chromium.org
      >
      > Bug: v8:10351
      > Change-Id: I7681f40aa2516557ef3ab4efd9a2c1f88e3b4df7
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135727
      > Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org>
      > Commit-Queue: Clemens Backes <clemensb@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#67018}
      
      Bug: v8:10351, v8:10403
      Change-Id: I4c2f1af46233546d6ebeb638c7ef10aac56cd92d
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139575
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarEmanuel Ziegler <ecmziegler@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#67049}
      904a3e78
  2. 06 Apr, 2020 2 commits
  3. 26 Mar, 2020 1 commit
  4. 25 Mar, 2020 1 commit
  5. 14 Jan, 2020 1 commit
    • Clemens Backes's avatar
      [wasm][debug] Fix index-named locals · 4d69c548
      Clemens Backes authored
      This fixes local names that are the string representation of a valid
      element index.
      Even though both the Liftoff and the interpreter-based test are changed,
      only the latter needs to be fixed right now since Liftoff does not use
      the names currently. Modifying the test just ensures that we implement
      this correctly once we use the name.
      
      R=jkummerow@chromium.org
      
      Bug: v8:10019
      Change-Id: Ib7f7d6e244a344a85ab540b6c2c67f98b1f3078e
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1998079
      Commit-Queue: Clemens Backes <clemensb@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#65751}
      4d69c548
  6. 13 Jan, 2020 1 commit
  7. 10 Jan, 2020 1 commit
  8. 09 Jan, 2020 1 commit
  9. 15 Nov, 2019 1 commit
    • Eric Leese's avatar
      Report real module in addition to fake scripts · 6ec6ed9c
      Eric Leese authored
      Currently the inspector reports Wasm in one of two ways:
       - If there is a source map, report one script per Wasm script, with
         bytecode but no source.
       - If there is no source map, report one script per Wasm function, with
         source (Wasm disassembly) but no bytecode.
      
      With this change, behavior with source map is same, but without source
      map it will report both ways. This will allow us to change the frontend
      to do its own disassembly, allowing us to remove the per-function scripts
      in a future change.
      
      Bug: chromium:1013527
      Change-Id: I0c559ad08896e8d0da419e3c6ad8d1edff3976fc
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899782Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
      Commit-Queue: Eric Leese <leese@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#64980}
      6ec6ed9c
  10. 24 Oct, 2019 1 commit
  11. 08 Oct, 2019 2 commits
  12. 10 May, 2019 1 commit
  13. 30 Jan, 2019 1 commit
  14. 11 Jan, 2019 1 commit
  15. 31 May, 2018 2 commits
  16. 03 Jul, 2017 1 commit
    • Clemens Hammacher's avatar
      [wasm] Decode local names for debugging · 07752032
      Clemens Hammacher authored
      When providing scope information (containing the value of local
      variables of live stack frames), decode the local variable names of all
      functions in a wasm module and store this in the WasmDebugInfo
      structure.
      Use these names to actually name the reported locals, instead of using
      the default names "param#<d>" and "local#<d>". These names are only used
      as fallbacks for locals which were not assigned a name.
      
      R=titzer@chromium.org,kozyatinskiy@chromium.org
      BUG=v8:6245
      
      Change-Id: Ibf7d30e392248ef5590177cd8b6329239b45e018
      Reviewed-on: https://chromium-review.googlesource.com/548495
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46379}
      07752032