- 12 Jun, 2015 24 commits
-
-
bmeurer authored
Up until now we used int32_t for NodeId, but that was not ideal because negative values are invalid for NodeId and we use it as an array index for example in the NodeMarker class, where C++ compilers on x64 have to generate code that does proper sign extension for the indices, which is completely unnecessary. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/1178403004 Cr-Commit-Position: refs/heads/master@{#28997}
-
wingo authored
Revert of Add script context with context-allocated "const this" (patchset #2 id:20001 of https://codereview.chromium.org/1173333004/) Reason for revert: nosnap failure Original issue's description: > Add script context with context-allocated "const this" > > This is a reapplication of https://codereview.chromium.org/1179893002/. > > R=rossberg@chromium.org,mstarzinger@chromium.org > LOG=N > BUG=498811 > > Committed: https://crrev.com/cfc764f4050edc74aef92daa4c39ccc113893968 > Cr-Commit-Position: refs/heads/master@{#28994} TBR=mstarzinger@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498811 Review URL: https://codereview.chromium.org/1177903004 Cr-Commit-Position: refs/heads/master@{#28996}
-
dusan.milosavljevic authored
Allocation must respect requested reserve size, not requested commit area size. Additionally fix check failures in debug mode for mips64. After CL: https://codereview.chromium.org/1147503002/ memory for large code objects is allocated from code range, memory for regular code objects is allocated normally. TEST=cctest/test-spaces/MemoryChunk BUG= Review URL: https://codereview.chromium.org/1172333002 Cr-Commit-Position: refs/heads/master@{#28995}
-
wingo authored
This is a reapplication of https://codereview.chromium.org/1179893002/. R=rossberg@chromium.org,mstarzinger@chromium.org LOG=N BUG=498811 Review URL: https://codereview.chromium.org/1173333004 Cr-Commit-Position: refs/heads/master@{#28994}
-
bmeurer authored
R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1177353003 Cr-Commit-Position: refs/heads/master@{#28993}
-
machenbach authored
Revert of Add script context with context-allocated "const this" (patchset #7 id:120001 of https://codereview.chromium.org/1179893002/) Reason for revert: [Sheriff] Breaks gc mole: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/2435 Original issue's description: > Add script context with context-allocated "const this" > > R=rossberg@chromium.org > LOG=N > BUG=498811 > > Committed: https://crrev.com/fa32d461c16a053cc6d48d3fb326016bc2765765 > Cr-Commit-Position: refs/heads/master@{#28988} TBR=rossberg@chromium.org,mstarzinger@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498811 Review URL: https://codereview.chromium.org/1180043004 Cr-Commit-Position: refs/heads/master@{#28992}
-
yangguo authored
Revert of MIPS64: Enable shorten-64-to-32 warning. (patchset #12 id:240001 of https://codereview.chromium.org/1133163005/) Reason for revert: Compile failure: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Mac64%20-%20debug/builds/3070/steps/compile/logs/stdio Original issue's description: > MIPS64: Enable shorten-64-to-32 warning. > > Port cdc43bc5 > > Original commit message: > Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings > that arise. > > BUG= > > Committed: https://crrev.com/9af578a7c83b58a0ce25345998d9287cbf2030cb > Cr-Commit-Position: refs/heads/master@{#28990} TBR=danno@chromium.org,martyn.capewell@arm.com,paul.lind@imgtec.com,akos.palfi@imgtec.com,dusan.milosavljevic@imgtec.com,jkummerow@chromium.org,machenbach@chromium.org,svenpanne@chromium.org,balazs.kilvady@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1182493007 Cr-Commit-Position: refs/heads/master@{#28991}
-
balazs.kilvady authored
Port cdc43bc5 Original commit message: Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings that arise. BUG= Review URL: https://codereview.chromium.org/1133163005 Cr-Commit-Position: refs/heads/master@{#28990}
-
yangguo authored
R=vogelheim@chromium.org Review URL: https://codereview.chromium.org/1180043003 Cr-Commit-Position: refs/heads/master@{#28989}
-
wingo authored
R=rossberg@chromium.org LOG=N BUG=498811 Review URL: https://codereview.chromium.org/1179893002 Cr-Commit-Position: refs/heads/master@{#28988}
-
jochen authored
Original review https://codereview.chromium.org/1133773002/ BUG=v8:3996 TBR=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1177083003 Cr-Commit-Position: refs/heads/master@{#28987}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#28986}
-
jochen authored
BUG=none R=yangguo@chromium.org LOG=n Review URL: https://codereview.chromium.org/1179053004 Cr-Commit-Position: refs/heads/master@{#28985}
-
jochen authored
R=yangguo@chromium.org BUG=none LOG=n Review URL: https://codereview.chromium.org/1184493003 Cr-Commit-Position: refs/heads/master@{#28984}
-
Benedikt Meurer authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/1184693002. Cr-Commit-Position: refs/heads/master@{#28983}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#28982}
-
machenbach authored
Revert of [es6] Bound function names (patchset #1 id:1 of https://codereview.chromium.org/1182513002/) Reason for revert: [Sheriff] Speculative revert for changing layout tests: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_32/379/layout-test-results/results.html Exact blame assignment is not possible as our blink bots were in a bad state for a few builds. Original issue's description: > [es6] Bound function names > > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function.prototype.bind > > Bound functions should have a name based on the function that was > bound. > > BUG=N > LOG=N > R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/4e2a673881c55a13124dd62f2d05c8d9fe233cd3 > Cr-Commit-Position: refs/heads/master@{#28968} TBR=adamk@chromium.org,arv@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=N Review URL: https://codereview.chromium.org/1186463002 Cr-Commit-Position: refs/heads/master@{#28981}
-
bmeurer authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/1181123002 Cr-Commit-Position: refs/heads/master@{#28980}
-
bmeurer authored
Revert of Keep track of array buffers in new space separately (patchset #4 id:60001 of https://codereview.chromium.org/1133773002/) Reason for revert: GC stress unhappy Original issue's description: > Keep track of array buffers in new space separately > > BUG=v8:3996 > R=hpayer@chromium.org > LOG=n > > Committed: https://crrev.com/506397d0a4241c19f5fab890e49e22d1d9b28bdc > Cr-Commit-Position: refs/heads/master@{#28978} TBR=hpayer@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3996 Review URL: https://codereview.chromium.org/1178403003 Cr-Commit-Position: refs/heads/master@{#28979}
-
jochen authored
BUG=v8:3996 R=hpayer@chromium.org LOG=n Review URL: https://codereview.chromium.org/1133773002 Cr-Commit-Position: refs/heads/master@{#28978}
-
jacob.bramley authored
With this patch, we can generate simple immediate-shift instructions for immediates outside the range "0 <= imm < width". Several related instruction selectors have also been updated accordingly. Example of generated code: ---- Before --- ---- After ---- movz w0, #33 lsr w0, w1, #1 lsr w0, w1, w0 BUG= Review URL: https://codereview.chromium.org/1179893003 Cr-Commit-Position: refs/heads/master@{#28977}
-
martyn.capewell authored
Before selecting multiply-accumulate for a multiplication with add operation, check that the multiply can't be reduced to add-with-shift. This prevents simple multiplications by 3, 5, etc turning into register moves and madd instructions. Review URL: https://codereview.chromium.org/1180863002 Cr-Commit-Position: refs/heads/master@{#28976}
-
mstarzinger authored
This fixes the graph wiring of implicit JSToNumber nodes inserted by JSTypedLowering, to be correctly hooked into a surrounding exceptional continuation. R=bmeurer@chromium.org TEST=mjsunit/compiler/try-binop,test262 Review URL: https://codereview.chromium.org/1178153004 Cr-Commit-Position: refs/heads/master@{#28975}
-
v8-autoroll authored
Rolling v8/tools/clang to 8b3ed2cb2e2512fa1074043cea3ada1143b80f26 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1179113002 Cr-Commit-Position: refs/heads/master@{#28974}
-
- 11 Jun, 2015 16 commits
-
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1178123003 Cr-Commit-Position: refs/heads/master@{#28973}
-
dehrenberg authored
The spec says ToObject is called on the receiver, and this is observable if you call sort on a primitive. This patch trivially adds the call and a test. BUG=v8:4125 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1178193004 Cr-Commit-Position: refs/heads/master@{#28972}
-
arv authored
When setting a property using `super.prop = val` we need to use add property if we are adding a new property and not set property. BUG=493566 LOG=N R=verwaest@chromium.org, dslomov@chromium.org Review URL: https://codereview.chromium.org/1161073002 Cr-Commit-Position: refs/heads/master@{#28971}
-
Toon Verwaest authored
BUG=v8:4137 LOG=n R=arv@chromium.org Review URL: https://codereview.chromium.org/1179983002. Cr-Commit-Position: refs/heads/master@{#28970}
-
dehrenberg authored
%AddElement is not intended for objects which are not arrays, and its behavior may go away with future refactorings. This patch gets rid of it if the receiver of from or of is not the intrinsic Array object. Array.of and Array.from previously papered over failures in calling [[DefineOwnProperty]] when setting array elements. This patch makes them lead to exceptions, and adds tests to assert that the appropriate exceptions are thrown. BUG=v8:4168 R=adamk CC=rossberg,verwaest LOG=Y Review URL: https://codereview.chromium.org/1181623003 Cr-Commit-Position: refs/heads/master@{#28969}
-
arv authored
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-function.prototype.bind Bound functions should have a name based on the function that was bound. BUG=N LOG=N R=adamk CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1182513002 Cr-Commit-Position: refs/heads/master@{#28968}
-
verwaest authored
Reland of Use the LookupIterator in SetAccessor (patchset #1 id:1 of https://codereview.chromium.org/1175323004/) Reason: Didn't break anything Original issue's description: > Revert of Use the LookupIterator in SetAccessor (patchset #2 id:20001 of https://codereview.chromium.org/1178673003/) > > Reason for revert: > Blocks reverting of https://codereview.chromium.org/1175973002 > > Original issue's description: > > Use the LookupIterator in SetAccessor > > > > BUG=v8:4137 > > LOG=n > > > > Committed: https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9 > > Cr-Commit-Position: refs/heads/master@{#28955} > > TBR=jkummerow@chromium.org,verwaest@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4137 > > Committed: https://crrev.com/11dbd29de57b290ee8dac2a782a53f879beb416f > Cr-Commit-Position: refs/heads/master@{#28956} TBR=jkummerow@chromium.org,ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Review URL: https://codereview.chromium.org/1181813002 Cr-Commit-Position: refs/heads/master@{#28967}
-
verwaest authored
Revert of Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #1 id:1 of https://codereview.chromium.org/1179933002/) Reason for revert: Reland, this didn't break anything. Original issue's description: > Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/) > > Reason for revert: > It broke webkit_unit_tests > > Original issue's description: > > Remove GetAttributes from the mix to avoid another virtual dispatch. > > > > BUG=chromium:495949,v8:4137 > > LOG=n > > > > Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175 > > Cr-Commit-Position: refs/heads/master@{#28953} > > TBR=verwaest@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:495949,v8:4137 > > Committed: https://crrev.com/ae639d2ad646237e2f413259a0f116845ef96440 > Cr-Commit-Position: refs/heads/master@{#28958} TBR=ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:495949,v8:4137 Review URL: https://codereview.chromium.org/1182603002 Cr-Commit-Position: refs/heads/master@{#28966}
-
Toon Verwaest authored
BUG=v8:4137 LOG=n R=ishell@chromium.org Review URL: https://codereview.chromium.org/1173283004. Cr-Commit-Position: refs/heads/master@{#28965}
-
mtrofin authored
The main motivation is simplifying profiling activities: 1) Use hex instead of decimal for offsets, just like perf does. This affects --print-opt-code 2) When printing block information, indicate loop information: if block is header, where the end is; if block is in a loop, where the loop starts. This affects --code-comments. Using --print-opt-code --code-comments, and cross-referencing with data obtained from perf, one may now find the block a hotspot belongs to without needing to do hex2dec/dec2hex conversions. Once found, loop info is available locally, on the block. BUG= Review URL: https://codereview.chromium.org/1177123002 Cr-Commit-Position: refs/heads/master@{#28964}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1177103003 Cr-Commit-Position: refs/heads/master@{#28963}
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1178083002 Cr-Commit-Position: refs/heads/master@{#28962}
-
arv authored
BUG=v8:4116 LOG=N R=adamk@chromium.org Review URL: https://codereview.chromium.org/1180873002 Cr-Commit-Position: refs/heads/master@{#28961}
-
dstence authored
R=mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1177263002 Cr-Commit-Position: refs/heads/master@{#28960}
-
Toon Verwaest authored
BUG=v8:4137 LOG=n R=ishell@chromium.org Review URL: https://codereview.chromium.org/1178953003. Cr-Commit-Position: refs/heads/master@{#28959}
-
ishell authored
Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/) Reason for revert: It broke webkit_unit_tests Original issue's description: > Remove GetAttributes from the mix to avoid another virtual dispatch. > > BUG=chromium:495949,v8:4137 > LOG=n > > Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175 > Cr-Commit-Position: refs/heads/master@{#28953} TBR=verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:495949,v8:4137 Review URL: https://codereview.chromium.org/1179933002 Cr-Commit-Position: refs/heads/master@{#28958}
-