- 23 Jul, 2019 1 commit
-
-
Mythri A authored
Reland after splitting large classes further. es6/classes.js is large and causes timeouts and OOM on some of the configurations. Bug: v8:9246 Change-Id: I51952447eb6a6b46d78410d5d3798292f5a8d87d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706061 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62864}
-
- 17 Jul, 2019 2 commits
-
-
Sathya Gunasekaran authored
This reverts commit 21e34c71. Reason for revert: breaks TSAN https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/27444 Original change's description: > [cleanup][test] split es6/classes.js into different tests > > es6/classes.js is large and causes timeouts and OOM on some of the > configurations. > > Bug: v8:9246 > Change-Id: Iaabfc39dd8f9554e16f67d66ce64acd3dd56b9ee > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1704103 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62758} TBR=mythria@chromium.org,gsathya@chromium.org Change-Id: I296d51ed682f51a3e6794858ab96b9407cc8ec56 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9246 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706058Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#62760}
-
Mythri A authored
es6/classes.js is large and causes timeouts and OOM on some of the configurations. Bug: v8:9246 Change-Id: Iaabfc39dd8f9554e16f67d66ce64acd3dd56b9ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1704103Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#62758}
-
- 30 Apr, 2019 1 commit
-
-
Mythri A authored
With bytecode flushing and lazy feedback allocation, we need to call %PrepareForOptimization before we call %OptimizeFunctionOnNextCall Bug: v8:8801, v8:8394 Change-Id: I81918f174b2f97cbaa8b8ef2e459080c2581f535 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588415 Commit-Queue: Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#61122}
-
- 14 Dec, 2018 1 commit
-
-
Camillo Bruni authored
Do not set the name property on any function or classes. This is not required as per spec #sec-__proto__-property-names-in-object-initializers. Bug: v8:7773 Change-Id: Iade96573690e5b14b60434c37683f782cf9cb2cb Reviewed-on: https://chromium-review.googlesource.com/c/1375912Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58239}
-
- 14 Nov, 2018 1 commit
-
-
Igor Sheludko authored
Also add comments and regression tests. Bug: chromium:904272 Change-Id: I89e8ec537bbdce09fda120cd29d5a5e54e77cf19 Reviewed-on: https://chromium-review.googlesource.com/c/1335556Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57500}
-
- 09 Nov, 2018 1 commit
-
-
Toon Verwaest authored
The current implementation isn't very helpful anyway if we ever really want this. Change-Id: Iad4132734980937aee462a1613d47887383585a0 Reviewed-on: https://chromium-review.googlesource.com/c/1328928Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57388}
-
- 15 Jan, 2018 1 commit
-
-
Camillo Bruni authored
Bug: chromium:802040 Change-Id: I887a6e9d06bd1e66e0e8175a7bbb830f693e55ed Reviewed-on: https://chromium-review.googlesource.com/866854Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#50589}
-
- 17 Nov, 2017 1 commit
-
-
Igor Sheludko authored
This CL also includes fixes for CF issues found while the previous reland was active. Bug: v8:5799, chromium:783902, chromium:783926, chromium:783822 Change-Id: I1f7d9b037d90838469c45f5d72771a77444c662e Reviewed-on: https://chromium-review.googlesource.com/764067Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#49457}
-
- 28 Feb, 2017 1 commit
-
-
Georg Neis authored
BUG=v8:6022 Change-Id: I54205cb3ecc2dd31ed62e55726f0ec5fcd202c30 Reviewed-on: https://chromium-review.googlesource.com/446349 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#43500}
-
- 04 Nov, 2016 1 commit
-
-
henrique.ferreiro authored
This was removed from ECMAScript in the September 2016 TC39 meeting, see https://github.com/tc39/ecma262/issues/670. BUG=v8:5535 Review-Url: https://codereview.chromium.org/2430383004 Cr-Commit-Position: refs/heads/master@{#40770}
-
- 04 May, 2016 1 commit
-
-
neis authored
This fixes a bug where returning from a class literal inside a try-finally didn't restore the context properly when entering the finally clause. BUG=v8:4965 LOG=n Review-Url: https://codereview.chromium.org/1952633002 Cr-Commit-Position: refs/heads/master@{#36021}
-
- 08 Apr, 2016 1 commit
-
-
adamk authored
These were all on by default in M49 without complaint. R=littledan@chromium.org Review URL: https://codereview.chromium.org/1858943002 Cr-Commit-Position: refs/heads/master@{#35342}
-
- 04 Mar, 2016 1 commit
-
-
adamk authored
BUG=v8:3699, chromium:588803 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1749353004 Cr-Commit-Position: refs/heads/master@{#34474}
-
- 05 Nov, 2015 1 commit
-
-
cbruni authored
LOG=N BUG=v8:4428 Review URL: https://codereview.chromium.org/1425293007 Cr-Commit-Position: refs/heads/master@{#31839}
-
- 04 Nov, 2015 3 commits
-
-
cbruni authored
The current implementation of classes throws the TypeError at the wrong point, after activating a new context when directly calling a class constructor. According to the spec, the TypeError has to be thrown in the caller context. LOG=N BUG=v8:4428 Committed: https://crrev.com/6a06bc0a774933719f62009d81b3f1686d83bb90 Cr-Commit-Position: refs/heads/master@{#31786} Review URL: https://codereview.chromium.org/1418623007 Cr-Commit-Position: refs/heads/master@{#31790}
-
cbruni authored
Revert of [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. (patchset #20 id:370001 of https://codereview.chromium.org/1418623007/ ) Reason for revert: failing build bot Original issue's description: > [runtime] Fix ES6 9.2.1 [[Call]] when encountering a classConstructor. > > The current implementation of classes throws the TypeError at the wrong > point, after activating a new context when directly calling a class > constructor. According to the spec, the TypeError has to be thrown > in the caller context. > > LOG=N > BUG=v8:4428 > > Committed: https://crrev.com/6a06bc0a774933719f62009d81b3f1686d83bb90 > Cr-Commit-Position: refs/heads/master@{#31786} TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4428 Review URL: https://codereview.chromium.org/1415783006 Cr-Commit-Position: refs/heads/master@{#31787}
-
cbruni authored
The current implementation of classes throws the TypeError at the wrong point, after activating a new context when directly calling a class constructor. According to the spec, the TypeError has to be thrown in the caller context. LOG=N BUG=v8:4428 Review URL: https://codereview.chromium.org/1418623007 Cr-Commit-Position: refs/heads/master@{#31786}
-
- 26 Jun, 2015 1 commit
-
-
arv authored
Move class tests to es6 directory BUG=v8:3330 LOG=N R=adamk Review URL: https://codereview.chromium.org/1213813003 Cr-Commit-Position: refs/heads/master@{#29336}
-
- 22 Apr, 2015 1 commit
-
-
arv authored
BUG=v8:4009 LOG=N R=dslomov@chromium.org Review URL: https://codereview.chromium.org/1101543002 Cr-Commit-Position: refs/heads/master@{#28016}
-
- 09 Apr, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:3946, v8:3982 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel LOG=N R=arv@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1027283004 Cr-Commit-Position: refs/heads/master@{#27729}
-
- 12 Feb, 2015 1 commit
-
-
Dmitry Lomov authored
This CL fixes tests that no longer valid and also fixes two issues: 1. 'super()' in non derived constructors. 2. Failure to step into derived constructors. R=arv@chromium.org, yurys@chromium.org BUG=v8:3834 LOG=Y Review URL: https://codereview.chromium.org/923443003 Cr-Commit-Position: refs/heads/master@{#26628}
-
- 10 Feb, 2015 1 commit
-
-
arv authored
super() is only allowed in a class constructor. super.p is allowed in methods, accessors and constructors. The parser now checks the FunctionState to see what kind of function we are currently inside. BUG=v8:3330 LOG=N R=dslomov@chromium.org, marja@chromium.org Review URL: https://codereview.chromium.org/915563003 Cr-Commit-Position: refs/heads/master@{#26557}
-
- 05 Feb, 2015 1 commit
-
-
Erik Arvidsson authored
This also removes some convenience functions that were not used. BUG=v8:3700 LOG=N R=adamk@chromium.org, adamk Review URL: https://codereview.chromium.org/883073008 Cr-Commit-Position: refs/heads/master@{#26472}
-
- 04 Feb, 2015 1 commit
-
-
arv authored
Class methods and accessors (both prototype and static) should be non enumerable. BUG=v8:3330 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/896643003 Cr-Commit-Position: refs/heads/master@{#26437}
-
- 01 Dec, 2014 1 commit
-
-
dslomov authored
R=arv@chromium.org BUG=v8:3330 LOG=N Review URL: https://codereview.chromium.org/770843002 Cr-Commit-Position: refs/heads/master@{#25589}
-
- 28 Nov, 2014 1 commit
-
-
dslomov authored
R=rossberg@chromium.org,arv@chromium.org BUG=v8:3330 LOG=N Review URL: https://codereview.chromium.org/766663003 Cr-Commit-Position: refs/heads/master@{#25555}
-
- 26 Nov, 2014 1 commit
-
-
dslomov authored
Per TC39 Nov 2014 decision. This patch also changes behavior for "legacy const": assignments to sloppy const in strict mode is now also a type error. This fixes v8:2243 and also brings us in compliance with other engines re assignment to function names (see updated webkit test), but might have bigger implications. That change can easily be reverted by changing Variable::IsSignallingAssignmentToConst. BUG=v8:3713,v8:2243 LOG=N Review URL: https://codereview.chromium.org/749633002 Cr-Commit-Position: refs/heads/master@{#25516}
-
- 20 Nov, 2014 1 commit
-
-
Andreas Rossberg authored
Also clean up flag names a little. Baseline: https://codereview.chromium.org/713413003/ R=arv@chromium.org, dslomov@chromium.org BUG= Review URL: https://codereview.chromium.org/722203006 Cr-Commit-Position: refs/heads/master@{#25435}
-
- 18 Nov, 2014 1 commit
-
-
arv authored
This tests that the extends expression is treated as strict at runtime and not just at parse time. BUG=v8:3330 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/729323003 Cr-Commit-Position: refs/heads/master@{#25407}
-
- 14 Nov, 2014 1 commit
-
-
arv authored
Named class declarations and class expression have a const binding for the name that is in TDZ for the extends expression. BUG=v8:3330 LOG=Y R=dslomov@chromium.org, adamk Review URL: https://codereview.chromium.org/722793005 Cr-Commit-Position: refs/heads/master@{#25360}
-
- 11 Nov, 2014 3 commits
-
-
arv@chromium.org authored
This is currently done by generating a default constructor that looks like this: constructor() { %DefaultConstructorSuperCall(); } The a runtime function implements the logic which is pretty similar to Runtime_Apply except that it uses the [[Prototype]] of the current function. This is the second try. The first failed because the test was using a array that was too large for Function.prototype.apply. Revert "Revert "Classes: Add support for arguments in default constructor"" This reverts commit 43aa7e541df56a132608b8b4217e9da84575e4f8. BUG=v8:3672 LOG=Y TBR=dslomov@chromium.org Review URL: https://codereview.chromium.org/716853003 Cr-Commit-Position: refs/heads/master@{#25272} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25272 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
arv@chromium.org authored
This reverts commit 3f4ea6c91a962a04407c79f08e5c86ce9ff2911a. Broke tests on Mac64 http://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/923/steps/Check/logs/classes BUG=v8:3672 TBR=dslomov@chromium.org LOG=N Review URL: https://codereview.chromium.org/712333003 Cr-Commit-Position: refs/heads/master@{#25269} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
arv@chromium.org authored
This is currently done by generating a default constructor that looks like this: constructor() { %DefaultConstructorSuperCall(); } The a runtime function implements the logic which is pretty similar to Runtime_Apply except that it uses the [[Prototype]] of the current function. BUG=v8:3672 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/692333011 Cr-Commit-Position: refs/heads/master@{#25268} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25268 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Nov, 2014 1 commit
-
-
arv@chromium.org authored
Introduce two new function kind, one for default constructor and one for default constructor call super. Then when we are about to pares these we just generate the correct AST in source. BUG=v8:3661, v8:3672 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/700523003 Cr-Commit-Position: refs/heads/master@{#25222} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Nov, 2014 1 commit
-
-
rossberg@chromium.org authored
This is in preparation for making --harmony and --es-staging synonyms. The only remaining difference currently is block-scoping, which is still implied by --harmony, to avoid regressing on a long-available feature. Also removes the special-casing of --harmony-proxies. R=adamk@chromium.org BUG= Review URL: https://codereview.chromium.org/693153004 Cr-Commit-Position: refs/heads/master@{#25115} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25115 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Oct, 2014 1 commit
-
-
arv@chromium.org authored
This is done by installing the [[HomeObject]] on the method and the accessor functions. BUG=v8:3330 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/683893002 Cr-Commit-Position: refs/heads/master@{#24976} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24976 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Oct, 2014 3 commits
-
-
arv@chromium.org authored
BUG=3655 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/687453004 Cr-Commit-Position: refs/heads/master@{#24943} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24943 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
arv@chromium.org authored
Methods should not have a prototype property BUG=v8:3330 LOG=y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/678103004 Cr-Commit-Position: refs/heads/master@{#24939} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24939 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
arv@chromium.org authored
This adds the properties to the prototype and the constructor. BUG=v8:3330 LOG=Y R=dslomov@chromium.org Review URL: https://codereview.chromium.org/680993003 Cr-Commit-Position: refs/heads/master@{#24934} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24934 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-