- 28 Jul, 2022 32 commits
-
-
Leszek Swirski authored
1. A remainder equal to zero means no deopt. 2. We need the input value in the input register, so we need to treat rax as a clobbered temporary instead of a fixed input. Bug: v8:7700 Change-Id: I9a7b7f3cc48e17b262aa7f9084fa864ad505be54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788099 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#82044}
-
Milad Fa authored
Port ec6368bf R=yahan@iscas.ac.cn, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I268121f4b3ec66ca3b545551c337066ec5d7cdc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791905 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#82043}
-
Victor Gomes authored
Bug: v8:7700 Change-Id: Id5fddd337635b2932bb1ab0609db38ecc72d95b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3790961 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82042}
-
Victor Gomes authored
This is a reland of commit ef1e65d9 Original change's description: > [maglev] Inline allocation for heap numbers > > Bug: v8:7700 > Change-Id: I2ce46fcfaab6716e6a31167ed517d2e8d9e433d8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788094 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82027} Bug: v8:7700 Change-Id: I3d86880c20ef4b5765a87d272f18cad9fac210fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3790971Reviewed-by:
-
Leszek Swirski authored
While marking uses, record what values are used inside a loop, but defined outside of it. Then, on the loop end, extend the lifetime of these values. Bug: v8:7700 Change-Id: I1bba037be760b4871673ecf0af584f5bf72fc35c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782797Reviewed-by:
-
Toon Verwaest authored
Label already supports forward references through the label itself, so we don't need to keep track of that separately. Change-Id: I16fd10888041c833e1c65ffdaaa985a7adf8c126 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3790975 Auto-Submit: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Clemens Backes authored
Memory64 currently does not use trap handling, so we should not allocate a guard region (10GB total reservation). This is implemented by adding a {WasmMemoryFlag} enum in the backing store header, which replaces the previous {MemoryIndexType}. The flag is not stored with the backing store, as the backing store does not care about the index type, and we might want to share the same backing store for memory32 and memory64 (if sizes permit this). Instead, we (still) store the flag with the WasmMemoryObject and pass it to the backing store methods. R=jkummerow@chromium.org Bug: v8:10949 Change-Id: I284b85b98d181ba5e8d454b24bfa48f6ac201be5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789506Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Victor Gomes authored
I forgot to remove the -1 when hoisting it. Bug: v8:7700 Change-Id: I407d387058ef476ae2359f8c3815d6a70fff1b97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791904 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Register merges participate in the same parallel gap move as phi inputs, but their allocation is not aware of the phis' existence (since the register merge allocation sees the register state _before_ phi input allocation, which is because that's what parallel move requires). This means that they might move into a register that is used by a Phi, and possibly will clobber its value. Avoid this by recording what registers phis move values into during code gen, and skipping register moves into those registers. Also DCHECK that the recorded gap moves can't clobber a target register from a previous gap move. Additionally, add printing for register merges (both in regalloc tracing and graph printing). Bug: v8:7700 Change-Id: I8bd4803a30a894c5654e33fc5657ef3fe6cf7a0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791062Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#82036}
-
Matthias Liedtke authored
Bug: v8:7748 Change-Id: Ifd4caec2015894f736dd94356298f6ee35ac852b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779911Reviewed-by:
Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Matthias Liedtke <mliedtke@chromium.org> Cr-Commit-Position: refs/heads/main@{#82035}
-
Leszek Swirski authored
This reverts commit ef1e65d9. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20debug/42329/overview Original change's description: > [maglev] Inline allocation for heap numbers > > Bug: v8:7700 > Change-Id: I2ce46fcfaab6716e6a31167ed517d2e8d9e433d8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788094 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#82027} Bug: v8:7700 Change-Id: I63ba2b1c879db652270fa1a83e32f6fec948333b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791064 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82034}
-
Clemens Backes authored
This is deprecated since 10.5 and replaced by the new callback which receives more OOM details. R=mlippautz@chromium.org Bug: chromium:1323177 Change-Id: I9385da33c3d9227144ebc47d6dddae702701ff82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789509Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82033}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1404d7f..ce68e6e R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I3c4085d6ceec054f441fcfd53632b3cac7b85670 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791003 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82032}
-
Leszek Swirski authored
Matches changes in https://crrev.com/c/3780308 No-Tree-Checks: true Bug: chromium:1347876 Change-Id: Ifacff208785e87f31c9034361867ffde7c83a898 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3790966Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#82031}
-
Liviu Rau authored
Bug: v8:13083 Change-Id: I3c96d9f6cc1e459f4f5704ddfcab218c39643010 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3790965Reviewed-by:
Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#82030}
-
Jakob Kummerow authored
Strips the Name section off a module. Change-Id: Ie28b80e610e4a858689f6a8aa01c0855c4c905a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3787876 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#82029}
-
Victor Gomes authored
Change-Id: I317c42a6efd977ec990e28941fd7a9e638227be0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789517Reviewed-by:
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I2ce46fcfaab6716e6a31167ed517d2e8d9e433d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788094Reviewed-by:
-
Tobias Tebbi authored
Trigger tier-up faster for small functions, while waiting longer for big functions, while trying to keep the overall amount of optimization roughly the same. Change-Id: I279daa21e151e9db20340089f9fa111141c6e645 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779910Reviewed-by:
-
Hannes Payer authored
Change-Id: I07eaf3e1cfdff8190b91adfc3c428fe356e5f7a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791060Reviewed-by:
-
Victor Gomes authored
Bug: v8:7700 Change-Id: I73eae4aa0b81c3a8ae53b64a0f750a0e7cced40e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3784589 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Clemens Backes authored
Advance the deprecation of structs, classes, and methods which do not make sense any more after dynamic tiering. They were marked V8_DEPRECATE_SOON in 10.5. R=mlippautz@chromium.org Bug: v8:12899 Change-Id: I12b21f7d968a161b285b558d6e2437b0d03ef696 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789510Reviewed-by:
-
Marja Hölttä authored
Now with smaller repro Bug: v8:11111,chromium:1347721 Change-Id: I637d85e91249aa8eb433f6e00e4fd385d5b950ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789519 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Auto-Submit: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
after ccefc2e2. Bug: v8:13023 Change-Id: I5830296fa03e75e503cea116e90ff27327b0b642 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3790960Reviewed-by:
Clemens Backes <clemensb@chromium.org> Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#82021}
-
Victor Gomes authored
We visit the pointers in the same order as the ASCII diagram. Bug: v8:7700 Change-Id: Ia11f49cb84b1d5abf4723aa5604c4a302f4ea79d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789513Reviewed-by:
-
Clemens Backes authored
This method is only called from {AllocateWasmMemory}, so does not need to be public. R=jkummerow@chromium.org Bug: v8:10949 Change-Id: Idf411179b6cf816adc111ceebf79335177e3440b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789502Reviewed-by: -
Leszek Swirski authored
DoubleRegister RegisterMerge could get assigned a Tagged representation operand if the node in the merge was null. Also, we had a wrong DCHECK when materialising these moves, as a result of templatifying the gap move implementation. Bug: v8:7700 Change-Id: I2a425a6bedf4c67e8acf6c30c877e055b6445b12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3783994 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Al Muthanna Athamina authored
Add CI builder-pair for Mac-arm64 with no pointer compression with a matching optional trybot. Also rename existing similar builder for Linux to have "no" in the name as well. Bug: v8:13083 Change-Id: I33389b8f224f12cf9fd3abf78f9cbabdf6ee5bfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779914Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#82017}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8ec71a4..1404d7f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/184bc29..37aede2 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I7490ab280878824e90336ff9978adfd404c97f9f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789873 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82016}
-
v8-ci-autoroll-builder authored
Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/955e2ff..2a908ee Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b1e3787..84a7988 Rolling v8/third_party/fuchsia-sdk/sdk: version:9.20220726.1.1..version:9.20220727.1.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I1e7a959bb2a4c0c9c2c52c692a626cabeddc8d9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789872 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82015}
-
Leszek Swirski authored
After https://crrev.com/c/3787682 Bug: v8:11325 Change-Id: I3dbcd3f8f0be19d9ca9ea2ab239ec1d9e902bd9c No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789518Reviewed-by:
-
Lu Yahan authored
Bug: v8:11325 Change-Id: Iffe8d049cbb97384e81fa3eeae5066e58b303066 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3787682Reviewed-by:
Igor Sheludko <ishell@chromium.org> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#82013}
-
- 27 Jul, 2022 8 commits
-
-
Milad Fa authored
Change-Id: Ibe2be0079386dd56135a0ee3f2732797b62f258a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789512Reviewed-by:
-
Milad Fa authored
This CL includes the following changes: - Avoid using `UniqueRegister` as much as possible - Try to group opcodes under Binary or Unary when possible Some codegen ops had to also be modified to avoid using `Temp` registers. Change-Id: Ib21ab7a47f600068c8453d48c3549e481a19c328 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780496Reviewed-by:
-
Igor Sheludko authored
Bug: v8:10470 Change-Id: Icbd4c052b8d39300e45ab6fbee422839d852132b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3788207Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#82010}
-
Thibaud Michaud authored
This is a reland of commit 8cb02753 Original change's description: > [wasm] Materialize suspender in JS-to-wasm wrapper > > Instead of creating the Suspender object in JS and passing it to the > stack-switching js-to-wasm wrapper, the wrapper now automatically > creates the Suspender object and forwards it as an extra parameter to > the wasm function. See: > https://github.com/WebAssembly/js-promise-integration/pull/1/files > > R=ahaas@chromium.org > > Bug: v8:12191 > Change-Id: I2badee823f4223a293632f93e7e59f24c49d0820 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3779688 > Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81890} Bug: v8:12191 Change-Id: Iea233e30aa269279d2fe17f5230c87285c33e232 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3780817 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Danylo Boiko authored
New nenu buttons: - Uncollapse all blocks - Compress layout - Collapse selected blocks - Uncollapse selected blocks New hotkeys: - Layout graph - Select all nodes - Select all selected block's nodes - Collapse selected blocks - Uncollapse selected blocks - Select node's input nodes - Select node's output nodes - Collapse unused blocks (blocks that don't have direct inputs and outputs of a hovered node) - Copy hovered node's info Bug: v8:7327 Change-Id: I942fe595ffea878f10cfbd962c3eff1786f1b954 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3773778Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Danylo Boiko <danielboyko02@gmail.com> Cr-Commit-Position: refs/heads/main@{#82008}
-
Leszek Swirski authored
This reverts commit fb19bc36. Reason for revert: Test is flaky (see https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8807487788813571761/+/u/Check_-_isolates__flakes_/regress-crbug-1347721) Original change's description: > [rab/gsab] Fix accessing raw byte length > > Bug: v8:11111,chromium:1347721 > Change-Id: Idff4256f6720841ca4dee8f691babe7245277046 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3782812 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Auto-Submit: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81995} Bug: v8:11111,chromium:1347721 Change-Id: Ib29bd8fad1227acb21c79378c71ed081ba8b4914 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789505 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#82007}
-
Omer Katz authored
All objects allocated during Isolate initialization are long living and should be allocated in old space. Bug: v8:12612 Change-Id: I394cbaa2ba45750b98bfa219afa0c538552de9c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3785148Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Qifan Pan authored
Bug: v8:9407 Change-Id: I978f6d81c01bdf86131beca5a756181f23b0ed52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3789500Reviewed-by:
-
