- 16 Apr, 2021 6 commits
-
-
Almothana Athamneh authored
Add compile-only opt-in builder equivalent to "V8 Linux - vtunejit" on CQ. Bug: v8:11653 Change-Id: I8f2033f299b85113e60cec6aa8771b02c7e610c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826542Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/master@{#73990}
-
Leszek Swirski authored
Bug: v8:11650 Change-Id: Ice830eda80e81faf920c73214f7cd8f4230af6d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2831472 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#73989}
-
Mike Stanton authored
Instead, bail out of inline literal creation if a deprecated map is found. This makes it easier to compile on the background thread. Bug: v8:7790 Change-Id: I87941938d4f13dcf49230cf246c33bf2f49897f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2745134 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#73988}
-
Leszek Swirski authored
Add --compile-only and --repeat-compile=N options for benchmarking compilation performance. Change-Id: Ibcdce94ef0d2a24374badeca114f44b693adb2ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2827903 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#73987}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e966858..e00ea2a Rolling v8/third_party/aemu-linux-x64: V4pHBauOtd8S1jDOxP65uQ5t1vxtzWpESymTE3h7ZMMC..9sUPtFCh9UkUuiYa9MoTXIK9ycaDI3CAdFHoa7zIT9cC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3898886..02b5d39 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b1cc5ed..9ceff71 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I20c5b2a59bb597c5bf5b4b305b222fe03aa0175d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2830252Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73986}
-
Arno Renevier authored
- represent smis as fake heap numbers - numbers nodes (both smi and heap numbers) reference a child node whose name is "value" and whose entry is the string representation of that number That feature is disabled by default, and can be enabled by passing captureNumericValue: true when calling HeapProfiler.takeHeapSnapshot This patch slightly refactors some functions that operate on "essential objects". We now check that the object is essential before trying to create the entry. Otherwise, we would end up with smi objects created, but not referenced anywhere. Design doc: https://docs.google.com/document/d/1Qh1zxyn0SS5wzJzitD6ecBJTdFbQkJogSMwxDRsn44o/edit Change-Id: Ibbe6e79a54c4f9eace72bc0a0ccb622a97698e00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2806747Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Arnaud Renevier <arenevier@fb.com> Cr-Commit-Position: refs/heads/master@{#73985}
-
- 15 Apr, 2021 19 commits
-
-
Milad Fa authored
Port 06a2c2e0 Original Commit Message: We currently allow OSR (On-Stack Replacement) of arbitrarily deep return addresses. This is in direct violation of Intel CET's shadow stack, which we plan to enable eventually. This change works around this by postponing OSR until after we return to the old code. The main changes are: - Reserve a slot in Liftoff frames to store the OSR target, - Skip the return address modification, and instead store the new code pointer in the dedicated slot, - Upon returning to the old code, check the slot and do an indirect jump to the new code if needed. CET also prevents indirect jumps to arbitrary locations, so the last point is also a CET violation. Valid indirect jump targets must be marked with the ENDBRANCH instruction, which I will do in a follow-up CL. R=thibaudm@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Id972de1ba7556474cb00b377ea3a38eb4332eae3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2828870Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73984}
-
Ng Zhi An authored
Bug: v8:11589 Change-Id: I6f43e6382b3441adf59dbaea58d766013cf3793b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826712Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#73983}
-
Manos Koukoutos authored
The typing of br_table was relaxed in https://github.com/WebAssembly/spec/pull/1305. Before, we had to compute the greatest lower bound of all branch types and make sure that stack values are subtypes of that type. Now, we have to check that the stack values are subtypes of each individual branch. This makes a difference only in polymorphic stacks, but greatly simplifies the code, especially with the upcoming introduction of a much more complex type system in wasm-gc. Change-Id: I6e3b410cfe0e71a97623b3030b3575ef707c4900 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2827897 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73982}
-
Deepti Gandluri authored
This is a reland of 6ec52d90. The failing tests have been adapted at the blink side. Original change's description: > [wasm] Enable wasm threads by default in V8 > > Finer grained control of platforms that support threads are > enforced by chromium. > > Bug: chromium:1167733 > Change-Id: Ic34a4950aebf6ba394053b79df97b703af333636 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810190 > Reviewed-by: Lutz Vahl <vahl@chromium.org> > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73919} Bug: chromium:1167733 Cq-Include-Trybots: luci.v8.try:v8_linux_blink_rel Change-Id: I56a00a24f17fef8a8050ee6f4b28fc13c7d3fb30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826540Reviewed-by:
Lutz Vahl <vahl@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#73981}
-
Michaël Zasso authored
Bug: v8:11165 Change-Id: I022a50cc25ab57f6bb24739c0e65ebe599371e3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826129Reviewed-by:
-
Omer Katz authored
Drive-by: cleanup PersistentTest and MarkerTest Bug: chromium:1056170 Change-Id: I85d674cda7d580e8cd7be807791ba883b0f7a111 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2827898 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#73979}
-
Patrick Thier authored
This test relies on non-concurrent optimizations to precisely test transitions between the different tiers. Disable flags that invalidate this test: --no-always-opt to test transiation from Ignition to Sparkplug --deopt-every-n-times=0 to test transition from Sparkplug to TF Bug: v8:11656 Change-Id: I85047015d3f7cfdf00bddad59c9742d5d8f5d223 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2827902 Auto-Submit: Patrick Thier <pthier@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
We currently allow OSR (On-Stack Replacement) of arbitrarily deep return addresses. This is in direct violation of Intel CET's shadow stack, which we plan to enable eventually. This change works around this by postponing OSR until after we return to the old code. The main changes are: - Reserve a slot in Liftoff frames to store the OSR target, - Skip the return address modification, and instead store the new code pointer in the dedicated slot, - Upon returning to the old code, check the slot and do an indirect jump to the new code if needed. CET also prevents indirect jumps to arbitrary locations, so the last point is also a CET violation. Valid indirect jump targets must be marked with the ENDBRANCH instruction, which I will do in a follow-up CL. Bug: v8:11654 Change-Id: I6925005211aa95d60803b9409e3c07c7c226b25c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826127 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Dan Elphick authored
This should catch potential build file misconfigurations. Change-Id: I1bd1f808a4758e0d3b71c862cfc34e7b01e6fbd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2827894 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#73976}
-
Victor Gomes authored
Change-Id: I8db5f0b4cb1cfa23e210ac43b50680ce96e622b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826538 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#73975}
-
Jakob Gruber authored
- Allow pass/fail for all test-heap/LeakNativeContextVia* tests in stress_concurrent_inlining mode. - Don't capture stack locations in lambdas passed between threads. Bug: v8:7790,v8:11650 Change-Id: I6c23b527d5f96f2f4b2354d16f39d832dea17e71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2827895 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73974}
-
Sergei Glazunov authored
An exploitation technique that abuses `pop` and `shift` to create a JS array with a negative length was publicly disclosed some time ago. Add extra checks to break the technique. Bug: chromium:1198696 Change-Id: Ie008e9ae60bbdc3b25ca3a986d3cdc5e3cc00431 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2823707Reviewed-by:
-
Manos Koukoutos authored
Changes: - Implement function subtyping in wasm-subtyping.cc. - Add Signature::Build(), which takes initializer lists for the return and parameter types. - Only throw kTrapFuncSigMismatch in call_indirect, change that trap's message. - Add a missing "return 0" in function-body-decoder-impl.h - Fix a faulty check in wasm-objects.cc. - Improve some comments. - Write tests. Improve readability of subtyping-unittest. Bug: v8:7748 Change-Id: I1caba09d5bd01cfd4d6125f300cd9c16af7aba99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2822633Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#73972}
-
Leszek Swirski authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:11650 Change-Id: I12857a479f95f8c60a921118cf68f7f88a81a822 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826537 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#73971}
-
Jakob Gruber authored
- FLAG_turbo_inline_js_wasm_calls data race - Map::instance_descriptors non-atomic concurrent loads - Skip one more cctest incompatible with stress_concurrent_inlining Bug: v8:7790,v8:11648,v8:11651 Change-Id: Ie4833373a1da34497f4cfe129254071d8a5772dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2827891Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Some logic still remains, notably in compiler/. Bug: v8:8888 Change-Id: I7e7f10a487e1bc8b90bbbfedbc46bf09bae0717e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2825589 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#73969}
-
Omer Katz authored
building the unittests target for example fails when cppgc_is_standalone is set to true due to conflicting implementations of trace-event.h. It is not clear from the output for these failures that V8 targets cannot be built with cppgc_is_standalone. We could disable all non-cppgc targets that depend on cppgc when cppgc_is_standalone is set, but that would be fragile and dirty. Since all V8 targets need to include cppgc-js headers, adding a static assert in cpp-heap.h would cover all V8 targets. The static assert doesn't hide the current output, butadds a clear and expllicit message stating that it cannot be done. Bug: chromium:1056170 Change-Id: I8bd1b1a5ada18d9688e6b78de4693386539d78bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826535Reviewed-by:
-
Jakob Gruber authored
.. to increase coverage of concurrent inlining, at least in this stress mode. The common pattern in mjsunit tests is to call `%OptimizeFunctionOnNextCall(f)` for interesting function `f`. This explicitly triggers non-concurrent compilation, significantly decreasing relevant coverage of concurrent inlining. This CL recovers coverage by spawning an additional concurrent compile job when 1. --stress-concurrent-inlining is enabled, and 2. the requested compile mode is non-concurrent. The result of these additional jobs is discarded. Drive-by: Fix two simple uncovered issues. Bug: v8:7790,v8:11513,v8:11648 Change-Id: If1e8ca5ba737e3cecdec9e15e4a86b28fe9fb2de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2824440 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b30d9d1..e966858 Rolling v8/third_party/aemu-linux-x64: 81MEiC7zu9wgtKKP_jHorqj5uRmgBSx04zU75G1PX8YC..V4pHBauOtd8S1jDOxP65uQ5t1vxtzWpESymTE3h7ZMMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6cb38d7..3898886 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f9d141a..b1cc5ed Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/633b99a..eefe475 Rolling v8/tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0 Rolling v8/tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0 Rolling v8/tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0 TBR=v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I193cd09e604cf60f4a3243c7512de1d27a745149 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826915Reviewed-by:
-
- 14 Apr, 2021 15 commits
-
-
Ng Zhi An authored
Bug: v8:11589 Change-Id: I30dbdbc6266d703ce697352780da1d543afbb457 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826711 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Milad Fa authored
This is a partial port of : 2c38a477 Some of the opcodes were added back in later CLs. Change-Id: Iba33b0930f5b7ec95cdbe6febaa38766a9a6344f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826238Reviewed-by:
-
Milad Fa authored
The following error occurs without braces: error: suggest explicit braces to avoid ambiguous 'else'. Change-Id: Iae1af51dcaf8ab6b34fd9312f3133fbd395a653c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826234Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#73963}
-
Shu-yu Guo authored
The bricklink.com brickage has since been fixed upstream. I2S with LGTMs: https://groups.google.com/a/chromium.org/g/blink-dev/c/I8S78w7aFmE/m/qLHAcjhRCQAJ Bug: v8:10961 Bug: chromium:1170196 Change-Id: I460e1080aee837bde0e9861d761f2e7dbc8fd6b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2824101 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#73962}
-
Omer Katz authored
Bug: chromium:1056170 Change-Id: I78844ed1921c5558a2c5ab6121208c1887fe8b3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826118 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Omer Katz authored
Migrating unittests from Blink that were not already covered by cppgc. Bug: chromium:1056170 Change-Id: If31591c3f1e99562028087c2b818f5ceb8122ec9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2821542 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Maya Lekova authored
This reverts commit d435eaa5. Reason for revert: Breaks compilation on the vtunejit bot, see https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20vtunejit/41247/overview Original change's description: > [api] Add v8::Isolate::ThrowError helper > > Add a ThrowError helper to encourage throwing full Error objects > instead of just v8::Strings. > > Bug: v8:11195 > Change-Id: I15d75b1d39b817de3b9026a836b57a70d7c16a28 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811738 > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#73958} Bug: v8:11195 Change-Id: I2773d8ca7d73e7952d274381e2e0a2e5733a83da No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826533 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#73959}
-
Camillo Bruni authored
Add a ThrowError helper to encourage throwing full Error objects instead of just v8::Strings. Bug: v8:11195 Change-Id: I15d75b1d39b817de3b9026a836b57a70d7c16a28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2811738 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The flag is useful for disabling tests that are not supported in the third_party_heap build configuration. Example usage in the status files: ['third_party_heap', { 'testname': [SKIP], }], # third_party_heap Bug: v8:11155 Change-Id: I991532bf7cdf89d8c505e4d6cbd7cf9e4d70dd63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2821960 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: -
Milad Fa authored
After https://crrev.com/c/2807609 a test has started failing as parameter_slots was more than 16 bits, hence we need to load it instead of using it as an immediate value. Change-Id: I738472634b3e30cbf277959965e72b028f9fb969 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826231 Commit-Queue: Milad Fa <mfarazma@redhat.com> Reviewed-by:
-
Andreas Haas authored
R=manoskouk@chromium.org Change-Id: Ia5ecd3fac9178f2f9519686e818f9025ae95086d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2824441Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#73955}
-
Milad Fa authored
Port 885b1ac9 Original Commit Message: Similarly to Windows, on macOS we should touch the memory in a page when allocating stack space that crosses page boundaries. R=victorgomes@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I6d3fc012c5a88e287deb0bb4d78ae001a1318b4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2826230Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:1173527 Change-Id: If918b739f137b9c09030104b909e7bd2d4cd5984 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2817616Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
QiuJi authored
Change-Id: I3828c6a854d09629784f481c76781003b4030993 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2814562Reviewed-by:
Brice Dobry <brice.dobry@futurewei.com> Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/master@{#73952}
-
Sathya Gunasekaran authored
Instead of assigning serial numbers when the template infos are created, this patch creates serial numbers only when they are added to cache. This way only the ones that are first instantiated are allocated the fast template cache. Previously, various accessors and methods that would almost never get instantiated got assigned to the fast template cache. Bug: v8:11284 Change-Id: I8f7578aa0dae48267bbc6303515114eb6e24c1c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2621081Reviewed-by:
-
