1. 01 Jun, 2021 1 commit
  2. 14 Jul, 2017 1 commit
    • Alexey Kozyatinskiy's avatar
      [inspector] improve return position of explicit return in non-async function · 08965860
      Alexey Kozyatinskiy authored
      Goal of this CL: explicit return from non-async function has position after
      return expression as return position (will unblock [1]).
      
      BytecodeArrayBuilder has SetStatementPosition and SetExpressionPosition methods.
      If one of these methods is called then next generated bytecode will get passed
      position. It's general treatment for most cases.
      Unfortunately it doesn't work for Returns:
      - debugger requires source positions exactly on kReturn bytecode in stepping
        implementation,
      - BytecodeGenerator::BuildReturn and BytecodeGenerator::BuildAsyncReturn
        generates more then one bytecode and general solution will put return position
        on first generated bytecode,
      - it's not easy to split BuildReturn function into two parts to allow something
        like following in BytecodeGenerator::VisitReturnStatement since generated
        bytecodes are actually controlled by execution_control().
      ..->BuildReturnPrologue();
      ..->SetReturnPosition(stmt);
      ..->Return();
      
      In this CL we pass ReturnStatement through ExecutionControl and use it for
      position when we emit return bytecode right here.
      
      So this CL only will improve return position for returns inside of non-async
      functions, I'll address async functions later.
      
      [1] https://chromium-review.googlesource.com/c/543161/
      
      Change-Id: Iede512c120b00c209990bf50c20e7d23dc0d65db
      Reviewed-on: https://chromium-review.googlesource.com/560738
      Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
      Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46687}
      08965860
  3. 08 Nov, 2016 1 commit
  4. 21 Apr, 2016 1 commit
  5. 16 Dec, 2015 1 commit
  6. 27 Mar, 2015 1 commit
    • dslomov's avatar
      Make sure debugger is ready for breakpoins when we process 'debugger' statement. · 15ef61d4
      dslomov authored
      On 'debugger' statement, if anything in debugger calls 'EnsureDebugInfo'
      on a function, EnsureDebugInfo would compile and substitute code without
      debug break slots. This causes weird behavior later when stepping fails
      to work (see added test as an example).
      This fix is to make sure the debugger is prepared for breakpoints in
      that case as well.
      
      Also adds extra testing for bug 468661.
      
      R=yangguo@chromium.org,yurys@chromium.orh
      BUG=v8:3990,chromium:468661
      LOG=N
      
      Review URL: https://codereview.chromium.org/1032353002
      
      Cr-Commit-Position: refs/heads/master@{#27502}
      15ef61d4
  7. 24 Mar, 2015 2 commits
  8. 19 Nov, 2014 1 commit