- 01 Jun, 2021 1 commit
-
-
Benedikt Meurer authored
In the Chrome DevTools Protocol, the step actions are named StepOut, StepOver, and StepInto, but internally we used StepOut, StepNext, and StepIn instead. This change adjusts the naming to be consistent. Bug: chromium:901814, chromium:1162229 Change-Id: Id3502a1b0a4aadd94734ec3d1fef73c1782fa220 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928510Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74877}
-
- 14 Jul, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
Goal of this CL: explicit return from non-async function has position after return expression as return position (will unblock [1]). BytecodeArrayBuilder has SetStatementPosition and SetExpressionPosition methods. If one of these methods is called then next generated bytecode will get passed position. It's general treatment for most cases. Unfortunately it doesn't work for Returns: - debugger requires source positions exactly on kReturn bytecode in stepping implementation, - BytecodeGenerator::BuildReturn and BytecodeGenerator::BuildAsyncReturn generates more then one bytecode and general solution will put return position on first generated bytecode, - it's not easy to split BuildReturn function into two parts to allow something like following in BytecodeGenerator::VisitReturnStatement since generated bytecodes are actually controlled by execution_control(). ..->BuildReturnPrologue(); ..->SetReturnPosition(stmt); ..->Return(); In this CL we pass ReturnStatement through ExecutionControl and use it for position when we emit return bytecode right here. So this CL only will improve return position for returns inside of non-async functions, I'll address async functions later. [1] https://chromium-review.googlesource.com/c/543161/ Change-Id: Iede512c120b00c209990bf50c20e7d23dc0d65db Reviewed-on: https://chromium-review.googlesource.com/560738 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#46687}
-
- 08 Nov, 2016 1 commit
-
-
jgruber authored
BUG=v8:5530 Review-Url: https://codereview.chromium.org/2487673002 Cr-Commit-Position: refs/heads/master@{#40840}
-
- 21 Apr, 2016 1 commit
-
-
yangguo authored
R=vogelheim@chromium.org BUG=v8:4690 LOG=N Review URL: https://codereview.chromium.org/1910813002 Cr-Commit-Position: refs/heads/master@{#35701}
-
- 16 Dec, 2015 1 commit
-
-
yangguo authored
And tons of changes to debugger tests. R=bmeurer@chromium.org BUG=chromium:569835 LOG=N Review URL: https://codereview.chromium.org/1525173003 Cr-Commit-Position: refs/heads/master@{#32885}
-
- 27 Mar, 2015 1 commit
-
-
dslomov authored
On 'debugger' statement, if anything in debugger calls 'EnsureDebugInfo' on a function, EnsureDebugInfo would compile and substitute code without debug break slots. This causes weird behavior later when stepping fails to work (see added test as an example). This fix is to make sure the debugger is prepared for breakpoints in that case as well. Also adds extra testing for bug 468661. R=yangguo@chromium.org,yurys@chromium.orh BUG=v8:3990,chromium:468661 LOG=N Review URL: https://codereview.chromium.org/1032353002 Cr-Commit-Position: refs/heads/master@{#27502}
-
- 24 Mar, 2015 2 commits
-
-
dslomov authored
The root cause for the bug is that the positions assigned to desugared code was inconsistent with the source ranges of block scopes. Since the fact that the position is assigned causes the debugger to break at the parser-generated statement, the fix is to remove positions from those nodes that we do not want to break on. The CL also teaches Hydrogen to tolerate these cases. R=adamk@chromium.org,rossberg@chromium.org BUG=chromium:468661 LOG=Y Review URL: https://codereview.chromium.org/1032653002 Cr-Commit-Position: refs/heads/master@{#27424}
-
aandrey authored
BUG=chromium:450004 R=yangguo@chromium.org, kozyatinskiy@chromium.org LOG=N Review URL: https://codereview.chromium.org/1030673002 Cr-Commit-Position: refs/heads/master@{#27419}
-
- 19 Nov, 2014 1 commit
-
-
aandrey authored
BUG=chromium:432468 R=yangguo@chromium.org, adamk@chromium.org LOG=N Review URL: https://codereview.chromium.org/739523002 Cr-Commit-Position: refs/heads/master@{#25423}
-