- 31 May, 2021 15 commits
-
-
Mathias Bynens authored
Prior to this patch, regular expression objects with a monkeypatched `toString` were printed using the `toString` result value, rather than actually representing the regular expression’s contents. const re = /./; re.toString = () => 'whoops!'; console.log(re); // → logs 'whoops!' Now that `v8::RegExp::GetSource` properly escapes special characters in the source pattern [1], just like `RegExp#toString`, there is no longer any reason to avoid it. [1]: https://chromium-review.googlesource.com/c/v8/v8/+/2900737 Bug: v8:11693 Change-Id: I9a69cdb6813f76b669bdc24e4823c6d261f2ae73 Fixed: v8:11836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928188Reviewed-by:Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#74862}
-
Manos Koukoutos authored
Changes: - Fix OpcodeLength for array.copy - Check that the destination array for array.copy is mutable. Bug: v8:7748 Change-Id: I2c84b967ba91e150b772a959e76ebb382bfc29bc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928176Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74861}
-
Camillo Bruni authored
This adds a first crude version of displaying a flamechart in the system-analyzer. - Basic function types are distinguishable by colors. - Tooltip information is available as well Bug: v8:11835 Change-Id: I87e092f749d4c16aa5017af39df8d2f7bd7e2edd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928179 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#74860}
-
Victor Gomes authored
We must ensure that the sweeper is not running or has already swept mutable_double_buffer. Otherwise the GC can add it to the free list. Bug: v8:11837 Change-Id: Ifd9cf15f1c94f664fd6489c70bb38b59730cdd78 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928181 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74859}
-
Wenyu Zhao authored
When this flag is enabled, allocation folding behaviour depends on the --turbo-allocation-folding runtime flag. When it's disabled, --turbo-allocation-folding is ignored. This flag will be used later to control the CodeStubAssembler::InlineAllocate behaviour. Change-Id: Iea7bbafd8454571dda7d56349b3dc63d3b54ba99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2878754Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Wenyu Zhao <wenyu.zhao@anu.edu.au> Cr-Commit-Position: refs/heads/master@{#74858}
-
Maya Lekova authored
This CL enhances the interface of the fast C API with constants and structs necessary for supporting JSArrays, TypedArrays and ArrayBuffers. It also adds checks for incompatible combinations of argument type/flags. Bug: chromium:1052746 Change-Id: I032167d0739d33f8151f78574c89d565cb9bd821 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2903147Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#74857}
-
Camillo Bruni authored
Bug: v8:11820 Change-Id: Iec8c75737648ca239363069511fd7783c26a5d64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928497Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74856}
-
Thibaud Michaud authored
The delegate instruction is executed when an exception is thrown, not after the last instruction of the block. Handle reachability accordingly. R=ahaas@chromium.org Bug: chromium:1212396 Change-Id: I55e342cd73da44142cfbad7e16ab65ef513e6a60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928499Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#74855}
-
Patrick Thier authored
Change API RegExp::GetSource to return a string identical to ToString() and RegExp.prototype.source. Bug: v8:11693 Change-Id: I3d148883fe6f8a3ff49e552ddd72b1e92f52baf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2900737Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/master@{#74854}
-
Vicky Kontoura authored
This CL refactors mjsunit tests, so that the common core of all tests is abstracted away. Bug: v8:11525, v8:11706 Change-Id: I24a1af4298380e21a64e4d17149422c32fbf8a4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2914882Reviewed-by:
-
Maya Lekova authored
Bug: v8:10996 No-Try: true Change-Id: Ic75702e2d9db17762b21cd3d90e6fbf461c634bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928178 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Removing some additional complexity that is not frequently used. Change-Id: I10195971d872d710ba3a87170fb62c1948e7716e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2923502Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74851}
-
Victor Gomes authored
Bug: chromium:1213927 Change-Id: I11729540d9f20b437411f0b9f8077be2a7f066b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922117Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#74850}
-
Wael Almattar authored
Change-Id: I0e4de2d943db5a6af41bb1a1599e0ebb0568d290 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912881Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e5a2e0c..068753b TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I93438a1eb2ef704a3a50d8374acfdb2e0aa87ff4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2927501Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74848}
-
- 30 May, 2021 2 commits
-
-
Liu Yu authored
Port 032ab3d2 Bug: v8:11420 Change-Id: I7c5f627902db9f21ef35bf8d085ac6a6c72755ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2925315 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#74847}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ec279cc..e5a2e0c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/dca1c97..edf4e0e TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I3468fe7b1d66da0cc4adb2cbc672eb141243504f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2923407Reviewed-by:
-
- 29 May, 2021 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ca9596f..ec279cc Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e83a92e..dca1c97 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I15cc4fbe2fba7d10cc8c7873ac8ddbadc4821f07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2924506Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/db2de74..0e1255a Removing freenode from README (Dominic Hamon) https://chromium.googlesource.com/external/github.com/google/benchmark/+/0e1255a TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: Ibf16c3ba389fe8b35685660d3e78d3eccda1e6e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2924507Reviewed-by:
-
- 28 May, 2021 6 commits
-
-
Lu Yahan authored
Port 032ab3d2 Change-Id: I55715e1943e0e178079e810b8979d14d84e776cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2924605 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Reviewed-by:
Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/master@{#74843}
-
Shu-yu Guo authored
Use Relaxed_Memcpy when making a new TypedArray that copies from a SharedArrayBuffer. Bug: chromium:1209639 Change-Id: Iaa1f069552f0aa42a1f423e5ee0a913b3330153c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2923274Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#74842}
-
Lu Yahan authored
And add s10 to scratch_register_list. Clean up t* register used in macroassembler Bug: v8:7703 Change-Id: Ib8477cd7528b8c2a2297da3f46659f30af45286e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2914246Reviewed-by:
-
Michael Lippautz authored
Bug: v8:11822 Change-Id: I35f3b5ce71ab5f86a5d9991bb9d729a2fe56f6dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919955Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74840}
-
Sigurd Schneider authored
The refactoring makes it explicit that a v8::Array results in a protocol::ListValue, and a v8::Object in a protocol::DictionaryValue, which will be useful in a follow-up. Bug: chromium:1213393 Change-Id: I0d6e5b013a828e12cb3200672d4fd9b14a14a807 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919831Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2f6e88e..ca9596f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6fc394f..0694fa6 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/5ef44f0..d0e636e TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ic77cfdf2999bf19e8c50409a86e95ababe5dc73b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922991Reviewed-by:
-
- 27 May, 2021 15 commits
-
-
Paolo Severini authored
To support Fast API calls with overloads, implement compile-time function resolution based on the number of arguments passed to the JS function. Bug: v8:11739 Change-Id: I96839dc0b6fc540eff94573ac9e77f678908fc3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2901249Reviewed-by:
-
Dominik Inführ authored
The counter as size_t can legitimately overflow on 32-bit systems, since decreasing the counters is performed after all backing stores were freed on a background thread. Before sweeping is finished a new backing store could already be allocated which then leads to the overflow. Bug: v8:11788, chromium:1211437 Change-Id: Id9f3e58b0e84e831fe47109f7deb3a05ae7e489c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922242 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#74836}
-
Nico Hartmann authored
Bug: chromium:1212550 Change-Id: Ia3750305542caff97aeb83c078238c41cd2761d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919963 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Milad Fa authored
Port 032ab3d2 R=cbruni@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: I075377afc65999731223f4dce368e6aca4e784ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2920810Reviewed-by:
-
Milad Fa authored
Port 34b1c557 Original Commit Message: as arguments. The currently can be the same and thus we don't add any additional DHCECKs there. R=cbruni@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Icd0baf83cf2deeee5f7bfe19902484b6e073e833 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922311Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
-
Adam Klein authored
This reverts commit 17915002. Reason for revert: Breaks TSAN builds (e.g. https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20builder/19166/overview) Original change's description: > [builtins][x64] Use callee-saved registers for write barrier stubs > > Calls to the record write stub are quite frequent and the caller has to > save all registers used by the builtin. > > This CL moves the register saving to the builtin itself, reducing the > call-site code size significantly in many cases and thus improving > compilation speed of sparkplug. > > Follow-up CLs with introduce the same behaviour to other platforms. > > - CallRecordWriteStubSaveRegisters preserves the existing behaviour and > saves clobbered registers. > - CallRecordWriteStub expects the registers to match the ones specified > in the WriteBarrierDescriptor for more compact code. > > Bug: v8:11420 > Change-Id: Ib1260cf972712bb9ba879beacd34b06a7fa347f1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922103 > Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74831} Bug: v8:11420 Change-Id: I20f239e64ec2834acd651341634974291992add5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922316 Auto-Submit: Adam Klein <adamk@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74832}
-
Camillo Bruni authored
Calls to the record write stub are quite frequent and the caller has to save all registers used by the builtin. This CL moves the register saving to the builtin itself, reducing the call-site code size significantly in many cases and thus improving compilation speed of sparkplug. Follow-up CLs with introduce the same behaviour to other platforms. - CallRecordWriteStubSaveRegisters preserves the existing behaviour and saves clobbered registers. - CallRecordWriteStub expects the registers to match the ones specified in the WriteBarrierDescriptor for more compact code. Bug: v8:11420 Change-Id: Ib1260cf972712bb9ba879beacd34b06a7fa347f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922103Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Omer Katz authored
This CL does 2 things: 1) Implements forwarding of histogram reporting from cppgc to v8 via CppHeap. 2) Establishes the pipeline in GCTracer for sending the histograms to the embedder. Currently only cppgc histograms are populated. See crrev.com/c/2916956 for usage. Bug: chromium:1154636 Change-Id: I8150116f757e105d0dfac96a3f6e7dd95717f5bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2917033 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Daniel Lehmann authored
With mprotect-based write protection of the WebAssembly code space, we switch page protection flags each time (at least) one compilation thread needs write access. Two such switches happen when TurboFan compilation results are available in {ExecuteCompilationUnits}: One switch happens when calling {NativeModule::AddCompiledCode} and one more when calling {NativeModule::PublishCode} via {SchedulePublishCompilationResults} and {PublishCompilationResults}. So far, each TurboFan result was published eagerly, i.e., as soon as it became available. This has the benefit that faster code is available immediately, and had no large cost or downside without write protection. However, with write protection switching permissions is expensive (an mprotect syscall) and needs to lock the {WasmCodeAllocator::allocation_mutex_} (which causes lock contention and under Linux many futex syscalls). Thus, immediately publishing each TurboFan result when using write protection can cause up to 10x slower compilation compared with not using write protection. In terms of syscalls we measured (non scientifically) with {sudo perf stat -e 'syscalls:sys_enter*' d8 ...} on the Unity benchmark: - mprotect: 10k vs. 44k syscalls (baseline vs. write protection) - futex: 31k vs. 112k syscalls (baseline vs. write protection) - sys time: 1.6s vs. 10s (baseline vs. write protection) All of those are clearly to high. The fix here is simply to batch togther multiple TurboFan functions into one publishing step when using write protection. The batching logic already exists for Liftoff, so we can just disable eager publishing for TurboFan when using write protection. Additionally, we publish once when all Liftoff results are available (even if the batch is not complete), such that time-to-execute is not regressed. R=clemensb@chromium.org CC=jkummerow@chromium.org Bug: v8:11663, chromium:932033 Change-Id: Ibf6f28ecf4733b40322e62761e66046dec60a125 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922114 Commit-Queue: Daniel Lehmann <dlehmann@google.com> Reviewed-by:Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74829}
-
Clemens Backes authored
This reverts commit 5fd38582. Reason for revert: Failures on the predictable bot: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20predictable/36749/overview Original change's description: > [flags] Predictable should not imply single-threaded > > The --predictable flag is often used to reproduce issues, and having it > imply --single-threaded can change decisions like which compiler(s) to > use. This is because --single-threaded is meant to be set by embedders > (hence we do our best to support single-threaded execution), whereas > --predictable is a testing-only flag which should not change semantics > too much. The fact that --predictable executes everything in a single > thread is already implied by the PredictablePlatform. > > R=ahaas@chromium.org, machenbach@chromium.org > CC=jkummerow@chromium.org > > Change-Id: Ic174dd59dfdbd6aa1a410f983db05db26c944cd5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919828 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74822} Change-Id: Id312cd2b3a150fa3e61daf6550651dc252264ca2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922248 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74828}
-
Scott Violet authored
When 'beforeScriptExecution' is enabled, a pause event may be generated with a reason of 'instrumentation' rather than 'other.' This patch ensures that in the case of a schedule-break, both an 'instrumentation' and 'other' pause event is generated. This is important for debuggers that rely on getting 'other' breakpoints to determine if they should actually break, or continue executation. Change-Id: I73613f4df6fa7942e7ca2be58853e5420589ba0f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2915680Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#74827}
-
Michael Lippautz authored
Bug: chromium:1056170 Change-Id: I610f886699f7d1e8f343785b8dc9d9a9bd9c918a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922244 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Clemens Backes authored
This adds detection for constant memory indexes which can statically be proven to be in-bounds (because the effective offset is within the minimum memory size). In these cases, we can skip the bounds check and the out-of-line code for the trap-handler. This often saves 1-2% of code size. R=ahaas@chromium.org Bug: v8:11802 Change-Id: I0ee094e6f1f5d132af1d6a8a7c539a4af6c3cb5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919827 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This is to mitigate flaky timeouts due to memory problems on some Bionic bots. Bug: v8:11818 Change-Id: I4758f0f167b94d81f43e183a5599a39d8545b4e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922245 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Georg Neis authored
This function broke abstraction and as a result became incorrect when the call feedback was extended with the CallFeedbackContent flag. Bug: v8:11821, v8:9974 Change-Id: Ic40dc45440a697a554d015dd50f0178e79963920 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919820 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#74823}
-
