- 12 Oct, 2016 16 commits
-
-
bmeurer authored
This is the next step to unify the Call/Construct feedback collection and prepare it to be able to collect SharedFunctionInfo feedback. This also reduces the CallICStub overhead quite a bit since we only need one stub per mode (and tail call mode), not also one per call arity. R=mvstanton@chromium.org BUG=v8:2206 NOTRY=true Review-Url: https://codereview.chromium.org/2412453005 Cr-Commit-Position: refs/heads/master@{#40206}
-
clemensh authored
For the asm.js to WASM pipeline, the current stack traces only show low-level WASM information. This CL maps this back to asm.js source positions. It does so by attaching the asm.js source Script to the compiled WASM module, and emitting a delta-encoded table which maps from WASM byte offsets to positions within that Script. As asm.js code does not throw exceptions, we only store a mapping for call instructions. The new AsmJsWasmStackFrame implementation inherits from WasmStackFrame, but contains the logic to provide the source script and the position inside of it. What is still missing is the JSFunction object returned by CallSite.getFunction(). We currently return null. R=jgruber@chromium.org, titzer@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2404253002 Cr-Commit-Position: refs/heads/master@{#40205}
-
clemensh authored
If passing <nullptr, 0> to the decoder and trying to decode something, it correctly detects the error and sets an error message, but still returns true on ok(), and returns a valid result. I triggered this error by passing a null Vector, returned by FindSection(), to the decoder. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2410913002 Cr-Commit-Position: refs/heads/master@{#40204}
-
machenbach authored
Revert of [CQ] Remove experimental bot temporarily. (patchset #1 id:1 of https://codereview.chromium.org/2411283002/ ) Reason for revert: Root cause fixed. Original issue's description: > [CQ] Remove experimental bot temporarily. > > BUG=chromium:655033,v8:5502 > NOTRY=true > NOPRESUBMIT=true > TBR=tandrii@chromium.org > > Committed: https://crrev.com/f994fcb10ed9ebc09a3544221db8d2fc121c6e98 > Cr-Commit-Position: refs/heads/master@{#40193} TBR=tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:655033,v8:5502 Review-Url: https://codereview.chromium.org/2412073002 Cr-Commit-Position: refs/heads/master@{#40203}
-
ishell authored
BUG=chromium:645438 Review-Url: https://codereview.chromium.org/2412853002 Cr-Commit-Position: refs/heads/master@{#40202}
-
bmeurer authored
We accidently dropped the effect on the floor that we have for the polymorphic map check in case of array elements access. BUG=chromium:655004 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2411273002 Cr-Commit-Position: refs/heads/master@{#40201}
-
machenbach authored
Revert of [inspector] fix timestamp formatting with non C locales (patchset #7 id:120001 of https://codereview.chromium.org/2410933002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10548 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] fix timestamp formatting with non C locales > > If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted. > > BUG=chromium:653424 > R=dgozman@chromium.org > > Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4 > Cr-Commit-Position: refs/heads/master@{#40190} TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:653424 Review-Url: https://codereview.chromium.org/2419453002 Cr-Commit-Position: refs/heads/master@{#40200}
-
zhengxing.li authored
port 001926cd (r40163) original commit message: In fullcodegen we used to count CallICs as patching ICs, and thus the heuristics are currently off by the number of calls in a code object. BUG= Review-Url: https://codereview.chromium.org/2406373004 Cr-Commit-Position: refs/heads/master@{#40199}
-
jgruber authored
Our minifier (tools/jsmin.py) shortens variable names it comes across. It generally tries to avoid name conflicts caused by renamed variables, but cannot handle lambda function syntax. This is what happens here. Both lambda function parameters 'x' and 'y' are not recognized as identifiers by the minifier and it thus potentially causes naming conflicts. BUG=v8:5505 Review-Url: https://codereview.chromium.org/2412533002 Cr-Commit-Position: refs/heads/master@{#40198}
-
zhengxing.li authored
port 9192db20 (r40162) original commit message: Remove the special side channel from the CallICStub to the ArrayConstructorStub and make the CallICStub always use the general entry point. BUG= Review-Url: https://codereview.chromium.org/2410083004 Cr-Commit-Position: refs/heads/master@{#40197}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/83eadac..dd41141 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapul/+log/f1eba76..daccdeb Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clan/+log/36879c7..3d97083 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2414603002 Cr-Commit-Position: refs/heads/master@{#40196}
-
adamk authored
Instead of allocating an ArrayBuffer in the test, use a different example from the original bug. R=bmeurer@chromium.org BUG=chromium:644631, v8:5504 Review-Url: https://codereview.chromium.org/2408403002 Cr-Commit-Position: refs/heads/master@{#40195}
-
machenbach authored
BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2393863002 Cr-Commit-Position: refs/heads/master@{#40194}
-
machenbach authored
BUG=chromium:655033,v8:5502 NOTRY=true NOPRESUBMIT=true TBR=tandrii@chromium.org Review-Url: https://codereview.chromium.org/2411283002 Cr-Commit-Position: refs/heads/master@{#40193}
-
bmeurer authored
For ConsString, the left hand side must be either sequential or external if the right hand side is empty. R=jarin@chromium.org BUG=chromium:654723 NOTRY=true Review-Url: https://codereview.chromium.org/2410893003 Cr-Commit-Position: refs/heads/master@{#40192}
-
machenbach authored
The bot currently doesn't work with shared libraries. This temporarily works around the problem to get the bot green. BUG=v8:5412 NOTRY=true TBR=jochen, zhengxing.li, jgruber Review-Url: https://codereview.chromium.org/2405243002 Cr-Commit-Position: refs/heads/master@{#40191}
-
- 11 Oct, 2016 24 commits
-
-
kozyatinskiy authored
If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted. BUG=chromium:653424 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2410933002 Cr-Commit-Position: refs/heads/master@{#40190}
-
adamk authored
The ES spec has been updated to include this legacy syntax in Annex B: https://tc39.github.io/ecma262/#sec-initializers-in-forin-statement-heads R=neis@chromium.org BUG=v8:4942 Review-Url: https://codereview.chromium.org/2407863003 Cr-Commit-Position: refs/heads/master@{#40189}
-
adamk authored
R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2410333002 Cr-Commit-Position: refs/heads/master@{#40188}
-
adamk authored
R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2407313003 Cr-Commit-Position: refs/heads/master@{#40187}
-
adamk authored
This is a re-land of https://codereview.chromium.org/2393303002/ with an additional call to DisposeModuleEmbedderData() added to fix lsan failures. Unifies the approaches used for storing the specifier -> module mapping and the module -> directory mapping, using std::unordered_maps for both and storing them per-Context. This requires adding a method to the v8::Module API to get a hash code for a Module, but allows slimming down the API in return: gone are SetEmbedderData/GetEmbedderData, along with the fourth argument to ResolveModuleCallback. Besides a simpler API, this allows d8 to get closer to the HTML loader, which requires each Realm to have a persistent module map (though this capability is not yet exercised by any tests). BUG=v8:1569 TBR=neis@chromium.org,jochen@chromium.org Review-Url: https://codereview.chromium.org/2405313002 Cr-Commit-Position: refs/heads/master@{#40186}
-
neis authored
Forgot to do that in 4ff5c2a7. TBR=adamk@chromium.org BUG=v8:1569 NOTRY=true Review-Url: https://codereview.chromium.org/2411013002 Cr-Commit-Position: refs/heads/master@{#40185}
-
neis authored
R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2404243002 Cr-Commit-Position: refs/heads/master@{#40184}
-
bjaideep authored
Port 9192db20 Original commit message: Remove the special side channel from the CallICStub to the ArrayConstructorStub and make the CallICStub always use the general entry point. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2410183002 Cr-Commit-Position: refs/heads/master@{#40183}
-
bjaideep authored
Port 001926cd Original commit message: In fullcodegen we used to count CallICs as patching ICs, and thus the heuristics are currently off by the number of calls in a code object. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2410203002 Cr-Commit-Position: refs/heads/master@{#40182}
-
neis authored
R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2410003002 Cr-Commit-Position: refs/heads/master@{#40181}
-
neis authored
Install it as DataConstantDescriptor, not AccessorConstantDescriptor. R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2410823002 Cr-Commit-Position: refs/heads/master@{#40180}
-
ulan authored
BUG=chromium:652721 Review-Url: https://codereview.chromium.org/2408093003 Cr-Commit-Position: refs/heads/master@{#40179}
-
mtrofin authored
Treat allocation of splintered ranges differently, by optimizing for move counts (i.e. try to have less move counts), rather than optimizing for quality of moves (which is what normal allocation does). We can see reductions in code size in the benchmarks that measure it (e.g. Unity) BUG= Review-Url: https://codereview.chromium.org/2347563004 Cr-Commit-Position: refs/heads/master@{#40178}
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2411743002 Cr-Commit-Position: refs/heads/master@{#40177}
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2412453003 Cr-Commit-Position: refs/heads/master@{#40176}
-
mvstanton authored
We'll take expressions like typeof 'hello' and reduce it to 'string'. Neat! This CL moves the optimization to an explicit reduction in typed lowering that inserts a constant string, instead of relying on type matching. BUG= Review-Url: https://codereview.chromium.org/2411703002 Cr-Commit-Position: refs/heads/master@{#40175}
-
hpayer authored
BUG=chromium:648568 Review-Url: https://codereview.chromium.org/2409163002 Cr-Commit-Position: refs/heads/master@{#40174}
-
mvstanton authored
We'll stop storing string data in Type objects. At the moment, we have optimizations that read that string data in typed lowering. Instead, look at nodes for this data. R=bmeurer@chromium.org BUG= Review-Url: https://codereview.chromium.org/2406243002 Cr-Commit-Position: refs/heads/master@{#40173}
-
machenbach authored
The android_arm config is deprecated. We only use the v8 arch strings. NOTRY=true TBR=adamk, caitp Review-Url: https://codereview.chromium.org/2412513002 Cr-Commit-Position: refs/heads/master@{#40172}
-
machenbach authored
Revert of Speedup access to global_proxy.* attributes/accessors. (patchset #3 id:80001 of https://codereview.chromium.org/2403003002/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/2406213002/ Original issue's description: > Speedup access to global_proxy.* attributes/accessors. > > Using a global proxy (e.g. 'window.f', 'w.f' or 'this.f') is considerably slower than evaluating just 'f'. This CL aims to perform the necessary checks at compile time and inline the accesses. > > This is a follow-on CL to crrev.com/2369933005: > - The initial upload is crrev.com/2369933005 + a rebase. > - The remaining issues are the fixes requested by the reviewers on that CL. > > BUG=chromium:634276 > > Committed: https://crrev.com/8f43d748272536117008aa6a1b53ea52126261c1 > Cr-Commit-Position: refs/heads/master@{#40153} TBR=jochen@chromium.org,verwaest@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:634276 Review-Url: https://codereview.chromium.org/2408133002 Cr-Commit-Position: refs/heads/master@{#40171}
-
mythria authored
Also include feedback about Oddballs when collecting the type feedback. For now, Number and NumberOrOddball are collected separately because crankshaft does not handle NumberOrOddballs consistently. This should change once we fix crankshaft. BUG=v8:4280, v8:5400 LOG=N Committed: https://crrev.com/d5d283b27d406486e2f8d7b44c6d2b3db4f98458 Review-Url: https://codereview.chromium.org/2406843002 Cr-Original-Commit-Position: refs/heads/master@{#40124} Cr-Commit-Position: refs/heads/master@{#40170}
-
titzer authored
R=bradnelson@chromium.org, ahaas@chromium.org, clemensh@chromium.org BUG=chromium:575167 Review-Url: https://codereview.chromium.org/2403093002 Cr-Commit-Position: refs/heads/master@{#40169}
-
heimbuef authored
Added PrintF output whenever a zone is created or destroyed. Also enables setting of a name for each zone, which can then be shown in the v8-heap-stats tool: https://github.com/mlippautz/v8-heap-stats/pull/2 BUG=v8:5489 Review-Url: https://codereview.chromium.org/2397573007 Cr-Commit-Position: refs/heads/master@{#40168}
-
verwaest authored
This is blocked on https://bugs.chromium.org/p/v8/issues/detail?id=5484 BUG=v8:5501 Review-Url: https://codereview.chromium.org/2405813002 Cr-Commit-Position: refs/heads/master@{#40167}
-