- 31 Mar, 2016 1 commit
-
-
yangguo authored
R=bmeurer@chromium.org, cbruni@chromium.org, ulan@chromium.org BUG=chromium:124206,chromium:569811 LOG=N Review URL: https://codereview.chromium.org/1834633003 Cr-Commit-Position: refs/heads/master@{#35145}
-
- 15 Dec, 2015 1 commit
-
-
yangguo authored
Debug evaluate no longer writes back changes to the replicated context chain to the original after execution. Changes to the global object or script contexts still stick. Calling functions that bind to the original context chain also have their expected side effects. As far as I can tell, DevTools is not interested in modifying local variable values. Modifying global variable values still works as expected. However, I have not yet removed the old implementation, but merely keep it behind a flag. R=mstarzinger@chromium.org, rossberg@chromium.org Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330 Cr-Commit-Position: refs/heads/master@{#32841} Review URL: https://codereview.chromium.org/1513183003 Cr-Commit-Position: refs/heads/master@{#32857}
-
- 14 Dec, 2015 2 commits
-
-
machenbach authored
Revert of [debugger] debug-evaluate should not not modify local values. (patchset #2 id:20001 of https://codereview.chromium.org/1513183003/ ) Reason for revert: [Sheriff] Layout test changes. Original issue's description: > [debugger] debug-evaluate should not not modify local values. > > Debug evaluate no longer writes back changes to the replicated > context chain to the original after execution. Changes to the > global object or script contexts still stick. Calling functions > that bind to the original context chain also have their expected > side effects. > > As far as I can tell, DevTools is not interested in modifying > local variable values. Modifying global variable values still > works as expected. However, I have not yet removed the old > implementation, but merely keep it behind a flag. > > R=mstarzinger@chromium.org, rossberg@chromium.org > > Committed: https://crrev.com/92caa9b85eefffbef51c67428397951bd2e2c330 > Cr-Commit-Position: refs/heads/master@{#32841} TBR=mstarzinger@chromium.org,rossberg@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1526553003 Cr-Commit-Position: refs/heads/master@{#32845}
-
yangguo authored
Debug evaluate no longer writes back changes to the replicated context chain to the original after execution. Changes to the global object or script contexts still stick. Calling functions that bind to the original context chain also have their expected side effects. As far as I can tell, DevTools is not interested in modifying local variable values. Modifying global variable values still works as expected. However, I have not yet removed the old implementation, but merely keep it behind a flag. R=mstarzinger@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1513183003 Cr-Commit-Position: refs/heads/master@{#32841}
-
- 16 Sep, 2014 1 commit
-
-
wingo@igalia.com authored
R=rossberg@chromium.org BUG=v8:2355 LOG=Y Review URL: https://codereview.chromium.org/573963003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@23974 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Mar, 2014 1 commit
-
-
yangguo@chromium.org authored
R=mstarzinger@chromium.org BUG=v8:3225 LOG=N Review URL: https://codereview.chromium.org/207153004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-