- 28 Nov, 2017 1 commit
-
-
Adam Klein authored
It was shipped in Chrome 62. Bug: v8:5546, v8:4829 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I3ac318639f1f7483d4d4f4fe5606387a856be98a Reviewed-on: https://chromium-review.googlesource.com/777940Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49687}
-
- 13 Oct, 2017 1 commit
-
-
Caitlin Potter authored
Previously, Function("++f`...`) would not throw an exception until the created function was called. Now, it throws an early ReferenceError. This change matches the behaviour in JavaScriptCore and SpiderMonkey. Ordinary calls such as Function("++f()") are still thrown at runtime, also compatible with JavaScriptCore and SpiderMonkey. BUG=v8:4480, v8:6910 R=marja@chromium.org, littledan@chromium.org Change-Id: If31c6d360a0464744eff5d8dd377ebff184ae00e Reviewed-on: https://chromium-review.googlesource.com/712794 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#48553}
-
- 24 Aug, 2017 1 commit
-
-
Kevin Gibbons authored
This flag allows invalid escape sequences in tagged templates, which is a stage-4 TC39 proposal shipping in other browsers. Bug: v8:5546 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I3e7c374c9b547f62d5976f76a7208d05fe9decf8 Reviewed-on: https://chromium-review.googlesource.com/581885 Commit-Queue: Kevin Gibbons <bakkot@gmail.com> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#47584}
-
- 21 Jun, 2017 1 commit
-
-
bakkot authored
(Reland: NeedsManualRebaseline'd newly-fixed layout test in Chromium.) This was never legal; the spec only allows '\0' in strict-mode strings or templates when not followed by a decimal digit. Previously we were only enforcing that it not be followed by an _octal_ digit. This was already fixed for numeric literals, but not for escape sequences in strings. BUG=v8:6504 Review-Url: https://codereview.chromium.org/2948903002 Cr-Commit-Position: refs/heads/master@{#46106}
-
- 20 Jun, 2017 2 commits
-
-
machenbach authored
Revert of [parser] Forbid \08 in strict strings (patchset #3 id:40001 of https://codereview.chromium.org/2950633002/ ) Reason for revert: Breaks layout test: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/16403 See: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [parser] Forbid \08 in strict strings and in untagged templates > > This was never legal; the spec only allows '\0' in strict-mode strings or templates > when not followed by a decimal digit. Previously we were only enforcing that it > not be followed by an _octal_ digit. > > This was already fixed for numeric literals, but not for escape sequences in strings. > > BUG=v8:6504 > > Review-Url: https://codereview.chromium.org/2950633002 > Cr-Commit-Position: refs/heads/master@{#46046} > Committed: https://chromium.googlesource.com/v8/v8/+/b102540e44a72157098014a20399193a461153d2 TBR=vogelheim@chromium.org,bakkot@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6504 Review-Url: https://codereview.chromium.org/2946953002 Cr-Commit-Position: refs/heads/master@{#46068}
-
bakkot authored
This was never legal; the spec only allows '\0' in strict-mode strings or templates when not followed by a decimal digit. Previously we were only enforcing that it not be followed by an _octal_ digit. This was already fixed for numeric literals, but not for escape sequences in strings. BUG=v8:6504 Review-Url: https://codereview.chromium.org/2950633002 Cr-Commit-Position: refs/heads/master@{#46046}
-
- 12 Jan, 2016 1 commit
-
-
adamk authored
There's no need to mark these as possibly-direct-eval, since all such an eval-tagged string will ever get passed is the array of string parts, which will be immediately returns (since it's not a string). It will never do a lookup in the current scope, nor (in sloppy mode) introduce new declarations. This patch is not intended to change behavior, but I've added tests that demonstrate the stuff explained in the preceding paragraph. Review URL: https://codereview.chromium.org/1580463003 Cr-Commit-Position: refs/heads/master@{#33245}
-
- 05 Aug, 2015 1 commit
-
-
adamk authored
It was shipped in V8 4.4. Review URL: https://codereview.chromium.org/1271073002 Cr-Commit-Position: refs/heads/master@{#30035}
-
- 16 Jun, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:4183 R=arv@chromium.org, rossberg@chromium.org LOG=N Review URL: https://codereview.chromium.org/1184373002 Cr-Commit-Position: refs/heads/master@{#29055}
-
- 01 Apr, 2015 1 commit
-
-
mike authored
The modified assertions targeted the property descriptor for the template object's first "cooked" value. The code immediately preceeding these statements asserts these values. Update the assertions to instead target the property descriptor for the template object's first "raw" value (which are otherwise untested). BUG= Review URL: https://codereview.chromium.org/1049523003 Cr-Commit-Position: refs/heads/master@{#27566}
-
- 24 Mar, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:3980 R=arv@chromium.org LOG=N Review URL: https://codereview.chromium.org/1027183002 Cr-Commit-Position: refs/heads/master@{#27402}
-
- 23 Mar, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:3230 R=dslomov@chromium.org, arv@chromium.org LOG=N Review URL: https://codereview.chromium.org/1027593005 Cr-Commit-Position: refs/heads/master@{#27352}
-
- 12 Mar, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:3958, 450942 LOG=N R=arv@chromium.org Review URL: https://codereview.chromium.org/996223003 Cr-Commit-Position: refs/heads/master@{#27159}
-
- 12 Jan, 2015 1 commit
-
-
caitpotter88 authored
BUG=v8:3806 LOG=N R=arv@chromium.org, dslomov@chromium.org Review URL: https://codereview.chromium.org/808793004 Cr-Commit-Position: refs/heads/master@{#26028}
-
- 18 Dec, 2014 2 commits
-
-
caitpotter88 authored
LOG=N BUG= R=arv@chromium.org, dslomov@chromium.org Review URL: https://codereview.chromium.org/812163003 Cr-Commit-Position: refs/heads/master@{#25895}
-
arv authored
Correctly handle SyntaxErrors in escape sequences. BUG=v8:3736 LOG=Y R=dslomov@chromium.org, caitpotter88@gmail.com Review URL: https://codereview.chromium.org/811113002 Cr-Commit-Position: refs/heads/master@{#25891}
-
- 04 Dec, 2014 1 commit
-
-
arv authored
If we hade }` the right brace was always treated as part of the template literal. We should only treat the right brace as part of the literal when we continue to parse the template literal after a placeholder. BUG=v8:3734 LOG=Y Review URL: https://codereview.chromium.org/778813003 Cr-Commit-Position: refs/heads/master@{#25661}
-
- 03 Dec, 2014 1 commit
-
-
arv authored
BUG=v8:3710 LOG=Y R=dslomov@chromium.org, marja@chromium.org Review URL: https://codereview.chromium.org/768203002 Cr-Commit-Position: refs/heads/master@{#25640}
-
- 26 Nov, 2014 1 commit
-
-
caitpotter88 authored
BUG=v8:3710 Review URL: https://codereview.chromium.org/745233002 Cr-Commit-Position: refs/heads/master@{#25529}
-
- 20 Nov, 2014 1 commit
-
-
caitpotter88 authored
BUG=v8:3230 LOG=y Review URL: https://codereview.chromium.org/742643003 Cr-Commit-Position: refs/heads/master@{#25450}
-
- 19 Nov, 2014 1 commit
-
-
caitpotter88 authored
BUG= Review URL: https://codereview.chromium.org/731573004 Cr-Commit-Position: refs/heads/master@{#25410}
-
- 14 Nov, 2014 1 commit
-
-
caitpotter88 authored
BUG=v8:3230 Review URL: https://codereview.chromium.org/663683006 Cr-Commit-Position: refs/heads/master@{#25362}
-