- 09 May, 2014 20 commits
-
-
yangguo@chromium.org authored
R=yangguo@chromium.org, Yang, rossberg@chromium.org BUG=v8:3019, chromium:331971 LOG=Y Review URL: https://codereview.chromium.org/271733005 Patch from Andrey Adaykin <aandrey@chromium.org>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21224 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/275433004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21223 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ishell@chromium.org authored
1) runtime/references checks temporarily disabled (56 items left) 2) other errors fixed R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/277913002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21222 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rmcilroy@chromium.org authored
Even although the Arm64 specification specifies that csp only needs to be aligned to 16 bytes if it is dereferenced, some implementations show poor performance. Also makes the following change: - Enable CPU support for arm64 to enable probing of cpu implementer and cpu part. - Add ALWAYS_ALIGN_CSP CpuFeature for Arm64 and set it based on runtime probing of the cpu imp - Rename PrepareForPush and PrepareForPop to PushPreamble and PopPostamble and move PopPostabl Original Review URL: https://codereview.chromium.org/264773004 R=ulan@chromium.org Review URL: https://codereview.chromium.org/271543004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21221 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
hpayer@chromium.org authored
BUG= R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/279513003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21220 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
vogelheim@chromium.org authored
Revert of Prevent calls to ReturnValue::Set with pointer-valued types. (https://codereview.chromium.org/240013004/) Reason for revert: Looks like this broke the "V8 Linux64 ASAN" build. Original issue's description: > Prevent calls to ReturnValue::Set with pointer-valued types. > > Currently, this code will compile: > SomePointer* p = ...; > ReturnValue r = ...; > r.Set(p); > > What happens is that ReturnValue::Set has no pointer-ish overloads, but > a bool one, and hence C++ will convert the pointer to a bool and use > the Set(bool) overload. In other words, the example above is equivalent > to: r.Set(p ? true : false); Which probably isn't what the author had > in mind. This change adds a Set(void*) overload whose body forces a > compile error, to prevent this from happening inadvertently. The only > use of this indeed turned out to be an error. > > (Said error was fixed/removed in crrev.com/267393002.) > > BUG= > R=dcarney@chromium.org > > Committed: https://code.google.com/p/v8/source/detail?r=21217 R=ishell@chromium.org Review URL: https://codereview.chromium.org/271113002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21219 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Also inline BuildNewSpaceArrayCheck() into its caller, because the name BuildNewSpaceArrayCheck was confusing anyway, since it has nothing do with new space actually. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/275453004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21218 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
vogelheim@chromium.org authored
Currently, this code will compile: SomePointer* p = ...; ReturnValue r = ...; r.Set(p); What happens is that ReturnValue::Set has no pointer-ish overloads, but a bool one, and hence C++ will convert the pointer to a bool and use the Set(bool) overload. In other words, the example above is equivalent to: r.Set(p ? true : false); Which probably isn't what the author had in mind. This change adds a Set(void*) overload whose body forces a compile error, to prevent this from happening inadvertently. The only use of this indeed turned out to be an error. (Wait for issue 364025 before submitting.) BUG= R=dcarney@chromium.org Review URL: https://codereview.chromium.org/240013004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21217 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Storing a map or an immortal immovable object to old space allocations requires no write barriers if the object is the new space dominator. R=hpayer@chromium.org, mstarzinger@chromium.org Review URL: https://codereview.chromium.org/271103002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21216 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/279813002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21215 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
It is crucial that the Isolate is cleanly disposed, otherwise the optimizing compiler thread happily continues to run. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/274093002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21214 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/271583004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21213 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=ulan@chromium.org Review URL: https://codereview.chromium.org/276433004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21210 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jarin@chromium.org authored
R=hpayer@chromium.org BUG=370827 TEST=test/mjsunit/regress/regress-370827.js LOG=N Review URL: https://codereview.chromium.org/272503005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21209 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/264233005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21208 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
* Route all access to the 3 weak lists through getters/setters. * Removed superfluous visiting already done by ProcessWeakReferences. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/273653006 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21207 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=ulan@chromium.org Review URL: https://codereview.chromium.org/274043002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21206 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Changes compared to original CL: Until the Serializer/Isolate chaos is cleaned up, we can't initalize/dispose cctests in a tidy way, see cctest.cc. BUG=359977 LOG=y R=dcarney@chromium.org Review URL: https://codereview.chromium.org/267383002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21205 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
hpayer@chromium.org authored
BUG= R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/271843005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21204 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
TEST=mjsunit/array-shift,mjsunit/array-shift2,mjsunit/array-shift3 R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/279743002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21203 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 May, 2014 7 commits
-
-
rmcilroy@chromium.org authored
Rename Debug::MaybeRecompileFunctionForDebugging to EnsureFunctionHasDebugBreakSlots and ensure that it does nothing if the function is unoptimized code with debug break slots, otherwise, if the shared code has no debug break slots, it recompile that shared code and sets the function code to that shared code. Also removes two incorrect ASSERTs. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/271873003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21201 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/267343003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
R=dslomov@chromium.org, machenbach@chromium.org Review URL: https://codereview.chromium.org/250923002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21199 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
alph@chromium.org authored
BUG=v8:3308 LOG=N R=bmeurer@chromium.org, jochen@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/271683002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
R=dslomov@chromium.org Review URL: https://codereview.chromium.org/270273005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21197 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ulan@chromium.org authored
This instruciton clobbers the index register. BUG=368243 LOG=N TEST=mjsunit/regress/regress-368243 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/269273003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
svenpanne@chromium.org authored
Removed a related TODO in d8.cc on the way. BUG=v8::3318 LOG=y R=dcarney@chromium.org Review URL: https://codereview.chromium.org/275463002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 May, 2014 10 commits
-
-
mstarzinger@chromium.org authored
R=machenbach@chromium.org BUG=v8:3154 TEST=cctest/test-heap/ReleaseOverReservedPages Review URL: https://codereview.chromium.org/270303005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21192 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mvstanton@chromium.org authored
R=machenbach@chromium.org Review URL: https://codereview.chromium.org/268363010 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21191 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
R=machenbach@chromium.org Review URL: https://codereview.chromium.org/252143002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21190 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=verwaest@chromium.org Review URL: https://codereview.chromium.org/269343003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21189 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
This is mainly meant to help with the transition of chrome using the flag to promises being enabled by default BUG=none LOG=n R=rossberg@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/270503005 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=machenbach@chromium.org Review URL: https://codereview.chromium.org/275433002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Also try to determine an appropriate HType for tracked fields, instead of (incorrectly) using HType::NonPrimitive() everywhere. R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/269353003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
BUG=none LOG=n R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/272433002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Revert "Arm64: Ensure that csp is always aligned to 16 byte values even if jssp is not." and "Arm64: Fix check errors on Arm64 debug after r21177.". This reverts commit r21177 and r21179 for breaking the arm64 build. TBR=rmcilroy@chromium.org Review URL: https://codereview.chromium.org/271623002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21184 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/267363002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 May, 2014 3 commits
-
-
palfia@homejinni.com authored
Port r21165 (50673b25) Original commit message: The fix is to make the code aging sequence hang off the isolate. BUG= R=plind44@gmail.com Review URL: https://codereview.chromium.org/264823004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rmcilroy@chromium.org authored
r21177 added extra AssertStackConsistency() checks which increased code size on debug and caused the assembler buffer to be too large. Increased some of these buffers to compensate. Also, ProfileEntryHoolStub could use the wrong number of instructions for kProfileEntryHookCallSize depending upon whether debug code was being emitted or ALWAYS_ALIGN_CSP was enabled. Fixed this by taking ALWAYS_ALIGN_CSP into account and ensuring that no debug code is emitted during MaybeCallEntryHook(). TBR=ulan@chromium.org Review URL: https://codereview.chromium.org/263213008 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
Seems to crash some tests on buildbots. TBR=ishell@chromium.org CC=wingo@igalia.com,yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/273433002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21178 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-