- 29 Jul, 2021 17 commits
-
-
Andreas Haas authored
At the moment a WebAssembly module can be serialized successfully when all functions were compiled with TurboFan. However, for some functions it may not be necessary to be compiled with TurboFan, e.g. for functions where Liftoff code is as good as TurboFan code. With this CL we allow WebAssembly modules to get serialized even when not all functions are compiled with TurboFan. Missing functions are marked as missing in the serlialization. Upon deserialization, missing functions either get compiled by Liftoff, or initialized with a lazy-compilation stub, depending on the V8 configuration. Bug: v8:11862 Change-Id: Ic833a17639bf841c5def6fe3c35173fe0376c246 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960209 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75987}
-
Omer Katz authored
Cppgc reports used bytes statistics to CppHeap. CppHeap should forward the stats to v8. However, if we are not allowed to trigger a GC, CppHeap will cache the stats until the reporting. On GC finalization, CppHeap resets v8's counters to the current marked bytes counter. If the last reported stats before GC finalization are cached, CppHeap doesn't clear the cache on GC finalization. On the next stats reporting, CppHeap will report the cached values. If the cache is a decrease that is larger than the current marked bytes, a DCHECK in LocalEmbedderHeapTracer::DecreaseAllocatedSize will fail. Bug: chromium:1056170 Change-Id: I47933abc3e5f5c4a91454e0ec03adde5cf61d8fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056970 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#75986}
-
Camillo Bruni authored
- Make sure we use fast prechecks in the header files - MicrotaskQueue::CallEnqueueMicrotask returns a Smi instead of a more costly undefined value (the return value is enforced by the calling convention, but unused) - Merge FireMicrotasksCompletedCallback into OnComplete Change-Id: I3797b946bcffb6349e5693c41478bd2bad1f93fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3024154 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75985}
-
Clemens Backes authored
This fixes the youcompleteme config script to look for ninja_output.py in tools/vim instead of tools/ninja (it was moved there in https://crrev.com/c/2797536), and makes a minor adjustment for python3 compatibility. R=machenbach@chromium.org Bug: v8:11879 Change-Id: Ia825903fb6019865244c5529bf2d23935a10ad5e No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059077Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75984}
-
Camillo Bruni authored
If v8_enable_runtime_call_stats == false, we don't need TracingFlags::is_runtime_stats_enabled and can save a bit of code and needless overhead. Bug: v8:11299 Change-Id: Ia5ec51c29b2408b77b65984c5bba0ae16e0de243 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3024155Reviewed-by:
Patrick Thier <pthier@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#75983}
-
Leszek Swirski authored
This is a reland of 14941067 which is a reland of 0f79565b which is a reland of 85e6c4b6 The _other_ gc-stress issue should be now be fixed with https://crrev.com/c/3059072. Relanding without changes. TBR=verwaest@chromium.org Original change's description: > Reland^2 "[sparkplug] Enable sparkplug by default on desktop" > > This is a reland of 0f79565b > which is a reland of 85e6c4b6 > GC-stress issue was still flushing, now fixed for real with > https://crrev.com/c/3054117. > > Relanding without changes. > > TBR=verwaest@chromium.org > > Original change's description: > > Reland "[sparkplug] Enable sparkplug by default on desktop" > > > > This is a reland of 85e6c4b6 > > GC-stress issue was flushing, fixed with https://crrev.com/c/3048172. > > Relanding without changes. > > > > TBR=verwaest@chromium.org > > > > Original change's description: > > > [sparkplug] Enable sparkplug by default on desktop > > > > > > Bug: v8:11420 > > > Change-Id: I07ac7f30b5ffffe40170ac15d5df0d3bf8a53523 > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041418 > > > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#75868} > > > > Bug: v8:11420 > > Change-Id: I44ac0e4a5df07db79fa50db3134cdae3af41c88c > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3053588 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#75916} > > Bug: v8:11420 > Change-Id: I24c7aea81ca58c339fc3bcc904663bdefb93106b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3054118 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#75926} Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng,v8_linux_arm64_gc_stress_dbg_ng,v8_mac64_gc_stress_dbg_ng Bug: v8:11420 Change-Id: I94f9927b689d876135750f6151de14f295035c72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056986 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#75982}
-
Anton Bikineev authored
Due to missing locks, there is a race between AllocatePagesAt (or ReserveForSharedMemoryMapping) and other functions that modify std::sets in RegionAllocator (e.g. AllocatePages or ReleasePages). The CL adds locks to AllocatePagesAt and ReserveForSharedMemoryMapping. Bug: chromium:1232067 Change-Id: I0ec503ab1ab432952ea067eb916299ea88566879 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056985 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Andrew Comminos authored
If context filtration fails, ensure that we still include an empty sample. This ensures that we can properly terminate stacks. Bug: chromium:956688 Change-Id: I3edeb3434960c420e24827c209055f7c378361bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058053Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#75980}
-
Yoshisato Yanagisawa authored
- goma cache silo is a builder to build the same target with cache silo. This is needed for fair build performance comparison between reclient and Goma. - reclient compare is a builder to verify artifacts generated in remote and that generated locally matches. Bug: chromium:1233780 Change-Id: I5854d20880e972a07fa09cfc5d4a6f9385844fbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058059Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#75979}
-
Leszek Swirski authored
InterpreterOnStackReplacement_ToBaseline spills the accumulator register without a frame, but can then call kInstallBaselineCode. If that function then allocates, then the GC will see an invalid stack. Fix this by making sure that the accumulator register is spilled inside the internal frame of the kInstallBaselineCode, and either don't spill it at all outside that frame, or at least make sure that we pop/re-push the spilled value so that it moves inside the frame. Bug: v8:11420 Change-Id: Iad2aa718b0477ff960544d881fecae9efcbeef54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059072 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit 71e27849. Reason for revert: As of https://crrev.com/c/3059685 it's fast. Original change's description: > Mark json-parser-recursive as slow > > Bug: v8:12029 > Change-Id: I0d25f8c844c9826e10ca2ccc6beb385439e97dde > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058451 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75968} Bug: v8:12029 Change-Id: I9536adbe4d8434e44d3e113104694baa3b3cea47 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059687 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75977}
-
Leszek Swirski authored
The test makes sure that JSON parsing doesn't stack overflow if given a deeply nested JSON object. This deep nesting makes the test slow, so we can test ~the same thing by lowering both the nesting and the stack size. Bug: v8:12029 Change-Id: I689ffc1b9db167a1cf1de93beeb09c89e03264a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059685 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Yang Guo authored
R=machenbach@chromium.org Bug: chromium:1234045 Change-Id: Id72ac120d161d1419a1c07d68dbe6314bf865e84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059084 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Use the result of scripts.find() instead of using operator[] when looking up scripts. This avoids an ugly const_cast, and avoids doing the lookup twice. Change-Id: I7c1a6be28928e2e3d928c389328be8785be3cff7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056989 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Jakob Gruber authored
is_deprecated and is_stable are mutable and can be changed concurrently. We protect against changes through dependencies. CHECKs on such fields are invalid. Bug: v8:7790,chromium:1234206 Change-Id: I9bb7fab0342e0e2c33377c162b1912a8f93e760b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059682 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75973}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0c49d51..82f37a4 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/e6a0f63..cdb04dc Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/def6c30..30a89ee TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I422cf12eb5927bec02723c9b2937edaf0da84bfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058304Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75972}
-
Liu Yu authored
Port: ec717160 Bug: v8:11879 Change-Id: Ib1ef3d984d559e4d4cec4d4daa9e1fec856f3686 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058062 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#75971}
-
- 28 Jul, 2021 23 commits
-
-
Milad Fa authored
The test currently fails on machines with sparkplug enabled: ``` Flag --sparkplug: value implied by --jitless conflicts with explicit specification ``` And passes on platform without sparkplug. Bug: chromium:1233401 Change-Id: Ia0277f8d356e34efb611ca9960c11ec78b9b94ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058300 Commit-Queue: Milad Fa <mfarazma@redhat.com> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Junliang Yan <junyan@redhat.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#75970}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/96a4da9..0c49d51 Rolling v8/third_party/aemu-linux-x64: LiTUyHa0AyC2fE72v094aZIjv1aTdQEZfYm-LIJVQIwC..EfaAueisHmQB3i2Cqncpzj07xFoDNrwT09yreit16bgC Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2a8bb1c..def6c30 Rolling v8/tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:2c98a90e4f4daa808cb69d51e71eee9289bd5422 Rolling v8/tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:2c98a90e4f4daa808cb69d51e71eee9289bd5422 Rolling v8/tools/luci-go: git_revision:75ff299b9adf969190cafebe902255856a346f0b..git_revision:2c98a90e4f4daa808cb69d51e71eee9289bd5422 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I39ed6b937454484fff5edd7ce34ba9befdb1478d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058298Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12029 Change-Id: I0d25f8c844c9826e10ca2ccc6beb385439e97dde Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058451Reviewed-by:
-
Yang Guo authored
R=leszeks@chromium.org Bug: chromium:1233401 Change-Id: Ieaf7513d2dbd9bc84a996defbf0a929d35befa36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3059082 Commit-Queue: Yang Guo <yangguo@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#75967}
-
Rakhim Khismet authored
We add new alternative "new_object" in order to emit new struct and array types. We check whether heaptype is struct or array type so we could emit "NewDefault" or "NewWithRtt". The additional methods (IsArray/StructType, GetArray/StructType) was added to WasmModuleBuilder. Bug: v8:11954 Change-Id: I7a0e73edfbaa49beb1efd60b0f1b9916dc50df22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056459Reviewed-by:
-
Milad Fa authored
FP Div, Min and Max are added in this CL. Opcodes are also reordered in macros to match the instruction selector. Change-Id: Idd6909721b0d06d523c93873e5faff39449d937c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058294Reviewed-by:
-
Junliang Yan authored
Change-Id: Ib10b00443fe1d46ccb75bd93ec0c855919bb563d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058295Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75964}
-
Yang Guo authored
Previously we do not tier down from baseline to interpreter, which breaks per-bytecode side effect checks (to check whether e.g. we are mutating a temporary object, which is not considered a side effect). R=leszeks@chromium.org Bug: chromium:1233401 Change-Id: Ie08b5352aa4c124421b4c9abce18326938bbc822 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056981Reviewed-by:
-
Benedikt Meurer authored
Previously we'd report all property edges with symbol names as <symbol>, which was not very useful, especially with private class fields now seeing more adoption. Fixed: chromium:1232467 Change-Id: I53cf0811c4b83d016b988b687c6decbddd3c2fdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055309 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Bug: v8:11600 Change-Id: I38696d64da4e321d966933179800376b7fdedaca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056987 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#75961}
-
Clemens Backes authored
Found these when compiling the arm64 simulator for MSan (Release) and ASan (Debug and Release). Depending on the exact configuration (and compiler), different functions will get inlined and different symbols need to be available at link time. 1) Since GetRecoveredTrapCount is used in a unittest, it needs to be exported. 2) The thread-local g_thread_in_wasm_code cannot be exported on Windows, hence it cannot (safely) be used in unit tests. Use the {GetThreadInWasmThreadLocalAddress} function instead, which will return the address of that thread-local variable. R=ahaas@chromium.org, mseaborn@chromium.org Bug: v8:11955 Change-Id: I118f60c1580a8362f8232541576a1c41da7042bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3049077Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75960}
-
Mythri A authored
Use write barrier when storing code into JSFunction::Code field. Earlier, code from SharedFunctionInfo was always a builtin and hence it was safe to skip write barrier there. With Sparkplug we could also store baseline code and hence it isn't safe to skip write barrier. Change-Id: I6a68ac759d619cdbeec8d4a37e9493d46f7aa790 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056982Reviewed-by:
-
Leszek Swirski authored
The OSR entry stack check is needed as a function entry stack check to make sure the call isn't overflowing, but emitting it as part of the loop peeling meant that it would be within any exception handler ranges that the loop is in. In particular, this meant that code like this: try { loop { OSR(); } } catch {} would logically insert the entry stack check inside the try, and thus stack overflows of the function call would be caught within the function, and the function could continue runnning in an overflown state. Bug: chromium:1232875, chromium:1034322 Change-Id: I846c6f520fd3a897da016132419ad48043859c33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056980 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75958}
-
Jakob Gruber authored
Drive-by: Remove invalid DCHECK(!is_deprecated) since we cannot guarantee this in a concurrent setting. Drive-by: Instead, check for deprecation during dependency validation. Drive-by: Remove addtl. invalid or outdated DCHECKs. Bug: v8:7790 Change-Id: Ia77a82976b987fe1eaca6178dac6c7b75fbf98fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041666Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:11515 Change-Id: Ieece676f2f4ae258db8b7e1783c796ff6c0fa6f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055293Reviewed-by:
-
Liu Yu authored
Port 593fbb69 Bug: v8:12017 Change-Id: I0776820d0ab51950028da347d9d7d08acfb30386 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058652 Auto-Submit: Liu yu <liuyu@loongson.cn> Reviewed-by:
-
Maya Lekova authored
Bug: v8:11905 Change-Id: I845914a1c9dca760fd160fc2ff15aacc3f323993 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056976 Commit-Queue: Maya Lekova <mslekova@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Auto-Submit: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75954}
-
Clemens Backes authored
Fix ia32 for v8_enable_webassembly=false. This is not a configuration that we test on CQ or the waterfall, but it was working at some point so this CL makes it compile again. R=zhin@chromium.org Change-Id: I78dafe08199c89ec24613a62a3085e923a51b43e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056450Reviewed-by:
-
Santiago Aboy Solanes authored
This means that we are now background serializing RefSerializationKind::kBackgroundSerialized classes on all configs. Bug: v8:7790 Change-Id: Iaa54718303e07e37a95d3f54d0c4c173d4174967 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3056453Reviewed-by:
-
Jakob Gruber authored
.. instead of recalculating them at the risk of getting different answers. In a concurrent setting, repeated type/rep calculations are not guaranteed to return the same answer. Instead, calculate them once and pass them into dependency creation methods. Note with this CL we now get the type/rep off the holder map and not the field owner map. The results should be identical and behavior should not change (verified by CHECKs). Bug: v8:7790 Change-Id: I2b4c3bb8907082c69448ca743d3c8740cd8f71f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055306Reviewed-by:
-
Liu Yu authored
Port edc349db Bug: v8:11235 Change-Id: Ie3cfadf97afcea4048c20bc1a5646f4e3c2a82ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058061Reviewed-by:
-
Jakob Gruber authored
ComputeMinObjectSlack is called concurrently from background threads (when --concurrent-inlining) and must therefore be thread-safe. This CL adds a compiler-specific thread-safe variant of ComputeMinObjectSlack in addition to the plain old non-thread-safe one. Thread-safety is achieved through locking: on the bg thread, a shared lock when traversing transitions, and on the main thread, an additional exclusive critical section when overwriting prototype transitions. Tbr: leszeks@chromium.org Bug: v8:7790,v8:12010,chromium:1231901 Change-Id: If5af83df1ab896b22477921449fb5ba4c8d3e8a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3045342 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e3754f7..96a4da9 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/bfcda91..24e92c2 Rolling v8/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind/+log/23a5972..e6a0f63 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I9042ee9ede0949807a83329e8045811adad06fe2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3058290Reviewed-by:
-
