- 18 Oct, 2021 8 commits
-
-
Manos Koukoutos authored
This CL improves wasm inlining heuristics in Turbofan, for an average 8,5% performance improvement in selected benchmarks. Changes: - In WasmInliner::Reduce(), only collect inlining candidates into a priority queue, according to WasmInliner::LexicographicOrdering. Move actual inlining to Finalize(). - Remove the InlineFirstFew heuristic. Add two limits to inlining: Maximum relative size increase (reversely proportional to the function size), and absolute size increase. - Pass information about call frequency from liftoff-collected feedback to the WasmInliner though the wasm module. - Run wasm inlining along other optimizations in the pipeline. - Split inlining and speculative inlining tests. Bug: v8:7748, v8:12166 Change-Id: Iccee22093db765981889a24451fb458dfce1f1a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3222764Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#77428}
-
Marja Hölttä authored
Bug: chromium:1260577 Change-Id: I8944f2f1dda22ab9a24e389a686c707deb5f18c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3225936Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#77427}
-
Michael Lippautz authored
Change-Id: I2150c83eeb8939801aeed7e7bb0aec92f8f91733 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3227756 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77426}
-
Nico Hartmann authored
This reverts commit 929b83fb. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20UBSan/18725/overview Original change's description: > [heap] Attach to shared isolate after setting up main thread > > Attach to the shared isolate after the main thread was set up. Otherwise > it could happen that a shared GC initiated from another isolate might > see no threads are running and performs the safepoint operation in the > middle of isolate deserialization. > > We use DisallowSafepoints to check that the isolate doesn't join a > global safepoint before deserialization is complete. DisallowSafepoints > used to prevent only invocations of Safepoint() but was updated to > also prevent Park() and Unpark() invocations. Each state change could > cause the thread to reach a safepoint, which would allow a shared GC > to run. > > We now also DCHECK that every isolate has at least one local heap and > that shared collections aren't started before deserialization is > complete. > > Bug: v8:11708 > Change-Id: Iba3fb59dd951d5ee4fc9934158062287302fc279 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3221157 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77424} Bug: v8:11708 Change-Id: I0633150b6b40b297a335a39bf1a087ca93592e04 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3225937Reviewed-by:
-
Dominik Inführ authored
Attach to the shared isolate after the main thread was set up. Otherwise it could happen that a shared GC initiated from another isolate might see no threads are running and performs the safepoint operation in the middle of isolate deserialization. We use DisallowSafepoints to check that the isolate doesn't join a global safepoint before deserialization is complete. DisallowSafepoints used to prevent only invocations of Safepoint() but was updated to also prevent Park() and Unpark() invocations. Each state change could cause the thread to reach a safepoint, which would allow a shared GC to run. We now also DCHECK that every isolate has at least one local heap and that shared collections aren't started before deserialization is complete. Bug: v8:11708 Change-Id: Iba3fb59dd951d5ee4fc9934158062287302fc279 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3221157 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77424}
-
Benedikt Meurer authored
Bug: none Change-Id: If62875a1f907ac33b6c6e6a894099a83bba71783 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3225935Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#77423}
-
Marja Hölttä authored
Functions affected: filter find findIndex findLast findLastIndex forEach reduce reduceRight Bug: v8:11111 Change-Id: Ifb40143e5b6ed4a3eb30cb25332e2387009e3274 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3205421 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/0baacde..59bbc7f cmake: eliminate redundant `target_include_directories` (#1242) (Sergiu Deitsch) https://chromium.googlesource.com/external/github.com/google/benchmark/+/59bbc7f TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: Ibab54099357ee194a92c0c076b3053868ea5e4cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3228788Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77421}
-
- 15 Oct, 2021 14 commits
-
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I6a449ec60a75d55715f04b9a57988c8a7caf038c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3227267Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77420}
-
Milad Fa authored
Bug: chromium:1218005 Change-Id: I1c9aae03e460155002dfa2483c37cec4f50ec566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226782Reviewed-by:
Samuel Groß <saelo@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77419}
-
Patrick Thier authored
When copying properties, it should never happen that source == target. Add a CHECK to assert this assumption. Bug: chromium:1260129 Change-Id: Ia5248e4363d85e13052db726fb7143897cea9c87 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226779 Commit-Queue: Patrick Thier <pthier@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Id09544a9f55843d2474b6114da9d42e1ec994cff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226322 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Avoid repeated collisions when the name doesn't hold much entropy. This is typically the case with minified sources where 1 or 2 letter names are used very frequently. Bug: v8:12316 Change-Id: I20df3a6b0c5daf7975668d25404eca94a1230fe0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3222759Reviewed-by:
-
Leszek Swirski authored
This reverts commit 7366f6e2. Reason for revert: Speculative revert for cctest/test-debug-helper/GetObjectProperties failures https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8833300564873660401/+/u/Check/GetObjectProperties Original change's description: > [torque] Don't generate k(?:Start|End)Of\w+FieldsOffset constants > > Torque currently generates constants like kStartOfWeakFieldsOffset and > kEndOfStrongFieldsOffset, which can be used when writing custom > BodyDescriptors. However, these offsets have some potentially confusing > behaviors: > > * They don't take inheritance into account and describe only the fields > defined by the current class itself, so there might be (for example) > strong fields before kStartOfStrongFieldsOffset if they were defined > by a superclass. > * kStartOfWeakFieldsOffset points to the first field defined in Torque > using the keyword `weak`, which indicates fields with *custom* > weakness semantics (those that should be visited with > IterateCustomWeakPointers), not those that may contain standard weak > pointers (visited with IterateMaybeWeakPointers). (As a follow-up, I'd > like to also rename `weak` to `@customWeak`.) > > Given that these constants have very low usage and somewhat bizarre > semantics, I propose that we remove them. This change does so, and > updates the existing usages to either define the required constants > directly in C++ or not use them. I know that defining these constants in > C++ is more brittle, but I think that brittle and clear is better than > automatic and incomprehensible. > > Bug: v8:7793 > Change-Id: I87f8c85ccae4027f61ac73d4e7e4e2820e92003b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199731 > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> > Cr-Commit-Position: refs/heads/main@{#77411} Bug: v8:7793 Change-Id: Ia12b5d773db35739283ca8871d3dd6922413cc82 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226783 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77415}
-
Manos Koukoutos authored
GetUnusedRegister may spill registers and thus modify stack slots. Therefore, we have to call it before fetching stack slots. This is another instance of https://chromium-review.googlesource.com/c/v8/v8/+/3217199. Bug: v8:7748 Change-Id: I9ff28b26f2dce93ef7b71c1100d9bf88f7c2f7c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226327Reviewed-by:
-
Milad Fa authored
https://crrev.com/c/3222763 has added a new global value `TB` which is the same as our `test block` opcode. Cl is adding an underscore to resolve the naming issue. Change-Id: I4744f14dd594d4a58ed14d7651a6b7a0cad62ba8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226801Reviewed-by:
Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#77413}
-
Clemens Backes authored
This adds a few more trace events, also tracing the number of wrappers. This can help to understand instantiation time better. R=ahaas@chromium.org Bug: v8:12287 Change-Id: Ic1a03b2e278af64908f0dc45cd5db60ecf7c79f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226323Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#77412}
-
Seth Brenith authored
Torque currently generates constants like kStartOfWeakFieldsOffset and kEndOfStrongFieldsOffset, which can be used when writing custom BodyDescriptors. However, these offsets have some potentially confusing behaviors: * They don't take inheritance into account and describe only the fields defined by the current class itself, so there might be (for example) strong fields before kStartOfStrongFieldsOffset if they were defined by a superclass. * kStartOfWeakFieldsOffset points to the first field defined in Torque using the keyword `weak`, which indicates fields with *custom* weakness semantics (those that should be visited with IterateCustomWeakPointers), not those that may contain standard weak pointers (visited with IterateMaybeWeakPointers). (As a follow-up, I'd like to also rename `weak` to `@customWeak`.) Given that these constants have very low usage and somewhat bizarre semantics, I propose that we remove them. This change does so, and updates the existing usages to either define the required constants directly in C++ or not use them. I know that defining these constants in C++ is more brittle, but I think that brittle and clear is better than automatic and incomprehensible. Bug: v8:7793 Change-Id: I87f8c85ccae4027f61ac73d4e7e4e2820e92003b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3199731Reviewed-by:
-
Clemens Backes authored
This makes it easier to see if a module is taken from the cache. R=thibaudm@chromium.org Bug: v8:12287 Change-Id: I6b7acf15f1aa20f6531d746d37890608462606de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226326 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Array spread syntax `[...obj]` is compiled to a special bytecode that tries to take fast-paths for values special kinds of `obj`s, including Set, Map, and Array iterator instances. But these fast-paths skip the side-effect checks of `Runtime.evaluate` and friends, and thus lead to surprises for developers. This CL alters the behavior to always call the `next()` builtins when the debugger is active to make sure we catch the side effects correctly. Fixed: chromium:1255896 Change-Id: If3fc48a119cfa791c4fde7b5c586acc22dd973e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3226329 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/main@{#77409}
-
Michael Lippautz authored
Bug: v8:12295 Change-Id: Ibf18c936215e892edd5009dc59560988453e1203 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218063Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77408}
-
Lu Yahan authored
Port 255aaed9 Port 6bd44dfe Change-Id: I9d57cf7782c267bda4532d0408e69b671e6001f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3220271Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Reviewed-by:
-
- 14 Oct, 2021 18 commits
-
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/61339fd2..8d420cef4 Bug: v8:7834 Change-Id: I03213a87597bf9dcd810bcc55f7bc9f352342b3a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3222879Reviewed-by:
-
Shu-yu Guo authored
Bug: chromium:1258603 Change-Id: Ife2284de6151c7e70592b55871875061b93bbcca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218193Reviewed-by:
-
Bruce Dawson authored
In order to avoid namespace pollution and compilation overhead it is desirable to avoid include windows.h, and this enforces that. Bug: chromium:796644 Change-Id: I7fdcd3c182a77cee03672bc4324b9e21566896d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3223960Reviewed-by:
-
Samuel Groß authored
There is no need to wrap the cage's page allocator into a LsanPageAllocator as that page allocator ultimately relies on the platform page allocator to obtain pages. As the platform page allocator will be a LsanPageAllocator when LSAN is enabled, it will already take care of marking the pages as root regions with LSAN. luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Bug: chromium:1218005 Change-Id: I62b5da9cb320e5012a657951c0d4c85a1bb2b3fb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3222761Reviewed-by:
-
Samuel Groß authored
On Windows pre 8.1, userspace is limited to 8TB of virtual address space. Take that into account when determining the size and/or placement of the virtual memory cage. Bug: chromium:1218005 Change-Id: Idda94534cad67dc2db77e9ba459e3a4b239dac2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3222763Reviewed-by:
-
Ng Zhi An authored
4 instructions, i8x16, i16x8, i32x4, i64x2 relaxed lane select. These instructions only guarantee results when the entire lane is set or unset, so vpblendvb will give correct results for all of them. Bug: v8:12284 Change-Id: I76959a23f2d97de8ecc3bef43d138184484e3c4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3207006Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77401}
-
Thibaud Michaud authored
Add initial stack memory, jump buffer and continuation objects. R=ahaas@chromium.org CC=fgm@chromium.org Bug: v8:12191 Change-Id: I0c6bde4e5f15e9c539e5e8af1a3b84e5cb5bc9a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3220342 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
--trace-wasm-compilation-times: print one line per compiled function with basic performance information. Useful for narrowing down functions of interest before investigating them in more depth. --wasm-tier-up-filter=N: only tier up function #N. Useful for focusing features like --turbo-stats-wasm on a particular function. Change-Id: Iaddb29bf815f4de8381a08e29187e96cc9945779 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086341Reviewed-by:Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Samuel Groß authored
The virtual memory cage supports a fallback mode that attempts to obtain memory pages within a specific virtual address range by using PageAllocator hints. However, Prior to this CL, the default PageAllocator on Fuchsia would ignore hints alltogether, preventing these mechanisms from working there. Ultimately, on Fuchsia it would probably be better to manage the virtual memory cage purely through VMARs instead of actually creating pseudo mappings just to reserve virtual address space as is currently done through the PageAllocator. This will require broader changes though, so in the meantime, sticking to the current PageAllocator API is probably the best option. Bug: chromium:1218005 Change-Id: I821cfbb815d81479c3b3310296302addbb9cd8f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3220340Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Samuel Groß <saelo@chromium.org> Cr-Commit-Position: refs/heads/main@{#77398}
-
Jakob Kummerow authored
Since we introduced `array.init` as a way to create fully initialized arrays, immutable arrays are no longer useless, and they enable certain static optimizations, so this patch allows them. Bug: v8:7748 Change-Id: I404aab60099826f4bd83cf54e5e1acbc38a3ca9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3221151 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Samuel Groß authored
Besides the virtual memory cage, the DecommitPages API is also now required for Cppgc with crrev/c/3211583. A working implementation of this API is availabe in src/base/platform for all supported platforms and is used by the DefaultPlatform. Bug: chromium:1218005 Change-Id: I29765993ed54bb52de71998ae8c6295637ee4072 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3211584 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Lu Yahan authored
Port: 1cd7a582 Original Commit Message: Class Constructors are special, because they are callable but [[Call]] raises an exception. Instead of checking if a JS function is a class constructor for every JS function call, this CL adds a new instance type for class constructors. This way we can use a fast instance type range check for the common case, and only check for class constructors in the uncommon case were a class constructor is called and when we need to raise an exception. Change-Id: I8f11416124a1eefc4ba63423747686bc0b519bb9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218711 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
-
Igor Sheludko authored
... into UNIQUE_LEAF_INSTANCE_TYPE_MAP_LIST_GENERATOR and the rest where the former list contains only those maps which have 1:1 relation to instance type values. Bug: v8:11880 Change-Id: Ibe20ec7a7c432680dcf23a5c0102ae89c0689d47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218065 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Samuel Groß authored
This function tries to determine the number of virtual address bits available on the current CPU and with that the maximum size of the userspace address space. On x64, it can be implemented through CPUID. The result of this function is now used in two ways: first, it limits the maximum size of the virtual memory cage, currently to a quarter of the address space. Second, it influences the placement of fake cages, which are attempted to be placed into the lower half of the address space so that they are followed by large amounts of (hopefully) unused but addressable virtual memory in which pages can be allocated. Bug: chromium:1218005 Change-Id: I0edc5d241d899f16dbc47492fa1534b6aaa4aa13 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3220348 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
-
Samuel Groß authored
V8 can fall back to creating a virtual memory cage that does not have the desired security properties but at least allows V8 to run when caging is enabled. This API allows the embedder to determine which kind of cage is being used, for example for metrics collection. Bug: chromium:1218005 Change-Id: I6988d0a4fce8aeb1361b30fce8c9c2f68f3b92f9 Cq-Include-Trybots: luci.v8.try:v8_linux64_heap_sandbox_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3220343 Commit-Queue: Samuel Groß <saelo@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#77392}
-
Jakob Gruber authored
- Anonymous namespaces instead of static functions. - Comments. - Reserve enough space in the range ZoneList. Change-Id: Ie79fda770974796cd590a155dc5fd504472e5bc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3220341 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#77391}
-
Shu-yu Guo authored
The concurrent marker consults the page flags to see if it should skip objects in the shared heap, and it was missing a SynchronizePageAccess, causing TSAN false positives. Bug: v8:12314, v8:12007 Change-Id: I888a68a3eddaa3dfa1644364226010def8d2a9b6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3219946 Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77390}
-
Marja Hölttä authored
Scripts are treated as web snapshots if they start with a magic number. This enables end-to-end web snapshot implementations without changing the embedders. Bug: v8:11525 Change-Id: Ib8b098bb8cf0b9f96894009414b1cea7646b60dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3218977Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
