- 01 Jun, 2021 1 commit
-
-
Camillo Bruni authored
- Add d8.file.read() and d8.file.execute() helpers - Change tools and tests to use new d8.file helper - Unify error throwing in v8::Shell::ReadFile Change-Id: I5ef4cb27f217508a367106f01e872a4059d5e399 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928505 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74883}
-
- 12 Jun, 2020 1 commit
-
-
Andreas Haas authored
We want to enable the wasm-bigint implementation by default. However, at the moment there exist several tests which fail when wasm-bigint gets enabled. With this CL we adjust or delete these tests so that they pass once wasm-bigint gets enabled. At the same time we disable these tests for now, and re-enable them in the CL that flips the flag. R=jkummerow@chromium.org Bug: v8:7741 Change-Id: I733bfe7ff19e403913b143e6ea86ab13602ab993 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2243212 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68328}
-
- 06 Mar, 2020 1 commit
-
-
Andreas Haas authored
This CL fixes a special case where a WasmExportedFunction is passed to the WebAssembly.Function constructor. This is a case that was not yet implemented in V8, and which is also not specified in the proposal yet. With this CL we do a signature check of the provided function. If it matches, the function itself is returned. Otherwise a TypeError is thrown. I filed an issue: https://github.com/WebAssembly/js-types/issues/13 R=jkummerow@chromium.org Bug: chromium:1057534 Change-Id: Ib09d1ba18abaa6a8dd451aa747fd26c03d927413 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2084813 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#66610}
-
- 08 Oct, 2019 1 commit
-
-
Clemens Backes authored
This brings our constants back in line with the changed spec text. We already use kExprTableGet and kExprTableSet, but for locals and globals we still use the old wording. This renaming is mostly mechanical. PS1 was created using: ag -l 'kExpr(Get|Set|Tee)Local' src test | \ xargs -L1 sed -E 's/kExpr(Get|Set|Tee)Local\b/kExprLocal\1/g' -i PS2 contains manual fixes. R=mstarzinger@chromium.org Bug: v8:9810 Change-Id: I1617f1b2a100685a3bf56218e76845a9481959c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847354Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64161}
-
- 22 Aug, 2019 1 commit
-
-
Michael Starzinger authored
This preserves the object identity of a {WebAssembly.Function} instance that is being re-exported by a module. Such functions are considered to have an internal [[FunctionAddress]] slot and hence require their object identity to be preserved (similar to {WasmExportedFunction} already). R=jkummerow@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I88ba75fcd91ce04440008467f3b218a1ac3047db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1763545Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63346}
-
- 21 Aug, 2019 3 commits
-
-
Michael Starzinger authored
This adds type reflection support to the {WebAssembly.Module.exports} as well as {WebAssembly.Module.imports} method. It also refactors existing reflective code to use the internal instead of the public embedder API, which is slightly more efficient anyways. R=ahaas@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I88a6c7e9236a549808707c72e40a63302b7747a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1763527Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63312}
-
Michael Starzinger authored
This just adds a test case checking against the current behavior, but expectations might change once the proposal is clarified. For details see: https://github.com/WebAssembly/js-types/issues/11 R=ahaas@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I2fc502460c0a8094a414d138703b75497b2d1c6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762517Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63311}
-
Michael Starzinger authored
This adds type reflection support to the {WebAssembly.Module.exports} as well as {WebAssembly.Module.imports} method. It also refactors existing reflective code to use the internal instead of the public embedder API, which is slightly more efficient anyways. R=ahaas@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: Ic51b7b4744f7b3ad056a778aecfc4614ca8d6e75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762019 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#63299}
-
- 20 Aug, 2019 2 commits
-
-
Michael Starzinger authored
This adds type reflection support to the {WebAssembly.Module.exports} as well as {WebAssembly.Module.imports} method. It also refactors existing reflective code to use the internal instead of the public embedder API, which is slightly more efficient anyways. R=ahaas@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I168741d382373ec47ebe0517ce7803732cbb3b24 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762011 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#63276}
-
Michael Starzinger authored
This adds type reflection support to the {WebAssembly.Module.exports} as well as {WebAssembly.Module.imports} method. It also refactors existing reflective code to use the internal instead of the public embedder API, which is slightly more efficient anyways. R=ahaas@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I5f20ea57261f6433b8d86f55054216bf96b41382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1760826 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#63273}
-
- 02 Aug, 2019 1 commit
-
-
Michael Starzinger authored
This makes sure the "parameters" and "results" properties of the passed FunctionType object can be arbitrary iterable objects, not just plain JavaScript arrays. R=clemensh@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: Icba18c418e549deba9fff1855be4956813b1a953 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1733071 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63049}
-
- 29 Jul, 2019 1 commit
-
-
Michael Starzinger authored
This makes function objects constructed via the {WebAssembly.Function} constructor callable directly from JavaScript (not just from within WebAssembly modules). Semantics are as if the function performed the transition JS-to-Wasm and then Wasm-to-JS in sequence. R=clemensh@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: Ic7dcf36ccfda1b473f2541e49419f4d2ee38bc2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1720809 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62953}
-
- 11 Jul, 2019 2 commits
-
-
Michael Starzinger authored
This adds support for properly importing {WebAssembly.Function} objects that were constructed in JavaScript and just wrap a JavaScript callable. R=ahaas@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I00e01db0d85b83d405eb28517d00fba62c253985 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690949 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62641}
-
Michael Starzinger authored
This fixes a corner-case where a {WasmExportedFunction} that represents a re-export of a JavaScript callable from another module was identified correctly, but not all corner-cases were correctly covered. Concretely we failed to check for function signatures incompatible with JavaScript. R=ahaas@chromium.org TEST=mjsunit/regress/wasm/regress-9447 BUG=v8:9447 Change-Id: Ia6c73c82f4c1b9c357c08cde039be6af100727d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690941 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62632}
-
- 10 Jul, 2019 1 commit
-
-
Michael Starzinger authored
This adds test coverage for calling "table.set" with a constructed {WebAssembly.Function} object that uses a signature incompatible with JavaScript. R=ahaas@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I939d63db85b4eb9cffe5a901efe477397f20f925 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691917Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#62616}
-
- 03 Jul, 2019 1 commit
-
-
Michael Starzinger authored
This add signature checking when a constructed {WebAssembly.Function} is being imported into a module. Signatures must match exactly. Note that importing itself is not yet implemented and will be done as a follow-up. R=ahaas@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: Iaa3fee574f8edafdddfc9e7aafe2bbd1ae597ff2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1683729 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62502}
-
- 17 Jun, 2019 1 commit
-
-
Michael Starzinger authored
This adds preliminary support for storing constructed WebAssembly functions in tables. Note that for now only tables at index #0 are supported, extending it to other tables indexes will be done as a follow-up. R=ahaas@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I9aa07813e07f0ceb4eafe37af412b45c7d235722 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640209 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62210}
-
- 29 May, 2019 1 commit
-
-
Michael Starzinger authored
This is a reland of 8092acbe Original change's description: > [wasm] Store signature with {WebAssembly.Function} objects. > > This adds simple serialization and deserialization of the signature > provided when a {WebAssembly.Function} object is constructed. For now > this signature is only used by the {WebAssembly.Function.type} method, > but will soon be used when importing such functions as well. > > R=jkummerow@chromium.org > TEST=mjsunit/wasm/type-reflection > BUG=v8:7742 > > Change-Id: If4a687ea537d8c12f4f01a7d3ac5a795ceb999c6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632211 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61898} Bug: v8:7742 Change-Id: I5d784165c460abd9d7b07f5cdafc746d5380ccd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632159Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61910}
-
- 28 May, 2019 2 commits
-
-
Michael Starzinger authored
This reverts commit 8092acbe. Reason for revert: Causes UBSan warnings: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/6436 Original change's description: > [wasm] Store signature with {WebAssembly.Function} objects. > > This adds simple serialization and deserialization of the signature > provided when a {WebAssembly.Function} object is constructed. For now > this signature is only used by the {WebAssembly.Function.type} method, > but will soon be used when importing such functions as well. > > R=jkummerow@chromium.org > TEST=mjsunit/wasm/type-reflection > BUG=v8:7742 > > Change-Id: If4a687ea537d8c12f4f01a7d3ac5a795ceb999c6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632211 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61898} TBR=jkummerow@chromium.org,mstarzinger@chromium.org Change-Id: I56ea9df5db3f95c05068186097e298cb73a3675d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7742 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632218Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61899}
-
Michael Starzinger authored
This adds simple serialization and deserialization of the signature provided when a {WebAssembly.Function} object is constructed. For now this signature is only used by the {WebAssembly.Function.type} method, but will soon be used when importing such functions as well. R=jkummerow@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: If4a687ea537d8c12f4f01a7d3ac5a795ceb999c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632211Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61898}
-
- 27 May, 2019 1 commit
-
-
Michael Starzinger authored
This adds a reflective function to retrieve the function type of an exported or constructed WebAssembly function object. Note that this first implementation only supports exported functions for now, the support for constructed functions will be done as a follow-up. R=jkummerow@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: I38a16972d8437521993992ca20887c47c7c6b99b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627989Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61851}
-
- 23 May, 2019 1 commit
-
-
Michael Starzinger authored
This makes the WebAssembly function constructor return a proper function object. Note that the returned object is not yet callable, only the prototype structure is in place. R=jkummerow@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: If6a3d0ae7078b5526606eef1b8fd4815353b850b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627343 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61792}
-
- 20 May, 2019 1 commit
-
-
Michael Starzinger authored
This adds proper loading and parsing of the arguments that are being passed to the {WebAssembly.Function} constructor function, including tests covering most of the negative cases. R=jkummerow@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: Id4d67789604ee72aec5ad831004a01434c1c6d6f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619748Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61659}
-
- 17 May, 2019 1 commit
-
-
Michael Starzinger authored
This adds a constructor function to be used as the base class for all exported functions. With type reflection enabled exported functions are instances of this new constructor. Using the constructor directly as well as the 'type' property is still missing. R=jkummerow@chromium.org TEST=mjsunit/wasm/type-reflection BUG=v8:7742 Change-Id: Id58359cf7866d24be0745abf36a839d3d86e5922 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617253 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61614}
-
- 15 Mar, 2019 3 commits
-
-
Aseem Garg authored
This CL allows for either of 'minimum' or 'initial' for MemoryDescriptor and TableDescriptor. It also adds a flag for the reflection features. R=binji@chromium.org,adamk@chromium.org Bug=v8:7742 Change-Id: Icfd4825f63e1eb784a39d10f740d55e81489eba7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1485243 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#60256}
-
Aseem Garg authored
R=binji@chromium.org,adamk@chromium.org Bug=v8:7742 Change-Id: I5b9a614dd0c8b028d756cbd401c803de4cb9437f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513159 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#60252}
-
Aseem Garg authored
This CL also changes the constructor for WasmTableObject so that the maximum_length is set to undefined instead of a default value if there's no maximum provided. R=binji@chromium.org,adamk@chromium.org Bug=v8:7742 Change-Id: I6310224e9997464bf69c198e2694a6cd76e01e8f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513156 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#60250}
-
- 13 Mar, 2019 1 commit
-
-
Aseem Garg authored
R=binji@chromium.org,adamk@chromium.org Bug: v8:7742 Change-Id: I13a317372fa06c706e2c648b92d2f2dd3c5a337b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1513152Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#60200}
-