- 12 Aug, 2019 3 commits
-
-
Tobias Tebbi authored
Bug: chromium:992783 Change-Id: I54ac01dfaa6717a2600cf40af95d6e74872ad2b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1748731Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#63152}
-
Ross McIlroy authored
We have already parsed a function when we call CollectSourcePositions, so we shouldn't update the parsing statistics again otherwise we will double-count. Also, CollectSourcePositions needs to be made native-context independent, and Blink's CountUsage counter requires a context to have been entered when it is called and so isn't context independent. BUG=chromium:992063 Change-Id: Idda50b98a8308f022cb90e1a18afb43982e95298 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1746472 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#63151}
-
Ana Peško authored
This CL implements a naive tiering-up strategy where the interpreter is used for the first execution for every regex, and the compiler is used for every execution after that. The only exception is if a global replace is being executed on a regex, we eagerly tier-up to native code right away. To use the tier-up logic --regexp-tier-up needs to be set. It is currently disabled by default. Bug v8:9566 Change-Id: Ib64ed77cbfcde10411161c0541dfa2501a0a93bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710661Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ana Pesko <anapesko@google.com> Cr-Commit-Position: refs/heads/master@{#63150}
-
- 09 Aug, 2019 16 commits
-
-
Ross McIlroy authored
We might have to collect source positions for existing functions when we start profiling, and doing so requires a context to be entered in V8. Ensure we always enter a context by creating a temporary context and entering it before starting profiling. BUG=chromium:992063 Change-Id: I72b259a3ad31b712b0475f7729fb4ffdab5cdd96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745481 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63149}
-
Santiago Aboy Solanes authored
This reverts commit d1a4706a. Reason for revert: Experiment over. Original change's description: > Reland "[ptr-compr][arm64] Temporarily enable pointer compression on arm64" > > This is a reland of f5611402 > > Original change's description: > > [ptr-compr][arm64] Temporarily enable pointer compression on arm64 > > > > ... and make sure that the arm64 ptr-compr bots proceed testing V8 without > > pointer compression in order to keep testing the other config. > > > > Commented out the 'extra' variant since it was crashing. Opened a bug > > regarding that: https://bugs.chromium.org/p/v8/issues/detail?id=9568 > > > > Similar to x64's https://chromium-review.googlesource.com/c/v8/v8/+/1607654 > > > > Bug: v8:7703 > > Change-Id: Ifd46b029bab34524f9f536dcdbd1574f2ddcbf37 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1724216 > > Reviewed-by: Tamer Tas <tmrts@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#63019} > > Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng > Bug: v8:7703 > Change-Id: I1a82b87bf6db4e6d100aeffc29dae60ba73d8119 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730998 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63043} TBR=machenbach@chromium.org,tmrts@chromium.org,solanes@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7703 Change-Id: I86a801d44ad4ea14b1388ad8ca6109cc8a57a7d7 Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1746470Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#63148}
-
Jakob Kummerow authored
This contains the following upstream commits: 486d3fe: Rename DEBUG to WASM_API_DEBUG 8d8e37d: Explicitly number wasm_valkind_t 299ebe0: Fix underlying types for enums 70be7c6: Fix test Change-Id: I692fb6c909e5211920438740d2c57ea7ee74ab12 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745483Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#63147}
-
Mike Stanton authored
The BytecodeGraphBuilder still looks at the heap. This CL completely eliminates heap lookups for: * CreateBlockContext * CreateFunctionContext * CreateEvalContext * CreateCatchContext * CreateWithContext Bug: v8:7790 Change-Id: I8b88215ba14a11955729b33bd0ee57219719666d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745484 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#63146}
-
Joey Gouly authored
The operator== in RegisterBase only compares the reg_code. On arm64 we have another 'base', CPURegister. Before this change, registers from different classes but with the same register number would compare as equal. For example, x30 == d30 would be true, which is incorrect. Change-Id: I8f19139df3f041b07bfa0883ec5ca768ef540802 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745475Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Rodolph Perfetta <rodolph.perfetta@arm.com> Cr-Commit-Position: refs/heads/master@{#63145}
-
Yang Guo authored
R=szuend@chromium.org Bug: chromium:991217 Change-Id: Icf4d5522fe2a1d2400e6dd33744d6a60ab4e634c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745469 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#63144}
-
Santiago Aboy Solanes authored
Some of the Float(32|64) to CompressedSigned cases had their functions defined already so they are virtually free to implement. We are still missing the unsigned case so I am keeping the TODO. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:7703 Change-Id: Ibf40d5948226fd48aebe7f8e257c117d6a5ad478 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708483Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#63143}
-
Mythri A authored
Change-Id: I086c23a1aea8a3f8ff9d7e79ea73a69461366a8d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1743968 Auto-Submit: Mythri Alle <mythria@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#63142}
-
Santiago Aboy Solanes authored
Bug: v8:9396 Change-Id: Ic5082b91cc61a286bd6a440009bf18202e853339 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730997Reviewed-by:
-
Michael Lippautz authored
- Adds regular native heap entries to the HeapObjectsMap. - Adds a side map for keeping a mapping of native objects to their canonical heap entry that they have been merged into. Change-Id: Ida00628126ded1948ceb2a0cbe14da817af7f361 Bug: chromium:988350 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1720810 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#63140}
-
Swapnil Gaikwad authored
This is the first in a series of changes to reduce the number of bytecodes generated for the iteration protocol based operations. The GetIterator bytecode introduced in this change currently loads the @@iterator symbol from an object that was previously done using the LdaNamedProperty bytecode. This change uses builtin-based mechanism that would be extended to perform additional operations in the future on absorbing the bytecodes associated with the GetIterator operation from the iteration protocol. Bug: v8:9489 Change-Id: I83b8b55c27bae8260bf227f355eeca1ba80cd8f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701852 Commit-Queue: Swapnil Gaikwad <swapnilgaikwad@google.com> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#63139}
-
Clemens Hammacher authored
This is a reland of 11524453 Original change's description: > [wasm] Test concurrent code emission > > This extends the jump table stress test. Currently, we generate > different thunks (on the main thread) and then concurrently update the > jump table to jump to one of these thunks. > With this CL, we also generate the thunks concurrently. So this also > tests whether there is proper synchronization between code generation > and executing it in another thread. > > R=ahaas@chromium.org, mstarzinger@chromium.org > > Bug: v8:9477 > Change-Id: I3598329e37482ebd27a13acc752581c714226184 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735319 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63097} Bug: v8:9477 Change-Id: Iac696f1ff3cd5209231a8dd8d1500cf77c2777b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1739370 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This adds some documentation why concurrently emitting code, patching the jump table, and executing the jump table is safe. R=ahaas@chromium.org CC=mstarzinger@chromium.org, joey.gouly@arm.com Bug: v8:9477 Change-Id: Ibe295d538a1a330c6b1d94eb1f514d1078020754 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1738856 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Tamer Tas authored
TBR=machenbach@chromium.org Bug: chromium:883629 Change-Id: Ie9d4584f6fd2c59e51128b09df5de3fbf8cf8780 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745468Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c991845..f3d0ca5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/a01c121..30604c6 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a110bf6..1b4c7e9 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ib4c6baf8106ef5051efeb986f7e78a154c4e1ef8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745270Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#63135}
-
Yury Semikhatsky authored
Since the same value is also returned in 'result' field it is still populated in accord with 'returnByValue' parameter. This behavior is consistent with 'evaluate'. R=dgozman@chromium.org, lushnikov@chromium.org Bug: v8:9509 Change-Id: I9f72682f87492ce5cd0759dce75ab3d75a5fe31c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1707331Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#63134}
-
- 08 Aug, 2019 13 commits
-
-
Ng Zhi An authored
Bug: v8:9608 Change-Id: I676fd49c35dd65d96f524a9b6e09722ff12d472e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1744910Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Auto-Submit: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#63133}
-
Jakob Kummerow authored
Change-Id: Ic5145b7ba15ae58d15e2cc4511afc2f8c6d42ea0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741654 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Dominik Inführ authored
This reverts commit e2f98ec2. Reason for revert: Caused performance regression in ArrayLiteralInitialSpreadSmallHoley. Original change's description: > Use list of invalidated objects for old-to-new refs > > Instead of inserting "deletion" entries into the store buffer, keep > a list of invalidated objects to filter out invalid old-to-new slots. > > The first CL https://crrev.com/c/1704109 got reverted because both the sweeper and the main task were modifying the invalidated slots data structure concurrently. This CL changes this, such that the sweeper only modifies the invalidated slots during the final atomic pause when the main thread is not running. The sweeper does not need to clean this data structure after the pause, since the "update pointers" phase already removed all invalidated slots. > > Bug: v8:9454 > Change-Id: Iffb5bf96de2c89eee1ee1231a3414a0f2a155cbc > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1733081 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63087} TBR=ulan@chromium.org,petermarshall@chromium.org,dinfuehr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:9454 Change-Id: I328b9f72df45fc9570d4a4d1b5389eac010638c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1743970 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Gus Caplan authored
Cleans up a plethora of JumpIfUndefined().JumpIfNull() occurances by introducing a new JumpIfUndefinedOrNull bytecode. Change-Id: I715e9dd82ca8309e0f3eb6514ddec19b4efe7dbe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1743148 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Joshua Litt authored
Bug: v8:9603 Change-Id: I7a36c97feedaccf81509aae579f1594a0e7b1019 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1743527Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#63129}
-
Ross McIlroy authored
If the function has been uncompiled (bytecode flushed) it will have lost any preparsed data. When we recompile the outer function we will regenerate this PreParseData but it wasn't being reattached to the inner function. This CL fixes this by checking for this case in Compiler::GetSharedFunctionInfo and creating a new NewUncompiledDataWithPreparseData to attach to the inner function. BUG=v8:9479 Change-Id: I5c0fc8251006f8f5c7c7f5f9dd17b2ecc671b672 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741655 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Peter Marshall authored
The spec says we have to insert some wrapper code with extra line breaks in it, but this confuses users when they see stack traces as the line numbers come from the code with the wrapper, instead of the original. This CL sets line_offset on the script to indicate that line numbers should be offset by the 2 extra line breaks when reading them out e.g. for the purpose of stack traces. Bug: chromium:109362 Change-Id: Ib608e1043c38b595b1466766f7592e993ee3b996 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741660Reviewed-by:
-
Patrick Thier authored
This CL changes the dispatch technique in the regex interpreter to token-threaded dispatch, if computed gotos are supported by the compiler. Otherwise old switch-based dispatch is still used (e.g. for MSVC). With computed gotos, less jumps will be emitted (no extra jump to single branch point/begin of switch) and branch prediction will be better because of no single branch point. This CL improves performance on the RexBench Benchmark suite by ~10%. Bug: v8:9575 Change-Id: I585ad824ff1cc595a5dfa8831ad66d6810d0119b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1733073Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Patrick Thier <pthier@google.com> Cr-Commit-Position: refs/heads/master@{#63126}
-
Sathya Gunasekaran authored
Change-Id: I3768f2ca772d1ba60a5436a971c3f1966e8ab8f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741649Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Mythri A authored
With lazy feedback allocation, we don't have feedback vectors when function starts executing. If we mark the function on the first execution we would be missing feedback for the initial part of the function and hence the optimized code will not be useful. This cl resets the optimization markers on OSR if the invocation count of the function is less than 1. We may still do wasted optimizations if the function is hot enough for optimizing but not for OSRing. In the long term we may want to fix it differently. This fix covers the most common cases in benchmarks. Bug: chromium:987523 Change-Id: I1cfe82e6b9f95278b77c99b77d4b981828b5c0ab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1739373 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Tamer Tas authored
TBR=machenbach@chromium.org No-Try: True Change-Id: Ie0a94f97989a6f5a7e0b68c733035e3dac264215 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1743966Reviewed-by:
-
Simon Zünd authored
This CL adds an access check for the arguments to all calls to {console} like {console.log}. This is needed since the DevTools protocol notificiation event does not contain the context in which the {console.log} call occurred. Only the context of the argument. When DevTools then reads properties for the preview of the argument, it uses arguments context, instead of the calling context, potentially leaking objects/exceptions into the calling context. Bug: chromium:987502, chromium:986393 Change-Id: I6f7682f7bee94a28ac61994bad259bd003511c39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741664 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: -
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8400a89..c991845 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1b12368..a01c121 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/aa2db56..a110bf6 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/a45c24a..90a443f TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I12467c5b037ee1b6c757bc2f321d2af301928e1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1742747Reviewed-by:
-
- 07 Aug, 2019 8 commits
-
-
Gus Caplan authored
Each LHS expression that contains an optional chain of some form is wrapped in an OptionalChain node. This root node allows us to use a single jump location for every individual item in the chain, improving the performance and simplifying the implementation. Bug: v8:9553 Change-Id: I678563928b2dbfd6200bff55801919d4fd816962 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1723359 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
In instruction selector we were tagging as Compressed or Tagged Any when we could have been more specific. Also, we were marking as Word32 or Word64 when we should have been using CompressedSigned or TaggedSigned, respectively. Drive-by cleanup: Rename MarkAsReference to MarkAsTagged. Bug: v8:7703 Change-Id: I4df7a17e25cfa51a1e11eac0af40be21efb50990 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1739367Reviewed-by:
-
Eric Seckler authored
The previous ordering caused a SCOPED event to end after its parent event, which isn't really supported in the trace format. Change-Id: I2ddaa12596604499366854231506c889d910f951 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741926Reviewed-by:
-
Michael Achenbach authored
TBR=santa Change-Id: I05cdd74eea6f2b02158d6d9854f35a08b455edd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741656Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63117}
-
Ross McIlroy authored
Previous differences in eager and lazy parsing meant that it was possible that feedback vectors could be different for the same function depending on how it was compiled. These issues have now been fixed, so remove the workaround and add an explicit CHECK that the feedback vectors are the same. BUG=chromium:984344,v8:9511 Change-Id: I0edfa350b1a2f236db1ee2f86bc46690da926af1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741650 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This reverts commit 79b00555. Reason for revert: needs more discussion Original change's description: > [torque] introduce JSAny type for user-accessible JavaScript values > > This CL introduces a JSAny type for user-exposed JavaScript values and > a few new types to define it. Especially, it splits Symbol into > PrivateSymbol (not exposed) and PublicSymbol (JavaScript exposed > symbols). > > The change is mostly mechanical, but a few things are interesting: > - PropertyKey and JSPrimitive were designed to coincide with the spec > notions of IsPropertyKey() and primitive value, respectively. > - Since Name is an open type, we define AnyName to be the known > subtypes of Name. This is not too elegant, but by using AnyName > instead of Name, typeswitch can properly conclude something if a > subtype of Name is excluded. > > Small drive-by changes, which were necessary: > - Allow subtyping on label parameters. > - Fix the formatting of typeswitch, it was broken with union types > in case types. > > Bug: v8:7793 > Change-Id: I14b10507f8cf316ad85e048fe8d53d1df5e0bb13 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735322 > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63114} TBR=neis@chromium.org,jgruber@chromium.org,tebbi@chromium.org Change-Id: Ifde7881d74afe407628f40047997339d54cb2424 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7793 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741652Reviewed-by:
-
Tobias Tebbi authored
This CL introduces a JSAny type for user-exposed JavaScript values and a few new types to define it. Especially, it splits Symbol into PrivateSymbol (not exposed) and PublicSymbol (JavaScript exposed symbols). The change is mostly mechanical, but a few things are interesting: - PropertyKey and JSPrimitive were designed to coincide with the spec notions of IsPropertyKey() and primitive value, respectively. - Since Name is an open type, we define AnyName to be the known subtypes of Name. This is not too elegant, but by using AnyName instead of Name, typeswitch can properly conclude something if a subtype of Name is excluded. Small drive-by changes, which were necessary: - Allow subtyping on label parameters. - Fix the formatting of typeswitch, it was broken with union types in case types. Bug: v8:7793 Change-Id: I14b10507f8cf316ad85e048fe8d53d1df5e0bb13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735322 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Joyee Cheung authored
This patch stores the home objects in private methods that access super properties. Bug: v8:8330 Change-Id: I2507fda0bd70183f02d162ec50a5be76c248f0ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1724900Reviewed-by:
-
