- 01 Dec, 2017 8 commits
-
-
Clemens Hammacher authored
LiftoffRegister is an abstraction over Register and DoubleRegister. Many functions in Liftoff do not need to distinguish GP and FP registers. LiftoffRegister allows to implement most functions generically. Accessors allow to convert them back to Register or DoubleRegister. Both register types are represented in a unified index space, which allows to extend this concept to more register types and implement aliasing in a straight-forward manner. Many functions currently only implement the GP case. FP will be added later. R=titzer@chromium.org Bug: v8:6600 Change-Id: I043b787bc09dd1a06506ad515eb325b8ea19746d Reviewed-on: https://chromium-review.googlesource.com/793390Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49780}
-
Shiyu Zhang authored
In the special case of KeyedLoadIC, where the key is always undefined, LowerCheckEqualsInternalizedString fails and triggers deoptimization loops. It's because {exp}, which is undefined_string, does not match {val}, which is undefined_value. This patch drops the convertion from undefined_value to undefined_string for undefined key in KeyedLoadIC. It makes undefined key be able to pass LowerCheckEqualsInternalizedString and avoids the deoptimization loops. Bug: Change-Id: Ie15358e705490fb2e4907f4d37a3ef7921f74844 Reviewed-on: https://chromium-review.googlesource.com/789613 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#49779}
-
Camillo Bruni authored
This CL introduces a Context::kInvalidContext sentinel value to make clear that no context is active. We silently accept smi 0 (= nullptr) as a non-set context which usually was the default value making it hard to ensure whether this happened on purpose or not. Change-Id: I5c35616f26b0b64c1cd976563a6eeb0ce474927d Reviewed-on: https://chromium-review.googlesource.com/790291Reviewed-by:
-
Georg Neis authored
Bug: v8:6791 Change-Id: I1c57fc697dc143fec8bfd67db16c7bc4f840462d Reviewed-on: https://chromium-review.googlesource.com/800620 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49777}
-
Georg Neis authored
It reflects the semantics of ToBoolean, so it must be adapted for bigints. Bug: v8:6791 Change-Id: I18931df21528463dacf5ad50fa8264b1c968c6b5 Reviewed-on: https://chromium-review.googlesource.com/799831Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/64dd7ca..a7ac13d Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/505de88..282996b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/9968f9b..280aff0 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I906b25bd37386e64137a37a0706ca2b0103a0143 Reviewed-on: https://chromium-review.googlesource.com/803034Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#49775}
-
jing.bao authored
Bug: Change-Id: I0868da7ee73f1c7637d9c79b6c78f27557cd14a4 Reviewed-on: https://chromium-review.googlesource.com/792653Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Jing Bao <jing.bao@intel.com> Cr-Commit-Position: refs/heads/master@{#49774}
-
Jakob Kummerow authored
Bug: v8:6791 Change-Id: I976876a4956b5c65f6f3788389f42d394d08dc99 Reviewed-on: https://chromium-review.googlesource.com/788513 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49773}
-
- 30 Nov, 2017 32 commits
-
-
Alexey Kozyatinskiy authored
R=pfeldman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9005cd355f05143daeb125d851d18ff2c0924256 Reviewed-on: https://chromium-review.googlesource.com/801338Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49772}
-
Michal Majewski authored
TBR=jgruber@chromium.org Bug: v8:7120 Change-Id: I50b852a4526103d56b3a2c60c4a88b5ecaecf9bb Reviewed-on: https://chromium-review.googlesource.com/801270 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49771}
-
Michael Achenbach authored
This reverts commit e42e7fc8. Reason for revert: Speculative revert for: https://crbug.com/v8/7149 Original change's description: > [objects] No longer create short external strings. > > This fixes String::MakeExternal() to bail out if the subject string > doesn't fit a regular ExternalString, instead of creating a short > external string. The observation here is that for short external strings > the overhead of having to have the StringResource plus going to the > runtime/C++ for each and every character access from JavaScript land > is probably bigger than the anticipated benefits. > > If this turns out to be wrong and there's a real benefit, we should make > use of ThinStrings instead of having a separate way to represent > external strings. > > Bug: v8:6621, v8:7109, v8:7145 > Change-Id: I4b75da08b82a72027c782a69de9c8eaf3cca1d4d > Reviewed-on: https://chromium-review.googlesource.com/799750 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49735} TBR=yangguo@chromium.org,bmeurer@chromium.org Change-Id: I3f5cfa9ab5c99ddce1d61ede9ed9515cb3936cdd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6621, v8:7109, v8:7145, v8:7149 Reviewed-on: https://chromium-review.googlesource.com/801675Reviewed-by:
-
Ulan Degenbaev authored
This save ~40KB of code size in release mode. Bug: Change-Id: Ibdf7e64bb2592f53a4edf07665016dd5a65714a0 Reviewed-on: https://chromium-review.googlesource.com/801515Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49769}
-
Clemens Hammacher authored
This reverts commit 163c1c82. Reason for revert: Throws std::bad_alloc on linux: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/21927; needs investigation. Original change's description: > [wasm] Gracefully handle malformed custom sections in WebAssembly.Module.customSections(). > > R=clemensh@chromium.org > BUG=chromium:789952 > > Change-Id: Ida627fa6cdeacff01a0ec4d20e58281f17528010 > Reviewed-on: https://chromium-review.googlesource.com/800941 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49767} TBR=titzer@chromium.org,clemensh@chromium.org Change-Id: I63fbd8f55025f53c453e91d0f7a181c21ae53a39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:789952 Reviewed-on: https://chromium-review.googlesource.com/801554Reviewed-by:
-
Ben L. Titzer authored
R=clemensh@chromium.org BUG=chromium:789952 Change-Id: Ida627fa6cdeacff01a0ec4d20e58281f17528010 Reviewed-on: https://chromium-review.googlesource.com/800941Reviewed-by:
-
Ulan Degenbaev authored
This fixes false positive data race reported by TSAN. Bug: chromium:790004 Change-Id: I6335af1735fe9ea77a26cc9919ec4f089b004cdf Reviewed-on: https://chromium-review.googlesource.com/800936Reviewed-by:
-
Michael Lippautz authored
This reverts commit b4d2f3eb. Bug: chromium:651354, chromium:788113 Change-Id: I04b7541e7eb69f737d45e90bbfec591cf8f8190f Reviewed-on: https://chromium-review.googlesource.com/800552Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49765}
-
Camillo Bruni authored
Bug: chromium:757467 Change-Id: I52f8100e0c8b4ac07e1f875e44cb468fa8ce572b Reviewed-on: https://chromium-review.googlesource.com/793611Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Ali Ijaz Sheikh authored
(Previously landed as #48513 / e770879e) (Previously landed as #48606 / d0e3fb4f) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Bug: Change-Id: I302fb52fb47b6c9d59dd2b28eb9923c37881c15b Reviewed-on: https://chromium-review.googlesource.com/794857Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: Change-Id: I90c124253a9e307f914d889406965ada4c5ba404 Reviewed-on: https://chromium-review.googlesource.com/800070Reviewed-by:
-
Georg Neis authored
In my previous typer changes I had forgotten to remove one line. R=jarin@chromium.org Bug: Change-Id: If9e9984c23273707548c2d7329f9fa715a170a90 Reviewed-on: https://chromium-review.googlesource.com/800270Reviewed-by:
-
Michael Starzinger authored
R=cbruni@chromium.org BUG=v8:7109 Cq-Include-Trybots: master.tryserver.v8:v8_linux_noi18n_rel_ng Change-Id: I076b5b7760a454680de0e4247eb625a964905652 Reviewed-on: https://chromium-review.googlesource.com/796431Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49760}
-
Georgia Kouveli authored
Even though a previous patch made the number of slots pushed/claimed on the stack aligned, the boundary between frames was not a multiple of two slots as well. We were pushing the number of arguments (which belongs in the ArgumentAdaptor frame) together with the arguments to pass to the callee (which belong to the frame of the callee). Those need to be separated so we can drop the arguments without messing up the alignment. Bug: v8:6644 Change-Id: I259c58db33a7c2726e5a3c74bcd67496f607d1d0 Reviewed-on: https://chromium-review.googlesource.com/793047Reviewed-by:
-
Jeremy Roman authored
This is always equal to isolate_ (so getting it from the isolate is totally free), and this makes the code slightly smaller while avoiding a few loads and stores here and there. Change-Id: Ib648cd0a1f6ea7cbb73a0188ec92cd091ce34792 Reviewed-on: https://chromium-review.googlesource.com/794046Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#49758}
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:7109 Change-Id: Id5e5c653136dd0cb5d8dcd2cf61d7941ec7ff61b Reviewed-on: https://chromium-review.googlesource.com/800075Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49757}
-
Michal Majewski authored
This is a reland of 98cc9e86 Original change's description: > [test] Creating command before execution phase. > > Immutable command class with shell, flags and > environment. > > Command creation moved from worker to the main > process. Because of that there is no need to send > test cases beyond process boundaries and load test > suites in worker processes. > > Bug: v8:6917 > Change-Id: Ib6a44278095b4f7141eb9b96802fe3e8117678a6 > Reviewed-on: https://chromium-review.googlesource.com/791710 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49746} Bug: v8:6917 Change-Id: I49c29a8db813c47909f2cc45070ac7721a447c7a Reviewed-on: https://chromium-review.googlesource.com/800370Reviewed-by:
-
Michael Achenbach authored
This reverts commit 6b29f1cf. Reason for revert: Breaks many bots. Please no notry: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20verify%20csa/builds/4512 Original change's description: > [heap] Minor MC: Support ThinString > > No-try: true > Bug: chromium:651354, chromium:788113 > Change-Id: I53cc2f04974671982371d1c26c71bd559450a5aa > Reviewed-on: https://chromium-review.googlesource.com/800176 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49752} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I0a5f47f144ae9c8d2ba279243124fa10ec99e165 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:651354, chromium:788113 Reviewed-on: https://chromium-review.googlesource.com/800491Reviewed-by:
-
Jakob Gruber authored
This reverts commit 6b29f1cf. Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/21671 Original change's description: > [heap] Minor MC: Support ThinString > > No-try: true > Bug: chromium:651354, chromium:788113 > Change-Id: I53cc2f04974671982371d1c26c71bd559450a5aa > Reviewed-on: https://chromium-review.googlesource.com/800176 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49752} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I6268c5c090377cb97a3e8cdf1bb4b19b3c6876da No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:651354, chromium:788113 Reviewed-on: https://chromium-review.googlesource.com/800610Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49754}
-
Clemens Hammacher authored
Using the "jco" gdb macro on a WasmCode address would currently crash. With this change, you can also use it to print code objects off the gc heap. R=titzer@chromium.org CC=wasm-team@google.com Bug: v8:7140, v8:6876 Change-Id: I21daf58b6b4734e3d052b66284b95938b4f57d40 Reviewed-on: https://chromium-review.googlesource.com/796416Reviewed-by:
-
Michael Lippautz authored
No-try: true Bug: chromium:651354, chromium:788113 Change-Id: I53cc2f04974671982371d1c26c71bd559450a5aa Reviewed-on: https://chromium-review.googlesource.com/800176Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49752}
-
Michael Lippautz authored
No-try: true Bug: chromium:651354, chromium:788113 Change-Id: Iff2051751c4688c307e8f23ddd08de203974e842 Reviewed-on: https://chromium-review.googlesource.com/800272Reviewed-by:
-
Michael Hablich authored
TBR=machenbach@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I9d074745843b550603c0b68f2b397a121a494504 Reviewed-on: https://chromium-review.googlesource.com/800173 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#49750}
-
Ulan Degenbaev authored
Bug: chromium:758183 Change-Id: If43122140626207e3f972ccb7d048e012db3ed02 Reviewed-on: https://chromium-review.googlesource.com/796771 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Michael Lippautz authored
No-try: true Bug: chromium:651354, chromium:788113 Change-Id: I8955b322b826c0a59f85c32bb2c1ec8c9d4e0761 Reviewed-on: https://chromium-review.googlesource.com/800330Reviewed-by:
-
Michael Achenbach authored
This reverts commit 98cc9e86. Reason for revert: Breaks test isolation: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/builds/29746 Original change's description: > [test] Creating command before execution phase. > > Immutable command class with shell, flags and > environment. > > Command creation moved from worker to the main > process. Because of that there is no need to send > test cases beyond process boundaries and load test > suites in worker processes. > > Bug: v8:6917 > Change-Id: Ib6a44278095b4f7141eb9b96802fe3e8117678a6 > Reviewed-on: https://chromium-review.googlesource.com/791710 > Commit-Queue: Michał Majewski <majeski@google.com> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49746} TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com Change-Id: I44b99468d18fd093833f4185dad067a9eeaf2bc1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Reviewed-on: https://chromium-review.googlesource.com/800292Reviewed-by:
-
Michal Majewski authored
Immutable command class with shell, flags and environment. Command creation moved from worker to the main process. Because of that there is no need to send test cases beyond process boundaries and load test suites in worker processes. Bug: v8:6917 Change-Id: Ib6a44278095b4f7141eb9b96802fe3e8117678a6 Reviewed-on: https://chromium-review.googlesource.com/791710 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:775123 Change-Id: I8ca24e48c978b754b8cf9d455ae9314d730104c3 Reviewed-on: https://chromium-review.googlesource.com/800071Reviewed-by:
-
Benedikt Meurer authored
Finally address that long-standing TODO where ConsString allocation in TurboFan would always go for the two byte map instead of choosing the one byte map if the inputs are one byte strings. Bug: v8:5269, v8:7109 Change-Id: Ibcfceaf499ceebef0ef928ebc5f204bcacf29bc0 Reviewed-on: https://chromium-review.googlesource.com/799700Reviewed-by:
-
Ulan Degenbaev authored
Currently RuntimeCallStats stores CounterIds as inner pointers. This patch replaces them with enums and removes static table. Bug: chromium:758183 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Icb4030fc3ad3dd02e9c2648ce7c43b6f2d47fa9d Reviewed-on: https://chromium-review.googlesource.com/796477Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#49743}
-
Andreas Haas authored
This CL fixes an issue with --enable-tracing which was introduced recently where the tracing file was closed too early. In addition it adds a test for --enable-tracing to avoid such an issue in the future. R=machenbach@chromium.org, rmcilroy@chromium.org Change-Id: I1b3699a4dfbe27230ac1d21d5f6bc7b2ee9ed435 Reviewed-on: https://chromium-review.googlesource.com/796214Reviewed-by:
-
Michael Achenbach authored
This derives two global variables to ease adding new variants. Bug: chromium:788104 Change-Id: Ibe933dc0999f6dfa0ae8bf2afa0a5de8e44aefca Reviewed-on: https://chromium-review.googlesource.com/799790 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49741}
-
