- 31 May, 2018 11 commits
-
-
Sergiy Byelozyorov authored
This reverts commit 003159e7. Reason for revert: breaks roll into Chromium: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_headless_rel/3140 Original change's description: > [inspector] RemoteObject.description should be empty for primitive type > > We currently report description field for numbers. On client side user > can calculate description as remoteObject.unserializableValue || > (remoteObject.value + ''). Let's report description only for objects to > simplify value -> remoteObject logic a bit. > > R=dgozman@chromium.org > TBR=jgruber@chromium.org > > Bug: chromium:595206 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I91356a44aa3024e20c8f966869abf4a41b88e4bc > Reviewed-on: https://chromium-review.googlesource.com/737485 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53453} TBR=dgozman@chromium.org,pfeldman@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifc184e1ac158d9ea7034922a7250444448fac49f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:595206 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1081207Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#53461}
-
Bill Budge authored
- Adds v/pshufhw, v/palignr instructions to assembler and macro-assembler. - Uses better instruction sequences for 32x4 shuffles using half- shuffles and blends. - Uses better instruction sequences for 16x8 shuffles. - Uses better instruction sequences for concatenating 8x16 shuffles. Change-Id: I3e6dca2937a2b167c754c47331c3a2f8ab9786db Reviewed-on: https://chromium-review.googlesource.com/1066986 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#53460}
-
Alexey Kozyatinskiy authored
This is another step to remove a huge amount of legacy code from v8. R=dgozman@chromium.org Bug: v8:5530 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I634bda41c53a49dc4912291eb52f02847f56f4f3 Reviewed-on: https://chromium-review.googlesource.com/1080398Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#53459}
-
Dan Elphick authored
Removes all explicit calls to GetIsolate() in runtime/ by passing it through calling functions. Bug: v8:7786 Change-Id: I6485827ea3ef9b215ca487b1f823c9f585f31f98 Reviewed-on: https://chromium-review.googlesource.com/1080747Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#53458}
-
Dan Elphick authored
Removes all explicit calls to GetIsolate() in runtime/ by passing it through calling function functions and implicit calls via the single argument Handle constructor and handle function. Bug: v8:7786 Change-Id: I96ac2289a72a42c7abb6754418fecb8e03f2bb29 Reviewed-on: https://chromium-review.googlesource.com/1080528 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Dan Elphick authored
Removes all explicit calls to GetIsolate() in builtins/ by passing it through from calling functions and implicit calls via the Handle constructor. Bug: v8:7786 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I32e1cdee47075742e677a5f738a33ad30be515c6 Reviewed-on: https://chromium-review.googlesource.com/1079548Reviewed-by:
-
Predrag Rudic authored
Tests that pointed out error are cctest/test-code-generator/FuzzAssembleMove and cctest/test-multiple-return/ReturnLastValueFloat32 on big endian architecture. Change-Id: I47eb5d3b3aeffef4531f7961e94c0ccd7dece191 Reviewed-on: https://chromium-review.googlesource.com/1078755Reviewed-by:
Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com> Cr-Commit-Position: refs/heads/master@{#53455}
-
Dan Elphick authored
Explicitly use the isolate form of the Handle constructor and handle function in bootstrapper.cc Bug: v8:7786 Change-Id: I0c29d5951ca61b70f4a820f102d3da55944fbe3d Reviewed-on: https://chromium-review.googlesource.com/1080508Reviewed-by:
-
Alexey Kozyatinskiy authored
We currently report description field for numbers. On client side user can calculate description as remoteObject.unserializableValue || (remoteObject.value + ''). Let's report description only for objects to simplify value -> remoteObject logic a bit. R=dgozman@chromium.org TBR=jgruber@chromium.org Bug: chromium:595206 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I91356a44aa3024e20c8f966869abf4a41b88e4bc Reviewed-on: https://chromium-review.googlesource.com/737485 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#53453}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/10a93c2..a429f60 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8fbdf9f..517100c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I3da4d9e5880c5b82c0a6fe27acb6339b811e1626 Reviewed-on: https://chromium-review.googlesource.com/1080250Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#53452}
-
Alexey Kozyatinskiy authored
If async function A awaited async function B, stepOut from function B should go to function A. Bug: v8:7753 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iedc1d8b85a52aa60519e56b319325436fc2168c9 Reviewed-on: https://chromium-review.googlesource.com/1054618 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
- 30 May, 2018 20 commits
-
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: v8:6170,v8:6171 Change-Id: I1f3eb7fbe1c2a9347428ce9742f22826035be52d Reviewed-on: https://chromium-review.googlesource.com/1080046Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#53450}
-
Alexei Filippov authored
Do not create a CPU profiler for each isolate implicitly. BUG=v8:7070 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I6ddd93c58f56591477d8fe4249103a74b7698904 Reviewed-on: https://chromium-review.googlesource.com/1043449 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Ben Smith authored
This was renamed recently in the spec. Change-Id: I825e47e8b4113ddb2c3356ee8e7663705ba65e1c Reviewed-on: https://chromium-review.googlesource.com/1079851Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#53448}
-
Leszek Swirski authored
Compress the parameter count (and function length) stored in SharedFunctionInfo to a uint16_t. This limits us to 2^16 - 1 parameters per function, minus one for the "don't adapt arguments" sentinel value, which is one fewer than Code::kMaxArguments was already. Anyway, 65534 arguments should be enough for anyone! This drops SFI size by 4 bytes. Bug: chromium:818642 Change-Id: I126bfb24453dcdc5087a104d3a12cf195a56fa9f Reviewed-on: https://chromium-review.googlesource.com/1076627 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#53447}
-
Alexey Kozyatinskiy authored
We use name of the function at the moment of first appearance of given function in stack trace. Any further name changes would be ignored. It gives us around 20% speedup. Perf analysis: https://bit.ly/2wp99vt R=yangguo@chromium.org,jgruber@chromium.org Bug: v8:7078 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9f21f0bd9cd923e5abaeffb9209df0be2f49afff Reviewed-on: https://chromium-review.googlesource.com/1050984 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Alexey Kozyatinskiy authored
New intstrumentation consists of: - kAsyncFunctionSuspended when async function is suspended on await (called on each await), - kAsyncFunctionFinished when async function is finished. Old instrumentation was based on reusing async function promise. Using this promise produces couple side effects: - for any promise instrumentation we first need to check if it is special case for async function promise or not - it requires expensive reading from promise object. - we capture stack for async functions even if it does not contain awaits. - we do not properly cancel async task created for async function. New intsrumntation resolved all these problems as well as provide clear mapping between async task and generator which we can use later to fetch scope information for async functions on pause. R=dgozman@chromium.org,yangguo@chromium.org Bug: v8:7078 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifdcec947d91e6e3d4d5f9029bc080a19b8e23d41 Reviewed-on: https://chromium-review.googlesource.com/1043096Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
In Torque, we have several global singleton classes. Using the contextual variable pattern instead of passing around pointers in random places makes the code more readable. This CL does this for TypeOracle, we plan to do it for more classes in the future. Bug: v8:7754 Change-Id: Ib744b476ce51a4932c52274b2210149515f1663d Reviewed-on: https://chromium-review.googlesource.com/1078729 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#53444}
-
Junliang Yan authored
GCC 5.4 complains type mismatch as follows: ../../v8/src/contexts.cc:302:34: error: format '%hhu' expects argument of type 'int', but argument 3 has type 'v8::internal::VariableMode' [-Werror=format=] Bug: chromium:841460 Change-Id: Id90c1211f459309e477a8ad5658cecdf9cc10938 Reviewed-on: https://chromium-review.googlesource.com/1077051Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53443}
-
Pierre Langlois authored
The MathPowInternal builtin is now only called directly from the code-generator. Also, this patch takes the opportunity to cleanup the builtin for arm and arm64 a little. Change-Id: If53edcecd42b227ef74ee817bc5d7fbbcea8b0e2 Reviewed-on: https://chromium-review.googlesource.com/1076127Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#53442}
-
jgruber authored
Bug: v8:7754 Change-Id: I89d655129a860cd5f5d1d62600ab2df43d406974 Reviewed-on: https://chromium-review.googlesource.com/1078735Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53441}
-
Jaroslav Sevcik authored
Lowers JS calls to direct code object calls for known TFJ builtins. Bug: v8:7794 Change-Id: I68984eeeff799cae4b87e6ae6720228e90340200 Reviewed-on: https://chromium-review.googlesource.com/1078287Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#53440}
-
Alexey Kozyatinskiy authored
With this CL we use interrupt for pause in two cases: - when we process Debugger.pause on interruption, - when we would like to break as soon as possible after OOM. In all other cases, e.g. for async step into we use break on function call by calling StepIn debugger action. In mentioned cases we should not actually use interrupt as well: - Debugger.pause in this case scheduled using interrupt and we may just break right now without requesting another interrupt, unfortunately blink side is not ready, - we should use more reliable way to break right after near OOM callback, otherwise we can get this callback, increase limit, request break on next interrupt, before interrupt get another huge memory allocation and crash. There are couple advantages: - we get much better break locations for async stepping (see inspector tests expectations), - we can remove DEBUG_BREAK interruption (it should speedup blackboxing with async tasks, see removed todo in debug.cc for details) - it is required preparation step for async step out, (see https://chromium-review.googlesource.com/c/v8/v8/+/1054618) Bug: v8:7753 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iabd7627dbffa9a0eab1736064caf589d02591926 Reviewed-on: https://chromium-review.googlesource.com/1054155 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Add missing parameters to createSuiteWithWarmup Change-Id: I8865f162443b43b8b7bee4680e17c34d397f8d53 Reviewed-on: https://chromium-review.googlesource.com/1078747 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: Ide6440933d81fa82dd69d9eade9f289880ec0cb2 Reviewed-on: https://chromium-review.googlesource.com/1078308 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Type users of AllocateFixedArray with intptr parameters. Bug: v8:7796 Change-Id: I4b155fb3fcb90fe66a3c20a24f0cea678a5d85bc Reviewed-on: https://chromium-review.googlesource.com/1078347 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=jgruber@chromium.org Change-Id: I9925ded8cee5c620f543171b2f93abb1f954e72e Reviewed-on: https://chromium-review.googlesource.com/1078438Reviewed-by:
-
jgruber authored
https://crrev.com/c/1075047 introduced a bug on mips/mips64 in which sp and fp offsets were set incorrectly for INTERNAL frames. Bug: v8:6666,chromium:847728,chromium:847568 Change-Id: I9a48d30a82f10a4af50f1ed4dc1d77e8defbdd77 Reviewed-on: https://chromium-review.googlesource.com/1078109 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#53434}
-
Ben L. Titzer authored
Extends the functionality of Managed<T> to track an estimated size for the external memory associated with an instance of Managed<T> in order to allow for proper accounting in the garbage collector. R=mstarzinger@chromium.org CC=ulan@chromium.org Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I8c49c6245eaf267c9264ebb93b43d5dfbf4671fd Reviewed-on: https://chromium-review.googlesource.com/1076332 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
jgruber authored
This extends the ScriptCompiler::CompileModule function with a CompileOptions argument. Accepted values are kNoCompileOptions (in which case, behavior remains unmodified) and kConsumeCodeCache. If the latter is passed, we try to fetch the given module from the code cache. Since it is possible to compile the same source code as both a script and a module (and different code is generated for the two cases), a new is_module bit is added to the SerializedCodeData header to disambiguate between the two cases. Bug: v8:7685 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I34b3642505577ed9ed0caedbee5876308c5a53ea Reviewed-on: https://chromium-review.googlesource.com/1073327 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/39cffda..10a93c2 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0043a4a..8fbdf9f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f16fdf3..cf4aced TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I3057ec6ca493b4b901ff47fd037ccab2350f5b0e Reviewed-on: https://chromium-review.googlesource.com/1077847Reviewed-by:
-
- 29 May, 2018 9 commits
-
-
Daniel Bratell authored
builtins_util.h declares a macro named CHECK_RECEIVER and in some extreme jumbo build configurations, that macro will end up in the same translation unit as runtime-dataview.cc Bug: v8:7792 Change-Id: I6db865b6061afd6bf1c74b3a172485d68c749929 Reviewed-on: https://chromium-review.googlesource.com/1075052 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#53430}
-
Anna Henningsen authored
Document what pieces of data the global `FutexEmulation::mutex_` mutex protects from concurrent access, and reduce the scope in which said mutex is locked during `FutexEmulation::Wait()` to match that description more closely. Change-Id: I0764efabac06814d83ed5c4af4eb7da34af47cab Reviewed-on: https://chromium-review.googlesource.com/1074689 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#53429}
-
Andreas Haas authored
This CL fixes a bad interleaving that can happen between the CompilationState and streaming compilation. In that particular interleaving, streaming compilation tries to restart compilation tasks after compilation failed already, which fails with a check in the CancelableTaskManager. The problem is the following: The CompilationState notifies the streaming decoder of compilation errors. After receiving the notification, the streaming decoder ignores all subsequent incoming bytes. However, the CompilationState does not notify the streaming decoder directly, it posts a task which will notify the streaming decoder. This means that between the failing of compilation and the notification of the streaming decoder there is a time window in which compilation already failed but the streaming decoder can still restart compilation tasks. The crash happened when this time window was hit. With this CL we check that compilation did not fail before we restart compilation tasks. I was never able to reproduce this crash, so I don't really know if this particular issue caused the crash. R=titzer@chromium.org Bug: chromium:840713 Change-Id: Ic522b1c21a7d7749c1e7f6097aa450a09fb271cc Reviewed-on: https://chromium-review.googlesource.com/1075787Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53428}
-
Junliang Yan authored
Port 75763183 Original Commit Message: The code slot of internal frames seems to be basically unused. As always, there are exceptions: 1. In elements.cc we check whether the current code object is the apply builtin. We can use a heap lookup through the frame's pc instead. 2. In isolate.cc we store a reference to the frame's code object to try and pack it into the minidump. This can safely be skipped. Remaining use-sites in frames.cc all skip INTERNAL frames by using the JavaScriptFrameIterator. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I3612b206f25b9e53645d2e1bc726a5e318a1f4be Reviewed-on: https://chromium-review.googlesource.com/1076505Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53427}
-
Junliang Yan authored
Port b2abe2cf Original Commit Message: This makes the WasmCompileLazy builtin push a new WASM_COMPILE_LAZY frame type. We can thereby remove the workaround to return a relocated instance from the underlying runtime function. It also removes the last remaining embedded code objects from {WasmCode} objects. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Icdc1ee06a1fade4bb805ae0fadf8219316731cd7 Reviewed-on: https://chromium-review.googlesource.com/1076529Reviewed-by:
-
Eric Holk authored
This is no longer needed now that Wasm is more aggressive about collecting old memories. It also causes problems with the upcoming trap handler fallback path. Change-Id: I4b8513c28e0c0d7c6b232d399c1d97b645499ef1 Reviewed-on: https://chromium-review.googlesource.com/1043277Reviewed-by:
-
Vincent Belliard authored
Bug: v8:6600 Change-Id: I8662ac3589a6244565402c748624ea03d3e31960 Reviewed-on: https://chromium-review.googlesource.com/1071719Reviewed-by:
-
Junliang Yan authored
Port 0a373f8a Original Commit Message: This is the initial step towards moving all array constructor stubs to builtins. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I3b46a3bd91780c2be938f710ceb18a7a8cd1824e Reviewed-on: https://chromium-review.googlesource.com/1076595Reviewed-by:
-
Andreas Haas authored
This CL switches to the new taskrunner API in the MemoryReducer. We want to remove the old API eventually so that there is only one API for task posting. R=ulan@chromium.org CC=gab@chromium.org Change-Id: I1dd16e42dc0fca013a97c76dfce9c6479b97521b Reviewed-on: https://chromium-review.googlesource.com/1061531Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53422}
-
