1. 13 Mar, 2017 1 commit
  2. 16 Nov, 2016 1 commit
    • jgruber's avatar
      [debug-wrapper] Further extend the debug wrapper · b06c4ce5
      jgruber authored
      This CL further extends the debug wrapper, migrates around 60 tests, and
      removes a few tests that use functionality we will not support anymore.
      
      In more detail:
      
      * Removed tests that use:
        * enable/disable individual breakpoints
        * invocationText()
        * the ScriptCollected event
        * showBreakPoints
        * evalFromScript (and similar)
        * mirror.constructedBy and mirror.referencedBy
        * event_data.promise()
      * Some frame.evaluate uses were adapted since due to differences between
        remote objects (inspector) and mirrors. For instance, exceptions are
        currently not recreated exactly, since the inspector protocol does not
        give us the stack and message separately. Other objects (such as
        'this' in debug-evaluate-receiver-before-super) need to be explicitly
        converted to a string before the test works correctly.
      * Ensure that inspector stores the script before sending ScriptParsed and
        ScriptFailedToParse events in order to be able to use the script from
        within those events.
      * Better remote object reconstruction (e.g. for undefined and arrays).
      * New functionality in wrapper:
        * debuggerFlags().breakPointsActive.setValue()
        * scripts()
        * execState.setVariableValue()
        * execState.scopeObject().value()
        * execState.scopeObject().property()
        * execState.frame().allScopes()
        * eventData.exception()
        * eventData.script()
        * setBreakPointsActive()
      
      BUG=v8:5530
      
      Review-Url: https://codereview.chromium.org/2497973002
      Cr-Commit-Position: refs/heads/master@{#41019}
      b06c4ce5
  3. 07 Nov, 2016 1 commit
    • jgruber's avatar
      [debugger] Further stepping support in test wrapper · ea48d094
      jgruber authored
      This CL adds further support to the test wrapper. We are now able to
      run almost all mjsunit/debug-step-* tests using the inspector backend.
      
      debug-stepframe-* tests are not yet supported since inspector does not
      know a 'frame' step type.
      
      The interface has also been improved to be able to move these tests to
      inspector mostly without modification.
      
      BUG=v8:5330
      
      Review-Url: https://codereview.chromium.org/2466273005
      Cr-Commit-Position: refs/heads/master@{#40800}
      ea48d094
  4. 28 Oct, 2016 1 commit
    • jgruber's avatar
      [debugger] Various break-related functionality in test wrapper · 83b560b0
      jgruber authored
      This CL adds simple implementation of break and stepping-related functionality
      as required by the debug-step.js test. This includes
      
      * stepOver, stepInto, stepOut
      * setBreakPoint
      * clearBreakPoint
      * evaluate
      
      Some of these, e.g. setBreakPoint are not fully implemented for all cases but
      only for the ones we need right now.
      
      One interesting result of this is that using the inspector protocol is roughly
      14x slower for debug-step.js (14s instead of 0.5s). One cause of this seems to
      be iteration over all object properties in toProtocolValue, which is used to
      serialize JS objects before being sent over the wire (e.g. FrameMirrors).  This
      is something that should be fixed at some point. In the meantime, the test now
      runs 100 instead of 1000 iterations.
      
      BUG=v8:5530
      
      Review-Url: https://codereview.chromium.org/2447073007
      Cr-Commit-Position: refs/heads/master@{#40636}
      83b560b0