- 30 Jul, 2018 8 commits
-
-
Jaroslav Sevcik authored
This CL introduces InstanceTypeChecker namespace with type checkers for types used by the optimizing compiler. The type checkers are global functions. Examples: bool InstanceTypeChecker::IsJSFunction(InstanceType); bool InstanceTypeChecker::IsAllocationSite(InstanceType); The CL also uses these type checkers in the HeapObject::IsXXXX() functions to ensure consistency. Bug: v8:7790 Change-Id: I7eb9e79ca28da02fd489201f532e566d0d13243a Reviewed-on: https://chromium-review.googlesource.com/1154529Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54782}
-
Michael Lippautz authored
Bug: v8:7490 Change-Id: I6bed10a6389d83b1941ba894f06b2d9540e84139 Reviewed-on: https://chromium-review.googlesource.com/1152733Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54781}
-
Peter Marshall authored
Fixes: src/map-updater.h src/objects/property-descriptor-object.h src/objects/prototype-info-inl.h src/objects/regexp-match-info.h src/objects/shared-function-info-inl.h Bug: v8:7754,v8:7490,v8:7965 Change-Id: I7ae9dc86491c8e147d628f5fd8362534e861b15e Reviewed-on: https://chromium-review.googlesource.com/1154221Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54780}
-
Peter Marshall authored
Bug: v8:7754,v8:7490,v8:7965 Change-Id: I574dbade6dc21204461be4d83b138f7341016305 Reviewed-on: https://chromium-review.googlesource.com/1152819Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#54779}
-
Marja Hölttä authored
This reverts commit 13401d2b. Reason for revert: gc stress breakage Original change's description: > [in-place weak refs] Use WeakArrayList in wasm > > Now we can remove FixedArrayOfWeakCells (this was the last user). > > BUG=v8:7308 > > Change-Id: I7b74f7833288b20d8f4d098a4afce640ea6db823 > Reviewed-on: https://chromium-review.googlesource.com/1150170 > Commit-Queue: Marja Hölttä <marja@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54776} TBR=marja@chromium.org,mlippautz@chromium.org,ahaas@chromium.org Change-Id: I1bc1ad7e27813aeaaf191efdf74b865d676475f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1154787Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54778}
-
jgruber authored
When disassembling code (in particular embedded builtins), try to print better information about root-relative accesses. For example: REX.W movq rdx,[r13+0x548] REX.W movq rax,[r13+0x10a8] turns into REX.W movq rdx,[r13+0x548] (root (0x1ff420d0ccd9 <FixedArray[1672]>)) REX.W movq rax,[r13+0x10a8] (external reference (check_object_type)) This is a band-aid solution until we come up with something better. It does not understand multi-instruction sequences (such as loads from the builtins constants table), assumes every kRootRegister-relative access is actually root-relative (i.e. the register is not initialized to some other value), and is limited to a particular instruction pattern. Bug: v8:6666,v8:7969 Change-Id: I35af92e8233c9bb0f2ad6ba0e86bd0ab69177205 Reviewed-on: https://chromium-review.googlesource.com/1146806 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Marja Hölttä authored
Now we can remove FixedArrayOfWeakCells (this was the last user). BUG=v8:7308 Change-Id: I7b74f7833288b20d8f4d098a4afce640ea6db823 Reviewed-on: https://chromium-review.googlesource.com/1150170 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54776}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b222950..b668f37 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/f30572c..e26243c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I782a848d130ee7bc6f8ecd4553dd21dcbedeafd6 Reviewed-on: https://chromium-review.googlesource.com/1154628Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54775}
-
- 29 Jul, 2018 2 commits
-
-
Jungshik Shin authored
This reverts commit c83fae06. Reason for revert: the CL that required the revert of this CL was relanded. https://chromium-review.googlesource.com/c/v8/v8/+/1154247 Original change's description: > Revert "[Intl] Move Number.toLocaleString from js to c++" > > This reverts commit a895f01a. > > Reason for revert: Needed for other revert: > https://chromium-review.googlesource.com/c/v8/v8/+/1152767 > > Original change's description: > > [Intl] Move Number.toLocaleString from js to c++ > > > > > > Bug: v8:7960 > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > > Change-Id: I21a524b620e210cce625a1a00e68c0b687187087 > > Reviewed-on: https://chromium-review.googlesource.com/1144659 > > Commit-Queue: Frank Tang <ftang@chromium.org> > > Reviewed-by: Jungshik Shin <jshin@chromium.org> > > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#54741} > > TBR=jshin@chromium.org,gsathya@chromium.org,bstell.chromium.org@gmail.com,ftang@chromium.org > > Change-Id: I060fa2834dde5e1b4cc71923cc066d97bce2a33b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:7960 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Reviewed-on: https://chromium-review.googlesource.com/1152787 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54746} TBR=machenbach@chromium.org,jshin@chromium.org,gsathya@chromium.org,bstell.chromium.org@gmail.com,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7960 Change-Id: I7a7a67db77b9b5a181f1751a03186eb7e8b271a0 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1154248 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54774}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/79a29b1..b222950 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1e61f60..e05f902 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I62a3628dd0b3ce06b48813111a194c00a55705dd Reviewed-on: https://chromium-review.googlesource.com/1154433 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
- 28 Jul, 2018 9 commits
-
-
Frank Tang authored
This is a reland of 51ad234f With a manual layout rebaseline of js/fast/string-prototype-properties [1], this CL can be relanded without breaking the layout test. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1154289 also marks the test for skipping until this fix is rolled to Chromium. Original change's description: > [Intl] move localeCompare to C++ > > > Bug: v8:7958 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I84a27dda5205c8581a7ffe37213d685cc49974fa > Reviewed-on: https://chromium-review.googlesource.com/1144644 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54740} TBR=ftang@chromium.org, gsathya@chromium.org Bug: v8:7958 Test: layout test: js/fast/string-prototype-properties Change-Id: Ic546349fcbc935917ded018801f7d942e50565d5 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1154247 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:838266 Change-Id: I898579f780e40ee0fb5fd1948a92a6c500242dfd Reviewed-on: https://chromium-review.googlesource.com/1154219Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#54771}
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:838266 Change-Id: I0c288eeaf28569d671220ab320aaec677825bb37 Reviewed-on: https://chromium-review.googlesource.com/1154218Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:842224 Change-Id: Icd00b7b4b86e1cc2de0234c69632eb5e6a63b11a Reviewed-on: https://chromium-review.googlesource.com/1154216Reviewed-by:
-
Matheus Marchini authored
The metadata introduced in this patch will be useful for postmortem tools to inspect Contexts and ScopeInfos (see https://github.com/nodejs/llnode/issues/211). R=bmeurer@google.com, yangguo@google.com Change-Id: I927fcab4014d128bd782046c1ecb9ee045723e95 Reviewed-on: https://chromium-review.googlesource.com/1153858Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:842224 Change-Id: Ic7c6093331f1bd35fffbfc98cd3f1d0ed3571eb4 Reviewed-on: https://chromium-review.googlesource.com/1154212 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:842224 Change-Id: I63c96969382fff550a64f80d35a7576d84092a0a Reviewed-on: https://chromium-review.googlesource.com/1154211 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/adaab11..79a29b1 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/933672b..1e61f60 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/079812c..d795ab8 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/12961e5..e4f38ff TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I483a9915a057d44369212720b0a2d69ebe1b0ca3 Reviewed-on: https://chromium-review.googlesource.com/1154199 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:838864 Change-Id: Ie0e6e1742344bfd69ec109f55fcccbaca0d66d66 Reviewed-on: https://chromium-review.googlesource.com/1154209 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
- 27 Jul, 2018 21 commits
-
-
Deepti Gandluri authored
Functions/variables for some atomic memory operators use type, representation interchangeably. Fix to make it consistent. Bug: v8:7754, v8:6532 Change-Id: I16ae35b72728739aee4bc67287317c2fd4a9088a Reviewed-on: https://chromium-review.googlesource.com/1152462Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#54763}
-
Frank Tang authored
Bug: v8:7979 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Icf646f5b9888239acb100a4238bbccc288e93153 Reviewed-on: https://chromium-review.googlesource.com/1150918Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#54762}
-
Jakob Kummerow authored
The ToBigInt conversion can have side effects, so the check for neutered-ness must happen afterwards. Bug: chromium:867776 Change-Id: I6e550c77a284da4cf132c21a6c3b1ed8f34eedc9 Reviewed-on: https://chromium-review.googlesource.com/1153553 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#54761}
-
Deepti Gandluri authored
This reverts commit 670fa86f. Reason for revert: Causes gc-stress bots to fail - https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8939819990688690880/+/steps/Check_-_d8/0/logs/object-spread-ic/0 https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8939819696982258192/+/steps/Check_-_d8/0/logs/object-spread-ic/0 Original change's description: > [CloneObjectIC] overwrite monomorphic/polymorphic feedback if deprecated > > An object with a deprecated Map which has already been cached in > CloneObjectIC feedback is still a valid Map for fast cloning --- but > to be consistent with other ICs, deprecated maps are ignored, and are > expected to be transitioned away from. > > If the source object has a deprecated map, the instance is migrated. > > BUG=v8:7611, chromium:867958 > R=jkummerow@chromium.org, mvstanton@chromium.org > > Change-Id: I9771b00400fb4dda45a62e874a31d9b50630d847 > Reviewed-on: https://chromium-review.googlesource.com/1152414 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Caitlin Potter <caitp@igalia.com> > Cr-Commit-Position: refs/heads/master@{#54758} TBR=jkummerow@chromium.org,mvstanton@chromium.org,caitp@igalia.com Change-Id: Id17652ad6f3f09adb43848069549ad146d48b2d7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7611, chromium:867958 Reviewed-on: https://chromium-review.googlesource.com/1153747Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#54760}
-
Sergiy Byelozyorov authored
This reverts commit ba023371. Reason for revert: decided to use CIPD package instead, see reasoning here: http://shortn/_MgZHcjC60Q. Original change's description: > [tools] Add an option to checkout v8-perf repo before running perf tests > > R=machenbach@chromium.org > > No-Try: true > Bug: chromium:838864 > Change-Id: I02e38778ec4c33a20f4b2e93fb22615baa316883 > Reviewed-on: https://chromium-review.googlesource.com/1151295 > Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54723} TBR=machenbach@chromium.org,sergiyb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. No-Try: true No-Tree-Checks: true Bug: chromium:838864 Change-Id: I65a5b075c6fede61b59528ba92f6803011f187c7 Reviewed-on: https://chromium-review.googlesource.com/1153687 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Caitlin Potter authored
An object with a deprecated Map which has already been cached in CloneObjectIC feedback is still a valid Map for fast cloning --- but to be consistent with other ICs, deprecated maps are ignored, and are expected to be transitioned away from. If the source object has a deprecated map, the instance is migrated. BUG=v8:7611, chromium:867958 R=jkummerow@chromium.org, mvstanton@chromium.org Change-Id: I9771b00400fb4dda45a62e874a31d9b50630d847 Reviewed-on: https://chromium-review.googlesource.com/1152414Reviewed-by:
-
Brian Stell authored
Also removed an obsolete test that is covered by test262/intl402 Bug: v8:7954, v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I41113653cd27c165e6f0a52e4b63bb9ddc553cba Reviewed-on: https://chromium-review.googlesource.com/1150453 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
-
Brian Stell authored
Remove the JS versions. Bug: v8:7954 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1dc90932e570c4acc7ca32a807b452148a6b2d88 Reviewed-on: https://chromium-review.googlesource.com/1144524 Commit-Queue: Brian Stell <bstell@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
We currently only expose this to desugarings and not in the grammar to keep 'const' and 'let' bindings consistent. A side-effect of this change is that it is now possible to use a shadowed name in the initializer of a const binding. Bug: v8:7793 Change-Id: Ic2ca6af0735acf0e748d394f9039fe6612bd4a06 Reviewed-on: https://chromium-review.googlesource.com/1150534 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#54755}
-
Ben L. Titzer authored
Add codegen support for up to 4GiB memories in Liftoff code. This CL also adds three new mjsunit tests that stress large WASM memories (1, 2, and 4 GiB) and checks that accesses near these boundaries properly generate traps. Note there is still some trickiness around the setting of: 1.) the flag --wasm-max-mem-pages 2.) wasm-limits.h kSpecMaxWasmMemoryPages = 65536 3.) wasm-limits.h kV8MaxWasmMemoryPages = 32767 In particular, the allocation of memories is still limited to 3.) and the runtime flag can only lower this limit. The above means that the tests for 2GiB and 4GiB memories will silently OOM by design until 3.) is changed (though they currently pass with manual testing). I argue it is better to include these tests up front, since they will immediately trigger if their memory allocation succeeds. Therefore the plan is to lift the restriction on 3.) after removing all other other internal V8 limitations including array buffers and views. R=clemensh@chromium.org CC=mstarzinger@chromium.org BUG=v8:7881 Change-Id: I3205ac2daf5c9a84364c670a2c3ef2258e5649f6 Reviewed-on: https://chromium-review.googlesource.com/1151309 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#54754}
-
Michael Lippautz authored
The initial CL only re-wired the macro but did not convert the remaining manual uses. Change-Id: Ia4c6dea006d7c026d2376affee0b7027f5aa7895 Reviewed-on: https://chromium-review.googlesource.com/1152907Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL changes the for-loop so all parts are optional, allowing loops like: for (;;) {} for (;; ++i) {} ... R=danno@chromium.org, tebbi@chromium.org Bug: v8:7793 Change-Id: I7bf9ef9e59d55eb9ae9f38904a1c1106ae50df5a Reviewed-on: https://chromium-review.googlesource.com/1152727 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by: -
Michael Lippautz authored
Bug: v8:7490 Change-Id: I72444df6f75bc61c467c2df51f87581ef44fe09e Reviewed-on: https://chromium-review.googlesource.com/1151632 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Until now, this test mode was only active in CI. Adding it to CQ should help catching errors earlier. TBR=sergiyb@chromium.org Change-Id: I19a0971ecb318eb5bca3aee435700544d0ad2dcb Reviewed-on: https://chromium-review.googlesource.com/1131946Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54750}
-
Peter Marshall authored
Previously we used the start address of the AbstractCode object. This doesn't make sense for off-heap builtins, where the code isn't contained in the object itself. It also hides other potential problems - sometimes the sample.pc is inside the AbstractCode object header - this is never valid. There were a few changes necessary to make this happen: - Change the interface of CodeMoveEvent. Now 'to' and 'from' are both AbstractCode objects, which is nice because many users were taking 'to' and adding the header offset to it to try and find the instruction start address. This isn't valid for off-heap builtins. - Fix a bug in CodeMap::MoveCode where we didn't update the CodeEntry object to reflect the new instruction_start. - Rename the 'start' field in all of the CodeEventRecord sub-classes to make it clear that this is the address of the first instruction. - Fix the confusion in RecordTickSample between 'tos' and 'pc' which caused pc_offset to be calculated incorrectly. Bug: v8:7983 Change-Id: I3e9dddf74e4b2e96a5f031d216ef7008d6f184d1 Reviewed-on: https://chromium-review.googlesource.com/1148457 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: -
Peter Marshall authored
Fixes: src/objects/intl-objects-inl.h src/objects/js-collection.h src/objects/js-collection-inl.h src/objects/js-regexp-string-iterator-inl.h src/objects/microtask-inl.h src/objects/module-inl.h src/objects/ordered-hash-table-inl.h src/objects/promise-inl.h Bug: v8:7754,v8:7490 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id5a5017713fa9920add2b38dbc56ab74abd4addd Reviewed-on: https://chromium-review.googlesource.com/1152732Reviewed-by:
-
Michael Achenbach authored
This reverts commit 51ad234f. Reason for revert: Speculative revert. Suspect for layout test change: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064/25165 See also: https://github.com/v8/v8/wiki/Blink-layout-tests The bots currently have another problem with webkit_unit_tests and don't run the layout tests on every revision. Hence the speculative revert. Original change's description: > [Intl] move localeCompare to C++ > > > Bug: v8:7958 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I84a27dda5205c8581a7ffe37213d685cc49974fa > Reviewed-on: https://chromium-review.googlesource.com/1144644 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54740} TBR=jshin@chromium.org,gsathya@chromium.org,bstell.chromium.org@gmail.com,ftang@chromium.org Change-Id: Iceab3316bd1eacfe449c8182cbb3027acb56047e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7958 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1152767Reviewed-by:
-
Michael Achenbach authored
This reverts commit a895f01a. Reason for revert: Needed for other revert: https://chromium-review.googlesource.com/c/v8/v8/+/1152767 Original change's description: > [Intl] Move Number.toLocaleString from js to c++ > > > Bug: v8:7960 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I21a524b620e210cce625a1a00e68c0b687187087 > Reviewed-on: https://chromium-review.googlesource.com/1144659 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Jungshik Shin <jshin@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54741} TBR=jshin@chromium.org,gsathya@chromium.org,bstell.chromium.org@gmail.com,ftang@chromium.org Change-Id: I060fa2834dde5e1b4cc71923cc066d97bce2a33b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7960 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1152787Reviewed-by:
-
Creddy authored
The CSA fast path returned null for Proxy.prototype whereas runtime GetProperty returned undefined. The CL fixes this discrepancy by returning undefined for both cases and this makes it complaint with the spec. Change-Id: I35b75c09dc99e8fd629671e30eacd2cabea8c1d4 Reviewed-on: https://chromium-review.googlesource.com/1145438Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Florian Sattler authored
This places the hot part of SkipWhiteSpace in the header, allowing it to be inlined, and leaves a slow path to handle the rest. This improves comment scanning overall by ~10%. Bug: v8:7926 Change-Id: I2e2ebbbae0d1af619b161397712fdf667d078884 Reviewed-on: https://chromium-review.googlesource.com/1150230 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Théotime Grohens authored
This CL removes the last bit of Float64 math that was left, by adding a TypeGuard node to help the typer figure out that stuff actually fits in Int32 operations. This should improve the inline performance a little bit more. Change-Id: I35bf3445e6c73c9433d5ff5e177d6bb3c8b82071 Reviewed-on: https://chromium-review.googlesource.com/1151635Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Théotime Grohens <theotime@google.com> Cr-Commit-Position: refs/heads/master@{#54743}
-
