- 17 Sep, 2018 7 commits
-
-
Benedikt Meurer authored
While investigating crbug.com/878742 I found that somehow the MachineOperatorReducer lacks the ability to constant-fold comparisons of Float64 constants, which obviously leads to pretty weird code. Bug: v8:8015 Change-Id: I7e18ce10e9d5c87f131fb083ccd3e1e336189dae Reviewed-on: https://chromium-review.googlesource.com/1226132Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55935}
-
Marja Hölttä authored
E.g., "ToWeakHeapObject" was misleading, since it didn't convert to a weak heap object, instead returned a weakly pointed heap object. Change the function names (in this case, to "GetHeapObjectIfWeak") to reflect this. Also make casts explicit, if a MaybeObject is an Object, we can call cast<Object>(). Previous version: https://chromium-review.googlesource.com/1219025 BUG=v8:7308 TBR=ishell@chromium.org, ulan@chromium.org, ahaas@chromium.org, yangguo@chromium.org, tebbi@chromium.org Change-Id: I503d4a2a3a68f85e9e02e1c2f9fc1c4187c8e9a1 Reviewed-on: https://chromium-review.googlesource.com/1226800Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#55934}
-
Benedikt Meurer authored
We can remove redundant NumberSilenceNaN operations if the input is known to be an OrderedNumber, which means that it's any number (incl. -0) but not NaN. This seems to specifically occur in applications that perform number crunching on arrays with integer values outside the Smi range, as these arrays will have double elements kind, but for most of the stores to these arrays TurboFan will be able to tell that it's not going to be a NaN. Bug: v8:8015 Change-Id: I451ac0bf0cec26be18b991f6c3756fb41f1fbd97 Reviewed-on: https://chromium-review.googlesource.com/1225897 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Michael Hablich authored
This reverts commit 1a225459. Reason for revert: Makes GC stress unhappy: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/18325 and blocks the roll Original change's description: > Implement ResolveLocale in C++. > > Bug: v8:8065, v8:5751 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Id9dc16455d63b7c436126c21758d64fae0ec8de9 > Reviewed-on: https://chromium-review.googlesource.com/1211402 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55925} TBR=bstell@chromium.org,gsathya@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8065, v8:5751 Change-Id: I4d71adb31ffd5ab0d2ae42c0255d0a05edbaad29 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1226646Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#55932}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ibc3dedb0bce78ddce4004ee386757ce504bb073a Reviewed-on: https://chromium-review.googlesource.com/1226792 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55931}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I6bd8e0c8c1965f22a3429fda12bc70ae454c39c2 Reviewed-on: https://chromium-review.googlesource.com/1226978Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55930}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I62ef9a644bd8ba68c44e8e224e54e8c20c3442c7 Reviewed-on: https://chromium-review.googlesource.com/1225795Reviewed-by:
-
- 15 Sep, 2018 4 commits
-
-
Igor Sheludko authored
This is a reland of 16816e53 Bug: v8:8096 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I257fc391931a0a4bf01f2e8136183aaed044231c Reviewed-on: https://chromium-review.googlesource.com/1226915 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#55928}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e021b7c..dc14f7b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3e07166..c9dc040 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b5e8781..2174136 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic3b93484af284a4297862e12ded35e87229e9113 Reviewed-on: https://chromium-review.googlesource.com/1227505Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55927}
-
Igor Sheludko authored
This allows to avoid passing around Isolate instance for no actual reason when generating "codegen" functions. Bug: v8:8015 Change-Id: Ic3a9bd5a8ecb5b559479e44c5e1309a78a1546e7 Reviewed-on: https://chromium-review.googlesource.com/1226133Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55926}
-
Brian Stell authored
Bug: v8:8065, v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id9dc16455d63b7c436126c21758d64fae0ec8de9 Reviewed-on: https://chromium-review.googlesource.com/1211402Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55925}
-
- 14 Sep, 2018 29 commits
-
-
tzik authored
This is a reland of 836773c0 Original change's description: > Implement v8::internal::MicrotaskQueue::EnqueueMicrotask > > This adds `queue` and `pending_microtask_count` as members of > v8::internal::MicrotaskQueue, and implements its EnqueueMicrotask. > The implementation itself is similar to Isolate::EnqueueMicrotask. > > Bug: v8:8124 > Change-Id: Idb5c50b2add96b72cbe9e36aeec7cb568072f0cb > Reviewed-on: https://chromium-review.googlesource.com/1205430 > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55884} Bug: v8:8124 Change-Id: Ibd32aec28c8fd9eab88904e62ba97a715295765d Reviewed-on: https://chromium-review.googlesource.com/1226577Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#55924}
-
Ben Smith authored
Bug: chromium:883492 Change-Id: I69e76eb51c635d092918a3cb9a8fa94a86f58f2a Reviewed-on: https://chromium-review.googlesource.com/1226410Reviewed-by:
-
PhistucK authored
Previously, DateTimeFormat.prototype.formatToParts returned an object with the property key 'dayperiod' which is incorrect as per the spec. This patch updates the property key to say 'dayPeriod', making this spec compliant. R=cira@chromium.org Bug: chromium:865351 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I37f50797387bc69d5e29d7c2911bc5cc0fad37ac Reviewed-on: https://chromium-review.googlesource.com/1145304Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I6cd63aa164af2e3b4a846933899a9a1baa54b1ef Reviewed-on: https://chromium-review.googlesource.com/1224032Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55921}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I85fc4ba0e4188d60d15e389e4682541c65324b55 Reviewed-on: https://chromium-review.googlesource.com/1227071 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I20fd23b5370d15dddc913f6bdb05e649d71c2059 Reviewed-on: https://chromium-review.googlesource.com/1224373Reviewed-by:
-
Marja Hölttä authored
This reverts commit ad72d195. Reason for revert: Build failures on *san Original change's description: > [in-place weak refs] Fix MaybeObject function names > > E.g., "ToWeakHeapObject" was misleading, since it didn't convert to a weak heap > object, instead returned a weakly pointed heap object. Change the function names > (in this case, to "GetHeapObjectIfWeak") to reflect this. > > Also make casts explicit, if a MaybeObject is an Object, we can call cast<Object>(). > > BUG=v8:7308 > > Change-Id: I4ef078572b4f4415afe7e2e706d3bd684e16e47d > Reviewed-on: https://chromium-review.googlesource.com/1219025 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55906} TBR=ulan@chromium.org,marja@chromium.org,yangguo@chromium.org,ahaas@chromium.org,tebbi@chromium.org,ishell@chromium.org Change-Id: I054b578518e3f6fd7dbcddf0b56cc018726c1e7a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7308 Reviewed-on: https://chromium-review.googlesource.com/1226874Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I41b3d7c41ee9f8ff12f70feddcf38f2c9efc5049 Reviewed-on: https://chromium-review.googlesource.com/1224056Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55917}
-
Benedikt Meurer authored
When the backend sees an Int64Constant in a translation, this currently indicates the value is a Smi value. Bug: v8:8015 Change-Id: I1527a6374b395d3a33ae0339df4b563084ea678e Reviewed-on: https://chromium-review.googlesource.com/1226593Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55916}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I56b730814539df7fdc2e1e5fb06c8b2b104b5fc8 Reviewed-on: https://chromium-review.googlesource.com/1223830 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5404f0b94c7badce2c59d8eac2c32810f4fa2c3c Reviewed-on: https://chromium-review.googlesource.com/1224317Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55914}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ifb940f40d4145a6074702a3d870242aeca625d96 Reviewed-on: https://chromium-review.googlesource.com/1224092Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I4236a2cf85a414f9d7d1fbdaaaaf1c72a84f02e3 Reviewed-on: https://chromium-review.googlesource.com/1224093Reviewed-by:
-
Ivica Bogosavljevic authored
Port 6346cdb6 Change-Id: I397ff152f363a3f0345105fbdf5d939bc3245fb4 Reviewed-on: https://chromium-review.googlesource.com/1225707Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Sreten Kovacevic <skovacevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#55911}
-
Yang Guo authored
R=jgruber@chromium.org Bug: chromium:882664 Change-Id: I12248de9a01839433daa40e8273a18a15a9867bb Reviewed-on: https://chromium-review.googlesource.com/1221547 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Marja Hölttä authored
It's the same as JSFunction::BodyDescriptor, so the special cases can be removed. This is a pre-step for refactoring BodyDescriptorWeak away. BUG=v8:7308 Change-Id: Id65ce79f044960168d290fbbfdbc2a7aa854230e Reviewed-on: https://chromium-review.googlesource.com/1226592 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Currently dead ArrayBuffers with external memory are discovered and freed in sweeper. If sweeping is slow, it can take long time until the external memory is freed. This is why wasm currently forces at least two back-to-back GCs on allocaiton failure. This patch ensures eager finalization of ArrayBuffers on critical memory pressure notification. Bug: v8:7621 Change-Id: I96c75922577388cafab049f5cbce01d636a7b400 Reviewed-on: https://chromium-review.googlesource.com/1224328 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib48ead467519354715e3bc0e3f718cbdda28f989 Reviewed-on: https://chromium-review.googlesource.com/1225704 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Marja Hölttä authored
E.g., "ToWeakHeapObject" was misleading, since it didn't convert to a weak heap object, instead returned a weakly pointed heap object. Change the function names (in this case, to "GetHeapObjectIfWeak") to reflect this. Also make casts explicit, if a MaybeObject is an Object, we can call cast<Object>(). BUG=v8:7308 Change-Id: I4ef078572b4f4415afe7e2e706d3bd684e16e47d Reviewed-on: https://chromium-review.googlesource.com/1219025Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I4f9eb0fedbe1d35a571f3d5b111705a820edfb5b Reviewed-on: https://chromium-review.googlesource.com/1224377 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Stephan Herhut authored
The current formatting makes the build command seem to be one line, whereas it should be two. Change-Id: I9abe7cf3351aae1f1df51bf1e3ca46a0ed2c012b Reviewed-on: https://chromium-review.googlesource.com/1225708Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#55904}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I2a7a8c8447d2835205f7a506f04efe4d1801b934 Reviewed-on: https://chromium-review.googlesource.com/1224316Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: Ie0591d8f32ebd4b9681ef9eeec092e30b73bd0b8 Reviewed-on: https://chromium-review.googlesource.com/1224172Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie05d919cfd5cc4447c00603c8a46e975ad85cce3 Reviewed-on: https://chromium-review.googlesource.com/1224378Reviewed-by:
-
Clemens Hammacher authored
This test was disabled because of flakes. This should be fixed now. R=ahaas@chromium.org Bug: v8:7872 Change-Id: I288f3776ca7f946caf20a66f1cdf5d37bd6ba245 Reviewed-on: https://chromium-review.googlesource.com/1224376Reviewed-by:
-
Michael Achenbach authored
The test debug-live-edit-recursion flakily fails predictable testing and should match the status file rule debug-liveedit-* that skips the other ~10 liveedit tests. Bug: v8:8147 Change-Id: I9d88b44d97daa09914e0fa46fb204e85c1e7344c Reviewed-on: https://chromium-review.googlesource.com/1224430Reviewed-by:
-
Clemens Hammacher authored
This implements the five sign extension opcodes for ia32 and x64 (and bails out on other architectures). R=titzer@chromium.org Bug: v8:6600 Change-Id: Ibb8bae0e229e276b346f2d054b51864a0995a096 Reviewed-on: https://chromium-review.googlesource.com/1174533 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55898}
-
Jakob Gruber authored
This reverts commit 99e13e58. Reason for revert: Reverting in favor of a general mechanism for this in Torque. Original change's description: > [builtins] Add FastCallFunction builtin that elides some checks > > This CL adds a new "Call" stub that can be used by builtins that will > call the same JS call-back function often (e.g. compare function in > Array.p.sort). The checks have to be done upfront once, but can then > be omitted. > > R=jgruber@chromium.org > > Bug: v8:7861 > Change-Id: Id6e4ca27c3d488a7b1f708cbcb4cbe6cc382513e > Reviewed-on: https://chromium-review.googlesource.com/1208574 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55769} TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7861 Change-Id: I47260993ef2a16bd5348bb0b46da4d34d33ea10b Reviewed-on: https://chromium-review.googlesource.com/1226871 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I8546c58afbac278a764067173570b433dff6674d Reviewed-on: https://chromium-review.googlesource.com/1224413Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55896}
-
