- 30 Dec, 2015 7 commits
-
-
cbruni authored
counts specified in runtime.h. In the vast majority of the cases when we call into the runtime we use the default number of arguments. Hence, there is not need to specify it again. This CL also removes TailCallExternalReference as there were no users. BUG= Review URL: https://codereview.chromium.org/1553703002 Cr-Commit-Position: refs/heads/master@{#33066}
-
littledan authored
Reland "Clean up promises and fix an edge case bug (patchset #4 id:60001 of https://codereview.chromium.org/1488783002/ )" This patch relands a change to ES2015 Promises which brings us closer to spec compliance. In this new version, a bug which would lose async callstack data was fixed. R=adamk CC=rossberg,caitp LOG=Y BUG=v8:3641 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1538663002 Cr-Commit-Position: refs/heads/master@{#33065}
-
mbrandy authored
Port 97def807 Original commit message: According to the ES2015 specification, bound functions are exotic objects, and thus don't need to be implemented as JSFunctions. So we introduce a new JSBoundFunction type to represent bound functions and make them optimizable. This already improves the performance of calling or constructing bound functions by 10-100x depending on the use case because we avoid the crazy dance between JavaScript and C++ that was implemented in v8natives.js previously. There's still room for improvement in the performance of actually creating bound functions, which is also relevant in practice, but we already have a plan how to accomplish that later. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:535408, chromium:571299, v8:4629 LOG=n Review URL: https://codereview.chromium.org/1559473002 Cr-Commit-Position: refs/heads/master@{#33064}
-
mbrandy authored
Port bafb568b R=jarin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1552783002 Cr-Commit-Position: refs/heads/master@{#33063}
-
mbrandy authored
Do not abstract r0 as a general scratch register -- usage is valid only in short, localized sequences (since its value may be altered implicitly by some macro operations). R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:571370 LOG=N Review URL: https://codereview.chromium.org/1556643002 Cr-Commit-Position: refs/heads/master@{#33062}
-
bmeurer authored
There's no point in keeping the ObjectCreate JavaScript wrapper function, which even does allocation site pretenuring for the instances created via Object.create (where ObjectCreate itself is the AllocationSite), and does not offer any sane way forward. Instead introduce a new ObjectCreate C++ builtin, which currently serves as a baseline implementation, on top of which we can think about ways to optimize Object.create for the common case (i.e. frameworks such as Ember.js make heavy use of Object.create). R=cbruni@chromium.org TBR=hpayer@chromium.org Review URL: https://codereview.chromium.org/1558433002 Cr-Commit-Position: refs/heads/master@{#33061}
-
v8-autoroll authored
Rolling v8/tools/clang to d1e1de24f0e66c2f5a8b865c8ffb4042793286e9 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1551053002 Cr-Commit-Position: refs/heads/master@{#33060}
-
- 29 Dec, 2015 8 commits
-
-
cbruni authored
JumpToExternalReference ignored the passed-in result_size argument, which defaulted to 1. This change updates all users to not use a result_size. BUG= Review URL: https://codereview.chromium.org/1550923002 Cr-Commit-Position: refs/heads/master@{#33059}
-
ishell authored
BUG=chromium:571064 LOG=Y TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1548363003 Cr-Commit-Position: refs/heads/master@{#33058}
-
ishell authored
BUG=chromium:571370 LOG=Y Review URL: https://codereview.chromium.org/1546323002 Cr-Commit-Position: refs/heads/master@{#33057}
-
bmeurer authored
This matches the behavior of JSObject::JSObjectVerify() and seems to be the current contract for --verify-heap. BUG=chromium:572590 LOG=n Review URL: https://codereview.chromium.org/1553463002 Cr-Commit-Position: refs/heads/master@{#33056}
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1550113002 Cr-Commit-Position: refs/heads/master@{#33055}
-
machenbach authored
NOTRY=true TBR=rmcilroy@chromium.org, littledan@chromium.org Review URL: https://codereview.chromium.org/1552663002 Cr-Commit-Position: refs/heads/master@{#33054}
-
machenbach authored
Revert of Use ES2015-style TypedArray prototype chain (patchset #5 id:80001 of https://codereview.chromium.org/1541233002/ ) Reason for revert: [Sheriff] Changes layout tests. Please fix upstream first if intended. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689 Original issue's description: > Use ES2015-style TypedArray prototype chain > > This patch switches TypedArrays to use the prototype chain described > in the ES2015 specification, which adds a %TypedArray% superclass above > all individual TypedArray types. Most methods are defined on the > superclass rather than the subclasses. > > In order to prevent a performance regression, a few methods are > marked as inline. Inlining might prevent code which was previously > monomorphic from becoming polymorphic, and it was specifically > applied in places where methods became more polymorphic than before. > Tests with realistic workloads would be nice to do before this > ships in stable. > > This patch does not bring TypedArrays up to full spec compliance. In > particular, @@species is not yet supported. > > R=cbruni > BUG=v8:4085 > LOG=Y > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7 > Cr-Commit-Position: refs/heads/master@{#33050} TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4085 Review URL: https://codereview.chromium.org/1554523002 Cr-Commit-Position: refs/heads/master@{#33053}
-
v8-autoroll authored
Rolling v8/tools/clang to 2f115cac36580d305f8060d98fb9cc1f034e78e8 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1550883002 Cr-Commit-Position: refs/heads/master@{#33052}
-
- 28 Dec, 2015 7 commits
-
-
bmeurer authored
When calling into C++ for a ConstructStub, we need to enter the target context manually currently, which seems to be too fragile and easy to forget. So instead of doing that manually, we just always enter the correct context in the trampoline. Drive-by-fix: Trivial cleanups for some builtins. R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1551473002 Cr-Commit-Position: refs/heads/master@{#33051}
-
littledan authored
This patch switches TypedArrays to use the prototype chain described in the ES2015 specification, which adds a %TypedArray% superclass above all individual TypedArray types. Most methods are defined on the superclass rather than the subclasses. In order to prevent a performance regression, a few methods are marked as inline. Inlining might prevent code which was previously monomorphic from becoming polymorphic, and it was specifically applied in places where methods became more polymorphic than before. Tests with realistic workloads would be nice to do before this ships in stable. This patch does not bring TypedArrays up to full spec compliance. In particular, @@species is not yet supported. R=cbruni BUG=v8:4085 LOG=Y Review URL: https://codereview.chromium.org/1541233002 Cr-Commit-Position: refs/heads/master@{#33050}
-
littledan authored
When the 'y' flag was shipped, the property RegExp.prototype.unicode was accidentally also shipped. However, the existence of this property should be a usable feature testing point. This patch adds the 'unicode' getter on RegExp.prototype only if the --harmony-regexp-unicode flag is turned on. R=cbruni CC=yangguo BUG=v8:4644 LOG=Y Review URL: https://codereview.chromium.org/1550713002 Cr-Commit-Position: refs/heads/master@{#33049}
-
ivica.bogosavljevic authored
Fix 97def807 On MIPS64, the address of BoundTargetFunction was calculated badly because instruction ADD was used for this instead of instruction DADD. This caused flaky crashes of several tests. TEST=mjsunit/es6/debug-step-into-constructor,mjsunit/es6/array-of, mjsunit/function-bind,... BUG= Review URL: https://codereview.chromium.org/1549383002 Cr-Commit-Position: refs/heads/master@{#33048}
-
machenbach authored
This crashes flakily. Leftover from https://chromium.googlesource.com/v8/v8/+/e7373f42859cff71f2a64780dcab35244f1ce343 NOTRY=true TBR=bmeurer@chromium.org, rmcilroy@chromium.org, mythria@chromium.org, Review URL: https://codereview.chromium.org/1544363002 Cr-Commit-Position: refs/heads/master@{#33047}
-
zhengxing.li authored
port 97def807 (r33044) original commit message: According to the ES2015 specification, bound functions are exotic objects, and thus don't need to be implemented as JSFunctions. So we introduce a new JSBoundFunction type to represent bound functions and make them optimizable. This already improves the performance of calling or constructing bound functions by 10-100x depending on the use case because we avoid the crazy dance between JavaScript and C++ that was implemented in v8natives.js previously. There's still room for improvement in the performance of actually creating bound functions, which is also relevant in practice, but we already have a plan how to accomplish that later. The mips/mips64 ports were contributed by akos.palfi@imgtec.com. BUG= Review URL: https://codereview.chromium.org/1548253002 Cr-Commit-Position: refs/heads/master@{#33046}
-
zhengxing.li authored
As the operand in double register is put into stack, the SP delta should be increased too similar to the operand of kX87Push is in double slot of stack. BUG= Review URL: https://codereview.chromium.org/1549133002 Cr-Commit-Position: refs/heads/master@{#33045}
-
- 27 Dec, 2015 2 commits
-
-
bmeurer authored
According to the ES2015 specification, bound functions are exotic objects, and thus don't need to be implemented as JSFunctions. So we introduce a new JSBoundFunction type to represent bound functions and make them optimizable. This already improves the performance of calling or constructing bound functions by 10-100x depending on the use case because we avoid the crazy dance between JavaScript and C++ that was implemented in v8natives.js previously. There's still room for improvement in the performance of actually creating bound functions, which is also relevant in practice, but we already have a plan how to accomplish that later. The mips/mips64 ports were contributed by akos.palfi@imgtec.com. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel BUG=chromium:535408, chromium:571299, v8:4629 LOG=n Committed: https://crrev.com/ca8623eaa468cba65a5adafcdfb4615966f43ce2 Cr-Commit-Position: refs/heads/master@{#33042} Review URL: https://codereview.chromium.org/1542963002 Cr-Commit-Position: refs/heads/master@{#33044}
-
bmeurer authored
Revert of [runtime] Introduce dedicated JSBoundFunction to represent bound functions. (patchset #14 id:260001 of https://codereview.chromium.org/1542963002/ ) Reason for revert: Breaks arm64 sim nosnap: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/805/steps/Check/logs/function-bind Original issue's description: > [runtime] Introduce dedicated JSBoundFunction to represent bound functions. > > According to the ES2015 specification, bound functions are exotic > objects, and thus don't need to be implemented as JSFunctions. So > we introduce a new JSBoundFunction type to represent bound functions > and make them optimizable. This already improves the performance of > calling or constructing bound functions by 10-100x depending on the > use case because we avoid the crazy dance between JavaScript and C++ > that was implemented in v8natives.js previously. > > There's still room for improvement in the performance of actually > creating bound functions, which is also relevant in practice, but > we already have a plan how to accomplish that later. > > The mips/mips64 ports were contributed by akos.palfi@imgtec.com. > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > BUG=chromium:535408, chromium:571299, v8:4629 > LOG=n > > Committed: https://crrev.com/ca8623eaa468cba65a5adafcdfb4615966f43ce2 > Cr-Commit-Position: refs/heads/master@{#33042} TBR=cbruni@chromium.org,hpayer@chromium.org,yangguo@chromium.org,akos.palfi@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:535408, chromium:571299, v8:4629 Review URL: https://codereview.chromium.org/1552473002 Cr-Commit-Position: refs/heads/master@{#33043}
-
- 26 Dec, 2015 2 commits
-
-
bmeurer authored
According to the ES2015 specification, bound functions are exotic objects, and thus don't need to be implemented as JSFunctions. So we introduce a new JSBoundFunction type to represent bound functions and make them optimizable. This already improves the performance of calling or constructing bound functions by 10-100x depending on the use case because we avoid the crazy dance between JavaScript and C++ that was implemented in v8natives.js previously. There's still room for improvement in the performance of actually creating bound functions, which is also relevant in practice, but we already have a plan how to accomplish that later. The mips/mips64 ports were contributed by akos.palfi@imgtec.com. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel BUG=chromium:535408, chromium:571299, v8:4629 LOG=n Review URL: https://codereview.chromium.org/1542963002 Cr-Commit-Position: refs/heads/master@{#33042}
-
v8-autoroll authored
Rolling v8/tools/clang to 48322a540c208cda85790c2a6df4c4d335b191e1 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1552433002 Cr-Commit-Position: refs/heads/master@{#33041}
-
- 25 Dec, 2015 1 commit
-
-
v8-autoroll authored
Rolling v8/tools/clang to 58034a11a42065e1af1263dfead64df24cb879b9 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1545193002 Cr-Commit-Position: refs/heads/master@{#33040}
-
- 24 Dec, 2015 6 commits
-
-
jarin authored
Review URL: https://codereview.chromium.org/1544743004 Cr-Commit-Position: refs/heads/master@{#33039}
-
paul.lind authored
Per request in https://codereview.chromium.org/1047213002/ These files will continue to have a lot of churn in next two months as we finish support for MIPS r6 instruction set. When things settle down, we will do a clang-format --full to clean them up. For now, we'd prefer to be able to do easy diffs, and will do incremental re-formats as we make changes. BUG= Review URL: https://codereview.chromium.org/1546973003 Cr-Commit-Position: refs/heads/master@{#33038}
-
thakis authored
Follow-up to https://codereview.chromium.org/1495653002, and makes it easier to maybe have a clang/win build of v8 at some point in the future. BUG=none LOG=n Review URL: https://codereview.chromium.org/1549053002 Cr-Commit-Position: refs/heads/master@{#33037}
-
ivica.bogosavljevic authored
In Builtins::Generate_Construct, the system was trying to call ConstructProxy on a Proxy object without a constructor because it was checking the wrong bit in the Proxy object's supported operation mask. TEST=test262/built-ins/Proxy/create-target-is-not-constructor BUG= Review URL: https://codereview.chromium.org/1545983002 Cr-Commit-Position: refs/heads/master@{#33036}
-
zhengxing.li authored
port 866f9e6e (r33026) original commit message: BUG= Review URL: https://codereview.chromium.org/1541323005 Cr-Commit-Position: refs/heads/master@{#33035}
-
zhengxing.li authored
port d3f074b2 (r33024) original commit message: We'll be able to optimize rest parameters in TurboFan similarly to the arguments array. This CL restores the previous behavior, and a follow-on will enable TurboFan optimization. (TBR for rossberg since we discussed the revert beforehand. The only changes are a few lines related to tests and rebasing.) BUG= Review URL: https://codereview.chromium.org/1545053002 Cr-Commit-Position: refs/heads/master@{#33034}
-
- 23 Dec, 2015 7 commits
-
-
cbruni authored
atOrUndefined() will return undefined if the index is >= length() BUG= Review URL: https://codereview.chromium.org/1541413002 Cr-Commit-Position: refs/heads/master@{#33033}
-
cbruni authored
BUG= Review URL: https://codereview.chromium.org/1549793003 Cr-Commit-Position: refs/heads/master@{#33032}
-
ishell authored
Previous CL (https://codereview.chromium.org/1522413002) has a typo. BUG=chromium:571402,chromium:514080,chromium:527994,v8:4325 LOG=N Review URL: https://codereview.chromium.org/1541403002 Cr-Commit-Position: refs/heads/master@{#33031}
-
mbrandy authored
Revert mistaken removal of JumpIfBlack prototype. R=hpayer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:561449 LOG=n Review URL: https://codereview.chromium.org/1544043002 Cr-Commit-Position: refs/heads/master@{#33030}
-
ishell authored
BUG=chromium:570131 LOG=N Review URL: https://codereview.chromium.org/1546933002 Cr-Commit-Position: refs/heads/master@{#33029}
-
mbrandy authored
Port d3f074b2 Original commit message: We'll be able to optimize rest parameters in TurboFan similarly to the arguments array. This CL restores the previous behavior, and a follow-on will enable TurboFan optimization. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review URL: https://codereview.chromium.org/1549743003 Cr-Commit-Position: refs/heads/master@{#33028}
-
hablich authored
NOTRY=true TBR=rmcilroy,machenbach Review URL: https://codereview.chromium.org/1547913003 Cr-Commit-Position: refs/heads/master@{#33027}
-