- 01 Jul, 2020 14 commits
-
-
Kim-Anh Tran authored
This makes the 4GB max length compilable for 32 bit MSVC. Bug: chromium:1095721 Change-Id: I2be9f69668687f18beb86028debb3fd5ff350202 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2272558Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/master@{#68637}
-
Victor Gomes authored
This changes the default scope info for SyntheticFunctionContexts to the EmptyScopeInfo which does not contain an extension slot. The bug happened because, previously, the native context scope info was used as dummy. Change-Id: I4d6bf6918c11c79201d16bde99ed76800ad6f6c5 Bug: v8:10629 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277806 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68636}
-
Georg Neis authored
Also fix a typo in a log message. Change-Id: I247e5347b7f7d71b08630489896da463dd76b8a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277885 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#68635}
-
Clemens Backes authored
We spawn individual tests in their own shell, and then just kill that shell later. This often leaves the tests running (see linked bugs). By spawning the shell in its own new process group, we can just kill that whole process group later, which seems to work reliably for hanging tests. R=machenbach@chromium.org Bug: v8:8292, v8:8700 Change-Id: I6e38467d687cc0b395467d4b377644de7700f066 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274634Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68634}
-
Manos Koukoutos authored
Motivation: We used to approximate s33/i33 value parsing by first checking for specific negative codes, and then parsing an u32 value if that failed. This is not correct in all cases. Changes: - Implement i33 parsing in Decoder. - Factor out parsing of heap types into read_heap_type. - Introduce HeapType::kBottom. - Introduce helper functions in WasmFeatures and value_type_reader. - Remove macros from the parsing of value types. - HeapType::code now returns an i32 for compatibility with the i33 requirement. - Introduce HeapType::Repr. - Renamings: HeapType::type() -> representation(), ValueType::heap() -> heap_representation() Bug: v8:7748 Change-Id: I04deabce8837a48af2226411cd706a397f9e5725 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274118 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: -
Marja Hölttä authored
It's actually not an atomic variable, just raw memory, so this is technically not correct. However, the expert advice is to do this until atomic_ref is available. Change-Id: I4b74aa7123ed6ffeb2a06800c35b03e428861e80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270162 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68632}
-
Camillo Bruni authored
Skip unhandled promises for AsyncAwait performance test. Bug: v8:1099632 Change-Id: I21d69d5700860f0b05fb8c6c90ea85dc28cb3890 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274606Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68631}
-
Camillo Bruni authored
tools/callstats-from-telemetry.sh converts multiple telemetry results form benchmark runs into a single callstats-compatible json file. Change-Id: I775109d4274c2cf8d87797b73695497d82d59d4a No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276043Reviewed-by:
-
Salome Thirot authored
Modify the output of --trace-deopt to specify which version of the caller's pc (signed with PAC or unsigned) is shown when CFI is enabled. Change-Id: I77006839997a5f50d37d65facbba24d8a86a1509 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274867 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68629}
-
Jakob Gruber authored
This refactors the FastApiCall reduction to be more explicit about which inputs of the JSCall node are used. Bug: v8:8888 Change-Id: Ia950bbfcf359ec4ae232b8dd21adafb0b4a05177 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276032 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#68628}
-
Michael Lippautz authored
Move inlined methods to .h files accordingly, follwing style guide rule: https://google.github.io/styleguide/cppguide.html#Self_contained_Headers Bug: chromium:1056170 Change-Id: Ia6c4f82bd4352d507eece36e540ad0d318e56920 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273858Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68627}
-
Jakob Gruber authored
The typed version takes Effect/Control arguments instead of untyped Node* arguments. Bug: v8:8888 Change-Id: Ia4b9895256ab9ea2a22f9e590490280d7536eac7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274609 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Port ef1d6a3b https://crrev.com/c/2227257 Change-Id: Id829db611fdfd475462efec2aa0ab6f94d3ddce3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2251680 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#68625}
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/ef35868..23ef533 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3a5fbeb..29bc352 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/1ed9957..6099f10 Rolling v8/third_party/aemu-linux-x64: I_sHBnheTA3cmFAjzkyUAhsmhpWXu82YLidstkjgsvIC..OQ8c-S6dNd0LdVeElhAYBgsHeiiM4xyJ8E6hy3pRIUMC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/de622ae..3f5d1ca Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d9391fd..fdd2cd6 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6849229..b49c12a TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibab2c61210b9142ddd269b48aadc5a39c6996ede Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275116Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68624}
-
- 30 Jun, 2020 25 commits
-
-
Jake Hughes authored
Whether or not a store requires a write barrier depends on several invariants within V8. Some flags can break these invariants. In particular, it's not possible to use enable_single_generation with incremental marking because marking barriers are omitted in places where it is assumed an object will be allocated in the young generation. This CL introduces a new flag, enable_unconditional_write_barriers, which allows us to specify that full write barriers should always happens. The main purpose of this is to support single generation GC with incremental marking, but it can also aid as a debugging tool to check for missed write barriers. Bug: v8:10614 Change-Id: I3ab640436bcefc118c9c5c34765421cb9ea4896f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270546Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Release operation uses more expensive operations on some architectures. Change-Id: Iab84d92c84c791d429b6635641daadb2d608f791 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276039Reviewed-by:
-
Daniel Clifford authored
Also should address minor performance regressions for instance types that should (and used to) use map compare rather than instance_type comparison. In the process, convert a bunch of IsXXX methods from the CSA into exported Torque methods that call through to the Cast<> to ensure there is only a single implementation of the type checkers. Also clean up and remove duplicate/redundant code and unused Torque imports. Bug: v8:7793, chromium:1098481 Change-Id: I3cd5146d913bb75bab4f73415b1b94bc30924725 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270545 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68621}
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: I6bbb73ceb397b102783ecfcc553264d83e926df2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273126 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Prototype f64x2.nearest on ARM for both ARM v7 and ARM v8. ARM v8 has support for vrintn, and for ARM v7 we fallback to runtime. Since ARM v8 uses vrintn, which is the same instruction used for F64RoundTiesEven (scalar), wasm-compiler reuses the Float64RoundTiesEven check. Bug: v8:10553 Change-Id: Ia4c4245cac87c132331f54e81dad323fc3fb9f6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2268358Reviewed-by:
-
Daniel Clifford authored
e.g. the following is now valid Torque code: macro TestA(implicit c: Context)() {} macro TestB(): bool { return TestA(); } This is handy for more flexible usage of generics that may or may not use implicit parameters deep inside their specializations. Note that this change doesn't change the fundamental rigor (or lack thereof) around checking the usage of implicit parameters, which already do not require '_' before their parameter identifier if unused. It just silences errors in cases where a call site doesn't implicitly pass a parameter that ultimately doesn't have a use site and adds meaningful error messages in the case that it does. Bug: v8:7793 Change-Id: I559d06c0864a7e79fe52bee5a9a7af9941889748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274127 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: -
Mike Stanton authored
Often at the d8 prompt, you'd like to explore some pointer found from calls to %DebugPrint(). %DebugPrintPtr() takes a pointer and attempts to print it as an object. Change-Id: Ibc3368136a2ed92f400b52dbf2855f3c7d80d887 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276046Reviewed-by:
-
Jakob Gruber authored
This is likely the major change of the series, as Call nodes are the focus of call reducer (and to a lesser extent other phases like inlining). This CL essentially adds the new input to Call nodes, and updates the rest of the pipeline. As a (fairly large) drive-by, I also introduce the JSCallNode wrapper class and apply it in call reducer. This change, although large, will hopefully make future refactorings *much* easier, since it is now clear where certain assumptions about Call node layout are made. Bug: v8:8888 Change-Id: Ia15fe0ba459b6034863a5815a4e4662cee41fc83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264353 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Id88f9a9334160687af5f6234bc1cb30472949684 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274131 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Dominik Inführ authored
OldGenerationAllocationCounter() needs to be invoked in safepoint, otherwise invocation races with background threads incrementing the counter. First landed in https://crrev.com/c/2235544 and relanded in https://crrev.com/c/2259854 because of regressions. This CL also invokes UpdateNewSpaceAllocationCounter() in the safepoint. Bug: v8:10315 Change-Id: I6104bed0aad848250feecfe51d6d849b184a8842 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2260560 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
This patch does not include support for RTTs for i31ref yet. Bug: v8:7748 Change-Id: Ifbeb8e305c2d0a57e4d5d6be761d046e330e0da1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273135 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: v8:10658 Change-Id: Iccc20acea0b506e8acffca944d19b70af011ee3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276035 Auto-Submit: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Camillo Bruni authored
- Support loading combined trace json files from telemetry - Add "Blink RCS" source to separate blink details - Add prompt for naming newly loaded files - Add Group.addsToTotal variable for easier unclassified tracking Drive-by-fix: use let instead of var Change-Id: I5e471d8d1462987d1da98c2229090215c1fc6179 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273857 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#68611}
-
Andreas Haas authored
R=clemensb@chromium.org Bug: v8:10108 Change-Id: Ibfcef171e1a34153ea925aa657e66e7720c416ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274130 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Emit live bytes and evacuation mode as text for evacuated pages. Also emit the number of evacuated pages. Change-Id: Iadf1ac60f4fd35774f879277efb0b83fac39dd63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273136Reviewed-by:
-
Michael Achenbach authored
Mostly gc-related flags didn't flush out any bugs yet, but often reduce test performance and lead to timeouts. No-Try: true Bug: chromium:1044942 Change-Id: I2a7b55f78bfa3d597de1a5674658829e0812d01a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273861Reviewed-by:
-
Michael Achenbach authored
Previously we ran baseline (e.g. ignition) and one random secondary comparison configuration (e.g. turbofan) from the list of experiments. But Clusterfuzz imposes limitations on the total amount of fuzz tests. Therefore this change enables more throughput by always running the default configuration (ignition_turbofan like V8 is shipped) additionally to the baseline and the secondary configuration. This, hence, doubles the number of comparisons we run, with less than 50% additional runtime, since the slow baseline configuration is only run once. The experiments table is updated accordingly. Explicit entries running ignition_turbofan are removed (as it always runs now), instead some of the other configurations are increased in their relative percentage. We also get a few new configurations that didn't run before (e.g. forcing the slow path on x86). No-Try: true Bug: chromium:1100114 Change-Id: I69b2a41d78c06e556b309743a2aace1053c22f91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270307Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68607}
-
Simon Que authored
This is a reland of 32b685fa There was an unrelated breakage. See https://crbug.com/v8/10655#c10 Original change's description: > infra: Set gcc builders not to use Goma > > NOTRY=true > NOTREECHECKS=true > > Bug: chromium:1100009 > Change-Id: I67deb383d41e6609d5c3215e02422c8b1c16f8f4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2272738 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68593} TBR=liviurau@chromium.org NOTREECHECKS=true Bug: chromium:1100009 Change-Id: If59371bbe474383156effc6dfc92d848c304a416 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276031Reviewed-by:
-
zeynepCankara authored
Indicium is a new tool that integrates all our Map and IC processing tools into one tool. This CL does not attempt to cleanly integrate the Map Processor and IC explorer, but provides an in initial starting point for further integration work. Bug: v8:10644 Change-Id: I753c116fd409c8c07613bf15f22e14aa1e8c8a0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2259935 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#68605}
-
Camillo Bruni authored
Bug: chromium:1098842 Change-Id: Id29edfda99f49a167a03b5158396a07559c75907 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270231Reviewed-by:
-
Clemens Backes authored
It seems that the mix of atomic and non-atomic updates to the same memory location is not working correctly. One fix is changing all memory updates to be atomic. Another fix is removing the non-atomic access that happens while the workers are already running (using atomic accesses). This CL implements the latter. R=ahaas@chromium.org Bug: v8:10647, v8:10650 Change-Id: I84b4f3f442b6be3c4ea6e51962a523f443f5e43b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273133Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68603}
-
Manos Koukoutos authored
Change-Id: I04902e3f91dae6083b3de7630fd91d49ad805a2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2272565 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d83f4a5..3a5fbeb Rolling v8/third_party/aemu-linux-x64: FN-ckx_oV2JTqPuW3iMG50qdN5FgGqm-4XP9AkoLwPUC..I_sHBnheTA3cmFAjzkyUAhsmhpWXu82YLidstkjgsvIC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8353ff9..de622ae Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6e6c67d..d9391fd Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2479626..6849229 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e7c14e44cf7dc89f4a410a498af0ee306d9f0f2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274519Reviewed-by:
-
Zhao Jiazhong authored
On mips platform, call operations may be followed by trampolines, which leading to wrong information of the call instr's location in safepoint. This CL fix it by adding a last_call_pc_ to record the location. Besides, this CL also fix a bind operation in CheckTrampolinePool, which may try to use trampoline before it's emission. Change-Id: Ic0cbdb93afffa60a7389ee8177c381087fcaf52e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2095645 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
-
Zhi An Ng authored
This reverts commit fa9c6e17. Reason for revert: Didn't fix the build. Original change's description: > Revert "Add support for __declspec(nocf)." > > This reverts commit 0c58583b. > > Reason for revert: https://crbug.com/v8/10656 and failures in https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20-%20msvc/14135 > > Original change's description: > > Add support for __declspec(nocf). > > > > __declspec(nocf) syntax was added in https://reviews.llvm.org/D72167 > > and annotates that checks should not be added on indirect calls > > within that function. > > > > BUG=chromium:584575 > > > > Change-Id: Ib2e2d2a827186a9c1fd3de15356b2b04d6a69e49 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270707 > > Reviewed-by: Clemens Backes <clemensb@chromium.org> > > Commit-Queue: Will Harris <wfh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#68590} > > TBR=wfh@chromium.org,clemensb@chromium.org > > Change-Id: Icec64feb44715a65e905a93e0c47fb37d4f11a09 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:584575 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274736 > Reviewed-by: Zhi An Ng <zhin@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68598} TBR=wfh@chromium.org,clemensb@chromium.org,zhin@chromium.org Bug: chromium:584575 Change-Id: I0e305374c8325d87e4b18963da4e90802f136187 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274356 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#68599}
-
- 29 Jun, 2020 1 commit
-
-
Zhi An Ng authored
This reverts commit 0c58583b. Reason for revert: https://crbug.com/v8/10656 and failures in https://ci.chromium.org/p/v8/builders/ci/V8%20Win64%20-%20msvc/14135 Original change's description: > Add support for __declspec(nocf). > > __declspec(nocf) syntax was added in https://reviews.llvm.org/D72167 > and annotates that checks should not be added on indirect calls > within that function. > > BUG=chromium:584575 > > Change-Id: Ib2e2d2a827186a9c1fd3de15356b2b04d6a69e49 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270707 > Reviewed-by: Clemens Backes <clemensb@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68590} TBR=wfh@chromium.org,clemensb@chromium.org Change-Id: Icec64feb44715a65e905a93e0c47fb37d4f11a09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:584575 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274736Reviewed-by:
-
