- 20 Jul, 2018 30 commits
-
-
Caitlin Potter authored
As discussed in https://docs.google.com/document/d/1sBdGe8RHgeYP850cKSSgGABTyfMdvaEWLy-vertuTCo/edit?ts=5b3ba5cc#, this CL introduces a new bytecode (CloneObject), and a new IC type. In this prototype implementation, the type feedback looks like the following: Uninitialized case: { uninitialized_sentinel, uninitialized_sentinel } Monomorphic case: { weak 'source' map, strong 'result' map } Polymorphic case: { WeakFixedArray with { weak 'source' map, strong 'result' map }, cleared value } Megamorphic case: { megamorphic_sentinel, cleared_Value } In the fast case, Object cloning is done by allocating an object with the saved result map, and a shallow clone of the fast properties from the source object, as well as cloned fast elements from the source object. If at any point the fast case can't be taken, the IC transitions to the slow case and remains there. This prototype CL does not include any TurboFan optimization, and the CloneObject operation is merely reduced to a stub call. It may still be possible to get some further improvements by somehow incorporating compile-time boilerplate elements into the cloned object, or simplifying how the boilerplate elements are inserted into the object. In terms of performance, we improve the ObjectSpread score in JSTests/ObjectLiteralSpread/ by about 8x, with substantial improvements over the Babel and ObjectAssign scores. R=gsathya@chromium.org, mvstanton@chromium.org, rmcilroy@chromium.org, neis@chromium.org, bmeurer@chromium.org BUG=v8:7611 Change-Id: I79e1796eb77016fb4feba0e1d3bb9abb348c183e Reviewed-on: https://chromium-review.googlesource.com/1127472 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#54595}
-
Simon Zünd authored
R=petermarshall@chromium.org Bug: v8:7754 Change-Id: I045daa428a7830fa110c74d6636921be36ca1dbe Reviewed-on: https://chromium-review.googlesource.com/1145278Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#54594}
-
Clemens Hammacher authored
The name {kLastErrorMessage} is misleading, as it's not actually the index of the last message (or reason), but one more (i.e. number of messages / reasons). Thus this renaming. R=mstarzinger@chromium.org Bug: v8:7754 Change-Id: Id21edcecac84c0e6068423c6124ef2881116dc7c Reviewed-on: https://chromium-review.googlesource.com/1145305 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54593}
-
Clemens Hammacher authored
For checks and assertions (mostly for debug code, like stack alignment or zero extension), we had two modes: Emit a call to the {Abort} runtime function (the default), and emit a debug break (used for testing, enabled via --trap-on-abort). In wasm, where we cannot just call a runtime function because code must be isolate independent, we always used the trap-on-abort behaviour. This causes problems for our fuzzers, which do not catch SIGTRAP, and hence do not detect debug code failures. This CL introduces a third mode ("hard abort"), which calls a C function via {ExternalReference}. The C function still outputs the abort reason, but does not print the stack trace. It then aborts via "OS::Abort", just like the runtime function. This will allow fuzzers to detect the crash and even find a nice error message. Even though this looks like a lot of code churn, it is actually not. Most added lines are new tests, and other changes are minimal. R=mstarzinger@chromium.org Bug: chromium:863799 Change-Id: I77c58ff72db552d49014614436259ccfb49ba87b Reviewed-on: https://chromium-review.googlesource.com/1142163 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:7754 Change-Id: Ia4c2fb2d87c8a5de96fa9f1f0621d21ae3eda611 Reviewed-on: https://chromium-review.googlesource.com/1145181Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#54591}
-
Clemens Hammacher authored
The most important point of IWYU (include-what-you-use) is that each header includes everything it is using, so that whoever includes that header does not need to additionally include other things. This CL adds a script which generates files to automatically check this. It is automatically invoked during "gclient runhooks" if the "check_v8_header_includes" variable is set. This script generates a number of .cc files in the "check-header-includes" directory, together with a "sources.gni" file which lists all the generated cc files. Each file includes one header. If additionally the gn args "v8_check_header_includes" is set, this gni file is included, and all the generated CC files will be compiled. This will detect violations of the aforementioned IWYU rule. R=titzer@chromium.org, machenbach@chromium.org Bug: v8:7754, v8:7965 Change-Id: Id1cf256507052c3a9ea82f8c80ea1c0385457e31 Reviewed-on: https://chromium-review.googlesource.com/1145199 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#54590}
-
Marja Hölttä authored
string-builder.h was using functions defined in *-inl.h and that's not allowed. BUG=v8:7754,v8:7490 Change-Id: I442ff761f3a5799b60c0d02f7130bf694dca9b1b Reviewed-on: https://chromium-review.googlesource.com/1145185Reviewed-by:
-
Simon Zünd authored
R=petermarshall@chromium.org Bug: v8:7754 Change-Id: I5dde8026c80f279606c4c35c546dd41a2872aa3b Reviewed-on: https://chromium-review.googlesource.com/1145189Reviewed-by:
-
Georg Neis authored
Change-Id: Iadfec0133d45f6539fd0b2b5fbea0e39ab7dfc29 Reviewed-on: https://chromium-review.googlesource.com/1145180Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#54587}
-
Simon Zünd authored
R=petermarshall@chromium.org Bug: v8:7754 Change-Id: I70e433cda81629496aef0b5b2c8b379787765c31 Reviewed-on: https://chromium-review.googlesource.com/1144932 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Michael Achenbach authored
TBR=yangguo@chromium.org NOTRY=true Bug: v8:7963 Change-Id: I1a91047b2a3c7d128f3b01a0970ce53a63c196d6 Reviewed-on: https://chromium-review.googlesource.com/1145187Reviewed-by:
-
Michael Starzinger authored
R=petermarshall@chromium.org BUG=v8:7754 Change-Id: I44d5c808195b676c05f7d4837ad18cd33c377840 Reviewed-on: https://chromium-review.googlesource.com/1145067Reviewed-by:
-
Marja Hölttä authored
This reduces the build steps from touching api.h: 269 -> 156 BUG=v8:7754,v8:7490 Change-Id: I75abaeea4cc78027a47304ff9b9f6b12bdb2b75e Reviewed-on: https://chromium-review.googlesource.com/1144929Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54583}
-
Michael Starzinger authored
R=titzer@chromium.org BUG=v8:7754 Change-Id: Icf17677a3ca3c9be153b68a9a6f939259e7b7b5f Reviewed-on: https://chromium-review.googlesource.com/1143263 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:7754 Change-Id: Iffd3a2f665258032e2284e5cd700f9a3286618d1 Reviewed-on: https://chromium-review.googlesource.com/1145064Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54581}
-
Simon Zünd authored
R=jgruber@chromium.org Bug: v8:7754 Change-Id: Iec5f0a3f4f948a5f55c112324f4db68c69df2dbd Reviewed-on: https://chromium-review.googlesource.com/1145061Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#54580}
-
Leszek Swirski authored
Adds an Isolate::FromWritableHeapObject method, with a bool return value and Isolate* out parameter, and replace most accesses to Isolate via MemoryChunk (which handle objectsin ROSpace rather than just failing) to use that instead. Bug: v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Idb472a3d6037deed92e6fa8c8a7a1a14293e2462 Reviewed-on: https://chromium-review.googlesource.com/1144933 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#54579}
-
Marja Hölttä authored
BUG=v8:7754,v8:5402 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I5306005e7d0fcfe188c9e0270a003c6e1098c9e9 Reviewed-on: https://chromium-review.googlesource.com/1144824Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/20c1311..3899f1b Rolling v8/tools/luci-go: https://chromium.googlesource.com/chromium/src/tools/luci-go/+log/abcd908..445d7c4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ibd109913b42c2bd758855378ac61fb1a6a4f5cfe Reviewed-on: https://chromium-review.googlesource.com/1145040Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#54577}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:838864 Change-Id: I8242537847615848a3c2e6bdf39509c4692882ae Reviewed-on: https://chromium-review.googlesource.com/1143474 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Andreas Haas authored
This function has been deprecated for month by now. R=ulan@chromium.org Bug: v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I19d1b41bad2849b7f3d4d6684dc6f0f80af081f0 Reviewed-on: https://chromium-review.googlesource.com/1144922Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#54575}
-
Tobias Tebbi authored
Bug: v8:7793 Change-Id: I208edf856f0283d840358f3c11bab97af0397056 Reviewed-on: https://chromium-review.googlesource.com/1095192Reviewed-by:
Daniel Clifford <danno@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#54574}
-
Toon Verwaest authored
Bug: chromium:861953 Change-Id: Id3a57aca0b24c421ac959d69265c449eaa214c16 Reviewed-on: https://chromium-review.googlesource.com/1138083 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#54573}
-
Michael Starzinger authored
This is a reland of 0f2d22dd Original change's description: > [wasm] Improve module code size sampling approach. > > This samples module code sizes at GC time instead of during destruction. > It hence makes sure that we also receive samples for long-lived modules > which would otherwise die with the Isolate and never be finalized. Note > that this approach is still biased and just a stop-gap until we have a > sampling tick based on actual wall-clock time. > > R=clemensh@chromium.org > > Change-Id: I9558d383a5aada8876bc9cbf63baca771dbe5c28 > Reviewed-on: https://chromium-review.googlesource.com/1141866 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54554} Change-Id: I1863e94bbe91c89c248ddf8fc700ff91bc3593b2 Reviewed-on: https://chromium-review.googlesource.com/1143344Reviewed-by:
-
Yang Guo authored
R=machenbach@chromium.org Change-Id: Ia50f6e637aec58e9c1bdd726c84b296fd71d7cbb Reviewed-on: https://chromium-review.googlesource.com/1142767Reviewed-by:
-
Sergiy Byelozyorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/abdb548..385916c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/26d6aff..d26f5c3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f9afc77..20c1311 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/5d1ce93..f30572c TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic4e31241686394601dc3667f5159184f03789ef2 Reviewed-on: https://chromium-review.googlesource.com/1144645 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Simon Zünd authored
Drive-by change: Add "at" method to ZoneChunkList. R=petermarshall@chromium.org Bug: v8:7754 Change-Id: I75f4e3f786640f2a53b467aab18abe01b4f5b360 Reviewed-on: https://chromium-review.googlesource.com/1144823Reviewed-by:
-
Georg Neis authored
Chrome-crash tells me that occasionally a function gets stripped of an initial map entirely (e.g. report 917de3c31d0e0d9b). R=jarin@chromium.org Change-Id: Ie0103695c4801a4c2cbc488af91c3d580efe4eab Reviewed-on: https://chromium-review.googlesource.com/1143483Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7932 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia29e9e62022f0820c3a5aaf48a7724b13b61b275 Reviewed-on: https://chromium-review.googlesource.com/1143186Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#54567}
-
Jaroslav Sevcik authored
This will simplify the optimizing compiler (no need to pretenure COW arrays when compiling). Bug: v8:7790 Change-Id: I7502f43c6b6f7e10bce8536352462731083b5bef Reviewed-on: https://chromium-review.googlesource.com/1143466Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#54566}
-
- 19 Jul, 2018 10 commits
-
-
Deepti Gandluri authored
Currently AtomicStores use AtomicExchange to store to memory, but AtomicExchange produces an output that is ignored by the AtomicStore visitor, a side effect of this is that a register already in use gets overwritten by the output of the exchange. BUG:v8:7602 Change-Id: I4ec3107a0a27503611e349e6f56ca9492d05d9f8 Reviewed-on: https://chromium-review.googlesource.com/1134576Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#54565}
-
Tobias Tebbi authored
Bug: v8:7929 v8:7793 Change-Id: I7d9cdd0fb3e36ae6e81683cc4c3746f6ea119d15 Reviewed-on: https://chromium-review.googlesource.com/1138077Reviewed-by:
-
Dan Elphick authored
Uses the new Isolate version of methods. Bug: v8:7754 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I1a38dd61d10899ae33ef796f4f443b11640315c2 Reviewed-on: https://chromium-review.googlesource.com/1143861 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Tobias Sargeant authored
Change-Id: I5977c58d7d39f5f13352234f0d016c47ce9be133 Reviewed-on: https://chromium-review.googlesource.com/1143465Reviewed-by:
-
Junliang Yan authored
CHECK is accessing 1 byte across object boundary because *expect and *actual will return the object address with tag. And memcmp should return 0 if we expect (expected == actual) R=cbruni@chromium.org, gsathya@chromium.org, ishell@chromium.org Bug: v8:6443, v8:7569 Change-Id: I316e450a80400cea4c9394dbe470932a1f30cea5 Reviewed-on: https://chromium-review.googlesource.com/1142351Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#54561}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ib4f84d9b0bb2c54d5e1743c34b4034b14cb1152a Reviewed-on: https://chromium-review.googlesource.com/1143188Reviewed-by:
-
Michael Hablich authored
TBR=machenbach@chromium.org NOTRY=true Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I13105e27794ebbfdfc57ca351959b92bfbbad7c7 Reviewed-on: https://chromium-review.googlesource.com/1143280 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#54559}
-
Simon Zünd authored
This CL changes Array.p.fill to use the baseline implementation for everything other than JSArray. One of the reasons is that shadowing the length property on TypedArrays (and other ElementsKinds) is allowed and should be respected by Array.p.fill. The fast-path for fill for TypedArrays expects the indices to be clamped to the actual length of the underlying backing store and not to some length property. While this mismatch (and others) could probably be handled properly, we do the conservative thing and only use the fast-path for specific JSArrays. R=jgruber@chromium.org Bug: chromium:865312 Change-Id: Ib3050e3bfc22d47ca8597b6df34788dc2b59b6e1 Reviewed-on: https://chromium-review.googlesource.com/1142772Reviewed-by:
-
Michael Starzinger authored
This reverts commit 0f2d22dd. Reason for revert: Caused a race discovered by TSAN. Original change's description: > [wasm] Improve module code size sampling approach. > > This samples module code sizes at GC time instead of during destruction. > It hence makes sure that we also receive samples for long-lived modules > which would otherwise die with the Isolate and never be finalized. Note > that this approach is still biased and just a stop-gap until we have a > sampling tick based on actual wall-clock time. > > R=clemensh@chromium.org > > Change-Id: I9558d383a5aada8876bc9cbf63baca771dbe5c28 > Reviewed-on: https://chromium-review.googlesource.com/1141866 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54554} TBR=ulan@chromium.org,mstarzinger@chromium.org,clemensh@chromium.org Change-Id: Ie1fc99ad0ef36b30a73cc464808ce7679a0f15df No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1143284Reviewed-by:
-
Maya Lekova authored
This reverts commit 941d5f96. Reason for revert: Regressed performance tests https://bugs.chromium.org/p/chromium/issues/detail?id=864540 Original change's description: > [turbofan] Remove optimization for Cons strings > > We used to have an optimized version for nodes that are concatenating > two strings which was allocating an object on the heap, therefore > preventing this code from being executed on the compiler thread. > Octane benchmark results show insignificant increase in performance > (< 0.5%) without this optimization - see > https://docs.google.com/spreadsheets/d/1MC5NrMoMSsqxZqw0ojoZvomBb7q2EOt1S0sFoJ8ld2c/edit?usp=sharing > which leads to the conclusion we can safely remove the optimization for now. > > Bug: v8:7790 > Change-Id: I6492c6a76118cac568d28805995d55c5360bb123 > Reviewed-on: https://chromium-review.googlesource.com/1138246 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#54467} TBR=jarin@chromium.org,neis@chromium.org,mslekova@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7790 Change-Id: I20a8a11e40bcd2bcfaf58154a1ab5e4daa7a25e4 Reviewed-on: https://chromium-review.googlesource.com/1143144 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
