- 30 Jun, 2017 1 commit
-
-
Mathias Bynens authored
The `FAST_` prefix doesn’t make much sense — they’re all just different cases with their own optimizations. Packedness being implicit (e.g. `FAST_ELEMENTS` vs. `FAST_HOLEY_ELEMENTS`) is not ideal, either. This patch renames the FAST elements kinds as follows: - e.g. FAST_ELEMENTS => PACKED_ELEMENTS - e.g. FAST_HOLEY_ELEMENTS => HOLEY_ELEMENTS The following exceptions are left intact, for lack of a better name: - FAST_SLOPPY_ARGUMENTS_ELEMENTS - SLOW_SLOPPY_ARGUMENTS_ELEMENTS - FAST_STRING_WRAPPER_ELEMENTS - SLOW_STRING_WRAPPER_ELEMENTS This makes it easier to reason about elements kinds, and less confusing to explain how they’re used. R=jkummerow@chromium.org, cbruni@chromium.org BUG=v8:6548 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ie7c6bee85583c3d84b730f7aebbd70c1efa38af9 Reviewed-on: https://chromium-review.googlesource.com/556032Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#46361}
-
- 31 Oct, 2016 1 commit
-
-
adamk authored
Both --harmony-object-values-entries and --harmony-object-own-property-descriptors are on by default in v8 5.4, which has now shipped to stable as Chrome 54. R=caitp@igalia.com Review-Url: https://codereview.chromium.org/2464733003 Cr-Commit-Position: refs/heads/master@{#40683}
-
- 28 Mar, 2016 1 commit
-
-
caitpotter88 authored
Add support for optimizing objects with elements, which do not invoke JS and cannot change the shape of the Object. BUG=v8:4663 LOG=N Review URL: https://codereview.chromium.org/1767113004 Cr-Commit-Position: refs/heads/master@{#35081}
-
- 21 Mar, 2016 1 commit
-
-
adamk authored
Both of them shipped in Chrome 49 without incident. Also move relevant tests from harmony/ to es6/. Review URL: https://codereview.chromium.org/1815773002 Cr-Commit-Position: refs/heads/master@{#34964}
-
- 08 Feb, 2016 1 commit
-
-
caitpotter88 authored
Previously, Object.values() and Object.entries() were piggy-backing on Object.keys(). This meant that they would pre-filter non-enumerable properties, violating the runtime behaviour of the methods. Unfortunately, this does not match the current proposal text. Also incorporates several tests verifying this behaviour based on tests included in the ChakraCore implementation. In this reland, the new patch fills up the longer-lasting FixedArray with `undefined` to avoid the crash in Heap::Verify(). Originally reviewed at https://codereview.chromium.org/1637753004 BUG=v8:4663 LOG=N R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org Review URL: https://codereview.chromium.org/1673673002 Cr-Commit-Position: refs/heads/master@{#33818}
-
- 05 Feb, 2016 2 commits
-
-
machenbach authored
Revert of [es7] refactor and fix Object.values() / Object.entries() (patchset #6 id:100001 of https://codereview.chromium.org/1637753004/ ) Reason for revert: [Sheriff] Breaks gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/1642 Original issue's description: > [es7] refactor and fix Object.values() / Object.entries() > > Previously, Object.values() and Object.entries() were piggy-backing on > Object.keys(). This meant that they would pre-filter non-enumerable properties, > violating the runtime behaviour of the methods. Unfortunately, this does not > match the current proposal text. > > Also incorporates several tests verifying this behaviour based on tests included > in the ChakraCore implementation. > > BUG=v8:4663 > LOG=N > R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org > > Committed: https://crrev.com/5c5ccd9d7f8693990d1a9eb26ba3a94f376dcf0b > Cr-Commit-Position: refs/heads/master@{#33782} TBR=littledan@chromium.org,adamk@chromium.org,cbruni@chromium.org,rossberg@chromium.org,caitpotter88@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4663 Review URL: https://codereview.chromium.org/1675663002 Cr-Commit-Position: refs/heads/master@{#33787}
-
caitpotter88 authored
Previously, Object.values() and Object.entries() were piggy-backing on Object.keys(). This meant that they would pre-filter non-enumerable properties, violating the runtime behaviour of the methods. Unfortunately, this does not match the current proposal text. Also incorporates several tests verifying this behaviour based on tests included in the ChakraCore implementation. BUG=v8:4663 LOG=N R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org Review URL: https://codereview.chromium.org/1637753004 Cr-Commit-Position: refs/heads/master@{#33782}
-
- 22 Jan, 2016 1 commit
-
-
caitpotter88 authored
BUG=v8:4663 LOG=N TBR=hpayer@chromium.org R=ljharb@gmail.com, rossberg@chromium.org, adamk@chromium.org Review URL: https://codereview.chromium.org/1581033002 Cr-Commit-Position: refs/heads/master@{#33450}
-