1. 30 Jun, 2017 1 commit
    • Mathias Bynens's avatar
      [elements] Rename FAST elements kinds · 26c00f4a
      Mathias Bynens authored
      The `FAST_` prefix doesn’t make much sense — they’re all just different cases
      with their own optimizations. Packedness being implicit (e.g. `FAST_ELEMENTS`
      vs. `FAST_HOLEY_ELEMENTS`) is not ideal, either.
      
      This patch renames the FAST elements kinds as follows:
      
      - e.g. FAST_ELEMENTS => PACKED_ELEMENTS
      - e.g. FAST_HOLEY_ELEMENTS => HOLEY_ELEMENTS
      
      The following exceptions are left intact, for lack of a better name:
      
      - FAST_SLOPPY_ARGUMENTS_ELEMENTS
      - SLOW_SLOPPY_ARGUMENTS_ELEMENTS
      - FAST_STRING_WRAPPER_ELEMENTS
      - SLOW_STRING_WRAPPER_ELEMENTS
      
      This makes it easier to reason about elements kinds, and less confusing to
      explain how they’re used.
      
      R=jkummerow@chromium.org, cbruni@chromium.org
      BUG=v8:6548
      
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
      Change-Id: Ie7c6bee85583c3d84b730f7aebbd70c1efa38af9
      Reviewed-on: https://chromium-review.googlesource.com/556032Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
      Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
      Commit-Queue: Mathias Bynens <mathias@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46361}
      26c00f4a
  2. 31 Oct, 2016 1 commit
  3. 28 Mar, 2016 1 commit
  4. 21 Mar, 2016 1 commit
  5. 08 Feb, 2016 1 commit
    • caitpotter88's avatar
      reland [es7] refactor and fix Object.values() / Object.entries() · e708dd54
      caitpotter88 authored
      Previously, Object.values() and Object.entries() were piggy-backing on
      Object.keys(). This meant that they would pre-filter non-enumerable properties,
      violating the runtime behaviour of the methods. Unfortunately, this does not
      match the current proposal text.
      
      Also incorporates several tests verifying this behaviour based on tests included
      in the ChakraCore implementation.
      
      In this reland, the new patch fills up the longer-lasting FixedArray with
      `undefined` to avoid the crash in Heap::Verify().
      
      Originally reviewed at https://codereview.chromium.org/1637753004
      
      BUG=v8:4663
      LOG=N
      R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org
      
      Review URL: https://codereview.chromium.org/1673673002
      
      Cr-Commit-Position: refs/heads/master@{#33818}
      e708dd54
  6. 05 Feb, 2016 2 commits
  7. 22 Jan, 2016 1 commit