1. 25 Oct, 2021 1 commit
    • Jakob Gruber's avatar
      [regexp] Only emit valid ranges in MakeRangeArray · b7dc9915
      Jakob Gruber authored
      Character class handling in the irregexp pipeline is quite complex;
      codepoints outside the BMP (basic multilingual plane) are only
      translated into surrogate pairs when needed, e.g. when the subject
      string is two-byte. If not needed, the codepoints simply stay part of
      the list of CharacterRanges.
      
      In EmitCharClass, we determine the valid subset of ranges through
      ranges_length; until this CL, we forgot to pass that information on to
      MakeRangeArray. Do that now by truncating the list of CharacterRanges.
      
      Fixed: chromium:1262423
      Change-Id: I5bb5b839e9935890ca2d10908ad66d72c3217178
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3240782
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Auto-Submit: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#77514}
      b7dc9915
  2. 26 Jan, 2021 1 commit
  3. 27 Jun, 2019 1 commit
  4. 11 Apr, 2017 1 commit
    • gsathya's avatar
      [ESNext] Implement DynamicImportCall · 94283dcf
      gsathya authored
      This patch implements the runtime semantics of dynamic import.
      
      We create a new ASTNode so that we can pass the JSFunction closure() to
      the runtime function from which we get the script_url.
      
      d8 implements the embedder logic required to load and evaluate the modules.
      
      The API is mostly implemented as specified.
      
      BUG=8:5785
      
      Review-Url: https://codereview.chromium.org/2703563002
      Cr-Commit-Position: refs/heads/master@{#44551}
      94283dcf
  5. 28 Feb, 2017 1 commit
  6. 17 Feb, 2017 1 commit
    • vabr's avatar
      Report unexpected lexical decl also without destructuring · 454816f0
      vabr authored
      https://codereview.chromium.org/2694003002/ introduced
      "SyntaxError: Lexical declaration cannot appear in a single-statement context"
      for the case when let + desctructuring from a list happen.
      
      As was pointed out in https://codereview.chromium.org/2694003002/#msg18, the
      case without destructuring would also benefit from a better message: if a
      single statement is expected and "let identifier = ..." is seen, the error is
      indeed again that the lexical declaration is not a statement. However, the current
      error is "Unexpected identifier", because the parser tries to accept "let" as
      an identifier in an expression statement, and then gives up seeing the other
      identifier after "let".
      
      This CL ensures that the parser recognises the error properly and reports
      accordingly. It also renames the existing test, which contains destructuring,
      and adds the one with a non-destructuring lexical declaration.
      
      BUG=v8:5686
      
      Review-Url: https://codereview.chromium.org/2697193007
      Cr-Commit-Position: refs/heads/master@{#43275}
      454816f0
  7. 16 Feb, 2017 1 commit
  8. 16 Jan, 2017 1 commit
  9. 12 Jan, 2017 1 commit
  10. 04 Jan, 2017 1 commit