- 13 Dec, 2018 3 commits
-
-
Clemens Hammacher authored
Uses of the old API were removed from chromium in https://crrev.com/c/1373749. R=adamk@chromium.org Bug: chromium:912031 Change-Id: I3fed4d72c147ef8e00ec96f869af2134e7ee71c8 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1373769Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58205}
-
Yutaka Hirano authored
Currently v8::Promise::Then takes only one handler. It should take two handlers, on_fulfilled and on_rejected like ECMAScript Promise. Bug: chromium:912848 Change-Id: I08a20990a27b3f8621225fad42a8de1dad67796f Reviewed-on: https://chromium-review.googlesource.com/c/1375509Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#58204}
-
Frank Tang authored
TBR=jshin@chromium.org Bug: v8:8469 Change-Id: I60f7868a19eec925a597f1355182c2fd8550a2d2 Reviewed-on: https://chromium-review.googlesource.com/c/1374990Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#58203}
-
- 12 Dec, 2018 30 commits
-
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/407b393..2823bdd7 https://chromium-review.googlesource.com/c/chromium/src/+/1373009 The following change includes: 2823bdd7 Fix crash of new Intl.DateTimeFormat("ja-u-tz-uslax") Test: v8: intl/regress-8469 Bug: v8:8469 Change-Id: I349402026744cce44269a7ef5a3c6e416a8d9ff6 Reviewed-on: https://chromium-review.googlesource.com/c/1372073 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#58202}
-
Michael Achenbach authored
This reverts commit 2e36e9ea. Reason for revert: Missing explicit include in cc file: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Presubmit/986 Original change's description: > Don't use |v8_initializers| code in |v8_base| > > Removing |CodeStubAssembler| from |v8_base| source list (see > https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to > linkage problems with some build configurations because it was explicitly > and implicitly included in |v8_base| code. > > This CL decouple this code and fixes problems. > > Bug: v8:7777 > Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189 > Reviewed-on: https://chromium-review.googlesource.com/c/1372067 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58200} TBR=jkummerow@chromium.org,jgruber@chromium.org,bmeurer@chromium.org,atimoxin@yandex-team.ru Change-Id: I3e41fb5f8a9db6a78c56546a08e55610885d312b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7777 Reviewed-on: https://chromium-review.googlesource.com/c/1374292Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58201}
-
Alexander Timokhin authored
Removing |CodeStubAssembler| from |v8_base| source list (see https://chromium-review.googlesource.com/c/v8/v8/+/1346329) leads to linkage problems with some build configurations because it was explicitly and implicitly included in |v8_base| code. This CL decouple this code and fixes problems. Bug: v8:7777 Change-Id: I58de5c62914bc77645ed6cc9114409890bc13189 Reviewed-on: https://chromium-review.googlesource.com/c/1372067Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58200}
-
Clemens Hammacher authored
This information is already stored in ControlBase::stack_depth. R=titzer@chromium.org Bug: v8:8423 Change-Id: Ie707878b5d7ee5180e44881086d05a590c0dea21 Reviewed-on: https://chromium-review.googlesource.com/c/1373786Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58199}
-
Clemens Hammacher authored
The {last_end_found_} field is redundant. If it's false, there will be a control struct left on the stack. Thus remove that field, and simplify the error detection condition. R=titzer@chromium.org Bug: v8:8423 Change-Id: I16ac4597f229c5e3abd923f8eb504f93afb82eb4 Reviewed-on: https://chromium-review.googlesource.com/c/1373788Reviewed-by: -
Clemens Hammacher authored
Should be num_locals, and const. R=titzer@chromium.org Bug: v8:8562 Change-Id: I60889c9912ef95d344ede4d7755028116feee47e Reviewed-on: https://chromium-review.googlesource.com/c/1373784Reviewed-by:
-
Ben Smith authored
`memory.init` copies bytes from a passive data segment to linear memory. `memory.drop` is an instruction that informs the wasm VM that the instance no longer needs access to the passive data segment. Information about the passive data segments, including their contents, length, and whether they are dropped, is stored in the `WasmInstanceObject` as primitive arrays. Bug: v8:7747 Change-Id: I1515c8868c9be227743456a539126c15280b5365 Reviewed-on: https://chromium-review.googlesource.com/c/1370691Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#58196}
-
Clemens Hammacher authored
Compilation failures are already stored in the {CompilationState}. We never use the information which individual compilation unit failed. Hence remove that getter, and only check for failure of the overall compilation. R=ahaas@chromium.org Bug: v8:7921, v8:8343 Change-Id: Ibf90be233c9ff576ec8a3413ba5abefe2fdb645e Reviewed-on: https://chromium-review.googlesource.com/c/1373783Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58195}
-
Jakob Gruber authored
There's no reason to restrict off-heap targets to builtin host Code objects during serialization. They can also occur e.g. in irregexp code created by embedded scripts. Drive-by: unify the list of reloc modes that have a target_address_address. Bug: v8:8572,v8:6666 Change-Id: I26dce735463b79677a7b7dcfdb604c5234b5f10b Reviewed-on: https://chromium-review.googlesource.com/c/1371568Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58194}
-
peterwmwong authored
InternalPackedArray now only has one constructor variant that expects no arguments (Chrome's only usage of InternalPackedArray). As such, these TFC builtins are no longer used and were removed: - InternalArrayNoArgumentConstructor_Holey - InternalArraySingleArgumentConstructor_Packed - InternalArraySingleArgumentConstructor_Holey On x64.release, this reduces builtins size by ~1.2KB. Bug: v8:7624 Change-Id: I7316608dc02b1e09e9e414ee1aeb1fb08410c6f6 Reviewed-on: https://chromium-review.googlesource.com/c/1372772 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
-
Tobias Tebbi authored
Bug: v8:8490 Change-Id: Id9b1b1d8a994b6f1fdd6d93355d3f9555710f6ac Reviewed-on: https://chromium-review.googlesource.com/c/1370030Reviewed-by:
-
Mythri authored
Currently, the runtime IC functions deduce the IC kind and the language mode from the feedback slot kind. To support feedback free execution (for V8 lite mode and lazy allocation of feedback vectors) we need to infer the IC kind even when feedback vectors are not present. To be able to infer the language mode without feedback vectors, this cl forces context allocation in cases where we raise the language mode in the middle of a function. The language mode is the stricter of the language mode on the SFI and the language mode of the current context. This cl updates the bytecode handlers to check for valid feedback vectors and to call into runtime if the feedback vector is not allocated. It also adds new runtime functions to be able to infer the IC kind when there is no feedback vector. Most of the builtins and handlers remain unchanged because they are only used when feedback vector is present. Bug: v8:8394 Change-Id: I1f77740c0d68ddaa0de076597f5f6bcb2e966d70 Reviewed-on: https://chromium-review.googlesource.com/c/1358516 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58191}
-
Clemens Hammacher authored
Neither the TF backend nor Liftoff use the signature, thus remove it. R=titzer@chromium.org Bug: v8:8423 Change-Id: I909e9a0095cac67aaefaebcb4240f7d9829e4c87 Reviewed-on: https://chromium-review.googlesource.com/c/1373777Reviewed-by:
-
Michael Starzinger authored
This makes sure we properly recognize a newline character as part of semicolon insertion, even if the newline appears after a CPP-style single line comment. The same applies for newlines within C-style multi line comments. R=clemensh@chromium.org TEST=mjsunit/asm/regress-913822 BUG=chromium:913822 Change-Id: I64f098d7e386dea7b7fb6c233c1625425e36bde0 Reviewed-on: https://chromium-review.googlesource.com/c/1373551Reviewed-by:
-
Max Moroz authored
Bug: chromium:701825, chromium:911856 Change-Id: Ic8d1ea35e0b21b481aab4c87037de6646ddfe450 Reviewed-on: https://chromium-review.googlesource.com/c/1372072 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58188}
-
Michael Achenbach authored
This reverts commit 98bbb636. Reason for revert: https://crbug.com/v8/8584 Original change's description: > [build] Pull binutils via DEPS > > This pulls binutils from a subtreed repository of Chromium: > https://chromium.googlesource.com/chromium/src/third_party/binutils/ > > Bug: chromium:718157 > Change-Id: I532c7e84d83f716728e4f9f715cfdb82ea5d5f98 > Reviewed-on: https://chromium-review.googlesource.com/c/1370043 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58180} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org Change-Id: I43126c54846b14de10a0cd6bdc0b9d6e2e64999c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:718157 Reviewed-on: https://chromium-review.googlesource.com/c/1373780Reviewed-by:
-
Ross McIlroy authored
Bytecode flushing can overwrite a bytecode array with an UncompiledDataWithoutPreParsedScope. Since the bytecode array could be in the LO space, then we also need to allow UncompiledDataWithoutPreParsedScope in the LO space if it has overwritten a large bytecode array. BUG=v8:8395 Change-Id: I1b83b5c7a61830f5576260a4f4f4c0b689818acc Reviewed-on: https://chromium-review.googlesource.com/c/1373775 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Igor Sheludko authored
and update visitors to not look at raw part. This will allow to have effecient access to embedder data once kTaggedSize is switched to 32-bit value. Bug: v8:8518 Change-Id: Ia1875a5ac5f3fb85df5c5555b970fd88d9e8d7a4 Reviewed-on: https://chromium-review.googlesource.com/c/1369957Reviewed-by:
-
Andreas Haas authored
To allow any-ref parameters, we have to make sure that any-ref stack parameters get seen by the GC. This CL is a first step into that direction. The goal of this CL is to group any-ref parameters at the stack side of the parameters. This means that in the stack frame iterator we do not need information about where anyref parameters are in the stack frame. We only need information about how many anyref parameters there are at the bottom of the stack frame. R=mstarzinger@chromium.org Also-By: mstarzinger@chromium.org Bug: v8:7581 Change-Id: I3ff7cc38fabed5f8e51b5b990190e35f3ea29803 Reviewed-on: https://chromium-review.googlesource.com/c/1371827 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Chromium does not use this name any more since https://crrev.com/c/1369854, so we can deprecate it for the 7.3 branch. R=adamk@chromium.org Bug: v8:8238, chromium:912031 Change-Id: I0625f58a893f48d89dec76851af292c9c32af035 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1370035Reviewed-by:
-
Predrag Rudic authored
Fix cfb5bb72 Change-Id: I2c59cd6716f35ba35dc4417e6b6c2a4588f7acd2 Reviewed-on: https://chromium-review.googlesource.com/c/1370034 Commit-Queue: Predrag Rudic <prudic@wavecomp.com> Reviewed-by:
-
Sathya Gunasekaran authored
Sets the hash default when dictionary is created. Migrates the hash correctly when the dictionary grows. Bug: v8:6443, v8:7569 Change-Id: I9195b557796b9bd3d040bd6f4f77d1f9ead4fc7d Reviewed-on: https://chromium-review.googlesource.com/c/1337744Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This pulls binutils from a subtreed repository of Chromium: https://chromium.googlesource.com/chromium/src/third_party/binutils/ Bug: chromium:718157 Change-Id: I532c7e84d83f716728e4f9f715cfdb82ea5d5f98 Reviewed-on: https://chromium-review.googlesource.com/c/1370043Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58180}
-
Ross McIlroy authored
Also declare an implication between --stress-flush-bytecode and --flush-bytecode BUG=v8:8395 Change-Id: Ide60e17b283325c1142b07c4eb6f5c7af22d33e9 Reviewed-on: https://chromium-review.googlesource.com/c/1372070Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58179}
-
Clemens Hammacher authored
The comma was removed as part of this CL: https://crrev.com/c/1355144 But layout tests rely on this: https://crrev.com/c/1372232 Thus add it back. R=mslekova@chromium.org CC=ahaas@chromium.org, ssauleau@igalia.com Change-Id: I522cc9b448e5cf046074bf635bd9fc60ccf64795 Reviewed-on: https://chromium-review.googlesource.com/c/1373549Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58178}
-
Michael Lippautz authored
Allows adding a label to strong retainers in PersistentValueMapBase and its subclasses. These labels show up in DevTools and enable identifying strong retainers of objects. R: ulan@chromium.org Change-Id: Id5e19507c40e44688c82a4caec89449b563a0e8b Reviewed-on: https://chromium-review.googlesource.com/c/1372069Reviewed-by:
-
Maya Lekova authored
R=yangguo@chromium.org TBR=sigurds@chromium.org Bug: v8:8577 Change-Id: Ia7c671d44d4142a394de6088b646bd32d26725ce Reviewed-on: https://chromium-review.googlesource.com/c/1372066Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/510ff4c..e250719 Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/4408f60..6fdf92b Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/74c92bb..149e7c6 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fed2cb3..e760411 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/ac40df8..7914672 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I1f95a09001b683d456cb7ebe2ead54a0ff73e9c6 Reviewed-on: https://chromium-review.googlesource.com/c/1372855Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#58175}
-
tzik authored
This CL merges MicrotaskContext management into EnteredContext, so that MicrotaskContext can nest. Here is a brief explanation: https://docs.google.com/document/d/1MY_xlsYS7E6_qbwwY66-FH3JkAYeTHBlF5qVBrBpWyY/edit Benchmark result: No significant performance difference is observed for this CL. See "patched" row for the result of this CL. Maintaining |is_microtask_context_| for the deprecated Isolate::GetEnteredContext() seems to cost 1~2% of the score, but that will be resolved eventually. https://github.com/v8/promise-performance-tests https://docs.google.com/spreadsheets/d/1-SpO4nQNxcXQZAfHN5CmEyAyCBd33wZ_CdF4U78e44I/edit#gid=1701841321 Bug: v8:8124 Change-Id: Ic709bccba9c32d37578e15a7571014ce50129459 Reviewed-on: https://chromium-review.googlesource.com/c/1322290Reviewed-by:
-
Frank Tang authored
Fix intl402/*/ignore-invalid-unicode-ext-values Add tests for other valid/invalid -u- ext values. Bug: v8:7481 Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 Reviewed-on: https://chromium-review.googlesource.com/c/1351307 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
- 11 Dec, 2018 7 commits
-
-
peterwmwong authored
As per (https://github.com/tc39/proposal-string-matchall/pull/41), String.p.matchAll's fallback was removed. Additionally, removed a IsNullOrUndefined check that was already covered by MaybeCallFunctionAtSymbol. Updates to Test262 has been submitted: https://github.com/tc39/test262/pull/1990 Bug: v8:6890 Change-Id: I246cbbcb4641ebded704c5f772809f182deaa30e Reviewed-on: https://chromium-review.googlesource.com/c/1369091 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#58172}
-
Jakob Kummerow authored
and non-recursive in order to let Clang inline it. Bonus: Drop IsTwoByteRepresentationUnderneath, which was dead code except for one test, and is semantically redundant. Bug: chromium:910573 Change-Id: I86f1c312e93ab875b4b42101ac65ddc94b1c9518 Reviewed-on: https://chromium-review.googlesource.com/c/1369086Reviewed-by:
-
Igor Sheludko authored
when applicable. This CL also renames BodyDescriptorBase helpers IsValidSlotImpl() -> IsValidJSObjectSlotImpl() IterateBodyImpl() -> IterateJSObjectBodyImpl() to make it clear that these methods are only applicable to JSObject subclasses and fixes SmallOrderedHashTable::BodyDescriptor which used IsValidSlotImpl(). Bug: v8:8518 Change-Id: I11565bed6ebf56c6830ac0e21f866846e65025e6 Reviewed-on: https://chromium-review.googlesource.com/c/1372068 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Bug: chromium:913448, chromium:912935, chromium:913482 Change-Id: Iea85d14a9695b8c8157400f92b9576285799c944 Reviewed-on: https://chromium-review.googlesource.com/c/1371831Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#58169}
-
Clemens Hammacher authored
Callbacks can keep embedder objects alive, hence clear them after delivering the final event. R=ahaas@chromium.org Bug: chromium:912764 Change-Id: I9ac739bbce32cb1026991610e0720210717c333e Reviewed-on: https://chromium-review.googlesource.com/c/1371565 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
peterwmwong authored
Micro-benchmarks show speed improvements across the various types: TypedArrays-JoinBigIntTypes 7246 8297 14.50% TypedArrays-JoinBigIntTypes 7194 8637 20.06% TypedArrays-JoinBigIntTypes 7258 8586 18.30% TypedArrays-JoinFloatTypes 24461 28628 17.04% TypedArrays-JoinFloatTypes 24523 29647 20.89% TypedArrays-JoinFloatTypes 24419 29327 20.10% TypedArrays-JoinIntTypes 23378 33928 45.13% TypedArrays-JoinIntTypes 23333 34034 45.86% TypedArrays-JoinIntTypes 21653 34000 57.02% TypedArrays-JoinWithSeparatorBigIntTypes 6620 7339 10.86% TypedArrays-JoinWithSeparatorBigIntTypes 6566 7579 15.43% TypedArrays-JoinWithSeparatorBigIntTypes 6631 7481 12.82% TypedArrays-JoinWithSeparatorFloatTypes 18695 19670 5.22% TypedArrays-JoinWithSeparatorFloatTypes 18518 20088 8.48% TypedArrays-JoinWithSeparatorFloatTypes 18482 20193 9.26% TypedArrays-JoinWithSeparatorIntTypes 17849 21482 20.35% TypedArrays-JoinWithSeparatorIntTypes 17831 21578 21.01% TypedArrays-JoinWithSeparatorIntTypes 17937 21578 20.30% Drive-by: Removed unused CSA helper InternalArrayCreate. Bug: v8:7624 Change-Id: I8e63815982439cfd2267417d03cd2b71b4b7a812 Reviewed-on: https://chromium-review.googlesource.com/c/1369330 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#58167}
-
Clemens Hammacher authored
The vast majority of places puts a semicolon after these macros (DISALLOW_ASSIGN, DISALLOW_COPY_AND_ASSIGN). Thus remove the semicolon from the definition and fix the few places that omitted the semicolon at the use. R=mlippautz@chromium.org Bug: v8:8562 Change-Id: Id730576f3061b86d8a5cee0e0b9b762f693f16ec Reviewed-on: https://chromium-review.googlesource.com/c/1371824Reviewed-by:
-
