- 12 Oct, 2018 3 commits
-
-
Georg Neis authored
We don't need to store the native context explicitly anymore, the broker already has it. Bug: v8:7790 Change-Id: I1096953e3c56bed9d3a8d7d37b108888ef4ac7ec Reviewed-on: https://chromium-review.googlesource.com/c/1270594 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#56586}
-
Jakob Gruber authored
TBR=sigurds@chromium.org Bug: v8:6666 Change-Id: I85dbc33a4baf5fb3775a6f557fc146437e17ab80 Reviewed-on: https://chromium-review.googlesource.com/c/1276430Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#56585}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/85ceec4..dbb4fad Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/cd3378c..c8b97e3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2fddb95..066e110 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/6e1868c..9647596 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia8e468cdad8510de141672485ce58583613e908b Reviewed-on: https://chromium-review.googlesource.com/c/1278491Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#56584}
-
- 11 Oct, 2018 37 commits
-
-
Jakob Kummerow authored
The primary purpose of this is to untangle a circular dependency objects.h -> handles.h -> objects.h. Most compilation units only need message-template.h, without the rest of messages.h. Bonus: change the enum to an enum class for improved type safety. Bug: v8:3770 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I8102c55197a450811de2588a68a08e7f99ea6b9e Reviewed-on: https://chromium-review.googlesource.com/c/1272193 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#56583}
-
Frank Tang authored
Bug: v8:5751 Change-Id: I17e2a5b489e84edb87805dd49dc144d6503d2c27 Reviewed-on: https://chromium-review.googlesource.com/c/1275146 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#56582}
-
Junliang Yan authored
Port a63987a4 Original Commit Message: This JSAsyncFunctionObject represents the implicit generator object inside of async functions, and also holds the outer promise for the async functions. This in turn allows us to get rid of the .promise in the Parser / BytecodeGenerator completely, and will make it possible to build zero-cost async stack traces independent of the concrete synchronous part of the stack frame (which currently breaks in Node.js). In the bytecode all the async function operations now take this new JSAsyncFunctionObject instead of passing both the .generator_object and the .promise, which further simplifies and shrinks the bytecode. It also reduces the size of async function frames, potentially making the suspend/resume cheaper. This also changes `await` to use intrinsics instead of calling to special JSFunctions on the native context, and thus reduces the size of the native contexts. to TurboFan. R=bmeurer@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ife0aa45b11580f316e657942485907cf78336e4b Reviewed-on: https://chromium-review.googlesource.com/c/1276867 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#56581}
-
Tom Anderson authored
BUG=chromium:894427 R=machenbach Change-Id: I129f512960ffc81b607bcdae1e43ddb94358d1df Reviewed-on: https://chromium-review.googlesource.com/c/1277609Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#56580}
-
Toon Verwaest authored
We only need to report once that we're in an invalid path for binding patterns and arrow formals. Change-Id: I8c7edc1c2a9f431c98e09725d0534e661db76634 Reviewed-on: https://chromium-review.googlesource.com/c/1276626 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56579}
-
Junliang Yan authored
R=joransiu@ca.ibm.com Change-Id: Ie5d47a3c0bc132ddf01910e0b16fd550d769e1bd Reviewed-on: https://chromium-review.googlesource.com/c/1276866Reviewed-by:
-
Yang Guo authored
If the instance template is not marked as undetectable, we can allow it to be called as a constructor. This broke previously with commit ff056334. R=verwaest@chromium.org Bug: v8:7670 Change-Id: I6ecde33bd7532bea4786b2282efce9060bb76276 Reviewed-on: https://chromium-review.googlesource.com/c/1272579Reviewed-by:
-
Clemens Hammacher authored
Reported here: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20NumFuzz%20-%20TSAN/3108 R=yangguo@chromium.org Bug: v8:8278 Change-Id: I78d13cea592678c1ab73b61fd9738f375df565d0 Reviewed-on: https://chromium-review.googlesource.com/c/1276631Reviewed-by:
-
Maya Lekova authored
Skipping on all platforms, as it started appearing regularly. Bug:v8:8296 NOTRY=true TBR=machenbach@chromium.org Change-Id: Ia43ece07af5ed5f0767fad9651be30b2cd3563f2 Reviewed-on: https://chromium-review.googlesource.com/c/1276633Reviewed-by:
-
Toon Verwaest authored
Now that the preparser doesn't track errors anymore, it also doesn't make sense to prepare the message. Change-Id: Ifc69e67f9220be69812257b0fc18b55097236dbd Reviewed-on: https://chromium-review.googlesource.com/c/1275818 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Maya Lekova authored
NOTRY=true TBR=machenbach@chromium.org Bug: v8:8294 Change-Id: Ib235139087bd6a651dc8bd43c5f9990e0513c7a5 Reviewed-on: https://chromium-review.googlesource.com/c/1276627 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Hannes Payer authored
Change-Id: Idc52e3ed6af13b20569a412e98bae0841d32e009 Reviewed-on: https://chromium-review.googlesource.com/c/1254125 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#56572}
-
Clemens Hammacher authored
It's rarely used, so just using {compiler::WasmGraphBuilder} directly is easier to understand and does not add much to the code length. R=titzer@chromium.org Bug: v8:8238 Change-Id: I8eafaac59295047a8540ebe256f00dff61ddae82 Reviewed-on: https://chromium-review.googlesource.com/c/1276426Reviewed-by: -
Michael Hablich authored
TBR=machenbach@chromium.org NOTRY=true Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I8093d12c3a157bbe2ced667ad26e1e1efe8bb2a4 Reviewed-on: https://chromium-review.googlesource.com/c/1276429 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#56570}
-
Marja Hölttä authored
These test mainly the data structures of JSWeakFactory / JSWeakCell. BUG=v8:8179 Change-Id: I20ffd07c18bbb2e21c69d11aa65d1e245203cc82 Reviewed-on: https://chromium-review.googlesource.com/c/1267939 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56569}
-
Toon Verwaest authored
Simpliy track arrow-formal-parameters through errors and copy it from binding pattern errors in AccumulateImpl rather than using a separate flag. Change-Id: I8146718f490f3c9a5de3c30dec2aa3218831523f Reviewed-on: https://chromium-review.googlesource.com/c/1275816 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Mike Stanton authored
A new CSA function, MoveElements() does an efficient memmove operation when the ElementsKind or new-space status allows it. A few other TNode cleanups applied in the file, for example, preferring the StoreFixedDoubleArrayHole() function. Change-Id: Ia0848c066eebbbbe321f81afe0cfa7df7567cbb7 Reviewed-on: https://chromium-review.googlesource.com/c/1268235 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#56567}
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Icb9df07963b2fd6686946713d802e12e1d595e95 Reviewed-on: https://chromium-review.googlesource.com/c/1274087Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#56566}
-
Michael Achenbach authored
The tests are scratching at the overall timeout. TBR=mslekova@chromium.org NOTRY=true Change-Id: I817337eff76dcf36306d7f5ceaaef34eea7886d3 Reviewed-on: https://chromium-review.googlesource.com/c/1276385 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This will allow us to use ts-node to execute tests written in TypeScript. Bug: v8:7327 Change-Id: I0804db1f112448350c5e91135242e6ec6706d231 Reviewed-on: https://chromium-review.googlesource.com/c/1274086 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=titzer@chromium.org TEST=mjsunit/wasm/exceptions-rethrow,unittests/FunctionBodyDecoderTest BUG=v8:8091 Change-Id: If52be505fb9897af1bd59d17d1ab47b33b665be0 Reviewed-on: https://chromium-review.googlesource.com/c/1273050 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Bug: v8:8292 Change-Id: I74fd304692e90adfb694b73ecf5e7858e3b66607 Reviewed-on: https://chromium-review.googlesource.com/c/1275814Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Toon Verwaest authored
In the preparser we don't need to worry about adding duplicate error objects to the list, so we can simply unconditionally set the error flag. Restructure the accumulator so we can also guarantee that we're checking the same flag as we're setting. Change-Id: I6a22cae468e77e5c6283c6fe937ca655f73991ac Reviewed-on: https://chromium-review.googlesource.com/c/1275813Reviewed-by:
-
Clemens Hammacher authored
The {MaskOut} operation is faster than using {operator~}, since {operator~} needs to ensure to return a valid register list, so it contains an additional AND operation with the mask of all registers. Hence use {MaskOut} more consistently, and remove the now unused {operator~} on {LiftoffRegList}. R=ahaas@chromium.org Bug: v8:6600 Change-Id: Icf072e564c4e391cafa2abeeba53cf275cee75f8 Reviewed-on: https://chromium-review.googlesource.com/c/1275810Reviewed-by:Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#56560}
-
Michael Starzinger authored
The templatized function body decoder already properly terminates control flow, it is not needed for the graph building implementation to do that explicitly upon {Throw} and {Rethrow}. R=titzer@chromium.org BUG=v8:8091 Change-Id: I47a93135c41b4cdf2fa6b8f5c7abfd6c212aaa12 Reviewed-on: https://chromium-review.googlesource.com/c/1273239 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Sigurd Schneider authored
Change-Id: I63abed81995b408ac4e82a4d3b31c948a96de06d Bug: v8:6666, v8:8288 Reviewed-on: https://chromium-review.googlesource.com/c/1275809 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Georg Neis authored
For now, all it does is control when the heap broker starts serializing. Eventually it will do what its name suggests. I'm also renaming --concurrent-compiler-frontend to the more accurate --concurrent-typed-lowering. Note that it's forceably implied by --concurrent-inlining. Bug: v8:7790 Change-Id: I55c1d8f1538146e89f3e166cb9165f6f38447146 Reviewed-on: https://chromium-review.googlesource.com/c/1270839Reviewed-by:
-
Michael Starzinger authored
This makes sure that catch blocks that are practically unreachable due to missing exceptional projections are handled properly. Note that this is independent of how reachability will be outlined in the final spec for exception handling. Currently we just assume that all catch blocks are spec-wise reachable. R=titzer@chromium.org TEST=mjsunit/wasm/exceptions-catchall BUG=v8:8091 Change-Id: I13607a59bd76be146df836e88105a2fbafedb760 Reviewed-on: https://chromium-review.googlesource.com/c/1273018Reviewed-by:
-
Daniel Clifford authored
The implicit parameter syntax adds a second parameter list before the explicit parameter list when declaring macros, builtins and runtime functions: extern macro MyMacro(implicit a: Smi)(b: Oddball); when calling the macro, only the formal parameters can be provided at the call site. The implicit parameters are implicitly looked-up by name in the scope of the call and prepended to the explicit parameter list. The values that are found by name for each implicit parameter must be castable the corresponding implicit parameter type: MyMacro(Null); // Error, a is not defined ... const a: Smi = 0; MyMacro(Null); // OK ... const a: Object = 0; MyMacro(Null); // Error, a has wrong type For external macros, builtins and runtime functions, the formal parameter list expected on the C++ side is the concatenation of the implicit and explicit parameter lists. As a drive-by: fix the formatting of typeswitch statements in the the presence of deferred-marked blocks and funky white space. Bug: v8:7793 Change-Id: I40da8405c706d7cdeca35367c9c954d0b33f6bf4 Reviewed-on: https://chromium-review.googlesource.com/c/1270996 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
This JSAsyncFunctionObject represents the implicit generator object inside of async functions, and also holds the outer promise for the async functions. This in turn allows us to get rid of the .promise in the Parser / BytecodeGenerator completely, and will make it possible to build zero-cost async stack traces independent of the concrete synchronous part of the stack frame (which currently breaks in Node.js). In the bytecode all the async function operations now take this new JSAsyncFunctionObject instead of passing both the .generator_object and the .promise, which further simplifies and shrinks the bytecode. It also reduces the size of async function frames, potentially making the suspend/resume cheaper. This also changes `await` to use intrinsics instead of calling to special JSFunctions on the native context, and thus reduces the size of the native contexts. Drive-by-fix: Introduce a dedicated JSCreateAsyncFunctionObject operator to TurboFan. Bug: v8:7253, v8:7522 Change-Id: I2305302285156aa1f71328ecac70377abdd92c80 Ref: nodejs/node#11865 Design-Document: http://bit.ly/v8-zero-cost-async-stack-traces Reviewed-on: https://chromium-review.googlesource.com/c/1273049 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56554}
-
Dan Elphick authored
Cast byte* to void* before printing so that it's not interpreted as a null-terminated string. Change-Id: I32b5a51913c3382b43d7b231d6b8fd4c17e32bb6 Reviewed-on: https://chromium-review.googlesource.com/c/1275352Reviewed-by:
-
Igor Sheludko authored
... and Heap::root_handle() to RootsTable. This is a preliminary step before moving IsolateData object from Heap to Isolate which is required for pointer-compression friendly heap layout. Bug: v8:8182 Change-Id: Ideacc1c9e4435be7a33db08415ac1ad46e956199 Reviewed-on: https://chromium-review.googlesource.com/c/1273238Reviewed-by:
-
Igor Sheludko authored
... containing RootsTable, ExternalReferenceTable, builtins array and potentially some other data that can be accessed via the RootRegister. This is a preliminary step before adding support for pointer-compression friendly heap layout. Bug: v8:8182 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I2899f657aaff1351a5304afa0b1a4c5ae4cfc31d Reviewed-on: https://chromium-review.googlesource.com/c/1245426Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#56551}
-
Georg Neis authored
This is behind a new flag --harmony-namespace-exports. Bug: v8:8101 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9c252b6de2b08223fcf3296340b78d721471bdb4 Reviewed-on: https://chromium-review.googlesource.com/c/1258004 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Frank Tang authored
Remove InstallWithIntrinsicDefaultProto which is not needed and reduce the size of context Bug: v8:5751 Change-Id: Ia830629abdf94921315faadc708f4f135f720949 Reviewed-on: https://chromium-review.googlesource.com/c/1274986 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 2148d827. Reason for revert: bug was fixed Original change's description: > [test] Skip test on gc fuzzer > > TBR=marja@chromium.org > > Bug: v8:8286 > Change-Id: I862d557c22e373c81171f0bb33b23d37157fbccd > Reviewed-on: https://chromium-review.googlesource.com/c/1273120 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56527} TBR=machenbach@chromium.org,marja@chromium.org Change-Id: I9bf0632815acdd1ea29f5e622e8313b061ddd20e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8286 Reviewed-on: https://chromium-review.googlesource.com/c/1275805Reviewed-by:
-
Michael Achenbach authored
This migrates the test configurations of all builders on the main console (aka client.v8) to the V8 repository, preparing removal from build/scripts/slave/recipe_modules/v8/builders.py. NOTRY=true Bug: chromium:830557 Change-Id: I40b8f31ab48426c7122c87e0221d6f05dc205e81 Reviewed-on: https://chromium-review.googlesource.com/c/1273237 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
