Commits · b4d617e48dbde1e96c64221bfddc036987255217 · Linshizhi / V8

24 Mar, 2014 27 commits

Parser fix: check allow_harmony_scoping() instead of FLAG_harmony_scoping. · b4d617e4

marja@chromium.org authored Mar 24, 2014

Without this fix, ParserBase::set_allow_harmony_scoping() and the
kAllowHarmonyScoping in test-parsing.cc don't have any effect, and we end up not
running the tests with harmony scoping allowed.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/209993002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20200 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b4d617e4

Use HType::Tagged when allocating elements. · 5fd9ddbc

dslomov@chromium.org authored Mar 24, 2014

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/201573010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20199 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5fd9ddbc

ARM64: Use a double register to break cycle involving double values. · f8c29ff0

baptiste.afsa@arm.com authored Mar 24, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/208183002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20198 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f8c29ff0

Correctly convert micro-sign to its upper case. · 9c0f5be8

yangguo@chromium.org authored Mar 24, 2014

R=dcarney@chromium.org
BUG=355485
LOG=N

Review URL: https://codereview.chromium.org/209323007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20197 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9c0f5be8

MIPS: Do stack checks while pushing locals. · 2c8229f6

plind44@gmail.com authored Mar 24, 2014

Port r20176 (a1bfd83)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/208323010

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20196 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2c8229f6

Fix DebugEvaluate for generators. · f1bacf8f

yangguo@chromium.org authored Mar 24, 2014

R=mstarzinger@chromium.org
BUG=v8:3225
LOG=N

Review URL: https://codereview.chromium.org/207153004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20195 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f1bacf8f

Replaced unreachable code in DoStoreNamedField by an assertion. · 3081e1b7

svenpanne@chromium.org authored Mar 24, 2014

This is part of the effort to assign an environment if and only if we can deopt.

Removed some related dead code on the way.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/209873005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20194 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3081e1b7

Fix debuggersupport=off build after r17184 and r18149. · 0ed1317b

rossberg@chromium.org authored Mar 24, 2014

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/209533002

Patch from Kang-Hao (Kenny) Lu <kennyluck@csail.mit.edu>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20193 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0ed1317b

IA32: Rename MacroAssembler::Set() and MacroAssembler::SafeSet() to Move() and SafeMove(). · df25d21d

titzer@chromium.org authored Mar 24, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/208073003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20192 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

df25d21d

ARM64: update the path to android_stlport_libs. · d700952b

ulan@chromium.org authored Mar 24, 2014

BUG=
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/209383007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20191 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d700952b

Follow up to r20125 (enabling tests). · 7dcaf268

marja@chromium.org authored Mar 24, 2014

These tests were never meant to be disabled.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/209953002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20190 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7dcaf268

PreParser cleanup: no need to track with-ness of scopes. · 25260c2b

marja@chromium.org authored Mar 24, 2014

Historically, we used to track the "with-ness" of a scope differently; not
creating a with scope, but setting a property on the scope (see
https://codereview.chromium.org/5166006 ). For laziness decisions, checking the
with-ness should be unnecessary: the current scope is function scope, and if the
outer scope is global scope, there's surely no with scope in between.

R=ulan@chromium.org
BUG=

Review URL: https://codereview.chromium.org/209863004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20189 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

25260c2b

Fix component build some more. · e5f5cc95

marja@chromium.org authored Mar 24, 2014

Not V8_EXPORTing ScriptCompiler::Source got rid of the last errors. This fixes
the new ones created by it. V8_INLINEing these funcs makes sense anyway.

In addition, added declared-private-and-unimplemented assignment operators
which were accidentally omitted.

R=dcarney@chromium.org
BUG=

Review URL: https://codereview.chromium.org/209873004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20188 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e5f5cc95

Revert "A64: Now that we have veneers, fix a couple of branches to directly jump to their target." · 49a7de45

svenpanne@chromium.org authored Mar 24, 2014

This reverts commit r20169, it heavily regresses a Mozilla test:

make -j32 arm64.release.check TESTFLAGS=--time TESTJOBS=mozilla/js1_5/Regress/regress-280769-2

Before:
--- Total time: 00:01.928 ---
   1 (00:01.911) mozilla/js1_5/Regress/regress-280769-2
   2 (00:01.910) mozilla/js1_5/Regress/regress-280769-2
   3 (00:01.910) mozilla/js1_5/Regress/regress-280769-2

After:
--- Total time: 01:36.025 ---
   1 (01:36.004) mozilla/js1_5/Regress/regress-280769-2
   2 (01:35.403) mozilla/js1_5/Regress/regress-280769-2
   3 (01:32.098) mozilla/js1_5/Regress/regress-280769-2

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/209333004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20187 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

49a7de45

Delete mjsunit/string-oom-slow-* tests. · 55d5b022

jkummerow@chromium.org authored Mar 24, 2014

They are too slow, and there is no feasible way to speed them up.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/205553005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20186 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

55d5b022

[ia32/x64] Smaller instruction to check NaN · b7c3cd5e

jkummerow@chromium.org authored Mar 24, 2014

substract 1 and test for overflow

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/202083002

Patch from Weiliang Lin <weiliang.lin@intel.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20185 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b7c3cd5e

Reland "Remove Failure::OutOfMemory propagation and V8::IgnoreOutOfMemoryException." · 8b8fb30e

yangguo@chromium.org authored Mar 24, 2014

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/209903003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20184 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8b8fb30e

Revert "Remove Failure::OutOfMemory propagation and V8::IgnoreOutOfMemoryException." · 03866841

yangguo@chromium.org authored Mar 24, 2014

This reverts r20179.

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/201573007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20183 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

03866841

Remove an unused isolate_ field from BacktrackStack. · 1c90c951

rmcilroy@chromium.org authored Mar 24, 2014

Found by Nico Weber with -Wunused-private-field

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/208613002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20182 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1c90c951

Use V8_FINAL and V8_OVERRIDE in ElementsAccessor classses. · cd5cc705

ishell@chromium.org authored Mar 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/208063002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20181 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cd5cc705

Builtin helper function EnsureJSArrayWithWritableFastElements() handlified. · 89732db6

ishell@chromium.org authored Mar 24, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/208033002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20180 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

89732db6

Remove Failure::OutOfMemory propagation and V8::IgnoreOutOfMemoryException. · 62f65d86

yangguo@chromium.org authored Mar 24, 2014

R=dcarney@chromium.org
BUG=v8:3060
LOG=Y

Review URL: https://codereview.chromium.org/208263002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20179 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

62f65d86

add setaccessorproperty to object · 3ab0622b

dcarney@chromium.org authored Mar 24, 2014

R=svenpanne@chromium.org

LOG=N
BUG=v8:2964

Review URL: https://codereview.chromium.org/209853002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20178 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3ab0622b

Refactor inlined typed array runtime functions. · 15951521

yangguo@chromium.org authored Mar 24, 2014

R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/203443002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20177 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

15951521

Do stack checks while pushing locals · 493c6b35

dcarney@chromium.org authored Mar 24, 2014

R=yangguo@chromium.org

BUG=

Review URL: https://codereview.chromium.org/207543003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20176 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

493c6b35

Fix options for calling push-to-trunk script. · db8196ae

machenbach@chromium.org authored Mar 24, 2014

BUG=
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/209833002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20173 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

db8196ae

Disable concurrent OSR. · 479bb2ff

yangguo@chromium.org authored Mar 24, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/208263011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20172 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

479bb2ff

21 Mar, 2014 13 commits

ARM: fix assertions for uxtb and co. · d5753f27

rodolph.perfetta@arm.com authored Mar 21, 2014

Allow operands with ROR #0. Behind the scene they are mapped to LSL #0.

BUG=v8:3209
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/198053014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20171 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d5753f27

Tentative Windows dll build fix: Don't V8_EXPORT ScriptCompiler::Source. · be4c4953

marja@chromium.org authored Mar 21, 2014

For more information, see the bug. Compare to ScriptOrigin
which is not exported either.

BUG=v8:3228
LOG=Y
R=dcarney@chromium.org, jkummerow@chromium.org

Review URL: https://codereview.chromium.org/207703004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20170 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

be4c4953

A64: Now that we have veneers, fix a couple of branches to directly jump to their target. · 759bf428

alexandre.rames@arm.com authored Mar 21, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/207883002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20169 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

759bf428

Let auto-roll push the lkgr. · 04a418c5

machenbach@chromium.org authored Mar 21, 2014

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/205703004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20168 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

04a418c5

Add special check for topmost optimized code in deoptimizer verification. · 2aaaeb78

ulan@chromium.org authored Mar 21, 2014

BUG=354843
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/208283002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20167 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2aaaeb78

JSObject::EnsureCanContainElements() handlified. · deca3f36

ishell@chromium.org authored Mar 21, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/198053013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20166 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

deca3f36

Enable concurrent OSR. · 265ae631

yangguo@chromium.org authored Mar 21, 2014

R=danno@chromium.org

Review URL: https://codereview.chromium.org/208253002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20165 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

265ae631

ARM64: Fix some stub-cache TODOs · 7eb99dbe

m.m.capewell@googlemail.com authored Mar 21, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/208023002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20164 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7eb99dbe

ARM: Fix Q register encoding · 6c417833

m.m.capewell@googlemail.com authored Mar 21, 2014

Fix Q register encoding for registers other than Q0. Also, fix value in NeonSize
enumeration.

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/207523005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20163 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6c417833

Add option to run ScopeIterator faster giving up nested scope chain. · 50ca2eb9

ulan@chromium.org authored Mar 21, 2014

We'd like to be able to trade nested scope chain info (consisting of with, block and catch scopes) in favor of speed in some cases.

BUG=chromium:340285
LOG=N
R=ulan@chromium.org, pfeldman, ulan, yangguo

Review URL: https://codereview.chromium.org/203463011

Patch from Andrey Adaykin <aandrey@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20162 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50ca2eb9

Reland of r20146 "JSObject::NormalizeElements() handlified." · 90b1077e

ishell@chromium.org authored Mar 21, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/208003002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20161 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

90b1077e

Add a utility method to the ia32 macro assembler to move a double immediate into an XMM register. · a428b0d5

titzer@chromium.org authored Mar 21, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/197233011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20160 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a428b0d5

Split of rolling Chromium from push-to-trunk. · e134d32f

machenbach@chromium.org authored Mar 21, 2014

This moves rolling Chromium into a new script with its own tests.

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/199733012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20159 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e134d32f