1. 01 Mar, 2016 7 commits
  2. 29 Feb, 2016 20 commits
  3. 28 Feb, 2016 6 commits
  4. 27 Feb, 2016 4 commits
  5. 26 Feb, 2016 3 commits
    • mbrandy's avatar
      PPC: [turbofan] Don't use the CompareIC in JSGenericLowering. · c1507e15
      mbrandy authored
      Port d00da47b
      
      Original commit message:
          The CompareICStub produces an untagged raw word value, which has to be
          translated to true or false manually in the TurboFan code. But for lazy
          bailout after the CompareIC, we immediately go back to fullcodegen or
          Ignition with the raw value, to a location where both fullcodegen and
          Ignition expect a boolean value, which might crash or in the worst case
          (depending on the exact computation inside the CompareIC) could lead to
          arbitrary memory access.
      
          Short-term fix is to use the proper runtime functions (unified with the
          interpreter now) for comparisons. Next task is to provide optimized
          versions of these based on the CodeStubAssembler, which can then be used
          via code stubs in TurboFan or directly in handlers in the interpreter.
      
      R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
      BUG=v8:4788
      LOG=n
      
      Review URL: https://codereview.chromium.org/1745643002
      
      Cr-Commit-Position: refs/heads/master@{#34341}
      c1507e15
    • mbrandy's avatar
      Revert of PPC: [compiler] Drop the CompareNilIC. (patchset #1 id:1 of... · 76b66159
      mbrandy authored
      Revert of PPC: [compiler] Drop the CompareNilIC. (patchset #1 id:1 of https://codereview.chromium.org/1733663003/ )
      
      Reason for revert:
      Original commit reverted.
      
      Original issue's description:
      > PPC: [compiler] Drop the CompareNilIC.
      >
      > Port 666aec03
      >
      > Original commit message:
      >     Since both null and undefined are also marked as undetectable now, we
      >     can just test that bit instead of having the CompareNilIC try to collect
      >     feedback to speed up the general case (without the undetectable bit
      >     being used).
      >
      >     Drive-by-fix: Update the type system to match the new handling of
      >     undetectable in the runtime.
      >
      > R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
      > BUG=
      >
      > Committed: https://crrev.com/546ea6b8393a894f07597ade5ec1c7db02c1e425
      > Cr-Commit-Position: refs/heads/master@{#34266}
      
      TBR=bmeurer@chromium.org,joransiu@ca.ibm.com,jyan@ca.ibm.com,michael_dawson@ca.ibm.com
      # Not skipping CQ checks because original CL landed more than 1 days ago.
      BUG=
      
      Review URL: https://codereview.chromium.org/1736253003
      
      Cr-Commit-Position: refs/heads/master@{#34340}
      76b66159
    • littledan's avatar
      Fix strict mode function error message · 92ed0853
      littledan authored
      ES2015 allows strict mode block scoped function declarations; weaken
      the error message about misuse to allow this.
      
      BUG=v8:2198
      LOG=Y
      R=adamk
      
      Review URL: https://codereview.chromium.org/1741903002
      
      Cr-Commit-Position: refs/heads/master@{#34339}
      92ed0853