Commits · b48e27ea0046055b84843b91bf9b16e495c1f554 · Linshizhi / V8

04 Nov, 2014 23 commits

titzer@chromium.org authored Nov 04, 2014

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/703633003

Cr-Commit-Position: refs/heads/master@{#25117}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25117 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b48e27ea

`1..isPrototypeOf.call(null)` should return false, not throw TypeError. · 357882a8

rossberg@chromium.org authored Nov 04, 2014

BUG=v8:3483
LOG=Y
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/433413002

Cr-Commit-Position: refs/heads/master@{#25116}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25116 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

357882a8

Remove --harmony implications for incomplete features · 0b9a70ad

rossberg@chromium.org authored Nov 04, 2014

This is in preparation for making --harmony and --es-staging synonyms.
The only remaining difference currently is block-scoping, which is still
implied by --harmony, to avoid regressing on a long-available feature.

Also removes the special-casing of --harmony-proxies.

R=adamk@chromium.org
BUG=

Review URL: https://codereview.chromium.org/693153004

Cr-Commit-Position: refs/heads/master@{#25115}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25115 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0b9a70ad

Reduce size of array in polymorph-arrays.js. · 3386da98

titzer@chromium.org authored Nov 04, 2014

R=danno@chromium.org
BUG=

Review URL: https://codereview.chromium.org/686273003

Cr-Commit-Position: refs/heads/master@{#25114}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25114 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3386da98

Fix predictable mode when job based sweeping is off. · 751289fb

hpayer@chromium.org authored Nov 04, 2014

BUG=
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/697423002

Cr-Commit-Position: refs/heads/master@{#25113}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25113 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

751289fb

Refactor ObjectGetOwnPropertyKeys to accept bitmask rather than boolean · d6ca29ce

arv@chromium.org authored Nov 04, 2014

BUG=v8:3549
LOG=Y
R=arv@chromium.org, rossberg@chromium.org

Review URL: https://codereview.chromium.org/557023002

Patch from Caitlin Potter <caitpotter88@gmail.com>.

Cr-Commit-Position: refs/heads/master@{#25111}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25111 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d6ca29ce

Introduce Diamond, a helper for building diamond-shaped control patterns. · faa71f96

titzer@chromium.org authored Nov 04, 2014

R=mstarzinger@chromium.org, bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/694063005

Cr-Commit-Position: refs/heads/master@{#25110}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

faa71f96

Parser & internalizing: efficiency fixes. · 94a08565

marja@chromium.org authored Nov 04, 2014

1) In ParseLazy, we're already using the heap, so we can also tell
AstValueFactory to internalize immediately. This is more efficient.

2) No need to collect the values in values_ and strings_ if they're already
internalized.

3) No need to collect AstValues which are strings in values_ since they don't
need to be internalized (the underlying strings will be internalized
separately).

BUG=429168
LOG=N
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/693803004

Cr-Commit-Position: refs/heads/master@{#25109}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25109 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

94a08565

[turbofan] Add AllocateHeapNumberStub to avoid runtime call. · 38971822

bmeurer@chromium.org authored Nov 04, 2014

TEST=unittests
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/703473004

Cr-Commit-Position: refs/heads/master@{#25107}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25107 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

38971822

[turbofan] Fix branch hints for ChangeInt32ToTagged and ChangeTaggedToUI32. · e56d4b92

bmeurer@chromium.org authored Nov 04, 2014

R=titzer@chromium.org

Review URL: https://codereview.chromium.org/694353006

Cr-Commit-Position: refs/heads/master@{#25106}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25106 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e56d4b92

Disable long running gc-stress tests on arm64 for TF. · 6ff255ea

ulan@chromium.org authored Nov 04, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/701723004

Cr-Commit-Position: refs/heads/master@{#25105}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25105 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6ff255ea

Revert "Optimize function across closures." · c66a3f95

yangguo@chromium.org authored Nov 04, 2014

This reverts r25102.

TBR=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/699143002

Cr-Commit-Position: refs/heads/master@{#25104}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25104 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c66a3f95

[turbofan] Fix recognition of Uint32Div in simplified lowering. · e6cfe350

bmeurer@chromium.org authored Nov 04, 2014

TEST=mjsunit/asm
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/701813003

Cr-Commit-Position: refs/heads/master@{#25103}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25103 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e6cfe350

Optimize function across closures. · 1d669345

yangguo@chromium.org authored Nov 04, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/699633002

Cr-Commit-Position: refs/heads/master@{#25102}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25102 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d669345

Follow up to fix v8::Exception::GetMessage() actually do what it was intended to. · a17b087a

aandrey@chromium.org authored Nov 04, 2014

The main thing for v8::Exception::GetMessage() is to extract message location from
error stack trace, even when stack trace capturing is off (when DevTools is closed).

BUG=chromium:427954
R=yangguo@chromium.org
LOG=N

Review URL: https://codereview.chromium.org/696703002

Cr-Commit-Position: refs/heads/master@{#25101}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25101 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a17b087a

Add debug mirror support for ES6 Map/Set iterators. · 35eaced2

aandrey@chromium.org authored Nov 04, 2014

This is to show values preview of an iterator in DevTools console.

API=v8::Value::IsMapIterator, v8::Value::IsSetIterator
BUG=chromium:427868
R=arv@chromium.org, yangguo@chromium.org, adamk@chromium.org
LOG=Y

Review URL: https://codereview.chromium.org/693813002

Cr-Commit-Position: refs/heads/master@{#25100}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25100 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

35eaced2

TransitionArray::Search() now returns insertion index if the entry was not found. · d7bc74f8

ishell@chromium.org authored Nov 04, 2014

This is a prerequisite for https://codereview.chromium.org/661133002/.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/698043003

Cr-Commit-Position: refs/heads/master@{#25099}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d7bc74f8

Actually also advance the iterator in StorePropertyWithInterceptor · 568ff345

verwaest@chromium.org authored Nov 04, 2014

BUG=v8:3636
LOG=n
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/702523002

Cr-Commit-Position: refs/heads/master@{#25098}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25098 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

568ff345

[turbofan] add RegisterConfiguration to decouple arch specific register layouts from compiler · 7cb25f50

dcarney@chromium.org authored Nov 04, 2014

R=bmeurer@chromium.org

BUG=

Review URL: https://codereview.chromium.org/694313002

Cr-Commit-Position: refs/heads/master@{#25097}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25097 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7cb25f50

Whitespace CL to trigger bots. · 470be4ac

machenbach@chromium.org authored Nov 04, 2014

Cr-Commit-Position: refs/heads/master@{#25096}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25096 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

470be4ac

Adds dependency on sanitizer · 10059cb7

danno@chromium.org authored Nov 04, 2014

The santizer target is empty if no sanitizers are defined, otherwise
it contains the necessary targets. Because of this we can always
depend on it. Without this dep asan builds fail.

R=brettw@chromium.org, danno@chromium.org

Review URL: https://codereview.chromium.org/697763002

Patch from Scott Violet <sky@chromium.org>.

Cr-Commit-Position: refs/heads/master@{#25094}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25094 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

10059cb7

[turbofan] Also print the non-value inputs in schedule. · cfb6e2a7

bmeurer@chromium.org authored Nov 04, 2014

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/702643002

Cr-Commit-Position: refs/heads/master@{#25092}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cfb6e2a7

[turbofan] Strip useless sign-extension for store8/store16. · 18e18d21

bmeurer@chromium.org authored Nov 04, 2014

TEST=unittests
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/698963002

Cr-Commit-Position: refs/heads/master@{#25091}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25091 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

18e18d21

03 Nov, 2014 17 commits

Remove FAIL from test262-es6.status · a27c7722

arv@chromium.org authored Nov 03, 2014

TBR=rossberg
BUG=v8:3642
LOG=Y

Review URL: https://codereview.chromium.org/698073003

Cr-Commit-Position: refs/heads/master@{#25088}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25088 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a27c7722

Classes: static should still be treated as a strict reserved word · 7a63c74c

arv@chromium.org authored Nov 03, 2014

When --harmony-classes is enabled we did not treat static as a
strict reserved word.

BUG=v8:3642
LOG=Y
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/652743009

Cr-Commit-Position: refs/heads/master@{#25087}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25087 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7a63c74c

Fix a few nits found by PVS Studio · e525e76f

jkummerow@chromium.org authored Nov 03, 2014

BUG=v8:3192
LOG=n
R=dslomov@chromium.org

Review URL: https://codereview.chromium.org/185563004

Cr-Commit-Position: refs/heads/master@{#25086}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25086 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e525e76f

Fix build because of dead fields. · ce06f447

titzer@chromium.org authored Nov 03, 2014

TBR=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/699673002

Cr-Commit-Position: refs/heads/master@{#25085}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25085 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ce06f447

Make visualizer robust to graphs with NULL inputs. · 5bba6b20

titzer@chromium.org authored Nov 03, 2014

R=mstarzinger@chromium.org, jarin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/652263002

Cr-Commit-Position: refs/heads/master@{#25084}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25084 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5bba6b20

Introduce phantom weak handles in the API and use them internally for debug info · 3d62e24c

erikcorry@chromium.org authored Nov 03, 2014

R=ulan@chromium.org, jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/687003005

Cr-Commit-Position: refs/heads/master@{#25083}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25083 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3d62e24c

Reland "Limit the number of transitions allowed per hidden class." · a19c18ac

ishell@chromium.org authored Nov 03, 2014

BUG=chromium:427813
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/676393002

Cr-Commit-Position: refs/heads/master@{#25082}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25082 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a19c18ac

MIPS: [turbofan] Also optimize unsigned division by constant. · 8960f5d8

balazs.kilvady@imgtec.com authored Nov 03, 2014

Port r25061 (7fe697f)

TEST=cctest,mjsunit,unittests
BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/701543002

Cr-Commit-Position: refs/heads/master@{#25081}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25081 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8960f5d8

Unbreak build fon non-TF targets. · 14e2d5d0

dusan.milosavljevic@imgtec.com authored Nov 03, 2014

Mips64 is affected but not for long.

TEST=
BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/689113003

Cr-Commit-Position: refs/heads/master@{#25080}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25080 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

14e2d5d0

Fix auto roll update. · 29552a40

machenbach@chromium.org authored Nov 03, 2014

Auto roll requires an additional "git fetch" now that it uses
a workdir. Before, the checkout used to be updated
externally.

BUG=408523
LOG=n
TEST=script_test.py
R=tandrii@chromium.org
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/695323002

Cr-Commit-Position: refs/heads/master@{#25079}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25079 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

29552a40

[turbofan] Introduce separate SelectLowering reducer. · 744c66bc

bmeurer@chromium.org authored Nov 03, 2014

Split lowering of Select nodes into a separate graph reducer and be more
clever when lowering to diamonds, i.e. reuse diamonds that have the same
condition and only add more phis to it.

TEST=unittests
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/702463002

Cr-Commit-Position: refs/heads/master@{#25078}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25078 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

744c66bc

Fix uninitialized fields in the BinaryOperation ast node. · 1c1a1a1a

jarin@chromium.org authored Nov 03, 2014

R=jkummerow@chromium.org, svenpanne@chromium.org
BUG=chromium:429194
LOG=n

Review URL: https://codereview.chromium.org/701533002

Cr-Commit-Position: refs/heads/master@{#25077}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25077 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1c1a1a1a

Don't double-check elements in the prototype chain in array builtins · 3ea82aa9

verwaest@chromium.org authored Nov 03, 2014

BUG=
R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/701513002

Cr-Commit-Position: refs/heads/master@{#25076}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25076 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3ea82aa9

[turbofan] Fix Typer::Rangify to handle integral bitset types. · 83806d56

jarin@chromium.org authored Nov 03, 2014

R=bmeurer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/688413003

Cr-Commit-Position: refs/heads/master@{#25074}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25074 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

83806d56

build fix after 25072 · 273a9ad2

dcarney@chromium.org authored Nov 03, 2014

TBR=bmeurer@chromium.org

BUG=

Review URL: https://codereview.chromium.org/688323005

Cr-Commit-Position: refs/heads/master@{#25073}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25073 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

273a9ad2

build fix after r25071 · e17194ba

dcarney@chromium.org authored Nov 03, 2014

TBR=bmeurer@chromium.org

BUG=

Review URL: https://codereview.chromium.org/684523003

Cr-Commit-Position: refs/heads/master@{#25072}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25072 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e17194ba

[turbofan] initial framework for unittesting of register allocator · 0d1cdeba

dcarney@chromium.org authored Nov 03, 2014

BUG=
R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/683133005

Cr-Commit-Position: refs/heads/master@{#25071}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25071 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0d1cdeba